Wednesday, March 2, 2022
10 changes · master
Enhancements to existing features
The employee profile now shows related action buttons in a clearer, standardized order across HR apps. This makes it easier for users to find common employee information such as documents, time off, planning, payroll, attendance, and appraisals.
Original PR description
…tons on hr_employee form Reorder smart buttons on the hr_employee form to have them in the following order: 1. Documents 2. Holiday status 3. Time Off 4. Planning 5. Timesheets 6. Equipments 7. Cars 8. Contracts 9. Appraisal 10. Work Entries 11. Payroll 12. Attendance 13. Extra Hours task-2735679
This update modernizes how several Odoo apps retrieve grouped business data, helping reports and dashboard counts run more consistently. The change is mostly internal, with no expected workflow changes for users, but it supports better maintainability and performance across accounting, documents, helpdesk, approvals, appointments, and related areas.
This update enables additional automated code quality checks and adjusts existing code so those checks pass. It helps reduce avoidable coding mistakes and keeps several business modules easier to maintain, with no expected direct change for end users.
Original PR description
The commits enable some rules. Some work was done to allow some of these rules to be enabled, and offending code was adapted. Linked odoo PR : https://github.com/odoo/odoo/pull/85569
The dashboard view has been updated to use the newer interface framework, replacing older internal components. This helps keep dashboards easier to maintain and reduces the risk of future compatibility issues without changing core business workflows.
Features or functions removed from Odoo
Barcode scanning directly from stock picking forms has been removed because the dedicated Barcode app now covers this workflow. This reduces duplicate maintenance, and users should use the Barcode app for scanning operations, including package type barcodes previously handled by the delivery barcode module.
Original PR description
Barcode handling within picking form is outdated and obsolete due to barcode app. To avoid having to maintain the same barcode features in both stock (picking form) and barcode apps, we remove the picking form barcode handler code. It is expected that most users will just use the barcode app anyways. This includes removing the now obsolete delivery_barcode module which only added the ability to scan a package type barcode in a picking form. Note that other form barcode handlers that exist at the time of this commit are left as is. Task: 2039720 Upgrade PR: https://github.com/odoo/upgrade/pull/3230
Miscellaneous changes
Warnings for commodity codes set from category are different that the ones set from the product directly. If a line has no commodity code before calling super()._fill_missing_values(), but has one after then the code is from the product's category. Before this, an invalid commodity on a product would display a warning for invalid codes on products but also invalid codes on categories. Tests were made more precise to detect this situation. See https://github.com/odoo/enterprise/pull/24768/c
Original PR description
Warnings for commodity codes set from category are different that the ones set from the product directly. If a line has no commodity code before calling super()._fill_missing_values(), but has one after then the code is from the product's category. Before this, an invalid commodity on a product would display a warning for invalid codes on products but also invalid codes on categories. Tests were made more precise to detect this situation. See https://github.com/odoo/enterprise/pull/24768/commits Task: 2752565 Forward-Port-Of: odoo/enterprise#24812
Original PR description
Companion of https://github.com/odoo/odoo/pull/84908
Steps to reproduce: - On the HomeMenu with studio installed - Click on the Studio icon to activate it - Open the "Customizations" dropdown - Click on "Change Background" - Browser's file picker opens, select a file => on validation, nothing happens. This commit prevents the HomeMenu customization dropdown from closing when one of its items takes focus. This behavior prevented the `<input type="file">` event listeners from being properly triggered as its node was already removed from
Original PR description
Steps to reproduce: - On the HomeMenu with studio installed - Click on the Studio icon to activate it - Open the "Customizations" dropdown - Click on "Change Background" - Browser's file picker opens, select a file => on validation, nothing happens. This commit prevents the HomeMenu customization dropdown from closing when one of its items takes focus. This behavior prevented the `<input type="file">` event listeners from being properly triggered as its node was already removed from the DOM when the browser's file picker closed. Note: this attribute was missing after the dropdown-item-selected event refactoring (see odoo/enterprise@36855c18597a5112d20c811cba9970b7fffc1466). Forward-Port-Of: odoo/enterprise#24887
Before this commit, when the industry_fsm_sale_report module is installed without demo data, no journal could be defined in the company used for the test and so the test failed because of no journal is defined in the current company. This commit uses the common class defined in the `industry_fsm_sale` module to used the journal set by the common class defined in `account` module. Forward-Port-Of: odoo/enterprise#24866
Original PR description
Before this commit, when the industry_fsm_sale_report module is installed without demo data, no journal could be defined in the company used for the test and so the test failed because of no journal is defined in the current company. This commit uses the common class defined in the `industry_fsm_sale` module to used the journal set by the common class defined in `account` module. Forward-Port-Of: odoo/enterprise#24866
Forward-Port-Of: odoo/enterprise#24847 Forward-Port-Of: odoo/enterprise#24775
Original PR description
Forward-Port-Of: odoo/enterprise#24847 Forward-Port-Of: odoo/enterprise#24775
During the refactoring https://github.com/odoo/enterprise/commit/5801b3e88194a2f64db03f19ec97ac0159c2b375, the environment of the expiration panel did change and no longer contains a service navigate. Here we adapt the code simmilarly to what was done elsewhere in the expiration panel by writing on browser.location directly. Forward-Port-Of: odoo/enterprise#24672
Original PR description
During the refactoring https://github.com/odoo/enterprise/commit/5801b3e88194a2f64db03f19ec97ac0159c2b375, the environment of the expiration panel did change and no longer contains a service navigate. Here we adapt the code simmilarly to what was done elsewhere in the expiration panel by writing on browser.location directly. Forward-Port-Of: odoo/enterprise#24672