Sunday, March 20, 2022
2 changes · master
Miscellaneous changes
When using price included taxes, the xml contained data that failed to meet the constraints of the edi. This is due to the local rounding on the lines of the invoice. For example: A product costing 321€, on two lines of the invoice, with a price included tax of 22% Rounded per line: float_round( 321 - (321/122 * 100), 2 # To two decimal places ) evaluates to 57.89, the total tax will be 2 * 57.89 = 115.78 In the case of global rounding float_round( 321 + 321 - (32
Original PR description
When using price included taxes, the xml contained data that failed to meet the constraints of the edi. This is due to the local rounding on the lines of the invoice. For example: A product costing…
When using price included taxes, the xml contained data that failed to meet the constraints of the edi. This is due to the local rounding on the lines of the invoice. For example: A product costing 321€, on two lines of the invoice, with a price included tax of 22% Rounded per line: float_round( 321 - (321/122 * 100), 2 # To two decimal places ) evaluates to 57.89, the total tax will be 2 * 57.89 = 115.78 In the case of global rounding float_round( 321 + 321 - (321/122*100) - (321/122*100), 2 # To two decimal places ) evaluates to 115.77, so we have a difference of one cent. This can be exacerbated by more lines. The constraints on the EDI that this conflicts with are on the tax summary section for each tax. The constraints (roughly reworded): 00422: The base taxable amount for the tax must be equal to the sum of the base product prices (for which we have already used the rounded computed values, calcuated in the invoice) + <Arrotondamento> (rounding). 00421: The value provided for the <importo> that is the value of the vat is equal to the taxable base multiplied by the tax rate. The problem is that because of our local roundings, the taxable base is equal to our products, but the tax rate * taxable base is not equal to the tax amount (as present in the invoice). This commit adds to the rounding field and subtracts from the taxable base of the tax summary a value rounding value that should make tax rate * taxable base equal to the value of the vat. task: 2789290 Forward-Port-Of: odoo/odoo#86052
Since [1] the CSS property reset for hovered outline buttons is using invalid property values. After this commit the color and image are only reset on non-hover: - the `background-color` is already set to `none` by `.btn`, - the `background-image` is only set if defined on the button's style - there is no need to reset it. [1]: https://github.com/odoo/odoo/commit/a010c91b5ee119cf54ed1a68a6ea06b2bc5f3978 task-2633169 Description of the issue/feature this PR addresses: Current b
Original PR description
Since [1] the CSS property reset for hovered outline buttons is using invalid property values. After this commit the color and image are only reset on non-hover: - the `background-color` is already set to `none` by `.btn`, - the `background-image` is only set if defined on the button's style - there is no need to reset it. [1]: https://github.com/odoo/odoo/commit/a010c91b5ee119cf54ed1a68a6ea06b2bc5f3978 task-2633169 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#86205