Odoo Changelog — 2022-04-25

Monday, April 25, 2022

36 changes · master

Improvements(9)

Enhancements to existing features

[IMP] models, *: compute missing default in batch

Coremasteraccountproductsale_couponwebsitewebsite_salewebsite_sale_comparisontest_new_apiMedium

Odoo now handles missing default values more efficiently when many records are created at once. This prevents duplicate sequence numbers in batch-created records and reduces repeated database lookups, especially for product and partner-related workflows.

Original PR description

`_add_missing_default_values` is made to work in batch. Models with a sequence can take advantage of that to increase the sequence for each new record in the batch. Before this commit, all records…

`_add_missing_default_values` is made to work in batch.

Models with a sequence can take advantage of that to increase the sequence for
each new record in the batch.

Before this commit, all records created in a batch would have the same sequence
if no sequence was provided to `create`.

The new sequence is computed after the parent `_add_missing_default_values`
instead of before (or instead of in `create`) to keep the possibility to have
the default value coming from other means, as computed in `default_get`.

The opportunity is also taken to change the definition of some defaults methods
that would lead to the execution of queries, because those queries would be done
for each record in the batch.

This is typically the case for defaults that use `ref` which does an `exists`
(as opposed to `xmlid_to_res_model_res_id`) or it is obviously also the case for
the defaults doing a `search` directly.

Indeed the result of these queries would then either be read or be added as a
many2one, both of which will already check the existence of the resource.

The focus of this commit was on products and partners, but the same logic can be
applied to other models if they have such defaults and the performance of their
batch create is important.

#batch creation#defaults#performance#sequences

[IMP] product: make combination_indices required

PR #44266

Coremasterproduct

Product variant records will now prevent missing combination information, reducing the chance of duplicate or inconsistent variants after migrations or external database updates. This helps keep product catalogs more reliable without changing day-to-day workflows.

Original PR description

On [1] it was wrongly assumed that `required` was unnecessary because the field
is computed and the compute method never set NULL.

However [2] highlighted cases where the field was NULL in database. This can
especially happen after a migration, or more generally for any database change
made outside the ORM.

To avoid issues, we need to ensure the same product.template does not have two
variants one with empty string and one with NULL, thus making the field required
to prevent NULL values.

[1] 22a11a6f4d0b08a56712fafd0f87a2e7bb5b00ec
[2] 03e7efc3b4592c5f063c665130011a91fcc4d683

#product variants#data consistency#migration

[IMP] mail: make chatter attachment button more explicit

PR #63085

CoremastermailMedium

The chatter area now makes the attachment action easier to recognize and use. This helps users find and manage document attachments more confidently during everyday communication workflows.

Original PR description

task-2413814

#chatter#attachments#usability

[IMP] hr_timesheet: add some test case in timesheet application

PR #86914

Coremasterhr_timesheethr_timesheet_attendanceproject_timesheet_holidays

This update adds test coverage to help ensure timesheet reminders, attendance reporting, multi-company timesheets, and time off-related timesheet entries behave correctly. It reduces the risk of payroll, approval, and absence-tracking issues by validating important business scenarios such as holidays overlapping with approved time off.

Original PR description

Reminders-
- employee reminder: an email should be sent when the employee has timesheet less hours than he should have
- manager reminder: an email should be sent when the manager has not validated timesheets within the corresponding timeframe.

Timesheet / attendance report 

Time off

- public holidays should not generate an entry if the employee is already on time off
- the project and task set on the time off type should be set on the generated timesheets

task-2727561

#timesheets#attendance#time off#reminders

[IMP] mail, website_slides: apply guideline on activity component

PR #72644

Coremastermailwebsite_slides

This update aligns the activity component with Odoo interface guidelines in Mail and eLearning slides. Users get a more consistent experience when viewing and managing activities across these areas.

Original PR description

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#activities#user interface#consistency

[IMP] project: rename starred field and other generic improvements

PR #87139

CoremasterprojectMedium

Project task starring is now presented as priority, making the purpose clearer for users. Task assignment dates are cleaned up when assignees are removed, collaborators gain a helpful action shortcut, and task calendars can now be viewed by year for broader planning.

Original PR description

- The starred field was renamed as priority.
- The assigned date is now set back to False when the user is unassigned from the task
- An action helper was added to the collaborators view
- The year mode was added to the calendar view of tasks

task-2802506

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#tasks#priority#calendar#collaboration

[IMP] timesheet_grid: add some test case in timesheet application

PR #25464

Enterprisemastertimesheet_grid

This update adds checks to ensure timesheet reminder emails are sent when employees are short on hours and when managers have pending validations. It also improves testing around resetting validated timesheets back to draft, helping protect key timesheet approval workflows from regressions.

Original PR description

Reminders-
- employee reminder: an email should be sent when the employee has timesheet less hours than he should have
- manager reminder: an email should be sent when the manager has not validated timesheets within the corresponding timeframe.

Timesheets validation
- reset a timesheet to draft

task-2727561

#timesheets#reminders#validation#testing

[IMP] mrp_plm: compute default sequence in batch

PR #5691

Enterprisemastermrp_plm

New PLM engineering change records created together now receive separate sequence numbers instead of sharing the same order. This improves list ordering and helps teams distinguish and manage newly created records more reliably.

Original PR description

`_add_missing_default_values` was made to work in batch, and this commit takes
advantage of that to increase the sequence for each new record in the batch.

Before this commit, all records created in a batch would have the same sequence.

Enterprise counterpart of odoo/odoo#36704

#plm#sequence#batch creation

[IMP] mail, *: apply guideline on activity component

PR #19194

EnterprisemasterapprovalsdocumentssignvoipmailMedium

Activity cards have been updated to follow the latest interface guidelines in Approvals, Documents, Sign, and VoIP. This creates a more consistent experience for users when reviewing and acting on activities across these apps.

Original PR description

* = approvals, documents, sign, voip

#activities#user experience#consistency

Refactoring(1)

Code cleanup and technical improvements

Master check fields seb

PR #71066

Coremasterhrhr_holidaysim_livechat

This update reorganizes how HR, Time Off, and Live Chat messaging components are registered behind the scenes. It should make these areas easier to maintain and less prone to configuration inconsistencies, with limited direct impact on day-to-day users.

Original PR description

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#messaging#maintenance#livechat#hr

Other(26)

Miscellaneous changes

[FW][IMP] SII: Improve appearance of menu, test env by default

PR #89480

Coremasterl10n_es_edi_sii

Description of the issue/feature this PR addresses: [Task-2809043](https://www.odoo.com/web#id=2809043&model=project.task) Current behavior before PR: SII's menu is not the best Desired behavior after PR is merged: SII's menu is clearer and more readable Forward-Port-Of: odoo/odoo#87101

Original PR description

Description of the issue/feature this PR addresses:
[Task-2809043](https://www.odoo.com/web#id=2809043&model=project.task)

Current behavior before PR:
SII's menu is not the best

Desired behavior after PR is merged:
SII's menu is clearer and more readable

Forward-Port-Of: odoo/odoo#87101

[FW][FIX] mass_mailing: ensure test templating is true

PR #89346

`_add_missing_default_values` is made to work in batch. Models with a sequence can take advantage of that to increase the sequence for each new record in the batch. Before this commit, all records created in a batch would have the same sequence if no sequence was provided to `create`. The new sequence is computed after the parent `_add_missing_default_values` instead of before (or instead of in `create`) to keep the possibility to have the default value coming from other means, as computed in `default_get`. The opportunity is also taken to change the definition of some defaults methods that would lead to the execution of queries, because those queries would be done for each record in the batch. This is typically the case for defaults that use `ref` which does an `exists` (as opposed to `xmlid_to_res_model_res_id`) or it is obviously also the case for the defaults doing a `search` directly. Indeed the result of these queries would then either be read or be added as a many2one, both of which will already check the existence of the resource. The focus of this commit was on products and partners, but the same logic can be applied to other models if they have such defaults and the performance of their batch create is important.

On [1] it was wrongly assumed that `required` was unnecessary because the field is computed and the compute method never set NULL. However [2] highlighted cases where the field was NULL in database. This can especially happen after a migration, or more generally for any database change made outside the ORM. To avoid issues, we need to ensure the same product.template does not have two variants one with empty string and one with NULL, thus making the field required to prevent NULL values. [1] 22a11a6f4d0b08a56712fafd0f87a2e7bb5b00ec [2] 03e7efc3b4592c5f063c665130011a91fcc4d683

Reminders- - employee reminder: an email should be sent when the employee has timesheet less hours than he should have - manager reminder: an email should be sent when the manager has not validated timesheets within the corresponding timeframe. Timesheet / attendance report Time off - public holidays should not generate an entry if the employee is already on time off - the project and task set on the time off type should be set on the generated timesheets task-2727561

Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

- The starred field was renamed as priority. - The assigned date is now set back to False when the user is unassigned from the task - An action helper was added to the collaborators view - The year mode was added to the calendar view of tasks task-2802506 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

`_add_missing_default_values` was made to work in batch, and this commit takes advantage of that to increase the sequence for each new record in the batch. Before this commit, all records created in a batch would have the same sequence. Enterprise counterpart of odoo/odoo#36704

Impacted versions: - 15.0 Steps to reproduce (starting from ENTERPRISE 15.2): - enable Work Orders - create new BoM for a new product - add 1 operation w/ 1 step (e.g. Instructions) - add 1 component to BoM with operation_id (Consumed in Operation) = the operation - Create and confirm a MO with new BoM + 2 Quantity to Produce - Produce 1 product via the tablet view flow (i.e. complete instruction step + Validate 1 component in "Register Consumed Materials" step + Mark As Done) Current behaviour: Backorder is correctly created, but its workorder is missing the "Register Consumed Materials" step Expected behaviour: Step is correctly created Note: same issue occurs with Byproducts having a operation_id (i.e. "Produced in Operation") Issue is due to when `_split_productions()` first creates the backorders, they are created without `move_raw_ids` and `move_finished_ids` (see: `_get_backorder_mo_vals()`). When the backorders are created, they auto-create and auto-confirm their workorders. Since a quality point (e.g. operation step) exists for the workorder, the initial `_action_confirm` will `_create_checks()` for the quality point, but the "Register Consumed Materials" steps are created by the `operation_id` values in the `move_raw_ids` and `move_finished_ids` which haven't been set yet. This makes it so when the second `_action_confirm()` is called on the workorders (i.e. after their moves have been set) at the end of `_split_productions()`, the `_create_checks()` will be skipped because it assumes all the quality points have been created since one already exists. Task: 2800975 Enterprise PR: https://github.com/odoo/enterprise/pull/26437 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#87681

Improvements(9)

[IMP] models, *: compute missing default in batch

[IMP] product: make combination_indices required

[IMP] mail: make chatter attachment button more explicit

[IMP] hr_timesheet: add some test case in timesheet application

[IMP] mail, website_slides: apply guideline on activity component

[IMP] project: rename starred field and other generic improvements

[IMP] timesheet_grid: add some test case in timesheet application

[IMP] mrp_plm: compute default sequence in batch

[IMP] mail, *: apply guideline on activity component

Refactoring(1)

Master check fields seb

Other(26)

[FW][IMP] SII: Improve appearance of menu, test env by default

[FW][FIX] mass_mailing: ensure test templating is true

Improvements(9)

[IMP] models, *: compute missing default in batch

[IMP] product: make combination_indices required

[IMP] mail: make chatter attachment button more explicit

[IMP] hr_timesheet: add some test case in timesheet application

[IMP] mail, website_slides: apply guideline on activity component

[IMP] project: rename starred field and other generic improvements

[IMP] timesheet_grid: add some test case in timesheet application

[IMP] mrp_plm: compute default sequence in batch

[IMP] mail, *: apply guideline on activity component

Refactoring(1)

Master check fields seb

Other(26)

[FW][IMP] SII: Improve appearance of menu, test env by default

[FW][FIX] mass_mailing: ensure test templating is true

[FW][FIX] website: autoplay youtube videos on mobile

[FW][FIX] mrp: Preserve component registration steps on backorder creation

[FW][FIX] mrp, sale_mrp: set bom_line_id on all moves for kits

[FW] 15.0 action service fix aab

[FW][FIX] web: basic_model: applyOnChange with 2 consecutive one2many

[FW][FIX] delivery: wrong invoice status for partially delivered orders

[FW][FIX] point_of_sale: add warning for SN not set in PoS

[FW][FIX] point_of_sale: speed-up picking creation at closing

[FW][FIX] hr_timesheet : round hour spent correctly

[FW][FIX] point_of_sale,pos_{sale,gift_card}: product taken in total disc…

[FW][FIX] web: get timezone offset from local time

[FW][FIX] project: readd token value in portal.message_thread template call

[FW][FIX] account: wrong destination account id in internal transfer

[FW][FIX] account_asset: Deferred Expense Not Allowing Prepayment Account

[FW][FIX] l10n_be_hr_payroll: Apply tax-shift from April 2022

[FW][FIX] hr_payroll_holidays: Fix reported deferred time off to next month

[FW][FIX] planning: fix various bugs in planning

[FW][FIX] l10n_nl_reports: XAF auditfile not exporting (timeout)

[FW][FIX] mrp_workorder: Preserve component registration steps on backorder

[FW][FIX] sale_subscription: groupby on date_start causing errors in cohort

[FW][FIX] documents_spreadsheet: drill-down record of merged cells

[FW][FIX] helpdesk: fix trigger of helpsesk tour

[FW][FIX] hr_contract_salary: missing required fields displayed on select

[FW][FIX] l10n_nl_intrastat: product origin country missing in cbs export