Daily updates from Odoo
Navigate
Branch
Thursday, April 28, 2022
6 changes
Resolved issues and error corrections
Module `documents_spreadsheet_bundle` was removed in 84d502c0. However, git did not interpret this commit as a pure deletion and the module .pot file was still forwardported in 746576d1. This commit should confirm the deletion of the module, preventing another occurence of this issue.
Original PR description
Module `documents_spreadsheet_bundle` was removed in 84d502c0. However, git did not interpret this commit as a pure deletion and the module .pot file was still forwardported in 746576d1. This commit should confirm the deletion of the module, preventing another occurence of this issue.
Code cleanup and technical improvements
This proof of concept restructures the Approvals activity interface so approval actions and display elements are represented more consistently. The change should make future improvements easier to build and test, while keeping the user-facing approval flow familiar.
Original PR description
Task-2338825 Related Community: https://github.com/odoo/odoo/pull/58962
Miscellaneous changes
In the case where we found a Purchase Order but its content doesn't match the values detected by the OCR, we will now apply the PO without modification. Previous behaviour was to use the PO but set all quantities to 0 then add the results of the OCR at the end. This foten resulted in more manual work than if we simply set the whole PO without any modification. Forward-Port-Of: odoo/enterprise#26392
Original PR description
In the case where we found a Purchase Order but its content doesn't match the values detected by the OCR, we will now apply the PO without modification. Previous behaviour was to use the PO but set all quantities to 0 then add the results of the OCR at the end. This foten resulted in more manual work than if we simply set the whole PO without any modification. Forward-Port-Of: odoo/enterprise#26392
Bug === When we create a ticket from the Outlook / Gmail addin, the acknowledgement email is not sent. Technical ========= The email is sent on a "stage" change (see `_track_template`). But in mail thread, we do not care about value coming from the default_get. So if the stage come from the default_get, the value is just ignored. As all fixes in mail thread will add additional SQL queries, we just fix it here (as nobody complained about that) and we give manually the team (so th
Original PR description
Bug === When we create a ticket from the Outlook / Gmail addin, the acknowledgement email is not sent. Technical ========= The email is sent on a "stage" change (see `_track_template`). But in mail thread, we do not care about value coming from the default_get. So if the stage come from the default_get, the value is just ignored. As all fixes in mail thread will add additional SQL queries, we just fix it here (as nobody complained about that) and we give manually the team (so the stage can be set in the create method of ticket and the acknowledgement email is sent). Task-2782150 Forward-Port-Of: odoo/enterprise#24904
Cf odoo/odoo#89496 Not quite clear why updates have different amounts. `_read` override adds: - 1 query for `is_system`, cacheable - 2 queries for `_get_public_fields`, cacheable - 2 queries for `partner_ids` (?) - additional ACL-related queries Expected to be able to reapply prefetch so that in `_slot_availability_prepare_values_meetings` the fetching of `event.start` and `event.stop` would be done (and cached) when fetching `attachment_ids`, but that was not successful. Forward
Original PR description
Cf odoo/odoo#89496 Not quite clear why updates have different amounts. `_read` override adds: - 1 query for `is_system`, cacheable - 2 queries for `_get_public_fields`, cacheable - 2 queries for `partner_ids` (?) - additional ACL-related queries Expected to be able to reapply prefetch so that in `_slot_availability_prepare_values_meetings` the fetching of `event.start` and `event.stop` would be done (and cached) when fetching `attachment_ids`, but that was not successful. Forward-Port-Of: odoo/enterprise#26663 Forward-Port-Of: odoo/enterprise#26570
### Observed Behaviour When creating a pivot view in accounting analytics and grouping on a field having a 'relation' property, the user get a traceback when trying to insert the pivot in a spreadsheet, with the error `TypeError: search_read() got an unexpected keyword argument 'orderBy'` ### Expected Behaviour Everything should work fine when trying to insert the pivot view in the spreadsheet, opening the spreadsheet after having creating a new sheet from the pivot. ### Reproducibility
Original PR description
### Observed Behaviour When creating a pivot view in accounting analytics and grouping on a field having a 'relation' property, the user get a traceback when trying to insert the pivot in a…
### Observed Behaviour When creating a pivot view in accounting analytics and grouping on a field having a 'relation' property, the user get a traceback when trying to insert the pivot in a spreadsheet, with the error `TypeError: search_read() got an unexpected keyword argument 'orderBy'` ### Expected Behaviour Everything should work fine when trying to insert the pivot view in the spreadsheet, opening the spreadsheet after having creating a new sheet from the pivot. ### Reproducibility This issue can be reproduced using the following steps : 1. Make sure the Analytic Accounting is enabled in the Settings (see attachment) 2. Accounting App 3. Configuration tab 4. Analytics Item 5. Pivot view 6. Filter the total by Journal Item 7. Click on Insert in spreadsheet ### Fix Description The issue was coming from the fact that, in the wrapper used to change some parameters in the call of the searh_read method, we checked if args.orderBy wasn't FALSE and then change it to args.order, while we should check if args.orderBy was defined, to be sure to handle the case when it's set to FALSE. ### Related Issue(s)/PR - opw-2812607 Forward-Port-Of: odoo/enterprise#26492 Forward-Port-Of: odoo/enterprise#26345