Odoo Changelog — 2022-06-16

Thursday, June 16, 2022

3 changes

Bug Fixes(3)

Resolved issues and error corrections

[FIX] sale_subscription: duplication of get param in url

Enterprisemastersale_subscription

Subscription portal links no longer repeat the access token when users navigate back and forth. This keeps portal URLs clean and prevents automated checks or users from hitting errors caused by excessively long repeated parameters.

Original PR description

Go to the subscription portal (/my/subscription)
Access the portal view of a given sub (/my/subscription/ID?access_token=...)
Go back to the subscription portal (the token is kept in the url bc of the keep_query in portal_breadcrumbs)
Hover/click on the link to the portal view of a specific sub, you'll see the token twice in the
	url GET params.

This commit removes the keep_query for the links on the subscription portal homepage, following
the existing behavior in sale, purchase, ...

This avoids a crash when the runbot crawl test reaches a python recursion error after
reaching an url where the access token is present more than 30 times (probably even more).

#subscription#portal#url#stability

[FIX] documents_spreadsheet: selected spreadsheet should be identifiable

PR #28463

Enterprisemasterdocuments_spreadsheet

The spreadsheet insertion dialog now clearly shows which spreadsheet is currently selected. This removes confusion when users choose a spreadsheet to insert, helping them confirm the right item before proceeding.

Original PR description

Before this commit, a selected spreadsheet in the inserting dialog was
not identifiable.

task-id 2884665

#spreadsheet#documents#selection#usability

[FIX] timesheet_grid : force employee when creating a timesheet

PR #23979

Enterprisemastertimesheet_gridhelpdesk_sale_timesheethelpdesk_timesheetindustry_fsm_saleindustry_fsm_sale_reportproject_timesheet_synchroMEDIUM

Timesheet entries now correctly keep or require an employee when users create time from the timesheet grid, even if their employee record was archived or deleted. This avoids incomplete task time records and improves the reliability of timesheet reporting and billing flows.

Original PR description

- Bug 1

Steps :
Archive your employee, go to your timesheets and add time on a task T line
Go to task T and note that a line have been added without any employe

Cause :
By default, views do not show archived values.

Fix :
Show archived employees with context key 'test_active=False'.

- Bug 2 :

Steps :
Delete your employee, go to your timesheets and add time on a task T line
Go to task T and note that a line have been added without any employe

Cause :
If this employee do not exist, the timesheet has no employee,
which does not make sense.

Fix :
At creation of aal, check that timesheets have an employee.

opw: 2740228
Related PR: https://github.com/odoo/odoo/pull/83918

#timesheets#employees#data quality#tasks

Go to the subscription portal (/my/subscription) Access the portal view of a given sub (/my/subscription/ID?access_token=...) Go back to the subscription portal (the token is kept in the url bc of the keep_query in portal_breadcrumbs) Hover/click on the link to the portal view of a specific sub, you'll see the token twice in the url GET params. This commit removes the keep_query for the links on the subscription portal homepage, following the existing behavior in sale, purchase, ... This avoids a crash when the runbot crawl test reaches a python recursion error after reaching an url where the access token is present more than 30 times (probably even more).

- Bug 1 Steps : Archive your employee, go to your timesheets and add time on a task T line Go to task T and note that a line have been added without any employe Cause : By default, views do not show archived values. Fix : Show archived employees with context key 'test_active=False'. - Bug 2 : Steps : Delete your employee, go to your timesheets and add time on a task T line Go to task T and note that a line have been added without any employe Cause : If this employee do not exist, the timesheet has no employee, which does not make sense. Fix : At creation of aal, check that timesheets have an employee. opw: 2740228 Related PR: https://github.com/odoo/odoo/pull/83918