Odoo Changelog — 2022-08-16

Tuesday, August 16, 2022

4 changes

Improvements(3)

Enhancements to existing features

[IMP] spreadsheet_edition: create filters on x2many fields

Enterprisemasterspreadsheet_editiondocuments_spreadsheetMedium

Spreadsheet pivot filters can now be matched using many-to-many and one-to-many fields, not just single related records. This gives users more flexibility when analyzing connected business data in spreadsheets.

Original PR description

Before this commit, it was only possible to match a pivot with a filter
based on a many2one field.
Now, it's possible for many2many and one2many fields

Task 2946466

#spreadsheets#filters#pivot#reporting

[IMP] [documents_]spreadsheet: edit pivot and list domain

PR #29321

Enterprisemasterdocuments_spreadsheetspreadsheetspreadsheet_editionMedium

Users can now adjust the filter criteria for spreadsheet pivots and lists directly from their properties panel. This makes it easier to refine spreadsheet reports without rebuilding them or needing technical assistance.

#spreadsheet#pivot#list#filters#reporting

[IMP] figure: link to odoo menu in dashboard mode

PR #30206

EnterprisemasterspreadsheetMedium

Dashboard charts linked to an Odoo menu are now easier to use: instead of a separate external-link button, users can click the whole chart to open the related menu. This streamlines navigation from dashboards and makes chart interactions more intuitive.

Original PR description

Remove button "external link" in charts in dashboard mode, and make the
whole figure clickable to redirect to the odoo menu linked to the chart.

Odoo task [2947461](https://www.odoo.com/web#id=2947461&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form)

#dashboard#charts#navigation

Bug Fixes(1)

Resolved issues and error corrections

[FIX] sign : false placeholder when no developer mode

PR #28303

EnterprisemastersignMedium

This fix prevents Sign document fields from displaying the word "false" when placeholders are empty or when users are not in developer mode. It keeps existing placeholder text stable when field types change and updates demo data so sample Sign templates display correctly.

Original PR description

This PR is a followup on https://github.com/odoo/enterprise/pull/27676 where a fix was set in stable to manage the specific case of empty placeholders. However this fix was not stable and made…

This PR is a followup on https://github.com/odoo/enterprise/pull/27676 where a fix was set in stable to manage the specific case of empty placeholders. However this fix was not stable and made pre-existing default placeholder disappear and it was hence revert in https://github.com/odoo/enterprise/pull/28496 on stable versions. This fix in master completes the first fix to treat other issues like the case where the user is not in developer mode, the false that appear in the situation of empty placeholders and a confusion in the js logic where we could not differentiate the name of a sign item that was just created (and has a default value of false) and a sign item that had its placeholder set to false. We also add the placeholders in the demo data. The commits of this PR totally rewrite the first fix commit and can be seen as a minor behavior change (the name field of the sign item always has the value of its placeholder while previously it was only the placeholder when it was not false, this mean that changing the type placeholder won't change the previously existing item default placeholder like it was the case before).

BUG1

Steps to reproduce:
- Install sign
- Put no developer mode on
- Set a signature block on a document
- Change if from customer to employee

Current behavior:
The block shows false

Expected behavior:
The block does not change

Explanation:
The bug was created after the fix commit 860ace5013d7f5cde1018f5eb1ec4fce1f6b3537
the fix did not take into consideration that the o_sign_name of the block form
only appeared when the use is in developer mode (t-if="widget.debug" in xml). 
https://github.com/odoo/enterprise/blob/da1b8691f8edceac5a7ba794921a24657886618c/sign/static/src/xml/sign_backend.xml#L5-L9
So the name was always false when pulled in the form hide function. To fix that we only pull
the name from o_sign_name if we are not in developer mode.

BUG2

Steps to reproduce:

- Install sign
- Create a template and add a sign item
- Set an empty placeholder with the developer mode
on the sign item and save

Expected behavior:
The placeholder is empty

Current behavior:
The placeholder is false

Explanation:
It was thought in a previous fix https://github.com/odoo/enterprise/commit/860ace5013d7f5cde1018f5eb1ec4fce1f6b3537
that the false value was the expected behavior. But is was just inudced by
an empty placeholder in the sign item type that returned the false value.
To solve the issue we add || "" after the different places where the name
is set so that if the type placeholder is false then the sign item
placeholder is an empty string.

BUG3
Steps to reproduce:
- Create a sign item
- Set an empty placeholder with developer mode
- Refresh
- Click on the sign item you just created

Expected behavior:
The placeholder is empty

Current behavior:
The placeholder is the sign item type default placeholder

Explanation:
The javascript is unabled to make the difference between the
name of a sign item that was just created (and has a default
value of false) and a sign item that had its placeholder set
to false. We solve that in the backend by setting a default
value for the sign item name at creation. It's cleaner than
the current implementation as the default placeholder is only
set once and it makes more sense.

opw-2767417
opw-2877149

Remove button "external link" in charts in dashboard mode, and make the whole figure clickable to redirect to the odoo menu linked to the chart. Odoo task [2947461](https://www.odoo.com/web#id=2947461&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form)

This PR is a followup on https://github.com/odoo/enterprise/pull/27676 where a fix was set in stable to manage the specific case of empty placeholders. However this fix was not stable and made pre-existing default placeholder disappear and it was hence revert in https://github.com/odoo/enterprise/pull/28496 on stable versions. This fix in master completes the first fix to treat other issues like the case where the user is not in developer mode, the false that appear in the situation of empty placeholders and a confusion in the js logic where we could not differentiate the name of a sign item that was just created (and has a default value of false) and a sign item that had its placeholder set to false. We also add the placeholders in the demo data. The commits of this PR totally rewrite the first fix commit and can be seen as a minor behavior change (the name field of the sign item always has the value of its placeholder while previously it was only the placeholder when it was not false, this mean that changing the type placeholder won't change the previously existing item default placeholder like it was the case before). BUG1 Steps to reproduce: - Install sign - Put no developer mode on - Set a signature block on a document - Change if from customer to employee Current behavior: The block shows false Expected behavior: The block does not change Explanation: The bug was created after the fix commit 860ace5013d7f5cde1018f5eb1ec4fce1f6b3537 the fix did not take into consideration that the o_sign_name of the block form only appeared when the use is in developer mode (t-if="widget.debug" in xml). https://github.com/odoo/enterprise/blob/da1b8691f8edceac5a7ba794921a24657886618c/sign/static/src/xml/sign_backend.xml#L5-L9 So the name was always false when pulled in the form hide function. To fix that we only pull the name from o_sign_name if we are not in developer mode. BUG2 Steps to reproduce: - Install sign - Create a template and add a sign item - Set an empty placeholder with the developer mode on the sign item and save Expected behavior: The placeholder is empty Current behavior: The placeholder is false Explanation: It was thought in a previous fix https://github.com/odoo/enterprise/commit/860ace5013d7f5cde1018f5eb1ec4fce1f6b3537 that the false value was the expected behavior. But is was just inudced by an empty placeholder in the sign item type that returned the false value. To solve the issue we add || "" after the different places where the name is set so that if the type placeholder is false then the sign item placeholder is an empty string. BUG3 Steps to reproduce: - Create a sign item - Set an empty placeholder with developer mode - Refresh - Click on the sign item you just created Expected behavior: The placeholder is empty Current behavior: The placeholder is the sign item type default placeholder Explanation: The javascript is unabled to make the difference between the name of a sign item that was just created (and has a default value of false) and a sign item that had its placeholder set to false. We solve that in the backend by setting a default value for the sign item name at creation. It's cleaner than the current implementation as the default placeholder is only set once and it makes more sense. opw-2767417 opw-2877149