Friday, October 7, 2022
86 changes · master
Enhancements to existing features
Users can now open a project's tasks directly from the project list using a new button. This saves time by avoiding the extra step of opening the project details page first.
Original PR description
In this commit we introduce a button in the project list view which, if clicked, redirects the user to the project task kanban, where they can see the project's tasks. This change gives the user the posibility of directly viewing a project's tasks from the project list view without needing to go through the form view, thus increasing efficiency. Task-2969697 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Emoji data in the Mail app is now loaded only when needed instead of during the initial page load. This reduces unnecessary upfront loading and can make messaging pages feel faster for users.
Original PR description
Make it so that emoji data are not in bundle during page load. Task-2984923
Payments registered manually on invoices can now open the bank reconciliation view with the correct bank statement already selected. This helps accounting users complete reconciliation more accurately and reduces confusion when matching invoice payments to bank transactions.
Original PR description
When a payment is registered manually for an invoice first and then reconciled with a bank statement, the move is not linked with the statement line. It's necessary to pass the statement line id through the widget to filter the bank reconciliation widget with a correct bank statement line when redirecting from the invoice payment widget. task-2928299
Resolved issues and error corrections
This fixes time off requests so employees can only select allocated leave types when they have a valid allocation for the requested period. It also improves validation messages by showing available allocation dates and balances, helping employees and HR understand why a request cannot be approved.
Original PR description
…ssages - Do not allow selecting an allocated time off if the employee has no allocation in the selected period - Display the available allocatiosn and dates in the validation error text if a time…
Miscellaneous changes
This PR adapts the form views since the merge of odoo/odoo#100570. task-3002465 Forward-Port-Of: odoo/odoo#102096
Original PR description
This PR adapts the form views since the merge of odoo/odoo#100570. task-3002465 Forward-Port-Of: odoo/odoo#102096
…ssages
- Do not allow selecting an allocated time off if the employee has no allocation in the selected period
- Display the available allocatiosn and dates in the validation error text if a time off is selected outside the allocation windows
If there is an allocation from Aug 1st to Aug 31st:
- If a time off is taken between the 1st and 31st of August: ok
- If a time off longer than the allocated days is taken between the 1st and 31st of August: Validation error message, missing allocated days
- If a time off is taken before or after the 31st of August: impossible, the time off should not appear in the list
- If there is a time off between 25/07 and 03/08: the allocated time off is displayed because of the month of August but it can't be validated
- Review the number of allocated days: it displays "0 days remaining out of 0 days" when there is an allocation
task-2667441
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prApproval requests now place the employee's manager first when that approver is part of a defined approval sequence. This helps requests reach the right decision-maker sooner and ensures the configured approval order is saved correctly.
Original PR description
When a sequence is defined on an approval category and the employee's manager is selected as approver, they were the last in line to approve. With this commit, they are first in line. task-2884137
This is a followup to: https://github.com/odoo/odoo/pull/102268 When navigating around the view with keyboard arrows: **Before this commit:** - there is blue outline on focused cell - focused row is not highlighted - https://youtu.be/kD72hic7dME **After this commit:** - row is highlighted when hovering or focusing - no more blue outline on focused cell - https://youtu.be/qqSqOVaqbEA --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Original PR description
This is a followup to: https://github.com/odoo/odoo/pull/102268 When navigating around the view with keyboard arrows: **Before this commit:** - there is blue outline on focused cell - focused row is not highlighted - https://youtu.be/kD72hic7dME **After this commit:** - row is highlighted when hovering or focusing - no more blue outline on focused cell - https://youtu.be/qqSqOVaqbEA --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102464
If source is something like `"admin@éxample.com" <admin@éxample.com>` candidates founds are `['"admin@\xc3\xa9xample.com"', 'admin@\xc3\xa9xample.com']` and the first one raises an error because of "". Malformed addresses should instead be ignored. Note: I will create a separate PR for 14.0 without the test since test_extract_rfc2822_addresses does not exist in 14 opw-2982426 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Por
Original PR description
If source is something like `"admin@éxample.com" <admin@éxample.com>` candidates founds are `['"admin@\xc3\xa9xample.com"', 'admin@\xc3\xa9xample.com']` and the first one raises an error because of "". Malformed addresses should instead be ignored. Note: I will create a separate PR for 14.0 without the test since test_extract_rfc2822_addresses does not exist in 14 opw-2982426 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102089 Forward-Port-Of: odoo/odoo#101637
The main goal of this commit, is to add missing `colspan="2"`. We also hide the div and its label at the same time. Steps to reproduce: * Open Project * Select a project * Select a task * Click on Recurrent checkbox (if not checked) * Select the Recurrent Notebook => BUG --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102394
Original PR description
The main goal of this commit, is to add missing `colspan="2"`. We also hide the div and its label at the same time. Steps to reproduce: * Open Project * Select a project * Select a task * Click on Recurrent checkbox (if not checked) * Select the Recurrent Notebook => BUG --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102394
Before this commit, the phone, email, and selection fields always displayed their field as in edit mode, even if not hovered. eg. The envelope button of the email field, the SMS and call button of the phone field and the caret of the selection field where always visible. Since the form is always in edition, it doesn't make sense to always display those elements. This commit makes those element display only on hover and on focus. Description of the issue/feature this PR addresses:
Original PR description
Before this commit, the phone, email, and selection fields always displayed their field as in edit mode, even if not hovered. eg. The envelope button of the email field, the SMS and call button of the phone field and the caret of the selection field where always visible. Since the form is always in edition, it doesn't make sense to always display those elements. This commit makes those element display only on hover and on focus. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102327
During the tests, many attachment can be created and unlink. They will be eventually cleaned up if the cron is ran but this is usually not the case during tests. The disk usage can increase to reach more than one 1 Go when design theme is installed. This can lead to unnecessary big database dumps. This is also a problem on odoosh where the filestore max size is limited to 1Go during automated testing. The gc should be quite fast if nothing was changed since it will just check the con
Original PR description
During the tests, many attachment can be created and unlink. They will be eventually cleaned up if the cron is ran but this is usually not the case during tests. The disk usage can increase to reach more than one 1 Go when design theme is installed. This can lead to unnecessary big database dumps. This is also a problem on odoosh where the filestore max size is limited to 1Go during automated testing. The gc should be quite fast if nothing was changed since it will just check the content of an empty directory. The method is made accessible in the test case in order to be able to gc on demand. This may be useful in the test_01_crawl_every_themes that can generate around 600~ Mo of attachment in the loop. We can also remove the bundle name from assets name The bundle name is irrelevant in the bundle content and will prevent attachment to store the same file if the bundles are exactly the same. Forward-Port-Of: odoo/odoo#101626
Before this commit, the `stock.replenishment.info` wizard form had alignment issues, because of `group` tag, the content was aligned to the left. before: <img width="733" alt="image" src="https://user-images.githubusercontent.com/15212149/194059886-408e6cdc-1a4b-4c89-bcba-69dcfc977b19.png"> after: <img width="738" alt="image" src="https://user-images.githubusercontent.com/15212149/194059732-435c2d8b-de40-4298-b588-5df385c1c1c3.png"> --- I confirm I have signed the CLA and rea
Original PR description
Before this commit, the `stock.replenishment.info` wizard form had alignment issues, because of `group` tag, the content was aligned to the left. before: <img width="733" alt="image" src="https://user-images.githubusercontent.com/15212149/194059886-408e6cdc-1a4b-4c89-bcba-69dcfc977b19.png"> after: <img width="738" alt="image" src="https://user-images.githubusercontent.com/15212149/194059732-435c2d8b-de40-4298-b588-5df385c1c1c3.png"> --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102276
Since new desaign made in point of sale, the payment screen has a HUGE numpad. Payment buttons and other buttons on this screen are too small to be easily touched on a touchscreen. We reduce the space take, by the numpad and give more space to other buttons to make the interface more usable. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at ww
Original PR description
Since new desaign made in point of sale, the payment screen has a HUGE numpad. Payment buttons and other buttons on this screen are too small to be easily touched on a touchscreen. We reduce the space take, by the numpad and give more space to other buttons to make the interface more usable. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102475
Restore the old CSS rule: ```css .o_form_view .o_group .o_field_widget { width: 100%; } ``` Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102524
Original PR description
Restore the old CSS rule:
```css
.o_form_view .o_group .o_field_widget {
width: 100%;
}
```
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#102524Avoid having multiple tooltips. We keep only one "t-field" in the template. The other are replaced by a "t-out". We also add a specific message when the datetime format is not respected. We also fix a traceback that occurs when trying to edit a sub-record of an event in the frontend (track and community room) task-2942617 Forward-Port-Of: odoo/odoo#99382
Original PR description
Avoid having multiple tooltips. We keep only one "t-field" in the template. The other are replaced by a "t-out". We also add a specific message when the datetime format is not respected. We also fix a traceback that occurs when trying to edit a sub-record of an event in the frontend (track and community room) task-2942617 Forward-Port-Of: odoo/odoo#99382
Purpose ======= Fix various form views broken because of the always edit mode. Specifications =========== website_event_questions Avoid truncated question display by making the question field to take all available horizontal space. website_slides Remove unnecessary helpers so that they don't clutter the form view. event_booth Adding placeholder for booth category on event type booth form. survey Fixing the question type previews which have been broken due to the new form g
Original PR description
Purpose ======= Fix various form views broken because of the always edit mode. Specifications =========== website_event_questions Avoid truncated question display by making the question field to take all available horizontal space. website_slides Remove unnecessary helpers so that they don't clutter the form view. event_booth Adding placeholder for booth category on event type booth form. survey Fixing the question type previews which have been broken due to the new form grid layout. Task-3004219 Parent-Task-2996467 Forward-Port-Of: odoo/odoo#101959
Forward-Port-Of: odoo/odoo#102058
Original PR description
Forward-Port-Of: odoo/odoo#102058
Before this fix, the expansion helper did not support formulas in the form LINE1.label / LINE2.label * 100 because "100" couldn't be splitted between line code and expression label. This case is now supported, as it is required for reports needing to compute percentages using other lines' values, like the executive summary. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed t
Original PR description
Before this fix, the expansion helper did not support formulas in the form LINE1.label / LINE2.label * 100 because "100" couldn't be splitted between line code and expression label. This case is now supported, as it is required for reports needing to compute percentages using other lines' values, like the executive summary. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102407
> **[FIX] web: properly align the cp_bottom_right** > > The commit https://github.com/odoo/odoo/commit/e88988f58582d5b49a32d7102a74a176f40c4c69 mistakenly changed a scss rule > for the control panel bottom right section. > > This commit reverse that. > **[FIX] web: align searchmenus when no view switcher** > > _Before this commit_ > The searchmenus are aligned to the right when there is no view switcher. > > _After this commit_ > They are aligned to the left > **[FIX] web:
Original PR description
> **[FIX] web: properly align the cp_bottom_right** > > The commit https://github.com/odoo/odoo/commit/e88988f58582d5b49a32d7102a74a176f40c4c69 mistakenly changed a scss rule > for the control panel…
> **[FIX] web: properly align the cp_bottom_right** > > The commit https://github.com/odoo/odoo/commit/e88988f58582d5b49a32d7102a74a176f40c4c69 mistakenly changed a scss rule > for the control panel bottom right section. > > This commit reverse that. > **[FIX] web: align searchmenus when no view switcher** > > _Before this commit_ > The searchmenus are aligned to the right when there is no view switcher. > > _After this commit_ > They are aligned to the left > **[FIX] web: make mobile viewswitcher look normal** > > _Before this commit_ > The viewswitcher in mobile would take the whole width of the device. > > _After_ > Fixed > > _Explanation_ > The dropdown menu is positioned through the usePosition hook. > > For this hook to compute a position, 019bbef > ceiled all the compared values. > > But it may occur cases where the comparison was missed by a pixel. > > Here we relaxed those comparisons in > manner that they may sometimes be off from 1 pixel, but at least the > positionment behaviour will be better. Forward-Port-Of: odoo/odoo#102485
# Before this commit Suppose that in a form view, there is an x2many list view that would open a form view dialog when edited. For the dialog to open, the concerned record is duplicated and passed in props to a FormRenderer. Now suppose that this form view dialog also has an x2many list view rendered somewhere: the StaticList datapoint attached to this list will have the same context as its parent. This is not what we want because some of the keys of the context does not make sense with the l
Original PR description
# Before this commit Suppose that in a form view, there is an x2many list view that would open a form view dialog when edited. For the dialog to open, the concerned record is duplicated and passed in props to a FormRenderer. Now suppose that this form view dialog also has an x2many list view rendered somewhere: the StaticList datapoint attached to this list will have the same context as its parent. This is not what we want because some of the keys of the context does not make sense with the list's model. In fact, it has led to tracebacks to be displayed in case of we want to open a record of this list in another form view dialog. # After this commit When those lists are created, their context are cleared from their parents' keys starting with "default_" or ending with "_view_ref". Forward-Port-Of: odoo/odoo#101910
Before this commit, in a list view, it is possible to have two records in edit mode at the same time if an error is thrown when saving the editedRecord. The editedRecord is the only list record that can be in edit mode. Why: If a server error is returned when saving the editedRecord, then it stays in edit mode but is no longer considered the editedRecord of the list. It is therefore possible to switch another record to edit mode. Solution: The record that fails its save due to the error
Original PR description
Before this commit, in a list view, it is possible to have two records in edit mode at the same time if an error is thrown when saving the editedRecord. The editedRecord is the only list record that…
Before this commit, in a list view, it is possible to have two records in edit mode at the same time if an error is thrown when saving the editedRecord. The editedRecord is the only list record that can be in edit mode. Why: If a server error is returned when saving the editedRecord, then it stays in edit mode but is no longer considered the editedRecord of the list. It is therefore possible to switch another record to edit mode. Solution: The record that fails its save due to the error should stay the editedRecord of the list. How to reproduce: - Go to a list view - Edit a record - Click on another record (the "write" operation returns an error) - Close the error dialog - Click again on the other record Before this commit: Both records are in edit mode After this commit: Only the edited commit is in edit mode. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102254
Previously, the emoji data that is used in the emoji grid was part of the main assets bundle. This file is almost 500kB and the data it needs is only needed when opening the emoji grid. This commit moves this file into its own bundle and only loads it when opening the emoji grid instead. This PR also batches the inserts in the emoji model, bringing the time it takes to do those inserts from ~8000ms to ~800ms. Enterprise: https://github.com/odoo/enterprise/pull/32449 Forward-Port-Of: odoo/
Original PR description
Previously, the emoji data that is used in the emoji grid was part of the main assets bundle. This file is almost 500kB and the data it needs is only needed when opening the emoji grid. This commit moves this file into its own bundle and only loads it when opening the emoji grid instead. This PR also batches the inserts in the emoji model, bringing the time it takes to do those inserts from ~8000ms to ~800ms. Enterprise: https://github.com/odoo/enterprise/pull/32449 Forward-Port-Of: odoo/odoo#102416
Reproduce: Click "send_reminder_preview" button on purchase form and error raise. Missing check if actions are None or not before get its length. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102453
Original PR description
Reproduce: Click "send_reminder_preview" button on purchase form and error raise. Missing check if actions are None or not before get its length. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102453
Before, carret was not contrasted enough which made it less visible. Now, it's more contrasted and visible. Before:  Now:  Forward-Port-Of: odoo/odoo#102530
Original PR description
Before, carret was not contrasted enough which made it less visible. Now, it's more contrasted and visible. Before:  Now:  Forward-Port-Of: odoo/odoo#102530
Before this commit, in new views, it is no longer possible to click on buttons with barcode_trigger="..." using a barcode scanner. How to reproduce: - Go to a form view with a button with barcode_trigger="doit" - Scan "O-BTN.doit", "Enter". Before this commit: Nothing happens. After this commit: An event click is applied to the button. Forward-Port-Of: odoo/odoo#102279
Original PR description
Before this commit, in new views, it is no longer possible to click
on buttons with barcode_trigger="..." using a barcode scanner.
How to reproduce:
- Go to a form view with a button with barcode_trigger="doit"
- Scan "O-BTN.doit", "Enter".
Before this commit:
Nothing happens.
After this commit:
An event click is applied to the button.
Forward-Port-Of: odoo/odoo#102279The purpose of this commit is to allow the restoration of open pages in notebooks of a form view when switching view. How to reproduce? - Go to a form view with a notebook. - Select a page in the notebook - Go to another view - Use the breadcrumb to go back to the previous form view Before this commit: The page opened in the notebook is the default one (the first one or the autofocus one) After this commit: The page opened in the notebook is the one previously selected Descript
Original PR description
The purpose of this commit is to allow the restoration of open pages in notebooks of a form view when switching view. How to reproduce? - Go to a form view with a notebook. - Select a page in the notebook - Go to another view - Use the breadcrumb to go back to the previous form view Before this commit: The page opened in the notebook is the default one (the first one or the autofocus one) After this commit: The page opened in the notebook is the one previously selected Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102374
enterprise: - https://github.com/odoo/enterprise/pull/32209 task-3005130 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101979
Original PR description
enterprise: - https://github.com/odoo/enterprise/pull/32209 task-3005130 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101979
There was a traceback when closing the session from the pos config. Step to reproduce: 1. Open a session 2. Go to the pos config 3. Try to close the session --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102542
Original PR description
There was a traceback when closing the session from the pos config. Step to reproduce: 1. Open a session 2. Go to the pos config 3. Try to close the session --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102542
Before this commit, in the mrp_production form view, the quantity items were spread out. After this commit, they are closer together. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102549
Original PR description
Before this commit, in the mrp_production form view, the quantity items were spread out. After this commit, they are closer together. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102549
With PRs odoo/#89145 and [enterprise/#26393](https://github.com/odoo/enterprise/pull/26393) came new methods for retrieving XSD files and using them for XML validation. The new retrieval method expects modules to provide a 'prefix' that is prepended to the XSD's filename. For example, l10n_cl_edi will name its XSD files 'l10n_cl_edi.filename.xsd'. However, this messes things up when one XSD file needs to import another. For example, l10n_cl_edi.DTE_v10.xsd has the statement '<xs:include sc
Original PR description
With PRs odoo/#89145 and [enterprise/#26393](https://github.com/odoo/enterprise/pull/26393) came new methods for retrieving XSD files and using them for XML validation. The new retrieval method…
With PRs odoo/#89145 and [enterprise/#26393](https://github.com/odoo/enterprise/pull/26393) came new methods for retrieving XSD files and using them for XML validation. The new retrieval method expects modules to provide a 'prefix' that is prepended to the XSD's filename. For example, l10n_cl_edi will name its XSD files 'l10n_cl_edi.filename.xsd'. However, this messes things up when one XSD file needs to import another. For example, l10n_cl_edi.DTE_v10.xsd has the statement '<xs:include schemaLocation="SiiTypes_v10.xsd"/>' Currently, the filename resolver has no way of knowing that this should resolve to 'l10n_cl_edi.SiiTypes_v10.xsd', not 'SiiTypes_v10.xsd'. In addition, the new retrieval method saves the ZIP archives received over the network under 'filename.xsd'. Thus 'SiiTypes_v10.xsd' might actually be a ZIP-encoded file. So, we need to do something to fix the imports. Here are two possible solutions: 1. We scrap this 'prefix' stuff so that 'SiiTypes_v10.xsd' is the correct file. Either save the ZIP files under a different name, or just don't save them. 2. Or, we provide a mechanism for indicating a prefix to the filename resolver. Personally, I don't see the point in saving the ZIP files, and this 'prefix' stuff seems pointless. So I prefer solution 1. But, because I assume there must be a reason for all of that 'prefix' stuff, here is an implementation of solution 2. I'd be keen to know the reason, btw. EDIT: In addition to the first issue described above, we have the second issue that some XSD files returned by the Chilean SII are encoded using ISO-8859-1 encoding (e.g. SiiTypes_v10.xsd). If we leave them in this encoding, then LXML isn't able to parse them when performing imports. Solution: convert the files to UTF-8 before storing them. Linked PR: https://github.com/odoo/enterprise/pull/31288 Task: 2976749 Forward-Port-Of: odoo/odoo#100110
Add missing feature of the ModelFieldSelector popover : * keyboard navigation * additional debug value * add default value page ( for dynamic placeholder) * add validate callback Migrate dynamic placeholder to be compatible with new OWL field. task-2978722 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101768
Original PR description
Add missing feature of the ModelFieldSelector popover : * keyboard navigation * additional debug value * add default value page ( for dynamic placeholder) * add validate callback Migrate dynamic placeholder to be compatible with new OWL field. task-2978722 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101768
[[FIX] web: currency field: always display currency left](https://github.com/odoo/odoo/pull/102359/commits/458189b6f1ebe585a59947465ddb467a59b66015) fix display of monetary fields by moving the currency symbol in front of the input https://app.excalidraw.com/l/65VNwvy7c4X/AuqaUljZ1Sl [[FIX] web: currency field: correctly align currencies](https://github.com/odoo/odoo/pull/102359/commits/a0957d102e796733b9d97e8283de3c81d76f891d) before, currencies were not aligned properly with the input field
Original PR description
[[FIX] web: currency field: always display currency left](https://github.com/odoo/odoo/pull/102359/commits/458189b6f1ebe585a59947465ddb467a59b66015) fix display of monetary fields by moving the currency symbol in front of the input https://app.excalidraw.com/l/65VNwvy7c4X/AuqaUljZ1Sl [[FIX] web: currency field: correctly align currencies](https://github.com/odoo/odoo/pull/102359/commits/a0957d102e796733b9d97e8283de3c81d76f891d) before, currencies were not aligned properly with the input field. now, it is properly aligned. Forward-Port-Of: odoo/odoo#102359
Remove no longer needed `!important` on `overflow: visible` because the new list view doesn't have any stacking context issues. Thanks to the `o_PopoverManager` inside the `o-main-components-container`. Steps to reproduce: > Open the helpdesk app > Click on VIP Support tickets > Go to the list view > reduce the size of the activities column => it's produce text contain overlapping with the other column => bug Description of the issue/feature this PR addresses: Current behavior
Original PR description
Remove no longer needed `!important` on `overflow: visible` because the new list view doesn't have any stacking context issues. Thanks to the `o_PopoverManager` inside the `o-main-components-container`. Steps to reproduce: > Open the helpdesk app > Click on VIP Support tickets > Go to the list view > reduce the size of the activities column => it's produce text contain overlapping with the other column => bug Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102413
The tour contains this part: 1. Change the font-size 2. Click on save 3. Check that edit mode was left 4. Check the font-size is ok The problem is that step 1 induces a series of RPC and processing (rebuilding assets, reloading them in the client, etc) but those are not awaited before going into step 2 which also induces a RPC (the save) which is only done once the other RPC are finished. While we will try to optimize the duration of those RPC in the future. Meanwhile we could simply
Original PR description
The tour contains this part: 1. Change the font-size 2. Click on save 3. Check that edit mode was left 4. Check the font-size is ok The problem is that step 1 induces a series of RPC and processing (rebuilding assets, reloading them in the client, etc) but those are not awaited before going into step 2 which also induces a RPC (the save) which is only done once the other RPC are finished. While we will try to optimize the duration of those RPC in the future. Meanwhile we could simply increase to the timeout of step 3 but it seems better to change the tour to divide the multiple things to await: 1. Change the font-size 2. Check the font-size is ok 3. Click on save 4. Check that edit mode was left 5. Check the font-size is still ok runbot-4706 Forward-Port-Of: odoo/odoo#102478
TaskId-3010484 Forward-Port-Of: odoo/odoo#102550
Original PR description
TaskId-3010484 Forward-Port-Of: odoo/odoo#102550
The percentage pie field was broken in enterprise, because the rules that it needs are overwritten in enterprise but scoped to the legacy version only. This commit moves the community rules so that they always apply and are not overwritten, it also removes an extra level of wrapper on the field. enterprise: https://github.com/odoo/enterprise/pull/32463 Forward-Port-Of: odoo/odoo#102552
Original PR description
The percentage pie field was broken in enterprise, because the rules that it needs are overwritten in enterprise but scoped to the legacy version only. This commit moves the community rules so that they always apply and are not overwritten, it also removes an extra level of wrapper on the field. enterprise: https://github.com/odoo/enterprise/pull/32463 Forward-Port-Of: odoo/odoo#102552
The current homeworking module doesn't answer the standard of quality. For now It will be removed from the settings and app store so it is not visible to any users. It will return after it has been reviewed and improved. task-2995332 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101093
Original PR description
The current homeworking module doesn't answer the standard of quality. For now It will be removed from the settings and app store so it is not visible to any users. It will return after it has been reviewed and improved. task-2995332 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101093
Fixed the style of some filters inputs (namely date filters) and added placeholders for dashboard mode. task 2995579 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101955
Original PR description
Fixed the style of some filters inputs (namely date filters) and added placeholders for dashboard mode. task 2995579 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#101955
The text about journal was broken, with a colspan it solves the issues task-id: 3007658 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102199
Original PR description
The text about journal was broken, with a colspan it solves the issues task-id: 3007658 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102199
This PR adapts the form views since the merge of #100570. task-3010032 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102499
Original PR description
This PR adapts the form views since the merge of #100570. task-3010032 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102499
OWLified qty_at_date_widget. Implementation notes: - 2 views = 2 widgets At time of conversion there was a bug where <widget> is not parsed by list view (feature was missed during its OWLification), but it is parsed by the form view => both a view_widget (for the form view, i.e. mobile version) and a field_widget (temporary hack for one2many list field) were created. Luckily they can have exactly the same functionality. TLDR: TODO: field_widget version to be removed after list views can handl
Original PR description
OWLified qty_at_date_widget. Implementation notes: - 2 views = 2 widgets At time of conversion there was a bug where <widget> is not parsed by list view (feature was missed during its OWLification),…
OWLified qty_at_date_widget. Implementation notes: - 2 views = 2 widgets At time of conversion there was a bug where <widget> is not parsed by list view (feature was missed during its OWLification), but it is parsed by the form view => both a view_widget (for the form view, i.e. mobile version) and a field_widget (temporary hack for one2many list field) were created. Luckily they can have exactly the same functionality. TLDR: TODO: field_widget version to be removed after list views can handle <widget> again - old popup using jquery is obsolete so a new Popup component is used instead. Note that original widget updated the record data directly whereas we now have a separate variable to keep the props consistent as per OWL standard. - sale_stock.xml is renamed to delay_alert.xml because xml related to this widget was moved into a separate file whereas the remaining xml data is not directly called by JS but is still static and used by another widget eventually ENT PR: https://github.com/odoo/enterprise/pull/32276 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102139
This commit fixes some css issues in the "Settings" tab of the project form view. The settings descriptions were wrapping at half the width they were supposed to, and the settings were misaligned compared to the sections titles. Enterprise: https://github.com/odoo/enterprise/pull/32359 Forward-Port-Of: odoo/odoo#102331
Original PR description
This commit fixes some css issues in the "Settings" tab of the project form view. The settings descriptions were wrapping at half the width they were supposed to, and the settings were misaligned compared to the sections titles. Enterprise: https://github.com/odoo/enterprise/pull/32359 Forward-Port-Of: odoo/odoo#102331
This commit removes legacy views that are not used anymore as they have been converted to owl. They could actually have been removed in the commit that converted them, as we never needed to have a double implementation of views, unlike we need to (field) widgets. The LazyColumnList is a special case. This view hasn't been converted. Instead, it has been decided not to use it anymore. So it was dead code, and this commit removes it. The form/list/kanban views are no longer necessary in the
Original PR description
This commit removes legacy views that are not used anymore as they have been converted to owl. They could actually have been removed in the commit that converted them, as we never needed to have a double implementation of views, unlike we need to (field) widgets. The LazyColumnList is a special case. This view hasn't been converted. Instead, it has been decided not to use it anymore. So it was dead code, and this commit removes it. The form/list/kanban views are no longer necessary in the view registry, since their owl version exists. However, we kept them in the test asset, as they are massively used in legacy tests (in field tests for instance). Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102540
Before this commit, some mouseenter and mouseleave handlers were prone to raising a traceback due not being properly guarded. Forward-Port-Of: odoo/odoo#102574
Original PR description
Before this commit, some mouseenter and mouseleave handlers were prone to raising a traceback due not being properly guarded. Forward-Port-Of: odoo/odoo#102574
Steps to reproduce: - Install sale_ebay, - Some accounting localization - Go to currencies and check the box saying it can be use with eBay - Go to attributes and create two of them - Create a product - Put the attributes - Go to the eBay tab of the product - Put fixed price to the listing type field - try to check one of the product variant Current behavior: Error: Database fetch misses ids ((<NewId origin=3>,<NewId origin=4>) and has extra ids ((3, 4)), may be caused by a type i
Original PR description
Steps to reproduce: - Install sale_ebay, - Some accounting localization - Go to currencies and check the box saying it can be use with eBay - Go to attributes and create two of them - Create a product - Put the attributes - Go to the eBay tab of the product - Put fixed price to the listing type field - try to check one of the product variant Current behavior: Error: Database fetch misses ids ((<NewId origin=3>,<NewId origin=4>) and has extra ids ((3, 4)), may be caused by a type incoherence in a previous request Expected behavior: No error Explanation: In this situation the product_variant_ids are newID and we can use only read on their origin record. opw-2974596 Forward-Port-Of: odoo/odoo#100655
Commit [1] broken the standalone tour of website's themes, which is run in nightly only (sadly). That tour was added a few months ago with [2] which was tested the fix done by [3]. [1]: https://github.com/odoo/odoo/commit/fcf6e462e116d13533014e31d4191763354811cf [2]: https://github.com/odoo/design-themes/commit/0e324061d1c4437ef19d07f23eaf5663cb8fe657 [3]: https://github.com/odoo/odoo/commit/bed3cd54a5c7baeab173129036246bef543eef94 Forward-Port-Of: odoo/odoo#102439
Original PR description
Commit [1] broken the standalone tour of website's themes, which is run in nightly only (sadly). That tour was added a few months ago with [2] which was tested the fix done by [3]. [1]: https://github.com/odoo/odoo/commit/fcf6e462e116d13533014e31d4191763354811cf [2]: https://github.com/odoo/design-themes/commit/0e324061d1c4437ef19d07f23eaf5663cb8fe657 [3]: https://github.com/odoo/odoo/commit/bed3cd54a5c7baeab173129036246bef543eef94 Forward-Port-Of: odoo/odoo#102439
SCSS optimization of the right side panel in project module. Remove custom SCSS and use Bootstrap classes instead. task-[2977963](https://www.odoo.com/web#id=2977963&menu_id=4720&cids=1&action=333&active_id=133&model=project.task&view_type=form) Requires : https://github.com/odoo/enterprise/pull/31094 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#99453
Original PR description
SCSS optimization of the right side panel in project module. Remove custom SCSS and use Bootstrap classes instead. task-[2977963](https://www.odoo.com/web#id=2977963&menu_id=4720&cids=1&action=333&active_id=133&model=project.task&view_type=form) Requires : https://github.com/odoo/enterprise/pull/31094 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#99453
Converts the legacy reception report into WOWL. Fixes 'Assign All' buttons disappearing from the report until it is reloaded when clicking on them. Removes references to 'report_type == html' from xml since it is only used as PDF now. Part of the global conversion of stock to WOWL. Part of task-2885757 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100710
Original PR description
Converts the legacy reception report into WOWL. Fixes 'Assign All' buttons disappearing from the report until it is reloaded when clicking on them. Removes references to 'report_type == html' from xml since it is only used as PDF now. Part of the global conversion of stock to WOWL. Part of task-2885757 -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100710
The /web loading was slow during test when some themes are installed. This is because the bundle pregenerate before post install are not the same version as the one asked when browsing /web This is because without any context and request, the assets are generated for website 1 before this fix. With this default website: - _get_active_addons_list returns only addons that are not themes - _get_asset_paths will return less assets When loading /web, no website is found because the do
Original PR description
The /web loading was slow during test when some themes are installed. This is because the bundle pregenerate before post install are not the same version as the one asked when browsing /web This is…
The /web loading was slow during test when some themes are installed.
This is because the bundle pregenerate before post install are not the same version as the one asked when browsing /web
This is because without any context and request, the assets are generated for website 1 before this fix.
With this default website:
- _get_active_addons_list returns only addons that are not themes
- _get_asset_paths will return less assets
When loading /web, no website is found because the domain is not empty.
This means that the web.assets_backend will have less assets when generated outside of a request than in a request not matching any website.
There is normally no assets for the backend in theme BUT a tour is added in each theme
```
('/theme_anelusia/static/src/js/tour.js', 'theme_anelusia', 'website.assets_editor')
('/theme_artists/static/src/js/tour.js', 'theme_artists', 'website.assets_editor')
('/theme_avantgarde/static/src/js/tour.js', 'theme_avantgarde', 'website.assets_editor')
('/theme_aviato/static/src/js/tour.js', 'theme_aviato', 'website.assets_editor')
('/theme_beauty/static/src/js/tour.js', 'theme_beauty', 'website.assets_editor')
('/theme_bewise/static/src/js/tour.js', 'theme_bewise', 'website.assets_editor')
('/theme_bistro/static/src/js/tour.js', 'theme_bistro', 'website.assets_editor')
('/theme_bookstore/static/src/js/tour.js', 'theme_bookstore', 'website.assets_editor')
('/theme_buzzy/static/src/js/tour.js', 'theme_buzzy', 'website.assets_editor')
('/theme_clean/static/src/js/tour.js', 'theme_clean', 'website.assets_editor')
('/theme_cobalt/static/src/js/tour.js', 'theme_cobalt', 'website.assets_editor')
('/theme_enark/static/src/js/tour.js', 'theme_enark', 'website.assets_editor')
('/theme_graphene/static/src/js/tour.js', 'theme_graphene', 'website.assets_editor')
('/theme_kea/static/src/js/tour.js', 'theme_kea', 'website.assets_editor')
('/theme_kiddo/static/src/js/tour.js', 'theme_kiddo', 'website.assets_editor')
('/theme_loftspace/static/src/js/tour.js', 'theme_loftspace', 'website.assets_editor')
('/theme_monglia/static/src/js/tour.js', 'theme_monglia', 'website.assets_editor')
('/theme_nano/static/src/js/tour.js', 'theme_nano', 'website.assets_editor')
('/theme_notes/static/src/js/tour.js', 'theme_notes', 'website.assets_editor')
('/theme_odoo_experts/static/src/js/tour.js', 'theme_odoo_experts', 'website.assets_editor')
('/theme_orchid/static/src/js/tour.js', 'theme_orchid', 'website.assets_editor')
('/theme_paptic/static/src/js/tour.js', 'theme_paptic', 'website.assets_editor')
('/theme_real_estate/static/src/js/tour.js', 'theme_real_estate', 'website.assets_editor')
('/theme_treehouse/static/src/js/tour.js', 'theme_treehouse', 'website.assets_editor')
('/theme_vehicle/static/src/js/tour.js', 'theme_vehicle', 'website.assets_editor')
('/theme_yes/static/src/js/tour.js', 'theme_yes', 'website.assets_editor')
('/theme_zap/static/src/js/tour.js', 'theme_zap', 'website.assets_editor')
```
Making the bundles for /web different with or without theme, and with or without website id.
The proposed fix wont return a website if not specified in context and if not during a request and if not forced to fallback.
The side effect is that the frontend assets where generated with a website id 1 before that and it won't be the case anymore. This may be a problem that could slow down frontend call on website 1 when design theme is installed.
Forward-Port-Of: odoo/odoo#101780… imported as vendor bill Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100530
Original PR description
… imported as vendor bill Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100530
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100825
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#100825
Purpose: fix domain widget rendering that was broken inside a group with nolabel="1". Task-3007130 Forward-Port-Of: odoo/odoo#102141
Original PR description
Purpose: fix domain widget rendering that was broken inside a group with nolabel="1". Task-3007130 Forward-Port-Of: odoo/odoo#102141
The pencil for the edit of the tax present in the tax total widget was too close of the amount, by adding a padding it's now corrected --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102333
Original PR description
The pencil for the edit of the tax present in the tax total widget was too close of the amount, by adding a padding it's now corrected --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102333
In Knowledge, we would like to disable the autofocus of the view search bar when the view is embedded in an article. Disableling the autofocus will ensure that: 1) The cursor of the user will not be teleported to the view search bar when loading an embedded view. 2) The autofocus will not trigger a page scroll when the view search bar is not visible on screen. To disable the autofocus, we will simply add a new key in the default configuration of the view. By default, the autofocus of the
Original PR description
In Knowledge, we would like to disable the autofocus of the view search bar when the view is embedded in an article. Disableling the autofocus will ensure that: 1) The cursor of the user will not be teleported to the view search bar when loading an embedded view. 2) The autofocus will not trigger a page scroll when the view search bar is not visible on screen. To disable the autofocus, we will simply add a new key in the default configuration of the view. By default, the autofocus of the view search bar will be active as it was the case before. task-3004117 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#102270
[FIX] web_editor, website: restore style of the autocomplete dropdown Before this commit, the autocomplete dropdown no longer had a maximum height, which meant that when it contained a lot of elements, it hid the entire editor panel. Indeed, since the CSS of the menu snippet is no longer that of the "frontend", the 'max-height' CSS rule defined for the autocomplete dropdown in the frontend (introduced by this commit: [1]) was no longer applied on the autocomplete dropdown of the backend
Original PR description
[FIX] web_editor, website: restore style of the autocomplete dropdown Before this commit, the autocomplete dropdown no longer had a maximum height, which meant that when it contained a lot of…
[FIX] web_editor, website: restore style of the autocomplete dropdown Before this commit, the autocomplete dropdown no longer had a maximum height, which meant that when it contained a lot of elements, it hid the entire editor panel. Indeed, since the CSS of the menu snippet is no longer that of the "frontend", the 'max-height' CSS rule defined for the autocomplete dropdown in the frontend (introduced by this commit: [1]) was no longer applied on the autocomplete dropdown of the backend. In this commit, we therefore moved this css code of the 'ui-autocomplete' defined for the frontend into the common css file (backend + frontend) in order to return to a situation where this code was applied to all autocomplete dropdowns in Website. And thanks to that, we were able to remove the css file "edit_menu.scss" which copied/pasted the frontend 'ui-autocomplete' code for only one of the backend 'ui-autocomplete'. [1]: https://github.com/odoo/odoo/commit/032dd007157de00b683a9d753aa929741c107c01 task-2900529 Forward-Port-Of: odoo/odoo#101909
During the port of social to OWL, see: https://github.com/odoo/enterprise/pull/31992 Some tests were lost to speed up the merge. This commit re-instates those tests. Task-2855647 Forward-Port-Of: odoo/enterprise#32466
Original PR description
During the port of social to OWL, see: https://github.com/odoo/enterprise/pull/31992 Some tests were lost to speed up the merge. This commit re-instates those tests. Task-2855647 Forward-Port-Of: odoo/enterprise#32466
This PR will gather several fixes and improvements for the recently introduced embedded views in Knowledge. It will be the final touch before the Odoo Experience event. It will: - Revamp the layout of the embedded views: The embedded view will no longer have a scrollbar, the loader will be more consistent with the other blocks, etc. - Change the description of the /kanban and /list to make it clearer. - Reduce the number of records loaded by the embedded view. - Make sure that the editor o
Original PR description
This PR will gather several fixes and improvements for the recently introduced embedded views in Knowledge. It will be the final touch before the Odoo Experience event. It will: - Revamp the layout…
This PR will gather several fixes and improvements for the recently introduced embedded views in Knowledge. It will be the final touch before the Odoo Experience event. It will: - Revamp the layout of the embedded views: The embedded view will no longer have a scrollbar, the loader will be more consistent with the other blocks, etc. - Change the description of the /kanban and /list to make it clearer. - Reduce the number of records loaded by the embedded view. - Make sure that the editor opens the newly created article when the user clicks on the 'create' button of the article item view list (after clicking on the "open" button of the embedded view). - Make sure that the newly created articles will have an empty h1 title in their body. - Disable the auto-focus of the embedded view search bars which caused flickers. - Change the columns displayed on the article list view and the article items list views. - Remove dead code. task-3004117 Forward-Port-Of: odoo/enterprise#32327
Fix move article rejection - - When moving an article under a readonly parent (which is not allowed), no feedback was shown: when drag/dropping an article, the article moved back to its previous position, and when using the "Move To" dialog, nothing happened at all. Now, an Access Error alert is shown in both cases, so that the user knows why the article did not move. - When the article had been moved back to its previous position when drag/ dropping an article as a child of a readonl
Original PR description
Fix move article rejection - - When moving an article under a readonly parent (which is not allowed), no feedback was shown: when drag/dropping an article, the article moved back to its previous…
Fix move article rejection - - When moving an article under a readonly parent (which is not allowed), no feedback was shown: when drag/dropping an article, the article moved back to its previous position, and when using the "Move To" dialog, nothing happened at all. Now, an Access Error alert is shown in both cases, so that the user knows why the article did not move. - When the article had been moved back to its previous position when drag/ dropping an article as a child of a readonly parent, the caret of the "falsy" readonly parent was not removed when the "falsy" parent had no child article before the drag&drop. Now, the caret is hidden in this scenario, as expected since the article has no child after the cancellation. Fix properties layout - Add style to show the "external link" icon next to many2one properties that was hidden, and to show entirely the box of the property name when moving a property (left edge was not shown) Fix autofocus inside the article body - When opening an article, the focus is not set inside the body of the article anymore. Now, when opening an article, the focus is set inside the body of the article, only if the article has an empty title: `focus()` places the cursor at the beginning of the body, which is not handy when the article already has some content. Use new emoji list for random emoji picker - Instead of using the old and small list of emojis for picking an emoji at random when clicking on the "Add icon" button, use the new one which contains much more emojis, and which is currently used for the emoji picker. The list of disallowed emojis has been updated accordingly, removing some emojis of it as the chances of picking them at random are very small, but adding some that we really do not want to show (eg. the middle finger). Prevent closing share panel on invite modal click - Previously, when inviting someone to an article, a click anywhere on the screen (including on the invite modal and its fields) closed the share panel. Now, the share panel cannot be closed when the invite modal is shown, so that the user can see the members that already have access to the article, and know which other people he should send an invitation to. Task-3004122 Forward-Port-Of: odoo/enterprise#32263
Forward-Port-Of: odoo/enterprise#31633
Original PR description
Forward-Port-Of: odoo/enterprise#31633
In the present the rental configurator wizard was opening on the sales and subscription app, this wizard should open only on the rental app. The problem came from the wizard not being aware of which app was being used. After this commit the rental configurator will only open on the rental app. Task - 3002268 Forward-Port-Of: odoo/enterprise#32164
Original PR description
In the present the rental configurator wizard was opening on the sales and subscription app, this wizard should open only on the rental app. The problem came from the wizard not being aware of which app was being used. After this commit the rental configurator will only open on the rental app. Task - 3002268 Forward-Port-Of: odoo/enterprise#32164
A few bugs crept in since the introduction of: - The new report engine (see https://github.com/odoo/enterprise/commit/7a0f4b0ffff6803446da1527f8875372f39d2561) - The custom report handler that accompanies it (see https://github.com/odoo/enterprise/commit/03d9353d85ed80c6e44fd231e5340d2378af8c81) This PR addresses them. task-2987946 Forward-Port-Of: odoo/enterprise#31586
Original PR description
A few bugs crept in since the introduction of: - The new report engine (see https://github.com/odoo/enterprise/commit/7a0f4b0ffff6803446da1527f8875372f39d2561) - The custom report handler that accompanies it (see https://github.com/odoo/enterprise/commit/03d9353d85ed80c6e44fd231e5340d2378af8c81) This PR addresses them. task-2987946 Forward-Port-Of: odoo/enterprise#31586
SCSS optimization of the right side panel in project module. Remove custom SCSS and use Bootstrap classes instead. task-[2977963](https://www.odoo.com/web#id=2977963&menu_id=4720&cids=1&action=333&active_id=133&model=project.task&view_type=form) Requires: https://github.com/odoo/odoo/pull/99453 Forward-Port-Of: odoo/enterprise#31094
Original PR description
SCSS optimization of the right side panel in project module. Remove custom SCSS and use Bootstrap classes instead. task-[2977963](https://www.odoo.com/web#id=2977963&menu_id=4720&cids=1&action=333&active_id=133&model=project.task&view_type=form) Requires: https://github.com/odoo/odoo/pull/99453 Forward-Port-Of: odoo/enterprise#31094
Auditing a cell in different column groups always gave the same result (corresponding to the base options dictionary, without splitting them per column group). This was wrong: the audit result should directly correspond to the cell amount. Forward-Port-Of: odoo/enterprise#32325
Original PR description
Auditing a cell in different column groups always gave the same result (corresponding to the base options dictionary, without splitting them per column group). This was wrong: the audit result should directly correspond to the cell amount. Forward-Port-Of: odoo/enterprise#32325
This commit removes legacy views that are not used anymore as they have been converted to owl. They could actually have been removed in the commit that converted them, as we never needed to have a double implementation of views, unlike we need to (field) widgets. In the community PR odoo/odoo#102540 removes the form and list views from the view registry, so this commit directly imports them in Studio. Those two views are a special case in v16, since we use the owl implementation outside studi
Original PR description
This commit removes legacy views that are not used anymore as they have been converted to owl. They could actually have been removed in the commit that converted them, as we never needed to have a double implementation of views, unlike we need to (field) widgets. In the community PR odoo/odoo#102540 removes the form and list views from the view registry, so this commit directly imports them in Studio. Those two views are a special case in v16, since we use the owl implementation outside studio, but still the legacy one in studio. Forward-Port-Of: odoo/enterprise#32457
This PR fixes some css issues in the "Settings" tab of the project form view. The settings descriptions were wrapping at half the width they were supposed to. Community: https://github.com/odoo/odoo/pull/102331 Forward-Port-Of: odoo/enterprise#32359
Original PR description
This PR fixes some css issues in the "Settings" tab of the project form view. The settings descriptions were wrapping at half the width they were supposed to. Community: https://github.com/odoo/odoo/pull/102331 Forward-Port-Of: odoo/enterprise#32359
Rental products display different info in their qty_at_date_widget popup, so we OWLify it to match the original widget it extends. Implementation notes: - cleaned up the naming a bit - fixed the weird loss of date conversion added by that seemed to have no purpose (but didn't work in the OWL template) https://github.com/odoo/enterprise/pull/31854/commits/a4953a86f436e69565f6ecdc9c82a08de4925e6b - left the `restrict_renting_products` context in even though I suspect it may not do anything a
Original PR description
Rental products display different info in their qty_at_date_widget popup, so we OWLify it to match the original widget it extends. Implementation notes: - cleaned up the naming a bit - fixed the weird loss of date conversion added by that seemed to have no purpose (but didn't work in the OWL template) https://github.com/odoo/enterprise/pull/31854/commits/a4953a86f436e69565f6ecdc9c82a08de4925e6b - left the `restrict_renting_products` context in even though I suspect it may not do anything anymore COM PR: odoo/odoo#102139 Forward-Port-Of: odoo/enterprise#32276
This PR adapts the form views since the merge of #100570. task-3010032 Forward-Port-Of: odoo/enterprise#32437
Original PR description
This PR adapts the form views since the merge of #100570. task-3010032 Forward-Port-Of: odoo/enterprise#32437
Some filters inputs were not properly expanding in the whole width of the panel. task 2995579 Forward-Port-Of: odoo/enterprise#32193
Original PR description
Some filters inputs were not properly expanding in the whole width of the panel. task 2995579 Forward-Port-Of: odoo/enterprise#32193
The current homeworking module doesn't answer the standard of quality. For now It will be removed from the settings and app store so it is not visible to any users. It will return after it has been reviewed and improved. task-2995332 Forward-Port-Of: odoo/enterprise#31762
Original PR description
The current homeworking module doesn't answer the standard of quality. For now It will be removed from the settings and app store so it is not visible to any users. It will return after it has been reviewed and improved. task-2995332 Forward-Port-Of: odoo/enterprise#31762
Removes the pages by location to have only one page. The locations (source and destination) are now displayed on each line. Forward-Port-Of: odoo/enterprise#30979
Original PR description
Removes the pages by location to have only one page. The locations (source and destination) are now displayed on each line. Forward-Port-Of: odoo/enterprise#30979
A query used by the partner ledger report was not making use of the tables returned by the query_get(), but was using its where_clause. Because of that, depending on the content of the options dict, it was possible that the where_clause referenced joined tables that did not exist (for example, account_move_line__move_id, if any domain computed from the options needed to access a field on the lines' parent move), leading to a crash when trying to run the query. Forward-Port-Of: odoo/enterprise#3
Original PR description
A query used by the partner ledger report was not making use of the tables returned by the query_get(), but was using its where_clause. Because of that, depending on the content of the options dict, it was possible that the where_clause referenced joined tables that did not exist (for example, account_move_line__move_id, if any domain computed from the options needed to access a field on the lines' parent move), leading to a crash when trying to run the query. Forward-Port-Of: odoo/enterprise#32406
Follow-up of fd916b7c52e8c7b3b7a3aaac61f0408339799ade for `>=saas-15.3`. When items are exempt amount_total is wrong, just like the rest. It's because the sale module in `saas-15.3` started using env['account.tax']._prepare_tax_totals_json(...) which doesn't take an amount_total parameter like env['account.move']._get_tax_totals() which was used in `<saas-15.3`. _prepare_tax_totals_json will calculate its own summed total which will be wrong. opw-3010212 Forward-Port-Of: odo
Original PR description
Follow-up of fd916b7c52e8c7b3b7a3aaac61f0408339799ade for `>=saas-15.3`. When items are exempt amount_total is wrong, just like the rest. It's because the sale module in `saas-15.3` started using env['account.tax']._prepare_tax_totals_json(...) which doesn't take an amount_total parameter like env['account.move']._get_tax_totals() which was used in `<saas-15.3`. _prepare_tax_totals_json will calculate its own summed total which will be wrong. opw-3010212 Forward-Port-Of: odoo/enterprise#32467 Forward-Port-Of: odoo/enterprise#32452
This css doesn't specialize the field and is useless. Community: https://github.com/odoo/odoo/pull/102552 Forward-Port-Of: odoo/enterprise#32463
Original PR description
This css doesn't specialize the field and is useless. Community: https://github.com/odoo/odoo/pull/102552 Forward-Port-Of: odoo/enterprise#32463
see https://github.com/odoo/odoo/pull/101768 task-2978722 Forward-Port-Of: odoo/enterprise#32461
Original PR description
see https://github.com/odoo/odoo/pull/101768 task-2978722 Forward-Port-Of: odoo/enterprise#32461
Since PR #26393 the XSD files are now called 'l10n_cl_edi.filename.xsd', not 'filename.xsd' In fact, 'filename.xsd' is the ZIP file that was received from SII containing the XSD file. So, we need to update those filenames in the code. Linked PR: https://github.com/odoo/odoo/pull/100110 Task: 2976749 Forward-Port-Of: odoo/enterprise#31288
Original PR description
Since PR #26393 the XSD files are now called 'l10n_cl_edi.filename.xsd', not 'filename.xsd' In fact, 'filename.xsd' is the ZIP file that was received from SII containing the XSD file. So, we need to update those filenames in the code. Linked PR: https://github.com/odoo/odoo/pull/100110 Task: 2976749 Forward-Port-Of: odoo/enterprise#31288
LU General Ledger report was not updated to the reportalypse and FAIA is not available in 16.0. This commit adds FAIA download option back. Forward-Port-Of: odoo/enterprise#32456
Original PR description
LU General Ledger report was not updated to the reportalypse and FAIA is not available in 16.0. This commit adds FAIA download option back. Forward-Port-Of: odoo/enterprise#32456
requires: - https://github.com/odoo/odoo/pull/101979 task-3005130 Forward-Port-Of: odoo/enterprise#32209
Original PR description
requires: - https://github.com/odoo/odoo/pull/101979 task-3005130 Forward-Port-Of: odoo/enterprise#32209
### OPW 2945104 The CFDI for the payment with version 4 now has the element "pago20" instead of the "pago10" that the 3.3 had. So in the report, the info was being retrieved from the "pago10" which doesn't exist with version 4.0 Now if there is no "pago10" element it will search for the "pago20" element. Before  After ![Ticket 19499 - After](https://user-
Original PR description
### OPW 2945104 The CFDI for the payment with version 4 now has the element "pago20" instead of the "pago10" that the 3.3 had. So in the report, the info was being retrieved from the "pago10" which doesn't exist with version 4.0 Now if there is no "pago10" element it will search for the "pago20" element. Before  After  Forward-Port-Of: odoo/enterprise#30103
Adapt knowledge module so that it explicitly load emoji data, which is now lazy-loaded. Community: https://github.com/odoo/odoo/pull/102416 Forward-Port-Of: odoo/enterprise#32449
Original PR description
Adapt knowledge module so that it explicitly load emoji data, which is now lazy-loaded. Community: https://github.com/odoo/odoo/pull/102416 Forward-Port-Of: odoo/enterprise#32449
The formulas of the executive summary computing a percentage were wrong: instead of giving a result between 0 and 100, they gave one between 0 and 1. Forward-Port-Of: odoo/enterprise#32389
Original PR description
The formulas of the executive summary computing a percentage were wrong: instead of giving a result between 0 and 100, they gave one between 0 and 1. Forward-Port-Of: odoo/enterprise#32389
When computing the report, engines don't round the amounts they return. Because of that, some amounts that should be 0 will instead be very small floats (like 1e-20, for example). If those amounts needed to be used in an aggregation, this failed when trying to expand the aggregation formula, because the "-" before the "e" was identified as an operator, and the terms were split in such a way that 1e could not be evaluated. We solve that by rounding all the amounts obtained from other expressio
Original PR description
When computing the report, engines don't round the amounts they return. Because of that, some amounts that should be 0 will instead be very small floats (like 1e-20, for example). If those amounts needed to be used in an aggregation, this failed when trying to expand the aggregation formula, because the "-" before the "e" was identified as an operator, and the terms were split in such a way that 1e could not be evaluated. We solve that by rounding all the amounts obtained from other expressions, as they will be rounded in the report anyway. We also avoid futher rounding issues doing so. Forward-Port-Of: odoo/enterprise#32333
Prior to this commit the notification was only triggered when the save button is clicked. This commit ensures that the same behavior occurs when exiting the current view through the use of the breadcrum or other means. task-3009063 Forward-Port-Of: odoo/enterprise#32394
Original PR description
Prior to this commit the notification was only triggered when the save button is clicked. This commit ensures that the same behavior occurs when exiting the current view through the use of the breadcrum or other means. task-3009063 Forward-Port-Of: odoo/enterprise#32394
*: hr_appraisal, hr_referral, l10n_be_hr_payroll This PR adapts the form views since the merge of odoo/odoo#100570. task-3002465 Forward-Port-Of: odoo/enterprise#32266
Original PR description
*: hr_appraisal, hr_referral, l10n_be_hr_payroll This PR adapts the form views since the merge of odoo/odoo#100570. task-3002465 Forward-Port-Of: odoo/enterprise#32266
Use 'iot/device_controller' instead of 'ComponentAdapter' (from web.OwlCompatibility) To instantiate the 'iotDevice' device closes odoo/enterprise#31489 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com> Forward-Port-Of: odoo/enterprise#32417
Original PR description
Use 'iot/device_controller' instead of 'ComponentAdapter' (from web.OwlCompatibility) To instantiate the 'iotDevice' device closes odoo/enterprise#31489 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com> Forward-Port-Of: odoo/enterprise#32417
Since a Payroll tab is now existing on a job position configuration in the recruitment app, all information regarding a belgian company can be grouped in the same Payroll tab. This commit moves the CP200 Category field in the Payroll tab for a belgian company. task-3001025 Forward-Port-Of: odoo/enterprise#32355 Forward-Port-Of: odoo/enterprise#32244
Original PR description
Since a Payroll tab is now existing on a job position configuration in the recruitment app, all information regarding a belgian company can be grouped in the same Payroll tab. This commit moves the CP200 Category field in the Payroll tab for a belgian company. task-3001025 Forward-Port-Of: odoo/enterprise#32355 Forward-Port-Of: odoo/enterprise#32244
Purpose ======= Purpose of this task is to improve performances of knowledge by * removing or delaying RPCs when possible; * removing queries by optimizing code; This merge does not contain any functional change. Specifications ============== Lessen RPCs when displaying or switching articles * fetch chatter data only when discuss panel is loaded; * fetch permission data only when permission (share) panel is loaded; * fetch properties data only when togging properties
Original PR description
Purpose ======= Purpose of this task is to improve performances of knowledge by * removing or delaying RPCs when possible; * removing queries by optimizing code; This merge does not contain any…
Purpose
=======
Purpose of this task is to improve performances of knowledge by
* removing or delaying RPCs when possible;
* removing queries by optimizing code;
This merge does not contain any functional change.
Specifications
==============
Lessen RPCs when displaying or switching articles
* fetch chatter data only when discuss panel is loaded;
* fetch permission data only when permission (share) panel is loaded;
* fetch properties data only when togging properties panel, on click
when choosing properties on an article item;
Lessen queries
* improve batch computation when inviting people;
* improve batch computation when sending invite emails;
* improve batch computation when duplicating articles;
See sub commits for more details.
Gains
=====
Some gains coming with this branch, using a database with 'website_knowledge'
installed
* home -> workspace article: from 16 RPs to 8 (no chatter loaded on previous
article save + update + new article fetch, no permission, less onchange);
* toggling chatter: 2 RPCs anyway;
* togging share: 0 RPcs to 1 (as permission data is loaded)
* create: 10 RPCs to 4 RPCs (+avatar)
Various tests show that query counters are decreased in various situations.
Task-3004723
Forward-Port-Of: odoo/enterprise#32192