Odoo Changelog — 2022-11-30

Wednesday, November 30, 2022

47 changes · master

Improvements(4)

Enhancements to existing features

[IMP] web: list: select range of records with shift

CoremasterwebMedium

Users can now select a continuous range of records in list views using Shift with the mouse or keyboard. This reduces repetitive manual checkbox selection and improves efficiency when working with many records, while also fixing related keyboard focus behavior in Safari.

Original PR description

Before, in the list view, the user could not select a record range easily. He had to
check/uncheck manually each checkbox in the range.

Now, the user can select a range of records in list view by hitting its first record
and and its last record while holding SHIFT for the second.

It's also possible to do it with the keyboard:
- pressing < SPACE > to select a record and <SHIFT+SPACE> to select a range of records.
- pressing <SHIFT+ARROW> to extend to current checkbox

![shiftList](https://user-images.githubusercontent.com/109217759/202680390-05708718-30a6-4d34-9229-5569269ea093.gif)

task-2039894

#list view#selection#keyboard shortcuts#productivity

hr_timesheet,_: improve generic UX of timesheet

PR #96330

Coremasterhr_timesheethr_timesheet_attendancesale_managementsale_projectsale_timesheetMedium

Timesheet users now see clearer labels, smarter sale order line choices, and helpful placeholders when work is non-billable. Managers and teams also get new filters in the Timesheet/Attendance report, making it easier to review activity by team or department.

Original PR description

*_* = hr_timesheet_attendance, sale_management, sale_project, sale_timesheet

Purpose of this PR to improve generic UX of timesheet app.

So in this PR done following changes:
- hide the SOL field if there is no project set or if the project is non billable.
- add the `My Team` and `My Department` filters in Timesheet/Attendance
report.
- add the placeholders for SOL field in timesheets,project.task.
- update the test to avoid searching the contract if hr_contract module is
installed before this hr_timesheet module.
- indicate the unit price of the SOL if the same service is present multiple
times in the SO.
- move nane_get method of SOL from sale_project to sale_management
so it we don't need to overide name_get in sale_planning to do same thing.

task-2893556

#timesheets

timesheet_grid,_: improve generic UX of timesheet

PR #29650

Enterprisemasterhelpdesk_sale_timesheetsale_timesheet_enterprisetimesheet_gridMedium

This update makes timesheet approval clearer and faster by using “approver” wording, adding validation actions in more views, and improving reminder emails. It also simplifies timesheet reporting by removing the suspicious durations filter and makes billing fields clearer by hiding or labeling sales order line information when it is not relevant.

Original PR description

*_* = helpdesk_sale_timesheet, sale_timesheet_enterprise Purpose of this PR to improve generic UX of timesheet app. So in this PR done following changes: - send the email reminder of manager to…

*_* = helpdesk_sale_timesheet, sale_timesheet_enterprise

Purpose of this PR to improve generic UX of timesheet app.

So in this PR done following changes:
- send the email reminder of  manager to approver as well and rename email
template as `timesheet: approver reminder` and change string of related field
from manager to approver.
- remove the 'suspicious durations' filter from timesheet and
timesheet_analysis_report.
- hide the SOL field if there is no project set or if the project is non billable.
- show the validate button in the list view of all validate menus.
- added the placeholders for the SOL field in timesheets,helpdesk.ticket.
- take employees contract into account for remainder mail's working_hours of
employees.
- remove with_price_unit from context and display price unit in display_name
without that context.
- add a 'validate' button in pivot view in validate > all timesheets menu. The
draft timesheets will be shown in all timesheet menu by default which are need
to validated.

task-2893556

[IMP] timesheet_grid: add overtime information to the "My Timesheet" …

PR #29023

Enterprisemastertimesheet_gridsale_timesheet_enterpriseMedium

Employees can now see daily and total overtime directly in the My Timesheet grid, including both extra hours worked and missing expected hours. This helps employees and managers quickly spot incomplete timesheets and better track potentially billable or payable time.

Original PR description

…grid view

This commit adds overtime information to the grid view in the "My Timesheet" page of the Timesheets app.
Specifically it adds the daily and total overtime in the total row of the grid. The overtime is calculated given the work hours specified in the employee record of each employee and the hours that have been timesheeted.
The overtime can be positive (when the user has worked more hours or when the user has worked on a day not specified in their employee record) or negative (when the user has timesheeted less hours than what is specified in their employee record). When the overtime is zero, it is not printed.
The overtime information is added on present or past dates and the total overtime information is computed for dates prior and including the present date.

It is very important to the company and its employees that they encode all of their timesheets. They need to see at a glance the overtime that they have done (that might be paid by the company) or the time that is missing (missing time means the company might lose money on time it could have invoiced).
The improvement that this task introduces ensures that all employees can easily keep track what they have yet to timesheet as well as whether they have been productive enough at a glance, from their defualt view in the Timesheet app.

In order to implement this improvement, the "Float Time Grid" component needed to be extended in order to include the overtime information. This meant that we created a new component: the "Overtime" grid component. For that, overtime_grid_component.js file needed to be created for the new component as well as the overtimeGridComponent.xml file for the QWeb template.
To get the work hours information (which is essential to the overtime computation) we made an rpc call to the hr_employee model inside of the timesheet_time_grid_model.js
Additionally, for the (total) overtime computation, the timesheet_timer_grid_rendered.js file was modified to include the necessary methods. One to caclulate the daily overtime, one to calculate the total overtime, and one to check whether to overtime should be computed (used by the other two methods mentioned).
For the sake of cohesion, we wanted the overtime to always be under the total time in the total grid row. For that, we created a new class in timesheet_grid.scss to accept the \n character when printing the overtime.
We also modified the timesheet_grid.xml file, in order to change the grid table template to include the prop of our new component - the overtime value.
Finally, we modified the hr_timesheet_view.xml to again include the new overtime grid component in the "My Timesheets" page's grid view and we modified the manifest file to include the new component.

task-2878635

Bug Fixes(5)

Resolved issues and error corrections

[FIX] test_lint: keep eslint test for eslint blacklisted modules

PR #106704

Coremasterwebtest_lint

This change ensures important code quality checks continue to run across the full codebase, even as the project moves to a newer linting setup. It helps prevent basic JavaScript issues from slipping through in areas that may otherwise be skipped by the new tooling.

Original PR description

There is an eslint test that verify a bunch of basic rules, more functional than about the code style.
As we are going toward a new linting system with the runbot that respect the eslint ignore file, we do still need those basic rules to be tested against the whole code base.

We use eslint config files inheritance to avoid configuration duplication.

#code quality#testing#linting

Refactoring(1)

Code cleanup and technical improvements

[MOV] mail: reorganize files

PR #106868

Coremasterbase_automationcalendarcrmhrhr_holidaysmailwebsitewebMedium

This update reorganizes mail-related files to make future maintenance easier while restoring and improving several messaging interactions. Users should see smoother mail behavior, including better follow controls, automatic loading of older messages while scrolling, and more reliable emoji picker navigation.

#mail#messaging#emoji

Other(37)

Miscellaneous changes

Flch m'a tué

PR #106917

Coremastermail

This change appears to make a small maintenance update in the messaging area of Odoo. Based on the limited information provided, it is unlikely to affect day-to-day business workflows.

#maintenance#messaging

[FW][FIX] delivery: unit test

PR #106717

Coremasterdelivery

Description of the issue/feature this PR addresses: Although currently no unit case error is shown, the error will be shown when there is any scaffold module has a computed field reference line.product_qty. The issue exist because self.product_2.id is using product_uom_unit, but the order line is using product_uom_hour. When reference line.product_qty, it will try to recompute and calculate the correct product_qty. However product_uom_hour and product_uom_unit has a different category. Theref

Before, in the list view, the user could not select a record range easily. He had to check/uncheck manually each checkbox in the range. Now, the user can select a range of records in list view by hitting its first record and and its last record while holding SHIFT for the second. It's also possible to do it with the keyboard: - pressing < SPACE > to select a record and <SHIFT+SPACE> to select a range of records. - pressing <SHIFT+ARROW> to extend to current checkbox ![shiftList](https://user-images.githubusercontent.com/109217759/202680390-05708718-30a6-4d34-9229-5569269ea093.gif) task-2039894

*_* = hr_timesheet_attendance, sale_management, sale_project, sale_timesheet Purpose of this PR to improve generic UX of timesheet app. So in this PR done following changes: - hide the SOL field if there is no project set or if the project is non billable. - add the `My Team` and `My Department` filters in Timesheet/Attendance report. - add the placeholders for SOL field in timesheets,project.task. - update the test to avoid searching the contract if hr_contract module is installed before this hr_timesheet module. - indicate the unit price of the SOL if the same service is present multiple times in the SO. - move nane_get method of SOL from sale_project to sale_management so it we don't need to overide name_get in sale_planning to do same thing. task-2893556

*_* = helpdesk_sale_timesheet, sale_timesheet_enterprise Purpose of this PR to improve generic UX of timesheet app. So in this PR done following changes: - send the email reminder of manager to approver as well and rename email template as `timesheet: approver reminder` and change string of related field from manager to approver. - remove the 'suspicious durations' filter from timesheet and timesheet_analysis_report. - hide the SOL field if there is no project set or if the project is non billable. - show the validate button in the list view of all validate menus. - added the placeholders for the SOL field in timesheets,helpdesk.ticket. - take employees contract into account for remainder mail's working_hours of employees. - remove with_price_unit from context and display price unit in display_name without that context. - add a 'validate' button in pivot view in validate > all timesheets menu. The draft timesheets will be shown in all timesheet menu by default which are need to validated. task-2893556

…grid view This commit adds overtime information to the grid view in the "My Timesheet" page of the Timesheets app. Specifically it adds the daily and total overtime in the total row of the grid. The overtime is calculated given the work hours specified in the employee record of each employee and the hours that have been timesheeted. The overtime can be positive (when the user has worked more hours or when the user has worked on a day not specified in their employee record) or negative (when the user has timesheeted less hours than what is specified in their employee record). When the overtime is zero, it is not printed. The overtime information is added on present or past dates and the total overtime information is computed for dates prior and including the present date. It is very important to the company and its employees that they encode all of their timesheets. They need to see at a glance the overtime that they have done (that might be paid by the company) or the time that is missing (missing time means the company might lose money on time it could have invoiced). The improvement that this task introduces ensures that all employees can easily keep track what they have yet to timesheet as well as whether they have been productive enough at a glance, from their defualt view in the Timesheet app. In order to implement this improvement, the "Float Time Grid" component needed to be extended in order to include the overtime information. This meant that we created a new component: the "Overtime" grid component. For that, overtime_grid_component.js file needed to be created for the new component as well as the overtimeGridComponent.xml file for the QWeb template. To get the work hours information (which is essential to the overtime computation) we made an rpc call to the hr_employee model inside of the timesheet_time_grid_model.js Additionally, for the (total) overtime computation, the timesheet_timer_grid_rendered.js file was modified to include the necessary methods. One to caclulate the daily overtime, one to calculate the total overtime, and one to check whether to overtime should be computed (used by the other two methods mentioned). For the sake of cohesion, we wanted the overtime to always be under the total time in the total grid row. For that, we created a new class in timesheet_grid.scss to accept the \n character when printing the overtime. We also modified the timesheet_grid.xml file, in order to change the grid table template to include the prop of our new component - the overtime value. Finally, we modified the hr_timesheet_view.xml to again include the new overtime grid component in the "My Timesheets" page's grid view and we modified the manifest file to include the new component. task-2878635

There is an eslint test that verify a bunch of basic rules, more functional than about the code style. As we are going toward a new linting system with the runbot that respect the eslint ignore file, we do still need those basic rules to be tested against the whole code base. We use eslint config files inheritance to avoid configuration duplication.

Since odoo/odoo@69c3d5aa25655173ed66a52570559322c650c7df the readonly and required modifiers were no longer passed for non-editable views. Which means: - kanban: never passed, - tree: passed only when `editable="1"` or `multi_edit="1"`, - form: always passed. The rationale behind that is that a view which is considered as readonly doesn't need to know if its field are readonly or required, as by definition, if the view is readonly, the user shouldn't be able to modify anything in the view. This was to make the views sent to the web client more light-weight, not sending unused information, and save KB of transfers. However, some widgets, used in the kanban and non-editable tree, allow to modify fields, even in readonly considered views, and therefore need to know these readonly/required modifiers from the field definition in the Python model. e.g. the `widget="color"`, odoo/odoo#103478 Ideally, these readonly/required modifiers should be transferred only when the widget requires it, to avoid transferring the readonly/required modifiers when they are not useful in kanban/tree views (which is 99% of the time). However, this would require a bigger refactoring, which is considered too risky compared to the added value for a stable release. task-3013110 Forward-Port-Of: odoo/odoo#106766

# Current behaviour Changing the package quantity may change the package type, leading to an incoherent product quantities in the SOL. (For ex: 20 uom in 2 packages of 20) # Expected behaviour When setting the package quantity, don't change the package type. If the user wants to change the package type they can do it by manually setting it or changing the product_uom. # Steps to reproduce - Install Sale and Inventory - Activate Packages in settings - Create 2 package types for a product of choice, one of 10, another of 20 - Create a new SO with that product - Set the quantity to 10 (a new package_qty=1 and packaging type of 10 should appear) - Save - Edit package_qty to 2 - Observe that we have 20 units of the product, 2 packages of 20, instead of 2 packages of 10 # Reason for the problem When setting the `product_packaging_qty`, the `product_uom_qty` compute is triggered. When `product_uom_qty` changes, it triggers `product_packaging_id`'s compute. When `product_packaging_id` is computed, it doesn't trigger `product_package_qty`, because it is protected, since we are writing to it. # Fix When we are writing the `product_packaging_qty` and the `product_uom_qty` we remove the compute for `product_packaging_id`. # Affected versions - saas-15.2 - saas-15.3 - 16.0 - master --- opw-3010703 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#106811 Forward-Port-Of: odoo/odoo#103669

The filtering logic was previously fixed in [commit 1] but was broken in [commit 2]. For report containing a "searchKey" (ex: General ledger where searchKey is in fact the accountCode), the search bar only looked at the searchKey and never went through the "else" statement to search on the name. It is now corrected by searching first on the code and then on the name. For other report that don't have a "searchKey", a search on the displayName is done. Another problem was that the total rows were displayed in the search because a total row has a displayName looking like "total 123 accountName". When it's the case, the accountName variable was "123 accountName", now the total rows are skipped to avoid processing them in the search. This search method is now the same as v15.0, and it also restores the logic of the export and print functionality. In addition, a tour has been added to verify that the search works when searching for a code or name. Co-authored-by: Tom De Caluwé <decaluwe.t@gmail.com> [commit 1]: https://github.com/odoo/enterprise/commit/e7e113e5a26b357da5c01caf9a278c5dfada0366 [commit 2]: https://github.com/odoo/enterprise/commit/f435654f70f3d6a1fec7fa696945f2c0eb9a7056 Forward-Port-Of: odoo/enterprise#32875

Improvements(4)

[IMP] web: list: select range of records with shift

hr_timesheet,*_*: improve generic UX of timesheet

timesheet_grid,*_*: improve generic UX of timesheet

[IMP] timesheet_grid: add overtime information to the "My Timesheet" …

Bug Fixes(5)

[FIX] test_lint: keep eslint test for eslint blacklisted modules

Refactoring(1)

[MOV] mail: reorganize files

Other(37)

Flch m'a tué

[FW][FIX] delivery: unit test

Improvements(4)

[IMP] web: list: select range of records with shift

hr_timesheet,*_*: improve generic UX of timesheet

timesheet_grid,*_*: improve generic UX of timesheet

[IMP] timesheet_grid: add overtime information to the "My Timesheet" …

Bug Fixes(5)

[FIX] test_lint: keep eslint test for eslint blacklisted modules

Refactoring(1)

[MOV] mail: reorganize files

Other(37)

Flch m'a tué

[FW][FIX] delivery: unit test

[FIX] test_lint: bump up eslint test to same version as tooling

[FIX] l10n_pt: tax report translation to English

[FIX] project: hide alert bar if planning_overlap is empty

[FIX] documents: generalize `ListRenderer.RecordRow` selector xpath

[FW][FIX] base, stock, delivery: replace support datamatrix barcode printing

[FW][FIX] pos_restaurant: correctly save splitted order

[FW][FIX] l10n_be: translate Belgian tax report

[FW][FIX] pos_restaurant: validate number of guest put by user

[FW][FIX] pos_loyalty: fix typo in pos_loyalty

[FW][FIX] loyalty, pos_loyalty: fix typo in loyalty, pos_loyalty

[FW][FIX] base, hr_recruitment_skills: fix typo

[FW][FIX] point_of_sale: recompute reward after pricelist change

[FW] Fixes bugs in project sharing task and kanban view

[FW][FIX] web: add Shortcut CTRL+K in user menu

[FW][FIX] crm_iap_enrich: correctly save 'Enrich lead automatically' setting

[FW][FIX] delivery: raise a `UserError` if the total weight is 0

[FW][FIX] purchase, stock : datetime is not correctly converted in date

[FW][IMP] web: update owl from 2.0.1 to 2.0.2

[FW][FIX] base, web: transfer readonly/required modifiers for kanban/tree

[FW][FIX] website: update comment in user_custom_bootstrap_overridden file

[FW][FIX] sale: not change the package type when setting the package qty

[FW][FIX] base: cannot specify 24-hour clock format and meridian

[FW][FIX] mail: chatter attachments overflow

[FW][FIX] l10n_fr: tax report - fix box_16 formula

[FW][FIX] account_online_synchronization: Fix dashboard displaying bad value

[FW][FIX] account_reports: Fixing UnboundLocalError with foreign_currency

[FW][FIX] account_reports: fix rounding of figure_type integer

[FW][FIX] web_map: missing check on before convert a DateTime value to UTC

[FW][FIX] account_reports: change searchbar

[FW][FIX] l10n_ch_reports: fix balance sheet's unaffected earnings

[FW][IMP] sale_subscription: block invoice creation if has draft

[FW][FIX] account_reports: fix grouping by analytic sub-plan in reports

[FW][FIX] account_accountant: reconciliation button missing

[FW][FIX] planning: fixes alignment issue in planning shift view duration

[FW][FIX] account_reports: general ledger: display values in 'Communication' column

[FW][FIX] mrp_workorder_hr: extends components instead of replace them

[FW][FIX] account_reports: Journal report balance col formatting

[FW][IMP] mrp_workorder: add test

[FW][FIX] stock_barcode: use builtin ECC200DataMatrix in demo data

hr_timesheet,_: improve generic UX of timesheet

timesheet_grid,_: improve generic UX of timesheet

hr_timesheet,_: improve generic UX of timesheet

timesheet_grid,_: improve generic UX of timesheet