Saturday, February 11, 2023
8 changes · master
Miscellaneous changes
This commit fixes the case where portal_customer is not added in the recipients group by the portal mixin. Steps to reproduce: - Go on a purchase - Log a note and tag a user who handles notification by email - Traceback: ``` File "/home/odoo/src/odoo/addons/purchase/models/purchase.py", line 346, in _notify_get_recipients_groups customer_portal_group = next(group for group in groups if group[0] == 'portal_customer') StopIteration ``` Current B
Original PR description
This commit fixes the case where portal_customer is not added in the recipients group by the portal mixin.
Steps to reproduce:
- Go on a purchase
- Log a note and tag a user who handles notification by email
- Traceback:
```
File "/home/odoo/src/odoo/addons/purchase/models/purchase.py",
line 346, in _notify_get_recipients_groups
customer_portal_group = next(group for group in groups if group[0] == 'portal_customer')
StopIteration
```
Current Behavior:
- Traceback StopIteration
Expected Behavior:
- Log a note with the tagged (boomer) user.
See odoo/odoo@f879cf28677a516b0cc01c671166de68d9c992e6
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#112455Benchmark: A batch of 1000 payments and a move of 1000 lines to reconcile each payment separately. Current observed time: +-288s Improvement: Adds some context keys when creating the account.full.reconcile to avoid the recomputation of dynamic lines (invoices), synchronization of payments/statement lines and check if the move is well balanced. => +-288s => +-34s --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#112463
Original PR description
Benchmark: A batch of 1000 payments and a move of 1000 lines to reconcile each payment separately. Current observed time: +-288s Improvement: Adds some context keys when creating the account.full.reconcile to avoid the recomputation of dynamic lines (invoices), synchronization of payments/statement lines and check if the move is well balanced. => +-288s => +-34s --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#112463 Forward-Port-Of: odoo/odoo#112210
Since website was moved from frontend to backend in 16.0 with [1], there was an issue with the page list view which would not show the homepage record when multi website group was not enabled. Indeed, we have our own `recordFilter` method which is based on the `website_id` field. But the framework ignore this field (it doesn't read the property at all and so don't have access to its value) if it's hidden by a `groups` property. In such cases, the field should be duplicated and hidden with `i
Original PR description
Since website was moved from frontend to backend in 16.0 with [1], there was an issue with the page list view which would not show the homepage record when multi website group was not enabled.…
Since website was moved from frontend to backend in 16.0 with [1], there was an issue with the page list view which would not show the homepage record when multi website group was not enabled. Indeed, we have our own `recordFilter` method which is based on the `website_id` field. But the framework ignore this field (it doesn't read the property at all and so don't have access to its value) if it's hidden by a `groups` property. In such cases, the field should be duplicated and hidden with `invisible`, as those fields will have their value retrieved depsite being hidden. Step to reproduce: - Install website with no demo data (to have only one website) Or go to runbot / install website with demo data and disable the multi website group - Go to Website > Site > Pages - You don't see the homepage in the list, because there is 2 homepage (one specific and one generic) but since the website_id is not fetch, both are considered generic (which is not supposed to be possible) and the filter is then considering those to be shadowed by the other, ultimately filtering out both. [1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b Forward-Port-Of: odoo/odoo#112392
To reproduce ============ - create a vendor Bill - add the PDF (from ticket attached files) in chatter - go back to list view and select the bill -> print Original Bills a traceback is raised Problem ======= for some excptional PDF files (like the one attached in the ticket), the library PyPDF2 that we use to manage PDF files crashes. Solution ======== a [fix](https://github.com/odoo/odoo/commit/e55196375aa124558b87ebd50012d5664295ca07) was backported from 16 and updated so that w
Original PR description
To reproduce ============ - create a vendor Bill - add the PDF (from ticket attached files) in chatter - go back to list view and select the bill -> print Original Bills a traceback is raised Problem ======= for some excptional PDF files (like the one attached in the ticket), the library PyPDF2 that we use to manage PDF files crashes. Solution ======== a [fix](https://github.com/odoo/odoo/commit/e55196375aa124558b87ebd50012d5664295ca07) was backported from 16 and updated so that we don't block the flow, we let a message on chatter that there was an error and we ignore adding the banner. opw-3141143 Forward-Port-Of: odoo/odoo#112454 Forward-Port-Of: odoo/odoo#110711
Forward-Port-Of: odoo/enterprise#36996 Forward-Port-Of: odoo/enterprise#36820
Original PR description
Forward-Port-Of: odoo/enterprise#36996 Forward-Port-Of: odoo/enterprise#36820
Purpose: - Currently, if a child article has only items as child articles, the caret for this article is shown after unfolding its parent. This commit hides the caret in this case, as there are no articles to unfold if the children articles are all items (since items are not shown in the sidebar). Task-3168666 Forward-Port-Of: odoo/enterprise#36779
Original PR description
Purpose: - Currently, if a child article has only items as child articles, the caret for this article is shown after unfolding its parent. This commit hides the caret in this case, as there are no articles to unfold if the children articles are all items (since items are not shown in the sidebar). Task-3168666 Forward-Port-Of: odoo/enterprise#36779
This commit fixes an issue where, when you would cancel the confirmation dialog when trying to restore the access to a children article a crash would be thrown at the user. This is caused by the discard function not being properly instanciated when no function is given as a parameter of the `_showConfirmDialog` function. Now instead of giving an unbound function as a discard method we give the same function as before but bound to the PermissionPanel object. task-3171926 Forward-Port-Of: o
Original PR description
This commit fixes an issue where, when you would cancel the confirmation dialog when trying to restore the access to a children article a crash would be thrown at the user. This is caused by the discard function not being properly instanciated when no function is given as a parameter of the `_showConfirmDialog` function. Now instead of giving an unbound function as a discard method we give the same function as before but bound to the PermissionPanel object. task-3171926 Forward-Port-Of: odoo/enterprise#36730
Purpose: - Currently, when an article has a long name, the name overflows out of the kanban card (both in the articles kanban view, and in the items embedded kanban). This commit prevents article names from overflowing their kanban cards using the bootstrap text-truncate class. This commit also prevents the name of embedded views of being hidden behind the "rename" and "open" buttons, then reappear after these buttons (with this commit, they are just hidden behind them, but one does not se
Original PR description
Purpose: - Currently, when an article has a long name, the name overflows out of the kanban card (both in the articles kanban view, and in the items embedded kanban). This commit prevents article names from overflowing their kanban cards using the bootstrap text-truncate class. This commit also prevents the name of embedded views of being hidden behind the "rename" and "open" buttons, then reappear after these buttons (with this commit, they are just hidden behind them, but one does not see a letter of the embedded view name between these buttons and the search bar). Task-3138134 Forward-Port-Of: odoo/enterprise#35896