Odoo Changelog — 2023-03-03

Friday, March 3, 2023

3 changes

Bug Fixes(3)

Resolved issues and error corrections

[FIX] pos_iot: LastTransactionStatus fixed

Enterprisemasterpos_iotMedium

Point of Sale shops can now open normally when Worldline is enabled and a Worldline terminal is linked to a payment method. This prevents an unnecessary startup blockage, even when that payment method is not used in the shop.

Original PR description

Currenlty, PoS shop cannot be opened if we activate Worldline and create a pos payment method with an associated Worldline terminal (even without adding it to the shop)

This PR solves this issue

#point-of-sale#worldline#payments

[FIX] knowledge: correctly rebind mousedown ev to add cover

PR #37748

Enterprisemasterknowledge

The Knowledge app now correctly keeps the Add Cover button responsive after interface updates. This prevents intermittent failures when users try to add a cover image, improving reliability without changing the feature itself.

Original PR description

Before this commit, and with the last version of owl [1], the knowledge_cover_selector_tour tour failed almost all the time, because at some point, the "Add cover" button had no mousedown event on it. This is because the useEffect used to add the event handler didn't correctly defined its dependencies: when the button changes, the handler must be re-added. It has been highlighted by the update of owl because it slightly changes the way refs are handled, and something that was luckily working before (whereas it shouldn't have) wasn't anymore.

[1] odoo/odoo@abaf9d0e70a480252afcf0e08f2a3c68fbbafa00

#knowledge#cover#reliability

[FIX] planning: handle the cases were save actually deletes

PR #37752

EnterprisemasterplanningMedium

Fixes an issue where changing a recurring planning shift to a single occurrence could delete the current shift and leave users stuck on an error screen. The form now returns to the previous view instead, keeping scheduling workflows smooth.

Original PR description

Steps:
- Create a planning shift, set a recurrence for ever.
- Go few occurences later (form via kanban) and set... ...recurrence type to "Number of Occurences",
...recurrence nmber to 1.
- Save.

Issue:
"This record doesn't exist".

Cause:
The write method will update the recurrence
so that it only contains only one occurrence.
Consequently, the record you just updated is deleted. Then we try to fetch the record to display its form again. Because de read returns [], _fetchRecord rejects the promise, and we're stuck.

Fix:
In community commit, we make `FormController.saveButtonClicked` call `Record.save` with its params.
In this commit, we override `FormController.saveButtonClicked` to call super with the arg `throwOnError` so that, if the shift is deleted when updating its recurrence, we will catch it and, rather than staying on its form, go back to the previous view.

Related: https://github.com/odoo/odoo/pull/112335

#planning#recurrence#scheduling#user experience

Before this commit, and with the last version of owl [1], the knowledge_cover_selector_tour tour failed almost all the time, because at some point, the "Add cover" button had no mousedown event on it. This is because the useEffect used to add the event handler didn't correctly defined its dependencies: when the button changes, the handler must be re-added. It has been highlighted by the update of owl because it slightly changes the way refs are handled, and something that was luckily working before (whereas it shouldn't have) wasn't anymore. [1] odoo/odoo@abaf9d0e70a480252afcf0e08f2a3c68fbbafa00

Steps: - Create a planning shift, set a recurrence for ever. - Go few occurences later (form via kanban) and set... ...recurrence type to "Number of Occurences", ...recurrence nmber to 1. - Save. Issue: "This record doesn't exist". Cause: The write method will update the recurrence so that it only contains only one occurrence. Consequently, the record you just updated is deleted. Then we try to fetch the record to display its form again. Because de read returns [], _fetchRecord rejects the promise, and we're stuck. Fix: In community commit, we make `FormController.saveButtonClicked` call `Record.save` with its params. In this commit, we override `FormController.saveButtonClicked` to call super with the arg `throwOnError` so that, if the shift is deleted when updating its recurrence, we will catch it and, rather than staying on its form, go back to the previous view. Related: https://github.com/odoo/odoo/pull/112335