Friday, March 17, 2023
15 changes · master
Enhancements to existing features
Spreadsheet exports to Excel now include images by having the server package the image files into the exported file. This reduces data sent from the browser and helps exported spreadsheets better match what users see in Odoo.
Original PR description
This commits implements the zipping of images when exporting xlsx file. Because the image file needs to be copied into the .xlsx, a helper function to get the image file using relative path is also made. Task: 3125701
Resolved issues and error corrections
Fixes issues in manufacturing work orders where quantities could fail to refresh in tablet view, timer values could be overstated when multiple employees worked at once, and employee avatars could display incorrectly. This improves accuracy and usability for shop floor teams using work order list and tablet views.
Original PR description
Various bug fixes introduced or noticed in https://github.com/odoo/enterprise/pull/34786 and https://github.com/odoo/odoo/pull/107473 task id : 3216277
Features or functions removed from Odoo
The project task interface no longer uses the separate project color field. This simplifies project task data and helps keep the project module easier to maintain without changing core task workflows.
Original PR description
TaskID: 3231143
Code cleanup and technical improvements
The Discuss app has been refactored to use Odoo’s newer interface building blocks and shared web services. This is mainly an internal modernization intended to keep the user experience working the same while making future maintenance and improvements easier.
Original PR description
This commit refactors discuss code to use OWL components and new tools and services in web/. Functionally, Discuss app should work relatively the same as before this commit. Co-authored-by: Alexandre (aku) <aku@odoo.com> Co-authored-by: Didier (did) <did@odoo.com> Co-authored-by: Géry (ged) <ged@odoo.com> Co-authored-by: Louis (wil) <wil@odoo.com> Co-authored-by: Maël (mapa) <mapa@odoo.com> Co-authored-by: Maryam (maki) <maki@odoo.com> Co-authored-by: Sébastien (seb) <seb@odoo.com> Co-authored-by: Thanh (tso) <tso@odoo.com> Co-authored-by: Matthieu (tsm) <tsm@odoo.com> Co-authored-by: Zelong (zel) <zel@odoo.com> closes https://github.com/odoo/odoo/pull/110188 Related: https://github.com/odoo/enterprise/pull/38058 https://github.com/odoo/upgrade/pull/4423
Miscellaneous changes
Prevents a traceback from being displayed in case of a crash during the user agent initialization. Instead, the error message is displayed in the dedicated VoIP window. Forward-Port-Of: odoo/enterprise#38257 Forward-Port-Of: odoo/enterprise#38200
Original PR description
Prevents a traceback from being displayed in case of a crash during the user agent initialization. Instead, the error message is displayed in the dedicated VoIP window. Forward-Port-Of: odoo/enterprise#38257 Forward-Port-Of: odoo/enterprise#38200
Field service tasks now reserve the specific product lots selected by users more accurately when adding items to linked sales orders. This reduces mismatches and delays when the chosen lot is only partially available, helping inventory reservations better reflect real task usage.
Original PR description
Industry fsm can choose a lot to use directly in their task and it will add it to the linked sale order. Before if the lot was not totaly available we reserve another ones and wait the validation before using the right lot. With the stock.move.line code updates, it's easier to set a lot and reserve it. So we adapt the code here to have a reservation that match the more possible the quantities/lot used in the task.
Add '-at_install' to not execute them during the at_install step. Forward-Port-Of: odoo/enterprise#38321
Original PR description
Add '-at_install' to not execute them during the at_install step. Forward-Port-Of: odoo/enterprise#38321
Steps to reproduce: 1. Set up UPS shipping, choose an international delivery service 2. Create a product with name longer than 35 characters 3. Make an international sale order with the product and confirm 4. Validate the delivery, get error from UPS API The length of product description needs to be limited to 35 characters or less. opw-3191379 Forward-Port-Of: odoo/enterprise#37726
Original PR description
Steps to reproduce: 1. Set up UPS shipping, choose an international delivery service 2. Create a product with name longer than 35 characters 3. Make an international sale order with the product and confirm 4. Validate the delivery, get error from UPS API The length of product description needs to be limited to 35 characters or less. opw-3191379 Forward-Port-Of: odoo/enterprise#37726
In some databases, there are multiple bank statement lines linked to the same move. Example: * account_move: id | statement_line_id ---+------------------ 5 | 20 * bank_statement_line: id | move_id -----+-------- 20 | 5 21 | 5 Thus, joining both tables should be done using the account_move.id and the bank_statement_line.move_id. Otherwise, some bank_statement_lines will be missed. opw-3202392 related https://github.com/odoo/odoo/pull/1
Original PR description
In some databases, there are multiple bank statement lines linked to the same move. Example: * account_move: id | statement_line_id ---+------------------ 5 | 20 * bank_statement_line: id | move_id -----+-------- 20 | 5 21 | 5 Thus, joining both tables should be done using the account_move.id and the bank_statement_line.move_id. Otherwise, some bank_statement_lines will be missed. opw-3202392 related https://github.com/odoo/odoo/pull/115060 https://github.com/odoo/upgrade/pull/4427 Forward-Port-Of: odoo/enterprise#38071
To reproduce: With German company, create a Misc entry, with 2 lines on debit with same account and 2 lines on credit. Export DateV on general ledger The lines appear without gegenkonto. To fix: We should look if we have a single account instead of looking if we have a single line. To note: We still don't fix the case with 2 different accounts on credit and 2 different accounts on debit on a single Misc move. This will be fixed in another task. opw-3166295 Forward-Port-Of: odoo
Original PR description
To reproduce: With German company, create a Misc entry, with 2 lines on debit with same account and 2 lines on credit. Export DateV on general ledger The lines appear without gegenkonto. To fix: We should look if we have a single account instead of looking if we have a single line. To note: We still don't fix the case with 2 different accounts on credit and 2 different accounts on debit on a single Misc move. This will be fixed in another task. opw-3166295 Forward-Port-Of: odoo/enterprise#38175 Forward-Port-Of: odoo/enterprise#37472
The 'weight' value may sometime be None on the product_product. When this value is formatted in the report intrastat_report_export_xml_items, an error is thrown because you can't format a None value. OPW-3193005 --- The report was 'recently' updated to format the Weight value, this cause the issue for some customers that have None weight. Comit: 22f433777a60b6753ad34fb0082c3d2427e6237a Forward-Port-Of: odoo/enterprise#38172 Forward-Port-Of: odoo/enterprise#38113
Original PR description
The 'weight' value may sometime be None on the product_product. When this value is formatted in the report intrastat_report_export_xml_items, an error is thrown because you can't format a None value. OPW-3193005 --- The report was 'recently' updated to format the Weight value, this cause the issue for some customers that have None weight. Comit: 22f433777a60b6753ad34fb0082c3d2427e6237a Forward-Port-Of: odoo/enterprise#38172 Forward-Port-Of: odoo/enterprise#38113
Before this commit, the partner VAT listing XML export included the (optional) total line, which is wrong. This fixes the issue by filtering the lines on their model before processing them. opw-3218046 Forward-Port-Of: odoo/enterprise#38123
Original PR description
Before this commit, the partner VAT listing XML export included the (optional) total line, which is wrong. This fixes the issue by filtering the lines on their model before processing them. opw-3218046 Forward-Port-Of: odoo/enterprise#38123
Email element is optional to send to DHL. If it does not exist, it should not send anything instead of sending 'False' as email. From DHL side, they get a warning about this and instead want to receive clean email with `@`. NOTE. This should be port forwarded to 15.0, 16.0. Forward-Port-Of: odoo/enterprise#36707
Original PR description
Email element is optional to send to DHL. If it does not exist, it should not send anything instead of sending 'False' as email. From DHL side, they get a warning about this and instead want to receive clean email with `@`. NOTE. This should be port forwarded to 15.0, 16.0. Forward-Port-Of: odoo/enterprise#36707
Comparing two float without `float_compare` may lead to unexpected results in case of floating point issue OPW-3149888 Forward-Port-Of: odoo/enterprise#38295
Original PR description
Comparing two float without `float_compare` may lead to unexpected results in case of floating point issue OPW-3149888 Forward-Port-Of: odoo/enterprise#38295
## Current behaviour When updating the hours of a timesheet, it doesn't update the total hours on the helpdesk ticket. ## Expected behaviour The total hours should be updated when changing the timesheet `unit_amount`, even outside of the Helpdesk app. ## Steps to reproduce - Install Helpdesk, Timesheets, helpdesk_timesheet - On a helpdesk ticket, log 0h30, add a description, the total hours is 0h30 - In Timesheets > List view > search the timesheet based on the description, change the
Original PR description
## Current behaviour When updating the hours of a timesheet, it doesn't update the total hours on the helpdesk ticket. ## Expected behaviour The total hours should be updated when changing the timesheet `unit_amount`, even outside of the Helpdesk app. ## Steps to reproduce - Install Helpdesk, Timesheets, helpdesk_timesheet - On a helpdesk ticket, log 0h30, add a description, the total hours is 0h30 - In Timesheets > List view > search the timesheet based on the description, change the hours to something else than 0h30 - Go back to the helpdesk ticket, notice the total hours hasn't updated. ## Reason for the problem Lack of dependency on `timesheet_ids.unit_amount` for the compute of the total hours on the ticket `_compute_total_hours_spent`. ## Fix Add the missing dependency. ## Affected versions - 15.0 - saas-15.2 - 16.0 - saas-16.1 - master --- opw-3196050 Forward-Port-Of: odoo/enterprise#37912