Tuesday, April 11, 2023
54 changes · master
Enhancements to existing features
This update improves user-facing text in Project forms and Live Chat demo shortcuts to make instructions clearer and more polished. The changes help users better understand access instructions and provide cleaner sample chat responses.
Original PR description
In this PR made following changes: - added copy writing content in project form view for access_instruction_message field. - modify mail short code demo data. task-3067151 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The rating portal now uses the phrase "share feedback" instead of "write a feedback." This makes the wording clearer and more natural for customers leaving feedback.
Original PR description
This PR replaces 'write a feedback' into 'share feedback' in the feedback content of rating portal page to share a feedback. task-3079119 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The forum user profile now shows vote dates without unnecessary milliseconds. This makes the votes tab easier to read and presents date and time information in a cleaner format for users.
Original PR description
before this commit, in the votes tab in the website user profile, the date time is shown including the milli seconds in it. * open forum * open own user profile * click votes tab and see the date time after this commit, the milli seconds info will be removed from the date time. Before:  After:  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update makes project and sales-related screens easier to use by improving spacing around resume content and prioritizing customer contacts in partner selection fields. These small usability changes help users find the right customer faster and make task and project pages read more clearly.
Original PR description
** = account,hr_skills,product_email_template . Purpose of this PR to do generic improvement. So in this PR done following improvements: - add margin b\w resume content header and its content so it'll display properly in UX. - add context in partner fields in various places to display customer partner first in selection of partner field. task-3099758
Several wizard screens now use "Discard" instead of "Cancel" for buttons that close the action without applying changes. This makes the choice clearer for users in accounting, timesheet, and sales-timesheet workflows.
Original PR description
In this commit, we changed the cancel button string to Discard.
task-3216495This update speeds up the suggestions shown when mentioning people in mail discussions. It improves responsiveness on large databases, reducing delays for users in companies with many contacts or users.
Original PR description
"Order by" makes the query really slow. On a database with 1000000 partner and 10000 user, this query goes from 5.5s to 600ms. Once cached by Pgsql it goes down below 100ms. task-2982401
The mail composer suggestion system has been improved to better support typed suggestions while users write messages. This should make composing messages smoother and help users find relevant suggestions more reliably.
Canned replies will now appear only in live chat conversations, not in regular mail discussions. This keeps email and internal message composition cleaner while preserving quick responses where support agents need them most.
Original PR description
Canned response should only enabled in livechat thread. task-3208438 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Several screens now use “Discard” instead of “Cancel” for actions that close a change without saving it. This makes the wording clearer and more consistent for users across Helpdesk, Field Service, Projects, Timesheets, and related workflows.
Original PR description
In this commit, we changed the cancel button string to Discard. task-3216495
Helpdesk screens now use clearer wording and guidance, making it easier for teams to configure members, live chat channels, canned responses, and ticket closure messages. These updates help support teams understand available tools faster and reduce confusion during daily setup and customer interactions.
Original PR description
In this PR following improvements have been made:
- helpdesk team form view copy-writing content
- removed the 'add team members' placeholder and added 'team members' label
- helpdesk team live chat feature:
- added the description "Create and search tickets from your conversations. Answer in an instant by using canned responses "
- add the following text in muted underneath:
- fa-lightbulb-o Type /helpdesk to create tickets
- Type /helpdesk_search to find tickets
- Type :shortcut to insert a canned response in your message
- now 'view channels' converted into view channel for opening specific team channel form view
- added new link button 'configure canned responses' for opening the canned reponses menu
- added "Team members on time off are not assigned any tickets" text in muted under the 'team members' field
- change the content of close ticket wizard portal view.
task-3067151Helpdesk users get clearer ticket submission pages, confirmation actions, and updated email wording, making the support process easier to understand. Teams also get cleaner stage and repair visibility settings so the interface better reflects enabled features and available records.
Original PR description
In this PR made following changes: - helpdesk team form view website_id field is required. - rename helpdesk contact form webpage into 'Submit a Ticket' also rename submit button into Submit Ticket.…
In this PR made following changes: - helpdesk team form view website_id field is required. - rename helpdesk contact form webpage into 'Submit a Ticket' also rename submit button into Submit Ticket. - added view ticket and go to home page button in ticket received webpage and replace string content. - modify the 'ticket: reception acknowledgement' email template. - change badge color of non folded stages in grey, as in the list view portal view. - added line break and improve string content in ticket: rating request' email template. - replace placeholder string in helpdesk stage form view, - hide the 'repairs' stat button if the nb of records = 0 in helpdesk team. - display the 'email template' field by default in the list view of helpdesk stage. - hide the template_id field in helpdesk stage tree view if the 'customer ratings' feature is disabled on all of the teams also display warning on template_id field of helpdesk stage form view when the rating feature is disabled on some of the team. task-3079119
Helpdesk Sales screens now prioritize customer contacts when users choose a partner. This makes it quicker for support and sales teams to find the right customer and reduces selection mistakes.
Original PR description
This commit does following changes: - add context in partner fields in various places to display customer partner first in selection of partner field. task-3099758
Resolved issues and error corrections
Users can now reattach the same file in the Discuss composer after removing it. This prevents a frustrating upload issue and makes file sharing behave as expected.
Original PR description
Before this commit, when clicking on "Attach files" in discuss composer, then removing it, it was not possible to upload the same file again. This happens because file input of file uploader relies on `change` from the input. The `input.value` contains the filepath, so if we upload the exact same file without clearing the value, the value will be unchanged and it won't trigger uploading as a result. This commit fixes the issue by clearing the input just after the file has been uploaded, so that we can upload the same file. Cannot reproduce bug in QUnit tests because `inputFile` helper programmatically always trigger "change" on input file.
Code cleanup and technical improvements
This update changes how Odoo identifies fields internally so every field placement gets a distinct identifier from the start. This reduces ambiguity when the same field appears multiple times, helping prevent inconsistent behavior across views and automated tests without changing business workflows.
Original PR description
Miscellaneous changes
When creating a quotation in the sales app with a different shipping address, this is not shown on the invoice report from the point of sale. Before it was always using the pos order partner address. Now we check if the sale order had a different shipping address before setting the address on the report. task-id: 3258679 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#117447
Original PR description
When creating a quotation in the sales app with a different shipping address, this is not shown on the invoice report from the point of sale. Before it was always using the pos order partner address. Now we check if the sale order had a different shipping address before setting the address on the report. task-id: 3258679 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#117447
This fix ensures filter dropdowns open next to the button users clicked, even inside embedded Knowledge list views. It improves usability by preventing menus from appearing in unexpected positions when page layout rules affect placement.
Original PR description
[FIX] web: compute containing block layout in position hook How to reproduce: - create a list embedded view in Knowledge (/item list) - in the control panel click on "Filters" Current behavior: - the dropdown is not correctly positioned Expected behavior: - the dropdown should be positioned around the button Fix: `getBestPosition` uses dimensions and layout positionning based on the viewport, but `reposition` modifies the style properties `top` and `left` of the element, which are relative to the closest containing block. Since in that case the style position is `fixed`, there are a number of factor that can influence the containing block, as specified in: https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block#identifying_the_containing_block We can easily compute the layout offset caused by the containing block just after resetting the popper top and left to `0px` and take it into account for the final value. Task-3267555
An internal accounting test was corrected after a related field was removed, preventing false failures in automated checks. This helps keep the development pipeline reliable without changing user-facing accounting features.
Original PR description
Bug === The tagged had only `post_install`, so it wasn't run on the runbot. In the meantime, the account team removed `user_type_id` and so the test is failing (and I could have been merged because of the tag).
This fix prevents unnecessary warning messages during module cleanup when Odoo encounters models that do not have database tables. It reduces noise for administrators and helps keep system logs focused on issues that require attention.
Original PR description
Along with improving the table_kind API, #117439 added a warning when dropping non-tables. This warning turns out to trigger on many models, in two major cases: - the hook is called on abstract models, which don't have a table in the first place, it probably should not be called for those but can easily be skipped - the hook is also called on `_auto = False` which don't have a table anymore, this is because we use `DROP TABLE $table CASCADE`, which implicitly drops any view (or table) depending on the table, it might be possible to avoid this by ensuring we drop models in reverse topological order *and* drop all of a module's views then tables at once (by passing multiple names to `DROP`, but for now just ignore the case where we're trying to drop an object which can't be found
This fixes an outdated link path used by the mail composer suggestion feature. It helps ensure users are directed to the correct place when interacting with suggested mail-related items, reducing small navigation errors.
Chat message bubbles from other people are now easier to see in the messaging interface. This improves readability and helps users follow conversations more comfortably.
Original PR description
Before:   After:  
Chat windows now automatically limit their height to the available page space. This prevents conversations from overflowing off-screen, making messaging easier to use on smaller or constrained displays.
Original PR description
Before this commit, when global height was below height of a chat window, the chat window was overflowing. This commit fixes the issue by ceiling the height of chat window to the global height. Before/After  
This fixes a visual issue where white corners could appear around rounded chat windows in the light theme. It also ensures hidden chat menu items display correctly above other chat windows, improving the overall live chat experience.
Original PR description
Before this commit, in white theme, chat window rounded borders had some white color leak. This comes from background color of chat window, which is white, while the header background color is purple. This commit fixes the issue by setting the chat window background color to purple. The content now defines its own color, and the header just inherit from the chat window background color. This commit also fixes a bug where the chat window hidden menu items were below visible chat windows. Before  After 
This fix ensures Sign template fields and template properties remain visible and properly contained on mobile devices. It prevents layout overflow, making it easier for users to manage signing templates from smaller screens.
Original PR description
In this PR, 'd-flex' replaced with 'd-md-flex' to make content visible within a div for mobile device. previously sign template fields and 'template properties' gets overflow in mobile device. task-3128541
Before this commit, the field node id (`field_id`) uses the field name for the first occurrence on the arch, and add an underscore and a number for the rest of the occurrences. This can create inconsistencies when sombody assumes that the field_id is equal to the name, and don't take into account the possibility of multiple occurrences. Now, a unique id is created since the first occurrence, this remove all ambiguity between the id and the name. Part-of task-id 3179751
Odoo now assigns unique identifiers to field elements from the start, reducing ambiguity when the same field appears multiple times on a page. This internal cleanup helps prevent inconsistent behavior in views and supports more reliable automated testing across several business apps.
Original PR description
Before this commit, the field node id (`field_id`) uses the field name for the first occurrence on the arch, and add an underscore and a number for the rest of the occurrences. This can create inconsistencies when sombody assumes that the field_id is equal to the name, and don't take into account the possibility of multiple occurrences. Now, a unique id is created since the first occurrence, this remove all ambiguity between the id and the name. Part-of task-id 3179751
This is an improvement over commit f6c13d7 in order to allow full customization of postgresql connection's `application_name`. In a PID linux namespace the containers processes IDs might not be relevant for a system administrator and one might want to customize the content of the `application_name` just like it was possible to do before commit f6c13d7 using the `PGAPPNAME` environment variable. This commit allows to expose an `ODOO_PGAPPNAME` environment variable whose content will be inte
Original PR description
This is an improvement over commit f6c13d7 in order to allow full customization of postgresql connection's `application_name`. In a PID linux namespace the containers processes IDs might not be…
This is an improvement over commit f6c13d7 in order to allow full customization of postgresql connection's `application_name`. In a PID linux namespace the containers processes IDs might not be relevant for a system administrator and one might want to customize the content of the `application_name` just like it was possible to do before commit f6c13d7 using the `PGAPPNAME` environment variable. This commit allows to expose an `ODOO_PGAPPNAME` environment variable whose content will be interpolated with the PID (optional) PR Note: I hesitated to let the result string untrimmed considering that psycopg2 does it anyway and when performing the trimming it raises a notice in the stderr. Finally decided to trim it in Odoo itself using the default NAMEDATALEN value of 63 chars. https://github.com/postgres/postgres/blob/c8e1ba736b2b9e8c98d37a5b77c4ed31baf94147/src/backend/parser/scansup.c#L92-L105 --- I confirm I have signed the Formulaire B-12 and read the Bible guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#117689
The if_other_expr_[above|below] subformulas were introduced in stable by https://github.com/odoo/enterprise/commit/f39862263c7e2332468a69736589a35d66d87b16. They basically allow displaying the value of an aggregation expression if another line's amount is above/below a provided bound. When using an expression with such a subformula to compute a carryover value (hence giving the expression a _carryover_... label) on a tax report, the posting of the said tax report's closing entry looped forever.
Original PR description
The if_other_expr_[above|below] subformulas were introduced in stable by https://github.com/odoo/enterprise/commit/f39862263c7e2332468a69736589a35d66d87b16. They basically allow displaying the value…
The if_other_expr_[above|below] subformulas were introduced in stable by https://github.com/odoo/enterprise/commit/f39862263c7e2332468a69736589a35d66d87b16. They basically allow displaying the value of an aggregation expression if another line's amount is above/below a provided bound. When using an expression with such a subformula to compute a carryover value (hence giving the expression a _carryover_... label) on a tax report, the posting of the said tax report's closing entry looped forever. No report from Odoo falls into this use case at the moment, but the issue occured on a development branch (for l10n_ma). This was due to the fact the tax closing expands only the aggregation expressions needed in the computation of the carryover to compute its value, hence not providing all the expressions of the report. Doing so, _get_aggregation_terms_details was called, and it neglected to include the expression used as comparison term by the subformula into the dependencies of the aggregation to expand. As a result, the comparison term could never be evaluated, and the loop went on forever, waiting for the comparison term to receive a value. Forward-Port-Of: odoo/odoo#117516
before this commit, the controllers directory is imported twice in the init file. after this commit, the duplicated import is removed. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#118069
Original PR description
before this commit, the controllers directory is imported twice in the init file. after this commit, the duplicated import is removed. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#118069
Fix the phone field buttons text alignment ("Call", "SMS", ...) which is currently rendering the letters on different lines because of a text-break css class introduced by: odoo/odoo#114442 Override this text-break class for the phone field buttons links. Task-3258943 Forward-Port-Of: odoo/odoo#117469
Original PR description
Fix the phone field buttons text alignment
("Call", "SMS", ...) which is currently rendering
the letters on different lines because of a text-break
css class introduced by: odoo/odoo#114442
Override this text-break class for the phone field buttons links.
Task-3258943
Forward-Port-Of: odoo/odoo#117469before this commit the lot field is visible even without activating the lot and serial number feature from the settings. after this commit the field will be visible only when the feature is activated in the settings. Related EE: https://github.com/odoo/enterprise/pull/35500 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#113030 Forward-Port-Of: odoo/odoo#109273
Original PR description
before this commit the lot field is visible even without activating the lot and serial number feature from the settings. after this commit the field will be visible only when the feature is activated in the settings. Related EE: https://github.com/odoo/enterprise/pull/35500 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#113030 Forward-Port-Of: odoo/odoo#109273
Changing end time for recurrent event will generate an error. steps to reproduce the error: 1- Create an event in the calendar app with recurrence on 2- Save and close 3- Edit this event again and select change all events at the top 4- Change the ending time The error was happening because the wrong key was accessed in a dictionary opw-3236432 Forward-Port-Of: odoo/odoo#117458
Original PR description
Changing end time for recurrent event will generate an error. steps to reproduce the error: 1- Create an event in the calendar app with recurrence on 2- Save and close 3- Edit this event again and select change all events at the top 4- Change the ending time The error was happening because the wrong key was accessed in a dictionary opw-3236432 Forward-Port-Of: odoo/odoo#117458
Accounts can be created with the help of `name_create`, where a user can add a code and a name in one place and we split that for them. To prevent the user from creating accounts by mistake too often, we've made it so that the quick create always raises an error to display the modal (pop-up to edit the account before creating it). However, now UserError does not bring the modal, but the error message is displayed instead. ValidationError in name_create makes more sense and also lets users see th
Original PR description
Accounts can be created with the help of `name_create`, where a user can add a code and a name in one place and we split that for them. To prevent the user from creating accounts by mistake too often, we've made it so that the quick create always raises an error to display the modal (pop-up to edit the account before creating it). However, now UserError does not bring the modal, but the error message is displayed instead. ValidationError in name_create makes more sense and also lets users see the modal. task-3262539 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#117629
before this commit, the shortcuts in the user menu is not translatable. here the gettext function is being placed inside a template literal and the library odoo use to extract _t occurrences from the sources doesn't seem to look inside javascript template literals by default. after this commit, the gettext is moved outside template and will get translated. Closes: https://github.com/odoo/odoo/issues/114711 --- I confirm I have signed the CLA and read the PR guidelines at www
Original PR description
before this commit, the shortcuts in the user menu is not translatable. here the gettext function is being placed inside a template literal and the library odoo use to extract _t occurrences from the sources doesn't seem to look inside javascript template literals by default. after this commit, the gettext is moved outside template and will get translated. Closes: https://github.com/odoo/odoo/issues/114711 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#118114 Forward-Port-Of: odoo/odoo#114720
Since https://github.com/odoo/odoo/pull/104062, the location and scrap location id fields on a scrap order are no longer editable (even while still in draft). To reproduce: - Enable storage locations in settings - Create a new scrap order Bug: The source and draft location are readonly. This fix restores the intended behaviour to make these fields editable while in draft state. Task: 3266655 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr F
Original PR description
Since https://github.com/odoo/odoo/pull/104062, the location and scrap location id fields on a scrap order are no longer editable (even while still in draft). To reproduce: - Enable storage locations in settings - Create a new scrap order Bug: The source and draft location are readonly. This fix restores the intended behaviour to make these fields editable while in draft state. Task: 3266655 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#117931
When assigned the role of restricted editor, there are many ways to break the web_editor when trying to do actions that should be unavailable. There is a traceback for the following scenarios under some circumstances (mainly because of pages without editable areas or features without the proper access rights): - Drag and dropping snippet when Restricted Editor. - Clicking on product when Restricted Editor in /shop. - Clicking on product image on specific product page. - Clicking on use
Original PR description
When assigned the role of restricted editor, there are many ways to break the web_editor when trying to do actions that should be unavailable. There is a traceback for the following scenarios under…
When assigned the role of restricted editor, there are many ways to break the web_editor when trying to do actions that should be unavailable. There is a traceback for the following scenarios under some circumstances (mainly because of pages without editable areas or features without the proper access rights): - Drag and dropping snippet when Restricted Editor. - Clicking on product when Restricted Editor in /shop. - Clicking on product image on specific product page. - Clicking on user name (e.g. Marc Demo). - Clicking on menu items or logo. - Clicking on a blog's image in /blog. - Clicking on a blog's image on specific blog page. - Clicking on calendar's image in /calendar. There is now no longer a traceback which makes the editor crash or freeze. This mimics the behavior in other cases where the editor does not show a traceback, but there is no message indicating that the action is unauthorized. When accessing a menu that cannot be edited, the "Edit the menu" button is not shown to the restricted editor. task-2747895 opw-3164176 Forward-Port-Of: odoo/odoo#118080 Forward-Port-Of: odoo/odoo#76900
before this commit, in the website forum faq section, it is shown, for each down vote it will reduce 10 xp, but actually it is reducing 2 XP. after this commit, the points shown in the faq will be corrected to 2 xp from 10 xp. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#118098
Original PR description
before this commit, in the website forum faq section, it is shown, for each down vote it will reduce 10 xp, but actually it is reducing 2 XP. after this commit, the points shown in the faq will be corrected to 2 xp from 10 xp. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#118098
before this commit, on clicking the picking calendar view, it allows the quick adding from the calendar view and entered value is going to the name field of stock.picking model. after this commit, quick adding will be disabled and on clicking form will be opened with selected date. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#112605
Original PR description
before this commit, on clicking the picking calendar view, it allows the quick adding from the calendar view and entered value is going to the name field of stock.picking model. after this commit, quick adding will be disabled and on clicking form will be opened with selected date. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#112605
Steps to reproduce: - Install appointments - Log in as Marc Demo - Go to Calendar/Online appointments - Click on a record in the availability x2many fields Current behaviour: It opens the record in a form modal. Expected behaviour It should not open the record since #110838 because the x2manyfield is in `editable="bottom"`. Forward-Port-Of: odoo/odoo#117913
Original PR description
Steps to reproduce: - Install appointments - Log in as Marc Demo - Go to Calendar/Online appointments - Click on a record in the availability x2many fields Current behaviour: It opens the record in a form modal. Expected behaviour It should not open the record since #110838 because the x2manyfield is in `editable="bottom"`. Forward-Port-Of: odoo/odoo#117913
Make the res_partner_many2one behave similarly to the many2one field during blur where a confirmation dialog is shown. TASK-ID: 3205625 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#114166
Original PR description
Make the res_partner_many2one behave similarly to the many2one field during blur where a confirmation dialog is shown. TASK-ID: 3205625 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#114166
Based on change from PR odoo@df74fb6, the rule stated on the document attached has been reverted. It should be using the customer's tax address rather than the delivery address'. One of Indonesian customers are getting a warning letter from the government regarding this. 3230742 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#117646 Forward-Port-Of: odoo/odoo#116140
Original PR description
Based on change from PR odoo@df74fb6, the rule stated on the document attached has been reverted. It should be using the customer's tax address rather than the delivery address'. One of Indonesian customers are getting a warning letter from the government regarding this. 3230742 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#117646 Forward-Port-Of: odoo/odoo#116140
The tax totals widget is formatting data using the old props instead of the new. When viewing an invoice the currency is correct, but when scrolling through records or changing currencies, the currency in the widget is not correct. To replicate: 1. Create 2 invoices, one in EUR, one in USD, ideally both with tax 2. Scroll through the record form views using the next/previous pager buttons 3. Observe the currency is not correct (display USD instead of EUR, and EUR instead of USD) This fi
Original PR description
The tax totals widget is formatting data using the old props instead of the new. When viewing an invoice the currency is correct, but when scrolling through records or changing currencies, the currency in the widget is not correct. To replicate: 1. Create 2 invoices, one in EUR, one in USD, ideally both with tax 2. Scroll through the record form views using the next/previous pager buttons 3. Observe the currency is not correct (display USD instead of EUR, and EUR instead of USD) This fix modifies the way the record data (props.value) is formatted, and ensures using the correct currency (nextProps) instead of the old one (props) OPW-3244079 Forward-Port-Of: odoo/odoo#118106 Forward-Port-Of: odoo/odoo#117509
Steps to reproduce: 1-create a weight unit 'jm' bigger than reference ratio 2.47541 rounding 0.001 2-create a stored product uom:'jm' / purchase_uom: 'kg' 3-set valuation method to automated (fifo) 4-create a replenishement for 200 (jm) 5-confirm and recieve the products 6-valuation for that stock move is null Bug: computations in the stock module are done with rounding method (half-up) when computing the unit price the recieved quantity is computed with up rounding which leads
Original PR description
Steps to reproduce:
1-create a weight unit 'jm' bigger than reference
ratio 2.47541 rounding 0.001
2-create a stored product uom:'jm' / purchase_uom: 'kg'
3-set valuation method to automated (fifo)
4-create a replenishement for 200 (jm)
5-confirm and recieve the products
6-valuation for that stock move is null
Bug:
computations in the stock module are done with rounding method (half-up) when computing the unit price the recieved quantity is computed with up rounding which leads to a mismatch
Fix:
applied the same rounding method on all the Steps
opw-3213997
Forward-Port-Of: odoo/odoo#117334Steps to reproduce: - Create two sales journals - Select the second journal - Upload an invoice - The invoice is in the first journal instead of the second Fix: We can simply use the context to retrieve the current selected journal if it's given, otherwise we use the previous fallback (infering the journal with the move type) task-id 3258956 Forward-Port-Of: odoo/odoo#117798 Forward-Port-Of: odoo/odoo#117491
Original PR description
Steps to reproduce: - Create two sales journals - Select the second journal - Upload an invoice - The invoice is in the first journal instead of the second Fix: We can simply use the context to retrieve the current selected journal if it's given, otherwise we use the previous fallback (infering the journal with the move type) task-id 3258956 Forward-Port-Of: odoo/odoo#117798 Forward-Port-Of: odoo/odoo#117491
Currently, if a product has a fixed tax associated with it, on invoice confirmation with the fixed tax as one of the tax lines, the `IMP_6` tag gets assigned a non-int value. This leads to an error when trying to build the xml using the `tim_section` template at line https://github.com/odoo/enterprise/blob/a7233c59b59d368d182ead0eae48297be1693e1f/l10n_co_edi/views/electronic_invoice.xml#L17 The fix is to assign it to 0 instead of an empty string. opw-3121940 Forward-Port-Of: odoo/ente
Original PR description
Currently, if a product has a fixed tax associated with it, on invoice confirmation with the fixed tax as one of the tax lines, the `IMP_6` tag gets assigned a non-int value. This leads to an error when trying to build the xml using the `tim_section` template at line https://github.com/odoo/enterprise/blob/a7233c59b59d368d182ead0eae48297be1693e1f/l10n_co_edi/views/electronic_invoice.xml#L17 The fix is to assign it to 0 instead of an empty string. opw-3121940 Forward-Port-Of: odoo/enterprise#39209 Forward-Port-Of: odoo/enterprise#38988
account_journal 'qif_date_format' was not being passed in the context when uploading a .qif to an account journal, so all dates were formatted with dayfirst=False. replaces self.env.context.get('qif_date_format') with self.qif_date_format to access the date format qif imports should now have the correct date format when uploading to a journal with qif_date_format='dd/mm/yy'. opw-3228677 (related to ticket) Forward-Port-Of: odoo/enterprise#39258
Original PR description
account_journal 'qif_date_format' was not being passed in the context when uploading a .qif to an account journal, so all dates were formatted with dayfirst=False.
replaces self.env.context.get('qif_date_format') with self.qif_date_format to access the date format
qif imports should now have the correct date format when uploading to a journal with qif_date_format='dd/mm/yy'.
opw-3228677 (related to ticket)
Forward-Port-Of: odoo/enterprise#39258check the input of the create to prevent potential error task-id: 3258828 Forward-Port-Of: odoo/enterprise#39137
Original PR description
check the input of the create to prevent potential error task-id: 3258828 Forward-Port-Of: odoo/enterprise#39137
Before this commit, since the conversion of the Gantt view in OWL the project_enterprise tour is no longer works because `o_gantt_progressbar` no longer exists in XML of the gantt view. The reason is that class has been replaced by `o_gantt_progress_bar` This commit updates the problematic selectors to be able to select the same elements than before conversion of the Gantt view in OWL. Forward-Port-Of: odoo/enterprise#39558
Original PR description
Before this commit, since the conversion of the Gantt view in OWL the project_enterprise tour is no longer works because `o_gantt_progressbar` no longer exists in XML of the gantt view. The reason is that class has been replaced by `o_gantt_progress_bar` This commit updates the problematic selectors to be able to select the same elements than before conversion of the Gantt view in OWL. Forward-Port-Of: odoo/enterprise#39558
[FIX] Tax code for withhold report The "code" used to assemble the withhold XML is not the same as "tax code" of the tax (SRI likes to have special codes for assembling the XMLs that differs from the "tax code"). The fix uses the "tax code" for the withhold pdf. Please note that for profit withhold and vat withhold a different field (tax code, and base tax code) is used, because of local common practise. Forward-Port-Of: odoo/enterprise#37777
Original PR description
[FIX] Tax code for withhold report The "code" used to assemble the withhold XML is not the same as "tax code" of the tax (SRI likes to have special codes for assembling the XMLs that differs from the "tax code"). The fix uses the "tax code" for the withhold pdf. Please note that for profit withhold and vat withhold a different field (tax code, and base tax code) is used, because of local common practise. Forward-Port-Of: odoo/enterprise#37777
The leaves to defer dashboard warning was not taking into account the companies the user was logged into. Users from another company clicking on the link would then get a multi-company error. Same thing for the warning banner on the gantt / calendar list view of work entries. Also, uses `search_count` instead of `search` to speed things up. task-3265145 Forward-Port-Of: odoo/enterprise#39522 Forward-Port-Of: odoo/enterprise#39374
Original PR description
The leaves to defer dashboard warning was not taking into account the companies the user was logged into. Users from another company clicking on the link would then get a multi-company error. Same thing for the warning banner on the gantt / calendar list view of work entries. Also, uses `search_count` instead of `search` to speed things up. task-3265145 Forward-Port-Of: odoo/enterprise#39522 Forward-Port-Of: odoo/enterprise#39374
Purpose ======= Avoid negative employer contribution to meal vouchers if the meal vouchers amount is equal to 0 Forward-Port-Of: odoo/enterprise#39273
Original PR description
Purpose ======= Avoid negative employer contribution to meal vouchers if the meal vouchers amount is equal to 0 Forward-Port-Of: odoo/enterprise#39273
* helpdesk_stock, industry_fsm_stock, quality, quality_control, quality_mrp_workorder, sale_stock_renting before this commit the lot field is visible even without activating the lot and serial number feature from the settings. after this commit the field will be visible only when the feature is activated in the settings. Forward-Port-Of: odoo/enterprise#37251 Forward-Port-Of: odoo/enterprise#35500
Original PR description
* helpdesk_stock, industry_fsm_stock, quality, quality_control, quality_mrp_workorder, sale_stock_renting before this commit the lot field is visible even without activating the lot and serial number feature from the settings. after this commit the field will be visible only when the feature is activated in the settings. Forward-Port-Of: odoo/enterprise#37251 Forward-Port-Of: odoo/enterprise#35500
This adds a test to ensure the issue fixed by https://github.com/odoo/odoo/pull/117516 in community does not occur again. This is done in enterprise, because that's where all the report engines are used and tested. Forward-Port-Of: odoo/enterprise#39486
Original PR description
This adds a test to ensure the issue fixed by https://github.com/odoo/odoo/pull/117516 in community does not occur again. This is done in enterprise, because that's where all the report engines are used and tested. Forward-Port-Of: odoo/enterprise#39486
When you have multiple accounts in a category of Disallowed Expenses, and you group by vehicle, the group by "hides" some of the accounts. This should not happen of course. The problem was caused by the key used during the postprocessing of the query results. If the fleet rate was the same for several accounts, the grouping key would be identical. This meant that on the last value was shown since the previous ones got overwritten. This is now fixed and the tests have been adadpted accordi
Original PR description
When you have multiple accounts in a category of Disallowed Expenses, and you group by vehicle, the group by "hides" some of the accounts. This should not happen of course. The problem was caused by the key used during the postprocessing of the query results. If the fleet rate was the same for several accounts, the grouping key would be identical. This meant that on the last value was shown since the previous ones got overwritten. This is now fixed and the tests have been adadpted accordingly in order to cover this occurrence. Also we should display percentages with a precision of two decimals. task-3258972 Forward-Port-Of: odoo/enterprise#39465
'Depreciated Amount' is currently translated 'Montant amortissable' but this is actually the translation of 'Depreciable Amount'. The correct translation is 'Montant amorti'. opw-3210599 Forward-Port-Of: odoo/enterprise#39304
Original PR description
'Depreciated Amount' is currently translated 'Montant amortissable' but this is actually the translation of 'Depreciable Amount'. The correct translation is 'Montant amorti'. opw-3210599 Forward-Port-Of: odoo/enterprise#39304
Prior to this commit, when the `ui-autocomplete` dropdown was longer than the input it came from, or if the dropdown appeared above the input (when there was not enough space below it), there was no top border and this created a graphical issue. After this commit, the dropdown always has a top border and fixes this issue. task-3140983 Forward-Port-Of: odoo/enterprise#36104
Original PR description
Prior to this commit, when the `ui-autocomplete` dropdown was longer than the input it came from, or if the dropdown appeared above the input (when there was not enough space below it), there was no top border and this created a graphical issue. After this commit, the dropdown always has a top border and fixes this issue. task-3140983 Forward-Port-Of: odoo/enterprise#36104