Tuesday, April 11, 2023
9 changes · master
Resolved issues and error corrections
Users can now reattach the same file in the Discuss composer after removing it. This prevents a frustrating upload issue and makes file sharing behave as expected.
Original PR description
Before this commit, when clicking on "Attach files" in discuss composer, then removing it, it was not possible to upload the same file again. This happens because file input of file uploader relies on `change` from the input. The `input.value` contains the filepath, so if we upload the exact same file without clearing the value, the value will be unchanged and it won't trigger uploading as a result. This commit fixes the issue by clearing the input just after the file has been uploaded, so that we can upload the same file. Cannot reproduce bug in QUnit tests because `inputFile` helper programmatically always trigger "change" on input file.
This fix ensures filter dropdowns open next to the button users clicked, even inside embedded Knowledge list views. It improves usability by preventing menus from appearing in unexpected positions when page layout rules affect placement.
Original PR description
[FIX] web: compute containing block layout in position hook How to reproduce: - create a list embedded view in Knowledge (/item list) - in the control panel click on "Filters" Current behavior: - the dropdown is not correctly positioned Expected behavior: - the dropdown should be positioned around the button Fix: `getBestPosition` uses dimensions and layout positionning based on the viewport, but `reposition` modifies the style properties `top` and `left` of the element, which are relative to the closest containing block. Since in that case the style position is `fixed`, there are a number of factor that can influence the containing block, as specified in: https://developer.mozilla.org/en-US/docs/Web/CSS/Containing_block#identifying_the_containing_block We can easily compute the layout offset caused by the containing block just after resetting the popper top and left to `0px` and take it into account for the final value. Task-3267555
An internal accounting test was corrected after a related field was removed, preventing false failures in automated checks. This helps keep the development pipeline reliable without changing user-facing accounting features.
Original PR description
Bug === The tagged had only `post_install`, so it wasn't run on the runbot. In the meantime, the account team removed `user_type_id` and so the test is failing (and I could have been merged because of the tag).
This fix prevents unnecessary warning messages during module cleanup when Odoo encounters models that do not have database tables. It reduces noise for administrators and helps keep system logs focused on issues that require attention.
Original PR description
Along with improving the table_kind API, #117439 added a warning when dropping non-tables. This warning turns out to trigger on many models, in two major cases: - the hook is called on abstract models, which don't have a table in the first place, it probably should not be called for those but can easily be skipped - the hook is also called on `_auto = False` which don't have a table anymore, this is because we use `DROP TABLE $table CASCADE`, which implicitly drops any view (or table) depending on the table, it might be possible to avoid this by ensuring we drop models in reverse topological order *and* drop all of a module's views then tables at once (by passing multiple names to `DROP`, but for now just ignore the case where we're trying to drop an object which can't be found
This fixes an outdated link path used by the mail composer suggestion feature. It helps ensure users are directed to the correct place when interacting with suggested mail-related items, reducing small navigation errors.
Chat message bubbles from other people are now easier to see in the messaging interface. This improves readability and helps users follow conversations more comfortably.
Original PR description
Before:   After:  
Chat windows now automatically limit their height to the available page space. This prevents conversations from overflowing off-screen, making messaging easier to use on smaller or constrained displays.
Original PR description
Before this commit, when global height was below height of a chat window, the chat window was overflowing. This commit fixes the issue by ceiling the height of chat window to the global height. Before/After  
This fixes a visual issue where white corners could appear around rounded chat windows in the light theme. It also ensures hidden chat menu items display correctly above other chat windows, improving the overall live chat experience.
Original PR description
Before this commit, in white theme, chat window rounded borders had some white color leak. This comes from background color of chat window, which is white, while the header background color is purple. This commit fixes the issue by setting the chat window background color to purple. The content now defines its own color, and the header just inherit from the chat window background color. This commit also fixes a bug where the chat window hidden menu items were below visible chat windows. Before  After 
This fix ensures Sign template fields and template properties remain visible and properly contained on mobile devices. It prevents layout overflow, making it easier for users to manage signing templates from smaller screens.
Original PR description
In this PR, 'd-flex' replaced with 'd-md-flex' to make content visible within a div for mobile device. previously sign template fields and 'template properties' gets overflow in mobile device. task-3128541