Thursday, April 27, 2023
29 changes
Enhancements to existing features
This update prepares several business modules for a safer migration to a newer way of loading records. It reduces the risk of disruption while teams move from the old approach to the new one, especially in appraisal, referral, and timesheet-related workflows.
Original PR description
duplicate code of read and search_read to support unity read. this will help us migrate code from the "old" read to the new without breaking everything
Odoo Studio now reads editable field widget options directly from each widget's own metadata instead of relying on a separate Studio-maintained list. This makes future widget updates easier to maintain and reduces the risk of Studio showing outdated or inconsistent configuration options.
Original PR description
*: knowledge This commit removes the need to declare and detail each available option for a specific widget. Now, this list of supported options are detailed directly on the field widget's object, with the supportedOptions attribute. Only the properties that are tied to a type of field remain in the file of the TypeWidgetProperties component. It is now easier to maintain and update the available options that are editable in studio, since a developer can only implement it in the widget implementation file, without the need to update a list in studio. task-3259617
Resolved issues and error corrections
Enterprise modules were adjusted to stay compatible with a related platform-wide layout correction in the community edition. This keeps appraisal, payroll, recruitment signing, and knowledge screens and tests working as expected after the underlying change.
Original PR description
Community counterpart: https://github.com/odoo/odoo/pull/119815 ### [FIX] *: adapt enterprise to the fix of root class attr *: adaptations for hr_appraisal_skills, hr_payroll, hr_recruitment_sign, knowledge **Introduced Changes** This is the enterprise counterpart for the adaptations due to changes in the community repo. See the commit of the community PR https://github.com/odoo/odoo/pull/119815 which states the following sentence: « ... the whole codebase has been checked and adapted ... »
Code cleanup and technical improvements
This change reorganizes internal files so the Discuss-related code can be separated from Mail in a future update. For business users, there should be no immediate change in behavior, but it supports cleaner product structure and easier maintenance going forward.
Original PR description
*: documents In preparation of splitting 'discuss' and 'mail' modules. This allow using new folder discuss/ that contains all static files of new module 'discuss'. Part of task-3265211 https://github.com/odoo/odoo/pull/119860
Miscellaneous changes
odoo/enterprise#26401 merged modules in a way that only added mandatory fields in the VAT declaration if it was an annual declaration. They should be also added for monthly, quarterly, and simplified declarations. At the same time, the test for the tax report was modified during the reportalypse and did not test the same xml file as the one normally generated for the user, which is why this error was not caught in the test. The xml file in the test contained fields that should be removed if t
Original PR description
odoo/enterprise#26401 merged modules in a way that only added mandatory fields in the VAT declaration if it was an annual declaration. They should be also added for monthly, quarterly, and simplified declarations. At the same time, the test for the tax report was modified during the reportalypse and did not test the same xml file as the one normally generated for the user, which is why this error was not caught in the test. The xml file in the test contained fields that should be removed if they amount to zero and did not contain the required fields. Now the test tests the same xml file a user would see when exporting the tax report. opw-3270105 Forward-Port-Of: odoo/enterprise#40263
The Knowledge app version is updated to 1.0 to match existing upgrade expectations. This keeps versioning consistent and helps avoid confusion during upgrades or maintenance.
Original PR description
Let us consider it is now 1.0 . And be coherent with upgrade scripts that already exist.
A minor issue in payroll planning calculations was corrected after a recent change introduced an incompatibility in how grouped payroll data was read. This helps ensure payroll planning information is processed reliably without changing the user workflow.
Original PR description
In https://github.com/odoo/enterprise/commit/0a24c01ec178984df032710b81d562366c016ebb, a small error has been introduced, fix it (_read_group has a new API)
There is not much documentation available, but a change in the community code is making the test to fail. That change fixes the fact that balance was not computed correctly if only the amount in foreign currency is given, so that amount was 0 in the test when it shouldn't have been. Now that this is fixed, we see that it makes sense to take the absolute value, just like when the tax code is `05` Forward-Port-Of: odoo/enterprise#40428
Original PR description
There is not much documentation available, but a change in the community code is making the test to fail. That change fixes the fact that balance was not computed correctly if only the amount in foreign currency is given, so that amount was 0 in the test when it shouldn't have been. Now that this is fixed, we see that it makes sense to take the absolute value, just like when the tax code is `05` Forward-Port-Of: odoo/enterprise#40428
To reproduce: - Create a new report, with one line whose only expression uses engine 'external', has 'integer' as figure_type and is editable. - Open the report and try editing its value => Traceback telling the rounding should be provided. For integer expressions, the rounding should implicitly be 0; asking for an explicit value makes no sense here. Forward-Port-Of: odoo/enterprise#40384 Forward-Port-Of: odoo/enterprise#40285
Original PR description
To reproduce: - Create a new report, with one line whose only expression uses engine 'external', has 'integer' as figure_type and is editable. - Open the report and try editing its value => Traceback telling the rounding should be provided. For integer expressions, the rounding should implicitly be 0; asking for an explicit value makes no sense here. Forward-Port-Of: odoo/enterprise#40384 Forward-Port-Of: odoo/enterprise#40285
Currently, when trying to use the "load more" feature, the partners just repeat themselves instead of loading the next batch. This was due to the fact that the offset and limit parameters were not included in the SQL query. task-3262534 Forward-Port-Of: odoo/enterprise#39719
Original PR description
Currently, when trying to use the "load more" feature, the partners just repeat themselves instead of loading the next batch. This was due to the fact that the offset and limit parameters were not included in the SQL query. task-3262534 Forward-Port-Of: odoo/enterprise#39719
Before this commit ================== - Record Production button inside tablet view doesn't go back to the WO kanban view, since it was not triggering the required action of WO kanban view. - If the first wo is cancelled and if we move to the last wo then it only shows mark as done button and not the mark as done and close mo, since the condition for mark as done and close mo to be visible was that all previous work order should be done and not consider the cancelled workorder. -
Original PR description
Before this commit ================== - Record Production button inside tablet view doesn't go back to the WO kanban view, since it was not triggering the required action of WO kanban view. - If the first wo is cancelled and if we move to the last wo then it only shows mark as done button and not the mark as done and close mo, since the condition for mark as done and close mo to be visible was that all previous work order should be done and not consider the cancelled workorder. - The BoM overview report doesn't consider the workcenter product specific setup and cleanup time. After this commmit ================== - When Record Production button triggered it will go back to the WO kanban view - MO closed even when first WO is cancelled. - Got correct value in BoM Overview Report when product specific setup and cleanup time is specified. TaskID - 3192078 Forward-Port-Of: odoo/enterprise#40135 Forward-Port-Of: odoo/enterprise#39132
Based on the lates DIAN specification, the tags <ADQ_8> and <ADQ_9> have been removed, and now are required only for the EDI specific for the Health care secto, which is not supported in Odoo as it requires additional features. These fields were used to send the first name and last name of the customer when they were clasified as "Individual", now the Customer name either for Individuals and for companies is sent in the ADQ_6 and ADQ_7. Forward-Port-Of: odoo/enterprise#40300 Forward-Port-Of: od
Original PR description
Based on the lates DIAN specification, the tags <ADQ_8> and <ADQ_9> have been removed, and now are required only for the EDI specific for the Health care secto, which is not supported in Odoo as it requires additional features. These fields were used to send the first name and last name of the customer when they were clasified as "Individual", now the Customer name either for Individuals and for companies is sent in the ADQ_6 and ADQ_7. Forward-Port-Of: odoo/enterprise#40300 Forward-Port-Of: odoo/enterprise#39852
Forward-Port-Of: odoo/enterprise#40283
Original PR description
Forward-Port-Of: odoo/enterprise#40283
When some records were selected, if the user was triggering the preview of a record, then the selection was not kept. TaskId-3171515 Forward-Port-Of: odoo/enterprise#39891
Original PR description
When some records were selected, if the user was triggering the preview of a record, then the selection was not kept. TaskId-3171515 Forward-Port-Of: odoo/enterprise#39891
Steps: - Make DB without demo data. - Now click on the planning module. Issue: Can't able to open the planning app it throws a traceback. Cause: try to get isFlexibleHours of resource even though there's no record. Fix: verify whether isFlexibleHours is available. task-3288652 Forward-Port-Of: odoo/enterprise#40339
Original PR description
Steps: - Make DB without demo data. - Now click on the planning module. Issue: Can't able to open the planning app it throws a traceback. Cause: try to get isFlexibleHours of resource even though there's no record. Fix: verify whether isFlexibleHours is available. task-3288652 Forward-Port-Of: odoo/enterprise#40339
Open a report with the action modify manual value (ex. Tax report) Click on the pencil button and without adding a value hit "Post" Traceback opw-3268271 Forward-Port-Of: odoo/enterprise#39738
Original PR description
Open a report with the action modify manual value (ex. Tax report) Click on the pencil button and without adding a value hit "Post" Traceback opw-3268271 Forward-Port-Of: odoo/enterprise#39738
Create an invoice with invoice date set to 3 days ago Add a line, confirm, send for validation Invoice will be rejected with error 301 Message : Error de validaciones adicionales [Error #CFDI40101] El campo Fecha no cumple con el patrón requerido. Folio: 7. Serie: INV/2023/03/. Han pasado más de 72 horas desde la fecha de generación del comprobante. This occurs because when confirming the invoice we save the current time in `l10n_mx_edi_post_time` When sending the xml, we combine the inv
Original PR description
Create an invoice with invoice date set to 3 days ago Add a line, confirm, send for validation Invoice will be rejected with error 301 Message : Error de validaciones adicionales [Error #CFDI40101] El campo Fecha no cumple con el patrón requerido. Folio: 7. Serie: INV/2023/03/. Han pasado más de 72 horas desde la fecha de generación del comprobante. This occurs because when confirming the invoice we save the current time in `l10n_mx_edi_post_time` When sending the xml, we combine the invoice date with the saved time. The result will be below the minimum validation time (72 hours) and the validation will be rejected Example (current datetime 2023-03-14T10:10:07): Fecha de emisión: 2023-03-11T10:10:00 Fecha de intento de timbrado: 2023-03-14T10:10:07 Fecha de emisión mínima permitida: 2023-03-11T10:10:07 opw-3206676 Forward-Port-Of: odoo/enterprise#38173
Purpose ======= Currently the salary configurator won't load properly if called before the frontend assets are generated. As the template is rendered and the transaction is rollbacked before loading the response to drop all the generated records used for the simulation (new employee, contract, payslip, company car, etc...), if the assets are generated with the template, they will be dropped and used afterward, which is leading to a broken page. For big production base like odoo.com thi
Original PR description
Purpose ======= Currently the salary configurator won't load properly if called before the frontend assets are generated. As the template is rendered and the transaction is rollbacked before loading the response to drop all the generated records used for the simulation (new employee, contract, payslip, company car, etc...), if the assets are generated with the template, they will be dropped and used afterward, which is leading to a broken page. For big production base like odoo.com this is not really an issue as the frontend assets are always loaded, but this could be problematic for smaller customer databases. Specification ============= The idea of this commit is to force the assets generation before doing the simulation so that this use case is not occuring anymore. TaskID: 3266112 Forward-Port-Of: odoo/enterprise#39562
Balance was wrong when filtering the report by unreconciled entries only. Steps: - Create an invoice for $1000 - Register payment for $700 - Go to reports/partner ledger - Select filter "Only Show Unreconciled Entries" -> Balance is showing $1000 instead of $300 opw-3268586 Forward-Port-Of: odoo/enterprise#40243 Forward-Port-Of: odoo/enterprise#40152
Original PR description
Balance was wrong when filtering the report by unreconciled entries only. Steps: - Create an invoice for $1000 - Register payment for $700 - Go to reports/partner ledger - Select filter "Only Show Unreconciled Entries" -> Balance is showing $1000 instead of $300 opw-3268586 Forward-Port-Of: odoo/enterprise#40243 Forward-Port-Of: odoo/enterprise#40152
A multi-company error would occur when trying to export work entries to SDWorx. Forward-Port-Of: odoo/enterprise#40369
Original PR description
A multi-company error would occur when trying to export work entries to SDWorx. Forward-Port-Of: odoo/enterprise#40369
Forward-Port-Of: odoo/enterprise#40143
Original PR description
Forward-Port-Of: odoo/enterprise#40143
Before this commit, a step could fail in planning tour because the progress selected to check if it is visible is the first one found instead of selecting the one of the employee created in the test. It means when there are some data (demo data for instance), the progressbar checked if not the one of the employee created in the test and so the step could fail because the progressbar is hidden for the employee selected. This commit selects progressbar of the employee created in the test to be
Original PR description
Before this commit, a step could fail in planning tour because the progress selected to check if it is visible is the first one found instead of selecting the one of the employee created in the test. It means when there are some data (demo data for instance), the progressbar checked if not the one of the employee created in the test and so the step could fail because the progressbar is hidden for the employee selected. This commit selects progressbar of the employee created in the test to be sure we select the progressbar of the right employee and to have a consistent test. Forward-Port-Of: odoo/enterprise#40376
### Summary Currently, when using both an early payment discount (upon invoice) and price-included taxes, the invoice totals are not calculated correctly. ### Steps to Reproduce 1. Set `Cash Discount Tax Reduction` to `Always (upon invoice)`. 2. Create an invoice with the payment term set to `2/7 Net 30`. 3. Add an invoice line with a price of 100 and a 21% price-included tax. 4. Save the invoice: The `Untaxed Amount` should be 100, but it incorrectly shows 100.35 instead. ### Cau
Original PR description
### Summary Currently, when using both an early payment discount (upon invoice) and price-included taxes, the invoice totals are not calculated correctly. ### Steps to Reproduce 1. Set `Cash Discount Tax Reduction` to `Always (upon invoice)`. 2. Create an invoice with the payment term set to `2/7 Net 30`. 3. Add an invoice line with a price of 100 and a 21% price-included tax. 4. Save the invoice: The `Untaxed Amount` should be 100, but it incorrectly shows 100.35 instead. ### Cause When calculating the totals, the price-included tax is applied to one of the early payment discount lines. Since the tax is price-included, the system recalculates a new base price for the EPD line, which ultimately leads to an incorrect `Untaxed Amount`. opw-3239904 Community PR: odoo/odoo#117099 Forward-Port-Of: odoo/enterprise#40088 Forward-Port-Of: odoo/enterprise#39007
Before this PR, we supported using the address of the Customer, but in some very specific case, the address of the customer is not precise enough to get an appropriate tax computation. If latitude and longitude information are set on the partner then avalara will use only the coordinates for computing the taxes. task-id: 3248767 Forward-Port-Of: odoo/enterprise#39846
Original PR description
Before this PR, we supported using the address of the Customer, but in some very specific case, the address of the customer is not precise enough to get an appropriate tax computation. If latitude and longitude information are set on the partner then avalara will use only the coordinates for computing the taxes. task-id: 3248767 Forward-Port-Of: odoo/enterprise#39846
The lines_widget on the bank recon width seems to be broken from saas-16.1 up. This commit removes a style that was applied for 16.0 but is no longer required. The manual operations tab also causes a small horizontal scroll on the bank recon form view. This is caused by the bootstrap row. Add css to remove the right & left padding. Fix the lines_widget table header, to match the standard table header, by adding a `<tr>` Fix the notes field on the form view - backport form_notes view ch
Original PR description
The lines_widget on the bank recon width seems to be broken from saas-16.1 up. This commit removes a style that was applied for 16.0 but is no longer required. The manual operations tab also causes a small horizontal scroll on the bank recon form view. This is caused by the bootstrap row. Add css to remove the right & left padding. Fix the lines_widget table header, to match the standard table header, by adding a `<tr>` Fix the notes field on the form view - backport form_notes view change from https://github.com/odoo/enterprise/pull/39955 Forward-Port-Of: odoo/enterprise#40150