Thursday, April 27, 2023
29 changes
Miscellaneous changes
- Import bank statement from the file not having label/partner - Access an existing reconciliation model and add a partner mapping - Try to reconcile bank statements Traceback ``` [...] File "/home/odoo/src/odoo/16.0/addons/account/models/account_reconcile_model.py", line 855, in _get_partner_from_mapping match_payment_ref = re.match(partner_mapping.payment_ref_regex, st_line.payment_ref) if partner_mapping.payment_ref_regex else True File "/usr/lib/python3.10/re.py", line 190, in
Original PR description
- Import bank statement from the file not having label/partner - Access an existing reconciliation model and add a partner mapping - Try to reconcile bank statements Traceback ``` [...] File "/home/odoo/src/odoo/16.0/addons/account/models/account_reconcile_model.py", line 855, in _get_partner_from_mapping match_payment_ref = re.match(partner_mapping.payment_ref_regex, st_line.payment_ref) if partner_mapping.payment_ref_regex else True File "/usr/lib/python3.10/re.py", line 190, in match return _compile(pattern, flags).match(string) TypeError: expected string or bytes-like object ``` opw-3235015 X-original-commit: f983e0f Forward-Port-Of: odoo/enterprise#40345
After https://github.com/odoo/enterprise/pull/39143 we face concurrency issue when fetching many transactions at the same time through bank sync. This is due to the fact the reconciliation cron is called twice on the same recordset of transaction. This PR removes the second useless call. Forward-Port-Of: odoo/enterprise#40286
Original PR description
After https://github.com/odoo/enterprise/pull/39143 we face concurrency issue when fetching many transactions at the same time through bank sync. This is due to the fact the reconciliation cron is called twice on the same recordset of transaction. This PR removes the second useless call. Forward-Port-Of: odoo/enterprise#40286
Currently, our SEPA mandate only applies to B2C/ CORE clients. More specifically, the header and the legal text has to be changed when the mandate is for B2B. opw-3170040 Forward-Port-Of: odoo/enterprise#40322 Forward-Port-Of: odoo/enterprise#39305
Original PR description
Currently, our SEPA mandate only applies to B2C/ CORE clients. More specifically, the header and the legal text has to be changed when the mandate is for B2B. opw-3170040 Forward-Port-Of: odoo/enterprise#40322 Forward-Port-Of: odoo/enterprise#39305
**Steps to reproduce the issue:** - Create a user “U1” with the following access right: - Inventory: User - Quality: User - Connect as Admin - Create a storable product “P1” - Go to Quality > Quality Control > Control Points: - product: P1 - control per: Operation - Go to inventory > operation > transfer: - Operation type: Reception - product: P1 - Demand: 10 units - Click on “Mark as todo” - Connect with “U1” - Go to the created transfer: - Pa
Original PR description
**Steps to reproduce the issue:** - Create a user “U1” with the following access right: - Inventory: User - Quality: User - Connect as Admin - Create a storable product “P1” - Go to Quality > Quality…
**Steps to reproduce the issue:**
- Create a user “U1” with the following access right:
- Inventory: User
- Quality: User
- Connect as Admin
- Create a storable product “P1”
- Go to Quality > Quality Control > Control Points:
- product: P1
- control per: Operation
- Go to inventory > operation > transfer:
- Operation type: Reception
- product: P1
- Demand: 10 units
- Click on “Mark as todo”
- Connect with “U1”
- Go to the created transfer:
- Pass the quality check
- Set the qty done to 5
- Try to validate the picking and create a backorder
**Problem:**
An access error is triggered, “You are not allowed to delete 'Quality Check' (quality.check) records.”
The backorder moves are not yet in their own picking when we confirmed them:
https://github.com/odoo/odoo/blob/f6d9abbf39d63e2c43e9d9d4014a2c2e2d547d4b/addons/stock/models/stock_move.py#L1814-L1816
So, we create the quality checks with the first picking:
https://github.com/odoo/enterprise/blob/0c2ce67ac3f1ba6fbcbdab8fa2209359a3b4d0de/quality_control/models/stock_move.py#L14
So when the backorder picking is created, the quality checks must be canceled with the status none in the first picking, but as the user does not have access rights, an error is triggered
**Solution:**
A user with quality user access should be able to process a receipt and create a backorder
opw-3284644
Forward-Port-Of: odoo/enterprise#40223