Friday, June 2, 2023
2 changes
Resolved issues and error corrections
Fixes Studio approval setup so enabling approvals automatically creates the expected first rule. Approval button previews now update when rules change, with minor visual improvements for a smoother configuration experience.
Original PR description
**Retargeted https://github.com/odoo/enterprise/pull/41332** This commit corrects some behaviours or issues caused by the migration to OWL of Studio with regards to the Studio Approvals flow. - When enabling approvals, there should be a new rule added by default. - Preview icons in the button should be reactive, update when the rules are. Some styling has also been fixed and improved. Task id: 3291968
Appraisal publishing now consistently shows the required warning to every user who is allowed to toggle publication, including selected appraisal managers. The update also simplifies manager-related logic and moves shared employee autocomplete data to the employee model for cleaner maintenance.
Original PR description
Behavior before commit: A user without appraisal rights or without being the direct manager of an employee but being selected in the manager_ids of an appraisal could publish it without having the warning like everyone else. Desired Behavior: Any user capable of toggling the publish button should have a warning. Behavior after commit: Computation of is_manager significantly simplified, merged is_appraisal_manager and is_implicit_manager into one field, as there is no difference between them. Employee_autocomplete_ids moved to hr_employee because it's not affected by the appraisal. Any user capable of toggling the button receives the warning first. task 3217812