Daily updates from Odoo
Navigate
Branch
Tuesday, July 4, 2023
26 changes
Enhancements to existing features
Portal users now see a Knowledge entry on their personal homepage, including the number of articles they can access. This makes it easier for customers or external users to find and open shared Knowledge content from the portal.
Original PR description
This commit adds an entry inside the `my` homepage for portal users, this entry shows the number of articles that portal user has access to and redirects the user to Knowledge's frontend view. We are adding a new template inside the views folder that inherits from the portal template for the user's `my` page and adds the entry after the others. We are also adding a portal controller that redirects the user to their Knowledge form view using a redirect to the route `/knowledge/home` so that we use route that already exists for future portal enhancements. task-3299238
Resolved issues and error corrections
The project update view now shows the Planned stat button again in the side panel. This restores visibility of planned work information that had disappeared, helping users quickly review project forecasts as expected.
Original PR description
Before this commit since #40050, the `Planned` was no longer visible in project update because `show` property is not given in the object and so the system the button has invisible. This commit adds the property to be able to show that stat button as before in the right side panel of project update view.
Search suggestions in mail-related areas now wait briefly before requesting results, instead of sending a request for every keystroke. This reduces unnecessary network and server load while keeping channel search and mention suggestions responsive for users.
Original PR description
Before this commit, fetching suggestions (e.g. channel selector in discuss sidebar "Find or create a channel", or `@`-mentions) were performing RPCs on each user input, resulting in wasted network and server load. This commit fixes the issue by debouncing the fetching of suggestions to 0.5 sec. X-original-commit: 6770ac3 https://github.com/odoo/odoo/pull/126952
Code cleanup and technical improvements
The spreadsheet name file was reformatted to match the project's standard style. This prevents future small edits from appearing as large, noisy changes, making reviews clearer and maintenance easier.
Original PR description
This commit prettifies `spreadsheet_name.js` file. If the file is left unprettified, any change made to the file with the web tooling enabled would result in the entire file being reformatted, leading to unnecessary noise.
Miscellaneous changes
Added the central bank of brazil exchange rates service to the list of services Task-id #3270798 Forward-Port-Of: odoo/enterprise#40709
Original PR description
Added the central bank of brazil exchange rates service to the list of services Task-id #3270798 Forward-Port-Of: odoo/enterprise#40709
Before this commit, the assert done in a test could failed because the component is not yet fully mounted/re-rendered. This commit adds a next tick to be sure we wait the component be mounted and rendered before doing the asserts. Forward-Port-Of: odoo/enterprise#43537
Original PR description
Before this commit, the assert done in a test could failed because the component is not yet fully mounted/re-rendered. This commit adds a next tick to be sure we wait the component be mounted and rendered before doing the asserts. Forward-Port-Of: odoo/enterprise#43537
Description of the issue/feature this PR addresses: - clicking on the task conflict warning does not return the proper task and switching to other views gives traceback Steps: - Install the project. - Duplicate any task. - You will receive a conflict warning message on top of the task. - Click on the warning message. - The conflict task will not return, and when switching to other views, you will receive a traceback. Cause: - The root cause of this issue is related to the 'ac
Original PR description
Description of the issue/feature this PR addresses: - clicking on the task conflict warning does not return the proper task and switching to other views gives traceback Steps: - Install the project.…
Description of the issue/feature this PR addresses: - clicking on the task conflict warning does not return the proper task and switching to other views gives traceback Steps: - Install the project. - Duplicate any task. - You will receive a conflict warning message on top of the task. - Click on the warning message. - The conflict task will not return, and when switching to other views, you will receive a traceback. Cause: - The root cause of this issue is related to the 'action_fsm_view_overlapping_tasks' action. This action includes a begin date, end date, and a user's default filter in context but the search view of the planning doesn't have the begin date and end date filters so it will not apply so this action won't show that conflict task and other tasks related to its date and assignee. Fix: - To fix this issue, modify the 'action_fsm_view_overlapping_tasks' action by passing a domain that includes the user, begin date, and end date instead of using the default filter so the warning button return that task and other task related to its dates and assignee. task-3247213 Forward-Port-Of: odoo/enterprise#43374 Forward-Port-Of: odoo/enterprise#39540
- L10NPE02, L10NPE03 and L10NPE07 are not used anywhere. They have been deleted. - L10NPE08-L10NPE11 can merged, since the user doesn't need to know the details of where exactly in the HTTP connection the error occurred. - L10NPE16 and L10NPE18 can be merged, since both relate to an incorrect URL in the ir.param l10n_pe_edi.endpoint (which can be used to indicate the URL of the IAP server). Also, we harmonize the error handling: - when calling the IAP server, we check for AccessError,
Original PR description
- L10NPE02, L10NPE03 and L10NPE07 are not used anywhere. They have been deleted. - L10NPE08-L10NPE11 can merged, since the user doesn't need to know the details of where exactly in the HTTP connection the error occurred. - L10NPE16 and L10NPE18 can be merged, since both relate to an incorrect URL in the ir.param l10n_pe_edi.endpoint (which can be used to indicate the URL of the IAP server). Also, we harmonize the error handling: - when calling the IAP server, we check for AccessError, InvalidSchema and InvalidURL. - when calling SUNAT or Digiflow, we check for ConnectionError, HTTPError, TypeError and ReadTimeout. Forward-Port-Of: odoo/enterprise#42281
Steps: - Create a subscription period with duration = 0 - Create a quotation with a recurring product and the created period - Try to validate Issue: Traceback Cause: To calculate the monthly price we get all subscription lines without distinguish those with fixed temporal price. opw-3373927 Forward-Port-Of: odoo/enterprise#43345
Original PR description
Steps: - Create a subscription period with duration = 0 - Create a quotation with a recurring product and the created period - Try to validate Issue: Traceback Cause: To calculate the monthly price we get all subscription lines without distinguish those with fixed temporal price. opw-3373927 Forward-Port-Of: odoo/enterprise#43345
In 16.0, it was not possible to generate the adjustment entry anymore without manually unfolding every line of the report, which was obviously wrong. This was due to the fact the wizard used the report lines generated for model 'account.move.line' instead of 'account.account'. This error was shadowed in the tests, because the options passed to the report there forced the unfold_all key to True, causing the lines to always be present. Also, because of the same error, the revaluation entry cont
Original PR description
In 16.0, it was not possible to generate the adjustment entry anymore without manually unfolding every line of the report, which was obviously wrong. This was due to the fact the wizard used the report lines generated for model 'account.move.line' instead of 'account.account'. This error was shadowed in the tests, because the options passed to the report there forced the unfold_all key to True, causing the lines to always be present. Also, because of the same error, the revaluation entry contained way too many move lines: one per line to adjust instead of aggregating them per account. We improve the tests so that this bug can be prevented in the future. In the meantime, we stop directly putting the options as the context of the action opening the wizard to do it in a more proper (and sandboxed) way. OPW 3271293 Forward-Port-Of: odoo/enterprise#43068
* Remove close button from the edit banner when testing a survey so that users can't hide it anymore. * Reduce height of the banner to align with the website Home/Go-to-backend button. Task-3374928 Forward-Port-Of: odoo/enterprise#43541 Forward-Port-Of: odoo/enterprise#43150
Original PR description
* Remove close button from the edit banner when testing a survey so that users can't hide it anymore. * Reduce height of the banner to align with the website Home/Go-to-backend button. Task-3374928 Forward-Port-Of: odoo/enterprise#43541 Forward-Port-Of: odoo/enterprise#43150
This commit simply fixes the account tax groups tour in enterprise to cope with the changes introduced by https://github.com/odoo/odoo/pull/111103 Forward-Port-Of: odoo/enterprise#43419
Original PR description
This commit simply fixes the account tax groups tour in enterprise to cope with the changes introduced by https://github.com/odoo/odoo/pull/111103 Forward-Port-Of: odoo/enterprise#43419
## Current behaviour Auto plan plans open shifts one by one. Also the highlights is toggled on and off on each auto-plan, leading to un-highlighted shifts that were planned each second time. ## Expected behaviour All shifts in the current scale of the view should be planned and all shifts should be highlighted to show what was auto-planned. ## Steps to reproduce - Install Planning - Make sure a role has multiple resources possible. - Plan an open shift for 1 day, but is repeated each
Original PR description
## Current behaviour Auto plan plans open shifts one by one. Also the highlights is toggled on and off on each auto-plan, leading to un-highlighted shifts that were planned each second time. ##…
## Current behaviour Auto plan plans open shifts one by one. Also the highlights is toggled on and off on each auto-plan, leading to un-highlighted shifts that were planned each second time. ## Expected behaviour All shifts in the current scale of the view should be planned and all shifts should be highlighted to show what was auto-planned. ## Steps to reproduce - Install Planning - Make sure a role has multiple resources possible. - Plan an open shift for 1 day, but is repeated each day until the end of the week. - Click on autoplan, only the first shift is planned. ## Reason for the problem A little 'oopsie' in the `_read_group` when get the max end date, it was specified as `min`, when the intention (deduced from the variable name) was to get the `max`. As for the highlight, we toggle the currently highlighted shifts regardless of current highlights. ## Fix Correct the `_read_group` for the planning, and for the highlight, first toggle off the currently highlighted shifts, before re-highlighting the newly planned ones. ## Affected versions - saas-16.3 - master --- opw-3375281 Forward-Port-Of: odoo/enterprise#43175
Post-merge milk fixes community: - https://github.com/odoo/odoo/pull/123915 task-3355091 part of task-332626 Forward-Port-Of: odoo/enterprise#42028
Original PR description
Post-merge milk fixes community: - https://github.com/odoo/odoo/pull/123915 task-3355091 part of task-332626 Forward-Port-Of: odoo/enterprise#42028
- Some Ecuadorian edi certificates don't correctly sign edi documents, and the SRI API returns the next error:"39 - The signature is invalid [Invalid signature. The signing certificate is invalid.] - INVALID SIGNATURE - ERROR". - This error occurs because the information in the description of the issuer that authorizes the digital certificate is not complete in the signed edi document. - To fix this bug, change the value of the armed string for the tag "x509_issuer_description" in the signed p
Original PR description
- Some Ecuadorian edi certificates don't correctly sign edi documents, and the SRI API returns the next error:"39 - The signature is invalid [Invalid signature. The signing certificate is invalid.] - INVALID SIGNATURE - ERROR". - This error occurs because the information in the description of the issuer that authorizes the digital certificate is not complete in the signed edi document. - To fix this bug, change the value of the armed string for the tag "x509_issuer_description" in the signed parameters of the edi document, to the native method "rfc4514_string()", which gathers all informational data from the authorized company. opw-3215344 opw-3304422 opw-3370111 Forward-Port-Of: odoo/enterprise#43257
The current behavior of this PR: there wasn't space between the Worksheet template and the drop-down Field and the Kanban view of the Field Service did not have any spacing between the planned date and the timer icon. Fix: spaces are adjusted to ensure proper alignment and enhance the visual appeal of the field. task: 3229105 Forward-Port-Of: odoo/enterprise#43401 Forward-Port-Of: odoo/enterprise#39098
Original PR description
The current behavior of this PR: there wasn't space between the Worksheet template and the drop-down Field and the Kanban view of the Field Service did not have any spacing between the planned date and the timer icon. Fix: spaces are adjusted to ensure proper alignment and enhance the visual appeal of the field. task: 3229105 Forward-Port-Of: odoo/enterprise#43401 Forward-Port-Of: odoo/enterprise#39098
**Prior to this commit:** In the knowledge module, when the embedded views are added to an article, the page is scrolled up to the beginning of the article. **Post this commit:** The article stays in the same position as that of the embedded view. **Task:** 3357953 Forward-Port-Of: odoo/enterprise#43361
Original PR description
**Prior to this commit:** In the knowledge module, when the embedded views are added to an article, the page is scrolled up to the beginning of the article. **Post this commit:** The article stays in the same position as that of the embedded view. **Task:** 3357953 Forward-Port-Of: odoo/enterprise#43361
The controls of Google Slides were being clipped as a result of a negative margin. Steps to reproduce: 1. Create a BoM 2. Add an operation w/ a Google Slides document 3. Don't create steps for the operation 4. Create a new manufacturing order with this BoM 5. Confirm it and open the tablet view from the workorders This commit fixes the clipping issue, ensuring that the Google Slides controls are displayed properly. OPW-3325158 Forward-Port-Of: odoo/enterprise#41744
Original PR description
The controls of Google Slides were being clipped as a result of a negative margin. Steps to reproduce: 1. Create a BoM 2. Add an operation w/ a Google Slides document 3. Don't create steps for the operation 4. Create a new manufacturing order with this BoM 5. Confirm it and open the tablet view from the workorders This commit fixes the clipping issue, ensuring that the Google Slides controls are displayed properly. OPW-3325158 Forward-Port-Of: odoo/enterprise#41744
Even if the field tag in the view doesn't have a help tooltip defined, there might still be a help string defined on the field itself. In this case we should also use it to prefill the help property in the field properties editor. opw-3375341 Forward-Port-Of: odoo/enterprise#43054
Original PR description
Even if the field tag in the view doesn't have a help tooltip defined, there might still be a help string defined on the field itself. In this case we should also use it to prefill the help property in the field properties editor. opw-3375341 Forward-Port-Of: odoo/enterprise#43054
The `t-set` directive can be used with a body value, in which case it is supposed to be translated. This was not the case until a recent owl fix (2.1.4), but now that Owl is fixed, the translation is properly applied and the document inspector code now crashes in non-english languages, since the code is using a field name as a key in an object. Note that I just fixed quickly all obvious occurences, but in general, no technical data should be translated. Forward-Port-Of: odoo/enterprise#43522
Original PR description
The `t-set` directive can be used with a body value, in which case it is supposed to be translated. This was not the case until a recent owl fix (2.1.4), but now that Owl is fixed, the translation is properly applied and the document inspector code now crashes in non-english languages, since the code is using a field name as a key in an object. Note that I just fixed quickly all obvious occurences, but in general, no technical data should be translated. Forward-Port-Of: odoo/enterprise#43522
This PR fixes the following issue - Documents sidebar changes height when one element is hovered => https://www.awesomescreenshot.com/video/16899491?key=d6be06f1cb9b37289c04d4600aaf4bbf Before this change, the sidebar elements (tags and sub-workspaces) would increase height on hover due to the cog icon appearing. The cog had an extra vertical padding which has since been removed, fixing the issue. task-3326522 part of task-3326263 Forward-Port-Of: odoo/enterprise#41045
Original PR description
This PR fixes the following issue - Documents sidebar changes height when one element is hovered => https://www.awesomescreenshot.com/video/16899491?key=d6be06f1cb9b37289c04d4600aaf4bbf Before this change, the sidebar elements (tags and sub-workspaces) would increase height on hover due to the cog icon appearing. The cog had an extra vertical padding which has since been removed, fixing the issue. task-3326522 part of task-3326263 Forward-Port-Of: odoo/enterprise#41045
Before this commit publish & publish and send buttons are not shown in calendar view when shift is in draft state. After this commit publish & publish and send buttons are shown in calendar view. task-3217930 Forward-Port-Of: odoo/enterprise#43429 Forward-Port-Of: odoo/enterprise#38680
Original PR description
Before this commit publish & publish and send buttons are not shown in calendar view when shift is in draft state. After this commit publish & publish and send buttons are shown in calendar view. task-3217930 Forward-Port-Of: odoo/enterprise#43429 Forward-Port-Of: odoo/enterprise#38680
When we try to update a marketing automation workflow that has emails that should be sent after some actions (eg: click, reply, etc), we have to update the scheduled date but currently we are trying to set the date this way: process_dt = trace.parent_id.mailing_trace_ids.state_update But state_update is never defined in the code which caused this issue. To fix the issue the new schedule date is defined according to the correct action. How to reproduce: 1. Marketing Automation -> Create
Original PR description
When we try to update a marketing automation workflow that has emails that should be sent after some actions (eg: click, reply, etc), we have to update the scheduled date but currently we are trying to set the date this way: process_dt = trace.parent_id.mailing_trace_ids.state_update But state_update is never defined in the code which caused this issue. To fix the issue the new schedule date is defined according to the correct action. How to reproduce: 1. Marketing Automation -> Create -> Add new activity 2. Create two emails in the workflow in a such way, one email is the parent of another and the child email is triggered when the email is Opened 3. Click on Start -> Launch test -> start the test workflow 4. Edit the interval_number of the child's email OPW: 3355807 Forward-Port-Of: odoo/enterprise#42553
see community PR. opw-3372581 Forward-Port-Of: odoo/enterprise#43104 Forward-Port-Of: odoo/enterprise#43052
Original PR description
see community PR. opw-3372581 Forward-Port-Of: odoo/enterprise#43104 Forward-Port-Of: odoo/enterprise#43052
before this commit, on neutralizing the database the keypay integration credentials are kept as it is. after this commit, on neutralizing the database the integration credentials values will be reset to dummy values. Forward-Port-Of: odoo/enterprise#43256
Original PR description
before this commit, on neutralizing the database the keypay integration credentials are kept as it is. after this commit, on neutralizing the database the integration credentials values will be reset to dummy values. Forward-Port-Of: odoo/enterprise#43256
Steps ===== - Install module industry_fsm - Create a task from the kanban view - In the form view, add a title but no customer - Open the subtasks tab of the notebook - Add a subtask and add a title to it - Save the created parent task - A pop-up indicate that the customer is missing - Add a customer and save the task Issue ===== A pop-up indicate that the subtasks field is invalid and there is no way to save the current task with its subtask. Cause ===== the module industry_
Original PR description
Steps ===== - Install module industry_fsm - Create a task from the kanban view - In the form view, add a title but no customer - Open the subtasks tab of the notebook - Add a subtask and add a title…
Steps
=====
- Install module industry_fsm
- Create a task from the kanban view
- In the form view, add a title but no customer
- Open the subtasks tab of the notebook
- Add a subtask and add a title to it
- Save the created parent task
- A pop-up indicate that the customer is missing
- Add a customer and save the task
Issue
=====
A pop-up indicate that the subtasks field is invalid and there is no way
to save the current task with its subtask.
Cause
=====
the module industry_fsm introduces a required=True for the field
"partner_id" when edited from a view in the app Field Service. When a
parent task is created without a "partner_id" id set, it can not be
saved, but subtasks can still be created from it. Those child tasks
should have the "partner_id" set to the same value as the one of their
parent. As it is not set in the parent task, its value will be False for
the child task, and changing it in the parent task (by adding a
customer) will not update the child task. As this field is required when
a task is edited from the app Field Service, the task can not be saved.
Fix
===
Two changes are introduced:
- A dependency to "parent_id.partner_id" is added to the method
"_compute_partner_id" of model project.task allowing to update it if
needed when a "partner_id" is set on the parent task.
- The field "patner_id" is not required anymore in the tree view that
display the subtasks in the form view of a fsm task if the customer is
not set on the parent task. This mixed behavior allows:
- to avoid "missing field: subtasks" message when trying to save a
task with subtask but no customer set.
- to prevent user to remove customer from a subtask in field service
once it is automatically set.
task-3343423
related-122905
Forward-Port-Of: odoo/enterprise#41700