Wednesday, August 2, 2023
37 changes
Enhancements to existing features
This update keeps the Field Service inventory module aligned with a related platform change in Odoo. It is an internal compatibility improvement that helps ensure stock movements continue to work correctly after the shared function signature was updated.
Original PR description
This commit uses the the new function signature done in the community PR: odoo/odoo#116803
Resolved issues and error corrections
Sales orders created from field service tasks now show free products as having nothing to invoice. This avoids incorrectly prompting teams to invoice items with a zero sales price.
Original PR description
Description of the issue: when product of sale price zero added to SO through field service it should show invoice status 'nothing to invoice' instead of 'to invoice' Desired behavior after PR is merged: product with a sales price of zero is added to SO through a field service, the invoice status is 'nothing to invoice' IMP: override _compute_invoice_status function in fsm sale_order and add condition to check product (total_amount <=0 and have task_id) task-3266856
Code cleanup and technical improvements
This update streamlines how Odoo finds contacts, email addresses, phone numbers, and countries when sending messages, notifications, or SMS. It reduces duplicated logic across apps, making communication features easier to maintain and more consistent for users.
Miscellaneous changes
When trying to import a fec file, we're getting an error due to the 'name_nospaces' constraint. We replace spaces by underscores in the partner field and modify the test file to make tests accurate with this flow. Task links: www.odoo.com/web#id=3428627&model=project.task www.odoo.com/web#id=3376313&model=project.task opw-3428627 opw-3376313 Forward-Port-Of: odoo/enterprise#44789
Original PR description
When trying to import a fec file, we're getting an error due to the 'name_nospaces' constraint. We replace spaces by underscores in the partner field and modify the test file to make tests accurate with this flow. Task links: www.odoo.com/web#id=3428627&model=project.task www.odoo.com/web#id=3376313&model=project.task opw-3428627 opw-3376313 Forward-Port-Of: odoo/enterprise#44789
A small issue in the timesheet grid test setup was corrected so copied setup data is registered properly. This helps keep automated checks reliable and reduces the risk of regressions reaching users.
Original PR description
community: https://github.com/odoo/odoo/pull/130461
This fixes an internal automated test setup for the accounting workflow between invoicing and accounting. It helps keep quality checks reliable after a recent technical change, reducing the risk of false failures during development.
Original PR description
The import system has changed, so the override is not working. (https://github.com/odoo/enterprise/commit/5a800d5e304d02e15def04ef76911543c633af92) We still need this import, even if we're just patching the registry, if the test is deactivated. Linked to runbot error 23638
The data merge list now refreshes correctly after merge-related actions following an internal model change. This prevents outdated or incorrect values from remaining visible, helping users see accurate information without disruption.
Original PR description
Since the relational model was rewritten (PR 114024), the removeRecord and removeGroup functions no longer exist. In this case, reloading the model is sufficient to display the correct values.
Original PR description
RATIONALE Simplify field management for mail / phone / sms flows. Make it working out of the box, easier to use and tweak. SPECIFICATIONS Move some helpers used in mail, phone_validation and sms…
RATIONALE Simplify field management for mail / phone / sms flows. Make it working out of the box, easier to use and tweak. SPECIFICATIONS Move some helpers used in mail, phone_validation and sms modules directly at BaseModel level. Those are used to find emails, partners, phone numbers and countries on records when sending them emails, notifications and sms. Improve default behavior of those helpers to cover most existing use case. Remove overrides now covered by standard behavior. Simplify phone / sms methods implementation. It was a bit messy with methods of sms overriding methods from phone. All this code can be simplified now that we have several years of usage in addons to see what people did with those modules. Globally * _sms_get_partner_fields is replaced by _mail_get_partner_fields; * _sms_get_number_fields is replaced by _phone_get_number_fields; * _sms_get_default_partners is replaced by _mail_get_partners; Add a generic phone formatting tool on BaseModel allowing to simplify most calls done to the phone_validation API. Remove custom definitions on some models as it is now available directly. Task-3422449 (Mail, Phone: Move and improve field helpers) Prepares Task-36879 (Mail: Support MultiCompany Aliases)
This update adapts several Enterprise modules to a revised web framework mechanism used for extending behavior. It should not change day-to-day workflows, but it helps keep accounting, appointment, approvals, and related features compatible and maintainable.
Original PR description
This PR is the counterpart of https://github.com/odoo/odoo/pull/125716 task 3410198
This update removes old QWeb-based code from several Odoo Enterprise apps and moves affected screens and widgets toward newer frontend patterns. Users should see little to no immediate change, but the cleanup helps keep appointment booking, knowledge, helpdesk, payroll, social, VoIP, and website features easier to maintain going forward.
Put a class on the softphone header icon to allow it to be retrieved from the javascript code. Forward-Port-Of: odoo/enterprise#44962
Original PR description
Put a class on the softphone header icon to allow it to be retrieved from the javascript code. Forward-Port-Of: odoo/enterprise#44962
Issue: ====== When you download a document with a date in it's name and the date has dots (.) it will mess the with file at it expects the type of the file after the first dot. Steps to reproduce the error : ============================== 1-Install accounting 2-Install German Language 3-Go to accounting/customer/followup reports 4-Select an item and do follow up 5-Print the report. 6-You will get a report not in the pdf format. Solution: ========= I replaced the '.' with '/' in
Original PR description
Issue: ====== When you download a document with a date in it's name and the date has dots (.) it will mess the with file at it expects the type of the file after the first dot. Steps to reproduce the error : ============================== 1-Install accounting 2-Install German Language 3-Go to accounting/customer/followup reports 4-Select an item and do follow up 5-Print the report. 6-You will get a report not in the pdf format. Solution: ========= I replaced the '.' with '/' in the date formats of the name. opw-3425241 Forward-Port-Of: odoo/enterprise#44932
Currently we take the language of the user generating the payslip, instead of taking the employee's language, which might be different. task-3389231 Forward-Port-Of: odoo/enterprise#44942 Forward-Port-Of: odoo/enterprise#43272
Original PR description
Currently we take the language of the user generating the payslip, instead of taking the employee's language, which might be different. task-3389231 Forward-Port-Of: odoo/enterprise#44942 Forward-Port-Of: odoo/enterprise#43272
In the community PR, we have made several minor changes to improve the display, and this PR continues to build upon those improvements. Here's a summary of what has been done: - In the bank journal, an empty div was added by "account_online_synchronization" which caused some display issues with "qif_decimal_point" and "qif_qif_date_format." By adding the missing "attrs invisible" attribute, the display issue is now resolved. - In the settings, there was a field followed by a refresh bu
Original PR description
In the community PR, we have made several minor changes to improve the display, and this PR continues to build upon those improvements. Here's a summary of what has been done: - In the bank journal, an empty div was added by "account_online_synchronization" which caused some display issues with "qif_decimal_point" and "qif_qif_date_format." By adding the missing "attrs invisible" attribute, the display issue is now resolved. - In the settings, there was a field followed by a refresh button, but the input field was not aligned properly with the rest of the settings. - Additionally, in the settings, the button links were not consistent with the changes made in the community PR. This PR addresses that inconsistency and brings uniformity to the button links. task-id: 3342969 Forward-Port-Of: odoo/enterprise#42216
community: - https://github.com/odoo/odoo/pull/129991 task-3439555 part of task-3326263 Forward-Port-Of: odoo/enterprise#44758
Original PR description
community: - https://github.com/odoo/odoo/pull/129991 task-3439555 part of task-3326263 Forward-Port-Of: odoo/enterprise#44758
Adds Balance Sheet and Profit and Loss for Canadian localization task-3098316 Forward-Port-Of: odoo/enterprise#44479
Original PR description
Adds Balance Sheet and Profit and Loss for Canadian localization task-3098316 Forward-Port-Of: odoo/enterprise#44479
- Create Taiwan Accounting Reports task-2865568 Forward-Port-Of: odoo/enterprise#44875 Forward-Port-Of: odoo/enterprise#31818
Original PR description
- Create Taiwan Accounting Reports task-2865568 Forward-Port-Of: odoo/enterprise#44875 Forward-Port-Of: odoo/enterprise#31818
Forward-Port-Of: odoo/enterprise#44478
Original PR description
Forward-Port-Of: odoo/enterprise#44478
- In certain specific values, the calculation of the withholding taxes are affected by the rounding configuration 'round globally' creating a variation of 0.01 cents in the calculation of the field l10n_ec_withhold_tax_amount - This results in a difference between the totals for withholding tax lines and the lines in the accounting entries in the withholding - To avoid this problem, we ensure to send the 'round' variable as True by context in withholding taxes to force 'round per line' **De
Original PR description
- In certain specific values, the calculation of the withholding taxes are affected by the rounding configuration 'round globally' creating a variation of 0.01 cents in the calculation of the field…
- In certain specific values, the calculation of the withholding taxes are affected by the rounding configuration 'round globally' creating a variation of 0.01 cents in the calculation of the field l10n_ec_withhold_tax_amount - This results in a difference between the totals for withholding tax lines and the lines in the accounting entries in the withholding - To avoid this problem, we ensure to send the 'round' variable as True by context in withholding taxes to force 'round per line' **Description of the issue/feature this PR addresses:** -The 'Round globally' setting in the company produces an erroneous rounding in the amount of the withholding lines, causing a variation of one cent compared to the accounting entries **Current behavior before PR:** In some specific values, the value of the withholding amount varies with one cent to the accounting entry **Desired behavior after PR is merged:** Force 'Rounding per line' to ensure the correct calculation in withholdings Forward-Port-Of: odoo/enterprise#43843 Forward-Port-Of: odoo/enterprise#43404
momentToLuxon was removed in community, and is replaced by a util function in website_sale_renting for the datetimepicker. This commit fixes the import from the right file. Forward-Port-Of: odoo/enterprise#44980
Original PR description
momentToLuxon was removed in community, and is replaced by a util function in website_sale_renting for the datetimepicker. This commit fixes the import from the right file. Forward-Port-Of: odoo/enterprise#44980
Before, the only ordering that was made there put the reports without a country after the ones who had one. This was not consistent with the new sequence field introduced on account.report in saas-16.4. We fix that in order to make use of it. Forward-Port-Of: odoo/enterprise#44956
Original PR description
Before, the only ordering that was made there put the reports without a country after the ones who had one. This was not consistent with the new sequence field introduced on account.report in saas-16.4. We fix that in order to make use of it. Forward-Port-Of: odoo/enterprise#44956
When search mps by bom, currently we always use "ilike" as operator to search by name. This leads to wrong result when we search by id, bom with the "id" in its name will also be shown. To fix, we don't force to use "ilike". Allow it to change by different cases. Task-3337966 Forward-Port-Of: odoo/enterprise#42547
Original PR description
When search mps by bom, currently we always use "ilike" as operator to search by name. This leads to wrong result when we search by id, bom with the "id" in its name will also be shown. To fix, we don't force to use "ilike". Allow it to change by different cases. Task-3337966 Forward-Port-Of: odoo/enterprise#42547
This PR makes the bus service start lazily. Since the bus service start method is no longer async some tests need to adapt the order in which the routes are asserted during tests. community: https://github.com/odoo/odoo/pull/129312 Forward-Port-Of: odoo/enterprise#44730
Original PR description
This PR makes the bus service start lazily. Since the bus service start method is no longer async some tests need to adapt the order in which the routes are asserted during tests. community: https://github.com/odoo/odoo/pull/129312 Forward-Port-Of: odoo/enterprise#44730
Currently, the "Add a note" span is hidden from HTML view with a t-att-style. Receivers of the follow up report who view their emails in plain text will still see the "Add a note" line. The new change using t-if will properly hide the span for users that view the email in plain text. opw-3413962 Forward-Port-Of: odoo/enterprise#44994 Forward-Port-Of: odoo/enterprise#44657
Original PR description
Currently, the "Add a note" span is hidden from HTML view with a t-att-style. Receivers of the follow up report who view their emails in plain text will still see the "Add a note" line. The new change using t-if will properly hide the span for users that view the email in plain text. opw-3413962 Forward-Port-Of: odoo/enterprise#44994 Forward-Port-Of: odoo/enterprise#44657
Currently the default deferral amount computation is set to be based on days. Because mostly people want to calculate equal amounts per month, we change the default calculation to that. [task-3441004](https://www.odoo.com/web#id=3441004&menu_id=4720&cids=1&action=333&active_id=967&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#44913
Original PR description
Currently the default deferral amount computation is set to be based on days. Because mostly people want to calculate equal amounts per month, we change the default calculation to that. [task-3441004](https://www.odoo.com/web#id=3441004&menu_id=4720&cids=1&action=333&active_id=967&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#44913
The styling of the ellipsis clone button was not applied correctly. On clicking on the clone button, there is now a notification telling the user that the text was copied and it closes the popover. Forward-Port-Of: odoo/enterprise#44845
Original PR description
The styling of the ellipsis clone button was not applied correctly. On clicking on the clone button, there is now a notification telling the user that the text was copied and it closes the popover. Forward-Port-Of: odoo/enterprise#44845