Wednesday, August 2, 2023
37 changes
Miscellaneous changes
7cd0563b762569484da1bef7af4ca84e189feca5: There were still old, hardcoded, colors being used in the sign module's PDF viewer. These have been replaced with the new ones, but Sign uses an iframe to render the PDF viewer and the variables weren't being applied. Some of the bootstrap classes, such as `.btn-primary` (changed to `.btn-secondary`), were already on some elements but were also not being applied. A copy of the current CSS variables was needed in the `iframe.scss` file in order t
Original PR description
7cd0563b762569484da1bef7af4ca84e189feca5: There were still old, hardcoded, colors being used in the sign module's PDF viewer. These have been replaced with the new ones, but Sign uses an iframe to…
7cd0563b762569484da1bef7af4ca84e189feca5: There were still old, hardcoded, colors being used in the sign module's PDF viewer. These have been replaced with the new ones, but Sign uses an iframe to render the PDF viewer and the variables weren't being applied. Some of the bootstrap classes, such as `.btn-primary` (changed to `.btn-secondary`), were already on some elements but were also not being applied. A copy of the current CSS variables was needed in the `iframe.scss` file in order to fix these issues. This also allows us to correct some of the viewer's color issues, which we override in this same file. Inputs with the class `o_input` just above the iframe weren't rendering well as they were white instead of being the same as the parent's background color. To solve this issue we override the value of the CSS variable being used by `.o_input`. fd29f9e8c9b9e225ec0955a54047bff86a5351c5: The PDF viewer used to be black. As it is now white, and the custom rotateCw arrow that is injected is a white `.png` image, it is no longer visible on the white background. There is also a sizing issue. The fix was to revert to the original rotateCw icon located in the PDF viewer and use the same way of working as for the other buttons. To do this a simple ID was needed on the element. task-3326565 part of task-3326263 Forward-Port-Of: odoo/enterprise#44577 Forward-Port-Of: odoo/enterprise#41035
When having a cash rounding line on an invoice, base amount is taken twice into account in the tax report when grouping by account > tax or tax > account. Steps: - Activate cash rounding, and create one with 0.05 rounding, method 'HALF_UP' and 'biggest_tax' strategy - Create an invoice with a product line with unit price 1.24$, tax 15% (included in price) - Select the rounding method created above. - A rounding line for tax 15.0% and 0.02$ should have been created - Go to tax report an
Original PR description
When having a cash rounding line on an invoice, base amount is taken twice into account in the tax report when grouping by account > tax or tax > account. Steps: - Activate cash rounding, and create one with 0.05 rounding, method 'HALF_UP' and 'biggest_tax' strategy - Create an invoice with a product line with unit price 1.24$, tax 15% (included in price) - Select the rounding method created above. - A rounding line for tax 15.0% and 0.02$ should have been created - Go to tax report and group by Account->Tax or Tax->Account -> Base amount is 2.48 instead of 1.24 opw-3336398 Forward-Port-Of: odoo/enterprise#44747 Forward-Port-Of: odoo/enterprise#44324
When the user will add the property, the property field values and Add a Property button are not well aligned with the property labels. Because in this commit https://github.com/odoo/enterprise/commit/22ce8a389ac0a1e03b32077a20caff88fb1ebe39, padding was applied only in property labels. Technical: Adding margin to the labels and padding to the values and Add a Property button. Now labels, values and Add a property button all are well aligned. **Task**-3381693 Forward-Port-Of: odoo/ent
Original PR description
When the user will add the property, the property field values and Add a Property button are not well aligned with the property labels. Because in this commit https://github.com/odoo/enterprise/commit/22ce8a389ac0a1e03b32077a20caff88fb1ebe39, padding was applied only in property labels. Technical: Adding margin to the labels and padding to the values and Add a Property button. Now labels, values and Add a property button all are well aligned. **Task**-3381693 Forward-Port-Of: odoo/enterprise#43227
This commit brings back the style of icons related to the fields available in the sidebar. During the refactor of the report editor, a lot of files present in the legacy folder were removed, and this scss was not yet ported to current stylesheets. With this fix, the mixin has been renamed to match the naming of the other ones, and the style related to the icons has been preserved to the studio_sidebar.scss file. task-3444791 Forward-Port-Of: odoo/enterprise#44837
Original PR description
This commit brings back the style of icons related to the fields available in the sidebar. During the refactor of the report editor, a lot of files present in the legacy folder were removed, and this scss was not yet ported to current stylesheets. With this fix, the mixin has been renamed to match the naming of the other ones, and the style related to the icons has been preserved to the studio_sidebar.scss file. task-3444791 Forward-Port-Of: odoo/enterprise#44837
Steps: - Install planning app without demo data. - Try to split shift of sample data. Cause: - The split shift feature was attempting to split shifts of sample data. Fix: - Modified the visibility of the scissor icon so that it only appears when there are actual shifts to split. Forward-Port-Of: odoo/enterprise#44844
Original PR description
Steps: - Install planning app without demo data. - Try to split shift of sample data. Cause: - The split shift feature was attempting to split shifts of sample data. Fix: - Modified the visibility of the scissor icon so that it only appears when there are actual shifts to split. Forward-Port-Of: odoo/enterprise#44844
Issue: ------ In the report of payroll application (pivot view), payslips (via its payslip lines) which contain no worked day won't be taken into account for the amounts displayed. It is therefore not possible to analyze them. A concrete example are the payslips of the 13th month in the Belgian localization. Cause: ------ To display these amounts, this SQL condition must be met: ```sql SELECT ... CASE WHEN wd.id = min_id.min_line THEN ...(display amount)... ELSE ... END ... FR
Original PR description
Issue: ------ In the report of payroll application (pivot view), payslips (via its payslip lines) which contain no worked day won't be taken into account for the amounts displayed. It is therefore…
Issue: ------ In the report of payroll application (pivot view), payslips (via its payslip lines) which contain no worked day won't be taken into account for the amounts displayed. It is therefore not possible to analyze them. A concrete example are the payslips of the 13th month in the Belgian localization. Cause: ------ To display these amounts, this SQL condition must be met: ```sql SELECT ... CASE WHEN wd.id = min_id.min_line THEN ...(display amount)... ELSE ... END ... FROM ... left join hr_payslip_worked_days wd on (wd.payslip_id = p.id) ... left join (select payslip_id, min(id) as min_line from hr_payslip_worked_days group by payslip_id) min_id on (min_id.payslip_id = p.id) ... ``` Payslips that do not have a working day won't be listed in the `hr_payslip_worked_days` table, so for these payslips we have: `wd.id = NULL` and `min_id.min_line = NULL`. In postgresql, the condition `NULL = NULL` is not true but unknown. Solution: --------- Modify the condition to handle the `NULL` value comparison like this: `wd.id = min_id.min_line OR (wd.id IS NULL AND min_id.min_line IS NULL)` This condition can be simplified as PostgreSQL supports `is not distinct from` operator: `wd.id IS NOT DISTINCT FROM min_id.min_line` opw-3429153 Forward-Port-Of: odoo/enterprise#44731
Forward-Port-Of: odoo/enterprise#44819 Forward-Port-Of: odoo/enterprise#44766
Original PR description
Forward-Port-Of: odoo/enterprise#44819 Forward-Port-Of: odoo/enterprise#44766
Bugfix. When sending an invoice to SUNAT, if the CDR is already registered on the server, SUNAT will respond with a 500 Server Error. The response content indicates that the invoice was already registered with other data. At the moment, we bail out as soon as we see the 500 Server Error, meaning that we don't check the response content and don't try to retrieve the CDR from the server even though that would be appropriate. With this commit, if we get a 500 Server Error, we still try to dec
Original PR description
Bugfix. When sending an invoice to SUNAT, if the CDR is already registered on the server, SUNAT will respond with a 500 Server Error. The response content indicates that the invoice was already registered with other data. At the moment, we bail out as soon as we see the 500 Server Error, meaning that we don't check the response content and don't try to retrieve the CDR from the server even though that would be appropriate. With this commit, if we get a 500 Server Error, we still try to decode the response content. Forward-Port-Of: odoo/enterprise#44489
In salary configurator some advantages may have requested documents. When the advantage is selected, the requested documents are shown and required, while when the advantage is not selected, the requested documents are hidden. Problem: On start, the requested documents of non-selected advantages are still showing. After this commit they will be hidden. task-3444804 Forward-Port-Of: odoo/enterprise#44849
Original PR description
In salary configurator some advantages may have requested documents. When the advantage is selected, the requested documents are shown and required, while when the advantage is not selected, the requested documents are hidden. Problem: On start, the requested documents of non-selected advantages are still showing. After this commit they will be hidden. task-3444804 Forward-Port-Of: odoo/enterprise#44849
Steps to reproduce: - Install CRM, Helpdesk. - Go to Settings > Discuss > Check `Custom Email Servers`, Alias Domain = `@example.com`. - CRM > Config > Sales teams > New > Enter Name = Team1 > Save. - Helpdesk > Create a new customer and record some tickets for them, or use an existing customer (e.g., Azure Interior). - CRM > Pipeline > New > Enter Contact = Azure Interior > Edit. - In the Extra Information tab, set Sales Team = Team1 > Save. - From the opportunity view, open the Azur
Original PR description
Steps to reproduce: - Install CRM, Helpdesk. - Go to Settings > Discuss > Check `Custom Email Servers`, Alias Domain = `@example.com`. - CRM > Config > Sales teams > New > Enter Name = Team1 > Save.…
Steps to reproduce: - Install CRM, Helpdesk. - Go to Settings > Discuss > Check `Custom Email Servers`, Alias Domain = `@example.com`. - CRM > Config > Sales teams > New > Enter Name = Team1 > Save. - Helpdesk > Create a new customer and record some tickets for them, or use an existing customer (e.g., Azure Interior). - CRM > Pipeline > New > Enter Contact = Azure Interior > Edit. - In the Extra Information tab, set Sales Team = Team1 > Save. - From the opportunity view, open the Azure Interior record through the internal link. - From the customer's profile, click on the Tickets stat button. Issue: Traceback: `Record does not exist or has been deleted.` This error occurs because the sales team of the opportunity is passed in the context as `default_team_id`. When clicking the stat button, we search for a helpdesk team using the same context variable, `default_team_id`. Since there is no helpdesk team with that id, the traceback appears. Solution: When clicking on the tickets stat button, our aim is to display all helpdesk tickets related to that customer, and the helpdesk team is not relevant in this context. Therefore, we can set `default_team_id` to False before displaying the tickets, and this change will not affect the results. opw-3371767 Forward-Port-Of: odoo/enterprise#44208
We added the feature to send the Tax Report to the Dutch government for our Dutch clients. This new module (which will be merged into l10n_nl_intrastat in master in a new task) will allow to send the Intra-Communautaire prestaties report (EC Sales List) the same way. Task : 3187020 Forward-Port-Of: odoo/enterprise#44709 Forward-Port-Of: odoo/enterprise#42849
Original PR description
We added the feature to send the Tax Report to the Dutch government for our Dutch clients. This new module (which will be merged into l10n_nl_intrastat in master in a new task) will allow to send the Intra-Communautaire prestaties report (EC Sales List) the same way. Task : 3187020 Forward-Port-Of: odoo/enterprise#44709 Forward-Port-Of: odoo/enterprise#42849
There was a traceback when right clicking on a spreaded cell beacause of the list "see record" context menu item. Fixed it. Task: [3425493](https://www.odoo.com/web#id=3425493&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#44141
Original PR description
There was a traceback when right clicking on a spreaded cell beacause of the list "see record" context menu item. Fixed it. Task: [3425493](https://www.odoo.com/web#id=3425493&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#44141