Daily updates from Odoo
Tuesday, September 19, 2023
6 changes
Resolved issues and error corrections
This update adjusts internal performance test expectations across several Odoo apps so they match the current automated runbot results. It helps keep the test suite reliable while preparing related work for multi-company mail aliases, with no direct change for end users.
Original PR description
Update (some) query counters according to runbot state. Prepares Task-36879 (Mail: Support MultiCompany Aliases)
This fix separates internal calculations that were mixing saved and on-the-fly values across several business apps. It helps prevent inconsistent results or unexpected behavior in areas such as assets, payroll, manufacturing, timesheets, and data cleaning.
Original PR description
Companion of https://github.com/odoo/odoo/pull/98565.
Odoo Studio now loads values for fields that are hidden in form, list, and kanban views when users choose to show invisible fields. This prevents crashes in form editing and avoids incorrect data being shown in list and kanban editors.
The generate offer wizard now displays explanatory text with proper alignment when no template is selected. This removes a visual glitch that could make the form look inconsistent or harder to read.
Original PR description
**Prior to this commit:** While generating offer, when the template is not selected, the text is weirdly aligned. This is because it is getting improper colspan due to the removal of the label. **Post this commit:** By giving the appropriate colspan, the text appears correctly. **Task:** 3430509
A Web Studio issue was corrected where the system made an incorrect assumption about how an internal request handler should behave. This helps prevent errors in Studio-related actions and improves reliability for users customizing Odoo.
Original PR description
model != controller
Basic employees could hit an error when opening the new appraisal form without HR or appraisal permissions. The change hides the appraisal shortcut that caused the problem for users who should not access it, allowing them to continue without a traceback.
Original PR description
Steps to reproduce: - Have a simple user with no hr and appraisal rights - Go to the appraisal and click on the new button We get a traceback saying: EvalError: Can not evaluate python expression: (bool(employee_appraisal_count < 2 or not employee_id)) Error: Name 'employee_appraisal_count' is not defined Explanation: The issue is coming from having 'employee_appraisal_count' on the domain of the smartbutton in the view. If we were to just put 'employee_appraisal_count' on the view, we don't have the issue and we read it properly. Which, probably means that fields (related field in this case) are not read properly for the domain. For a timely fix, we put the groups on the smartbutton. Should be removed once the issue is fixed. task- 3497285