Friday, November 17, 2023
36 changes · master
Enhancements to existing features
This update improves how returned serial numbers are counted in inventory, manufacturing, and repair workflows. By reducing the number of database lookups needed, it can make related product information load more efficiently without changing user-facing behavior.
Original PR description
To minimize query count to the database, rather than summing the result of multiple search_count, we "sum" the search domains into a single query. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update brings the spreadsheet engine up to a newer version with fixes for filters, charts, menus, and find-and-replace behavior. Users should see more reliable spreadsheet editing and faster handling of some formula-related operations, especially in sheets using lists or pivot data.
Original PR description
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/2ef5b1a6f [REL] 17.1.0-alpha.3 https://github.com/odoo/o-spreadsheet/commit/fc912f68a [IMP] demo: add demo data for…
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/2ef5b1a6f [REL] 17.1.0-alpha.3 https://github.com/odoo/o-spreadsheet/commit/fc912f68a [IMP] demo: add demo data for data validation https://github.com/odoo/o-spreadsheet/commit/86c44d531 [FIX] FiltersPlugin: removing row with data filter header Task: 3546012 https://github.com/odoo/o-spreadsheet/commit/448cf6e8c [FIX] FilterEvaluationPlugin: insert/remove rows on data filter header Task: 3546012 https://github.com/odoo/o-spreadsheet/commit/cfdf65f8a [MOV] tests: fix typo in test file name of context menu https://github.com/odoo/o-spreadsheet/commit/8dbab4a09 [FIX] F&R: Fix css rule https://github.com/odoo/o-spreadsheet/commit/5bd9054c1 [REV] Charts: Do not rely on history for the chartRuntimes Task: 3578417 https://github.com/odoo/o-spreadsheet/commit/a372a4b73 [FIX] Menus: Show Insert col/row menu when full sheet selected Task: 3450188 https://github.com/odoo/o-spreadsheet/commit/d7b4936dd [IMP] evaluation: improve perfs of `getCorrespondingFormulaCell` Task: 3584306 https://github.com/odoo/o-spreadsheet/commit/8f23f7b45 [FIX] cell: update cell tokens and dependencies Task: 3584306 https://github.com/odoo/o-spreadsheet/commit/fccf1fa08 [FIX] find_and_replace: take array formula result into account Task: 3413999 https://github.com/odoo/o-spreadsheet/commit/d3ca1aa2c [REM] sort,selection: remove duplicated code
Forum permission labels were updated to better describe what users can do with comments. This makes karma-based rights easier for administrators to understand and configure correctly.
Original PR description
Improve the following forum_forum model fields descriptions to best match their purpose: - the "karma_comment_convert_own" field: from 'Convert own answers to comments and vice versa' to 'Convert own comments to answers' - the "karma_comment_convert_all" field: from 'Convert all answers to comments and vice versa' to 'Convert all comments to answers' - the "karma_comment_unlink_own" field: from 'Unlink own comments' to 'Delete own comments' - the "karma_comment_convert_own" field: from 'Unlink all comments' to 'Delete all comments' **Task**-3476226
Spreadsheet list and pivot features now reuse formula information that was already prepared instead of recalculating it. This should slightly improve performance and responsiveness when working with spreadsheet data, with no expected change in user workflows.
Original PR description
Update o_spreadsheet library to version 17.1.0-alpha.3 The pivot/list helpers were tokenizing the cell's content when trying to find list/pivot formulas. But we can skip the tokenize call as we already have the tokens in the cell's compiledFormula. Task: 3584306
Code cleanup and technical improvements
Field components now automatically use the filter rules already defined in the underlying business model when no separate filter is provided. This reduces duplicate configuration and makes field behavior more consistent when reused outside standard views.
Original PR description
The goal of this commit is to simplify the use of fields components with a props domain (for example, x2ManyField, StatusBarField, ...) outside a view and therefore outside the Field component. To do this, we'll use the domain defined on the field (in python) if we don't pass domain props. Before this commit, fields components with a domain props (x2ManyField, StatusBarField, ...) used "[]" as the default value for the domain if we don't pass a domain props. After this commit, if no props domain is passed or if the props domain is a function returning no value, the default value will be the evaluated domain defined for the field in python (record.fields[fieldName].domain). If it doesn't have one, like before we will use "[]".
Miscellaneous changes
Fixes same issue as odoo/odoo#141210 except for the MO flow in barcode. ENT PR: odoo/enterprise#50526 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141797
Original PR description
Fixes same issue as odoo/odoo#141210 except for the MO flow in barcode. ENT PR: odoo/enterprise#50526 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141797
An unused internal field related to manufacturing stock movements has been removed. This simplifies the manufacturing codebase and related views without expected changes to day-to-day user workflows.
Original PR description
There's no real use to the `is_done` field on `stock.move` so we're removing it task 2648449 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change reduces unnecessary error handling during web context evaluation, such as when opening forms. It mainly improves developer troubleshooting by preventing avoidable caught errors without changing business workflows.
Original PR description
Before this commit, whenever we evaluate a partial context (for example, when opening a form view), we would do a large number of try/catch, with many of them resulting in an error. This is because the context string represents an object with many field values, which are not in the evaluation context. The purpose of the evalPartialContext is to get the static values from the context. But these errors are annoying if we are debugging and have a break on caught exception setting on, which is usually what i do. So, this commit improves the situation by avoiding the try/catch in some cases where we know that the operation will fail anyway. This is a heuristics, but it basically completely solves the issue in most cases. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Was already signed in pallavisrivastavaa.md Forward-Port-Of: odoo/odoo#142343
Original PR description
Was already signed in pallavisrivastavaa.md Forward-Port-Of: odoo/odoo#142343
Steps to reproduce: - Enable show detailed operation in delivery setting on Invetory overview - Create an SO and validate the delivery order - Create a return -> Click on the smart button on the SO for transfers - Click "New" from the list to create a new delivery order - Add a product on the detailed operation and return to the SO - The new picking isn't linked to the SO Bug: when adding a Product on the operation tab the move is created first with the correct procurement group and th
Original PR description
Steps to reproduce: - Enable show detailed operation in delivery setting on Invetory overview - Create an SO and validate the delivery order - Create a return -> Click on the smart button on the SO for transfers - Click "New" from the list to create a new delivery order - Add a product on the detailed operation and return to the SO - The new picking isn't linked to the SO Bug: when adding a Product on the operation tab the move is created first with the correct procurement group and then sets the correct group on the picking however when adding to the detailed operation (SML) the picking is created first (no group_id) and sets its group_id(False) the move Fix: apply the default group_id to the picking in both cases opw-3470090 Forward-Port-Of: odoo/odoo#138623
In commit [1], the media dialog has been improved in order to have a better UX when using it. However, its code is quite complex and could be simplified. This commit modifies again the UX of the media dialog to only consider the addition of the "scroll button" and leaves the "Load more" button after the attachments without making it fixed. The scroll button still disappears once the load more button appears in the modal. This commit also addresses the remaining review comments that were no
Original PR description
In commit [1], the media dialog has been improved in order to have a better UX when using it. However, its code is quite complex and could be simplified. This commit modifies again the UX of the media dialog to only consider the addition of the "scroll button" and leaves the "Load more" button after the attachments without making it fixed. The scroll button still disappears once the load more button appears in the modal. This commit also addresses the remaining review comments that were not resolved, as it was merged in a rush. [1]: https://github.com/odoo/odoo/commit/d1c7e371491b06176c2f5a432dccdc87b7002296 task-3580707 Forward-Port-Of: odoo/odoo#141356
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141741
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141741
The "reset password" feature does not take into account multi-website. steps to reproduce: - create a website A - uncheck 'Shared Customer Accounts' on website A - create a portal user user@example.com on website A - create a website B - uncheck 'Shared Customer Accounts' on website B - create a portal user user@example.com on website B - reset password for user@example.com on any website before this commit: An error is raised "No account found for this login" (which is false, actu
Original PR description
The "reset password" feature does not take into account multi-website. steps to reproduce: - create a website A - uncheck 'Shared Customer Accounts' on website A - create a portal user user@example.com on website A - create a website B - uncheck 'Shared Customer Accounts' on website B - create a portal user user@example.com on website B - reset password for user@example.com on any website before this commit: An error is raised "No account found for this login" (which is false, actually 2 accounts are found) after this commit: Only the user linked to the current website is properly selected opw-3551540 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#142110 Forward-Port-Of: odoo/odoo#140536
`os.path.join(..., <absolute>)` returns `<absolute>` path Forward-Port-Of: odoo/odoo#142307
Original PR description
`os.path.join(..., <absolute>)` returns `<absolute>` path Forward-Port-Of: odoo/odoo#142307
When using a 'Group by' on the Accounting Dashboard, the Kanban cards representing the Journals are placed in columns. However, the columns were too narrow, causing text overflow. task-3530756 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#142221 Forward-Port-Of: odoo/odoo#138496
Original PR description
When using a 'Group by' on the Accounting Dashboard, the Kanban cards representing the Journals are placed in columns. However, the columns were too narrow, causing text overflow. task-3530756 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#142221 Forward-Port-Of: odoo/odoo#138496
Just like for `assertQueryCount`, we should not take into account queries that are not run after a warmup, for consistency. This allows to easily interchange both context managers for debugging purpose for instance. Forward-Port-Of: odoo/odoo#142255
Original PR description
Just like for `assertQueryCount`, we should not take into account queries that are not run after a warmup, for consistency. This allows to easily interchange both context managers for debugging purpose for instance. Forward-Port-Of: odoo/odoo#142255
Since commit 550595d, it's no longer necessary to change the endpoint to the IAP services test server. Forward-Port-Of: odoo/odoo#141504
Original PR description
Since commit 550595d, it's no longer necessary to change the endpoint to the IAP services test server. Forward-Port-Of: odoo/odoo#141504
Since [1] when device visibility became a visibility option, when dropping a snippet that contains device-invisible blocks, all those blocks were made visible. This commit makes that behavior limited to blocks that are not device-invisible. (E.g. when dropping a popup) Steps to reproduce: - drop a Columns snippet - hide a column on mobile - hide a column on desktop - save snippet - drop saved snippet in either desktop or mobile preview => All columns were shown with the `o_snippet_
Original PR description
Since [1] when device visibility became a visibility option, when dropping a snippet that contains device-invisible blocks, all those blocks were made visible. This commit makes that behavior limited to blocks that are not device-invisible. (E.g. when dropping a popup) Steps to reproduce: - drop a Columns snippet - hide a column on mobile - hide a column on desktop - save snippet - drop saved snippet in either desktop or mobile preview => All columns were shown with the `o_snippet_override_invisible` effect on the conditional ones. [1]: https://github.com/odoo/odoo/commit/3103e0553011b5c1f4078972d7a88fa3fd4068b2 task-3538535 Forward-Port-Of: odoo/odoo#140505
Complement of the previous complement e2752a04ff (#137099) Those opcodes were added in Python 3.11 and we missed them. Fixes #140588 Forward-Port-Of: odoo/odoo#141015
Original PR description
Complement of the previous complement e2752a04ff (#137099) Those opcodes were added in Python 3.11 and we missed them. Fixes #140588 Forward-Port-Of: odoo/odoo#141015
Steps to reproduce: - Add a date field in a model with `tracking=True` - Log with a user with timezone set to UTC+2 - Create a record and set the date field to any date. - Update the date value to another date (Should have logged a message in the chatter with changes) - Log with a user with timezone set to `America/Los Angeles` - Check the chatter of the record created above Issue: New date value displayed in the chatter is wrong (set to one day before). Cause:
Original PR description
Steps to reproduce: - Add a date field in a model with `tracking=True` - Log with a user with timezone set to UTC+2 - Create a record and set the date field to any date. - Update the date value to another date (Should have logged a message in the chatter with changes) - Log with a user with timezone set to `America/Los Angeles` - Check the chatter of the record created above Issue: New date value displayed in the chatter is wrong (set to one day before). Cause: The value displayed in the chatter is the date value converted first as datetime (with Luxon library), then the system timezone is set on it and therefore might change the day. opw-3427502 Forward-Port-Of: odoo/odoo#142034 Forward-Port-Of: odoo/odoo#141227
Description of the issue/feature this PR addresses: The purpose of this change is to be able to get the price of the products from external APIs. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#142293
Original PR description
Description of the issue/feature this PR addresses: The purpose of this change is to be able to get the price of the products from external APIs. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#142293
Steps to reproduce: - In edit mode, drop the "Masonry" snippet. => There are spaces on the left and the right of the snippet. It should not be the case as it is supposed to take the whole space, since its container width is full (`container-fluid` class). This happens because since commit [1], the rule setting the `--gutter-x` CSS variable (which manages the row margins) to 30px when the container is full width is now overridden by the general `.o_grid_mode` rule that sets it to 0px, m
Original PR description
Steps to reproduce: - In edit mode, drop the "Masonry" snippet. => There are spaces on the left and the right of the snippet. It should not be the case as it is supposed to take the whole space,…
Steps to reproduce: - In edit mode, drop the "Masonry" snippet. => There are spaces on the left and the right of the snippet. It should not be the case as it is supposed to take the whole space, since its container width is full (`container-fluid` class). This happens because since commit [1], the rule setting the `--gutter-x` CSS variable (which manages the row margins) to 30px when the container is full width is now overridden by the general `.o_grid_mode` rule that sets it to 0px, making the negative margins disappear. Indeed, in commit [1], in order to disable the grid mode when used in a mega menu that is in an extra menu (because the layout was broken), the CSS selector managing the `.o_grid_mode` class has been modified. This change caused the specificity of the rule to increase (x3), which made it override the container rule. This commit reverts this change and disables the grid mode in the extra menu in a better way, by adding a proper rule for this specific case. [1]: https://github.com/odoo/odoo/commit/709bffcb6de8883b679c0fc942f45cb293621c30 task-3593697 Forward-Port-Of: odoo/odoo#142189 Forward-Port-Of: odoo/odoo#141956
This commit contains a few small improvements to Expense app. - Primary button moved to the left. - Reports are auto saved when created from an expense. - "Attach Receipt" button now sets the uploaded attachment as the main attachment. - Expense lines in a report are no longer editable. When a line is clicked, the main attachment for that expense (if any) is shown in the attachment previewer. task-3539382 Enterprise PR: odoo/enterprise/pull/50136 Forward-Port-Of: odoo/odoo#138387
Original PR description
This commit contains a few small improvements to Expense app. - Primary button moved to the left. - Reports are auto saved when created from an expense. - "Attach Receipt" button now sets the uploaded attachment as the main attachment. - Expense lines in a report are no longer editable. When a line is clicked, the main attachment for that expense (if any) is shown in the attachment previewer. task-3539382 Enterprise PR: odoo/enterprise/pull/50136 Forward-Port-Of: odoo/odoo#138387
Since [this commit], the color of the links in the backend is set to the value of the variable `o-cc3-link`. This causes problems... Firstly, this variable is defined in the website module, but it is used in the web_editor module, which does not depend of website. Secondly, this variable declared in website is made to be modified by the website administrator via the edit panel (the theme tab). This commit corrects this by replacing the use of this variable with a hardcoded color. Steps to rep
Original PR description
Since [this commit], the color of the links in the backend is set to the value of the variable `o-cc3-link`. This causes problems... Firstly, this variable is defined in the website module, but it is…
Since [this commit], the color of the links in the backend is set to the value of the variable `o-cc3-link`. This causes problems... Firstly, this variable is defined in the website module, but it is used in the web_editor module, which does not depend of website. Secondly, this variable declared in website is made to be modified by the website administrator via the edit panel (the theme tab). This commit corrects this by replacing the use of this variable with a hardcoded color. Steps to reproduce the bug fixed by this commit: - Have website and project installed - In the description of a project task, create a link - Edit a website page - Go to the theme tab - Click on Colors Preset - Open the 3rd preset - Change the color for "Links" (to red for example) => Go back to the project task where you put a link. The link is now red (this may require a page refresh). But the website option should not change the links in the backend. [this commit]: https://github.com/odoo/odoo/commit/5d598e4269431222ae28ac2196ff6f1f45466734 Enterprise PR: https://github.com/odoo/enterprise/pull/42455 task-3275134 Forward-Port-Of: odoo/odoo#142478 Forward-Port-Of: odoo/odoo#122097
Suppose a price_unit of 90.0034 and a fiscal position mapping a 10% price included tax to a 15% tax. Since the taxes computation was making a rounding, the computed price_unit was round(90.0034 / 1.10). This commit aims to remove such rounding for the price_unit computation in case of fiscal position. ticket: 3589921 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141688
Original PR description
Suppose a price_unit of 90.0034 and a fiscal position mapping a 10% price included tax to a 15% tax. Since the taxes computation was making a rounding, the computed price_unit was round(90.0034 / 1.10). This commit aims to remove such rounding for the price_unit computation in case of fiscal position. ticket: 3589921 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#141688
Some Odoo employees reported a traceback that appeared when saving a task in the Project app. It turned out that this was caused by an image having the class 'o_b64_image_to_save' even though the image was not in Base64 format. Although we couldn't reproduce the bug, we are addressing the result (the traceback) by preventing the saving of an image having the 'o_b64_image_to_save' class if the image is not in Base64. task-3576889 Forward-Port-Of: odoo/odoo#142432 Forward-Port-Of: odoo/odoo#14
Original PR description
Some Odoo employees reported a traceback that appeared when saving a task in the Project app. It turned out that this was caused by an image having the class 'o_b64_image_to_save' even though the image was not in Base64 format. Although we couldn't reproduce the bug, we are addressing the result (the traceback) by preventing the saving of an image having the 'o_b64_image_to_save' class if the image is not in Base64. task-3576889 Forward-Port-Of: odoo/odoo#142432 Forward-Port-Of: odoo/odoo#140449
Similar issue have been fixed for the create in 28a9e90 . This commits fixes the same issue for the write. _steps to reproduce:_ - create a fleet.vehicule with a res.users as driver_id - change value of plan_to_change_car _before this commit:_ access error on res.users _after this commit:_ field value is changed opw-3576960 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#142376 Forward-Port-Of: odoo/odoo#140
Original PR description
Similar issue have been fixed for the create in 28a9e90 . This commits fixes the same issue for the write. _steps to reproduce:_ - create a fleet.vehicule with a res.users as driver_id - change value of plan_to_change_car _before this commit:_ access error on res.users _after this commit:_ field value is changed opw-3576960 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#142376 Forward-Port-Of: odoo/odoo#140956
This commit adds a missing part of the neutralisation of the account_avatax app. This brings it back in line with the complete neutralisation script that is used on the PaaS and SaaS in versions < 16.0 Forward-Port-Of: odoo/enterprise#50889
Original PR description
This commit adds a missing part of the neutralisation of the account_avatax app. This brings it back in line with the complete neutralisation script that is used on the PaaS and SaaS in versions < 16.0 Forward-Port-Of: odoo/enterprise#50889
Issue: When no statement lines were auto reconciled, the false increment of counter variable to update the count of number of reconciled lines causes the cron to execute infinite time as it triggers the same cron by checking the same counter variable. This regression is mainly caused by the commit 0d7d1a2 where some statements were moved inside try...catch statement but forgot to move the counter variable along with it. As a result, it could falsely increment the counter variable when the Us
Original PR description
Issue: When no statement lines were auto reconciled, the false increment of counter variable to update the count of number of reconciled lines causes the cron to execute infinite time as it triggers the same cron by checking the same counter variable. This regression is mainly caused by the commit 0d7d1a2 where some statements were moved inside try...catch statement but forgot to move the counter variable along with it. As a result, it could falsely increment the counter variable when the UserError exception raises. Fix: Updated the reconciled line count variable when some lines were actually reconciled. Forward-Port-Of: odoo/enterprise#50416 Forward-Port-Of: odoo/enterprise#50268
The method _autosend_for_digitization was called twice when attaching a receipt in an expense. Once due to the widget `attach_document` and another due to an action with the same name. This commit moves the action to the community repo and changes it so it sets the main attachment for the expense instead. task-3539382 Community PR: odoo/odoo/pull/138387 Forward-Port-Of: odoo/enterprise#50136
Original PR description
The method _autosend_for_digitization was called twice when attaching a receipt in an expense. Once due to the widget `attach_document` and another due to an action with the same name. This commit moves the action to the community repo and changes it so it sets the main attachment for the expense instead. task-3539382 Community PR: odoo/odoo/pull/138387 Forward-Port-Of: odoo/enterprise#50136
This commit rewrites the Balance Sheet lines 'V. Profit or loss brought forward' and 'VI. Profit or loss for the financial year' using a cross-report formula from the Profit and Loss report. The formulae are written such that: - the line 'VI. Profit and loss for the financial year' is the line '18. Profit and Loss for the financial year' from the Profit and Loss report, for the current financial year. - the line 'V. Profit or loss brought forward' is the line 18 from the Profit and Loss rep
Original PR description
This commit rewrites the Balance Sheet lines 'V. Profit or loss brought forward' and 'VI. Profit or loss for the financial year' using a cross-report formula from the Profit and Loss report. The formulae are written such that: - the line 'VI. Profit and loss for the financial year' is the line '18. Profit and Loss for the financial year' from the Profit and Loss report, for the current financial year. - the line 'V. Profit or loss brought forward' is the line 18 from the Profit and Loss report, for past financial years, minus any amounts taken out of the 14 accounts. Task: 3060790 Forward-Port-Of: odoo/enterprise#50205 Forward-Port-Of: odoo/enterprise#42353
While retrieving emails from incoming customers, this issue will only be triggered when the emails contain attachments of the .xml file type. Subsequently, a data matching process is carried out between the email content and the searched database. If no matching data or IDs are found, an error is thrown. Traceback: ``` Move not found with partner: 672, name: FAC 016714, l10n_latam_document_type: 1, company_id: 1 ``` This commit will change logger error to logger warning. sentry- 4305
Original PR description
While retrieving emails from incoming customers, this issue will only be triggered when the emails contain attachments of the .xml file type. Subsequently, a data matching process is carried out between the email content and the searched database. If no matching data or IDs are found, an error is thrown. Traceback: ``` Move not found with partner: 672, name: FAC 016714, l10n_latam_document_type: 1, company_id: 1 ``` This commit will change logger error to logger warning. sentry- 4305483242 Forward-Port-Of: odoo/enterprise#44248
Following https://github.com/odoo/odoo/pull/138623, creating 2 moves with different procurement group in the same picking makes no sens opw-3470090 Forward-Port-Of: odoo/enterprise#50821
Original PR description
Following https://github.com/odoo/odoo/pull/138623, creating 2 moves with different procurement group in the same picking makes no sens opw-3470090 Forward-Port-Of: odoo/enterprise#50821
Issue: ====== When you have a sign template which has a sign request it shouldn't be editable, but accessing it and trying to drag some of sign items will raise an error because of `helperLines` is undefined. Steps to reproduce the issue: ============================= - Install sign - Go to sign and click on a templte which already have a sign request (in demo data : default it's real_estate_listing_agreement) - Try to drag or resize some sign elements. Origin of the issue: ========
Original PR description
Issue: ====== When you have a sign template which has a sign request it shouldn't be editable, but accessing it and trying to drag some of sign items will raise an error because of `helperLines` is undefined. Steps to reproduce the issue: ============================= - Install sign - Go to sign and click on a templte which already have a sign request (in demo data : default it's real_estate_listing_agreement) - Try to drag or resize some sign elements. Origin of the issue: ==================== The reason behind the error is that helperLines is only defined in `renderSignItems` which requires `this.allowEdit` to be true which is not the case , but enableCustom will register the resize and drag events in the sign item even if it's not editable. opw-3579341 Forward-Port-Of: odoo/enterprise#50633
Fixes same issue as odoo/odoo#141210 except for the MO flow in barcode. This commit simply adds a test to prevent this from happening again. COM PR: odoo/odoo#141797 Forward-Port-Of: odoo/enterprise#50526
Original PR description
Fixes same issue as odoo/odoo#141210 except for the MO flow in barcode. This commit simply adds a test to prevent this from happening again. COM PR: odoo/odoo#141797 Forward-Port-Of: odoo/enterprise#50526
### Steps - Create a product with its bill of materials - Include an operation with a pdf as instruction - Create a MO and confirm. - Go to shop floor and you will see the link to pdf in the operation record. - Go to the BOM and add a QC on the the operation - Create another MO, confirm and go to shop floor ### Issue The pdf doesn't appear. ### Reason In the method which checks if we display the worksheetData ``showWorksheetCheck()``, it returns false when there is a Quality Contro
Original PR description
### Steps - Create a product with its bill of materials - Include an operation with a pdf as instruction - Create a MO and confirm. - Go to shop floor and you will see the link to pdf in the operation record. - Go to the BOM and add a QC on the the operation - Create another MO, confirm and go to shop floor ### Issue The pdf doesn't appear. ### Reason In the method which checks if we display the worksheetData ``showWorksheetCheck()``, it returns false when there is a Quality Control present. After discussing with @MGM, it should always return the pdf if it's present. opw-3509503 Forward-Port-Of: odoo/enterprise#50766 Forward-Port-Of: odoo/enterprise#49389