Saturday, December 2, 2023
3 changes · master
Miscellaneous changes
Previously, if a tour was added to the registry after the tour service started, it would not be registered and could not be started. A previous PR ( https://github.com/odoo/odoo/pull/125055 ) fixed this behaviour, but did not auto-start the corresponding tour if needed. This commit fixes that. It also runs "auto" tours in exclusive mode, ie only one tour at a time, to prevent the check delay from being impacted by other tours which can lead to unwanted behaviour, especially with bootstra
Original PR description
Previously, if a tour was added to the registry after the tour service started, it would not be registered and could not be started. A previous PR ( https://github.com/odoo/odoo/pull/125055 ) fixed this behaviour, but did not auto-start the corresponding tour if needed. This commit fixes that. It also runs "auto" tours in exclusive mode, ie only one tour at a time, to prevent the check delay from being impacted by other tours which can lead to unwanted behaviour, especially with bootstrap modals, which are not immediately closable as soon as they start displaying, and can cause some test tours to fail. task-3377185 Forward-Port-Of: odoo/odoo#143598 Forward-Port-Of: odoo/odoo#125861
Previously a 10mm margin was added between the top edge and the image below. The way the margin was added only offsets the picture by 10mm without adjusting the image size (see PR #143383). This may lead to an overlap between the image and text below (depending on the dimensions of the image). This fixes this issue by putting the 10mm margin "inside" the image instead of "outside" of it. Thus the size of the image is adjusted correctly. Forward-Port-Of: odoo/odoo#144509
Original PR description
Previously a 10mm margin was added between the top edge and the image below. The way the margin was added only offsets the picture by 10mm without adjusting the image size (see PR #143383). This may lead to an overlap between the image and text below (depending on the dimensions of the image). This fixes this issue by putting the 10mm margin "inside" the image instead of "outside" of it. Thus the size of the image is adjusted correctly. Forward-Port-Of: odoo/odoo#144509
The tour `spreadsheet_create_list_view` would sometimes fail as the `beforeunload` process of the spreadsheet action occured at the last step of the test and is slow enough to be interrupted when the tour ends. This revision addresses this issue by adding an explicit last step to let the spreadsheet action clean itself properly. fixes runbot errors 21468 Forward-Port-Of: odoo/enterprise#51811 Forward-Port-Of: odoo/enterprise#51795
Original PR description
The tour `spreadsheet_create_list_view` would sometimes fail as the `beforeunload` process of the spreadsheet action occured at the last step of the test and is slow enough to be interrupted when the tour ends. This revision addresses this issue by adding an explicit last step to let the spreadsheet action clean itself properly. fixes runbot errors 21468 Forward-Port-Of: odoo/enterprise#51811 Forward-Port-Of: odoo/enterprise#51795