Sunday, January 7, 2024
2 changes · master
Miscellaneous changes
Recently, the vat validation was changed to support 16 digits vat introduced in Indonesia in January 2024. This change replaced the stdnum validation, but did not handle vat numbers written using the standard presentation format. This is fixed here, where we will remove the characters used in this format and strip the vat before doing the validation on the digit amount. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR i
Original PR description
Recently, the vat validation was changed to support 16 digits vat introduced in Indonesia in January 2024. This change replaced the stdnum validation, but did not handle vat numbers written using the standard presentation format. This is fixed here, where we will remove the characters used in this format and strip the vat before doing the validation on the digit amount. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#148314 Forward-Port-Of: odoo/odoo#148260
Since the StateSelectionField component handles the hotkey registration, it was necessary to verify that an hotkey can effectively be added, instead of trying to register to undefined. This issue happens when adding an option to the model, since more than 3 options can exist, and the code is written in a way each listed option should have an hotkey associated, which is not the case. A simple test case has been added, using the hotkey to set a state, and asserting the presence of more than
Original PR description
Since the StateSelectionField component handles the hotkey registration, it was necessary to verify that an hotkey can effectively be added, instead of trying to register to undefined. This issue happens when adding an option to the model, since more than 3 options can exist, and the code is written in a way each listed option should have an hotkey associated, which is not the case. A simple test case has been added, using the hotkey to set a state, and asserting the presence of more than 3 items in the dropdown. opw-3620129 Forward-Port-Of: odoo/odoo#148174 Forward-Port-Of: odoo/odoo#147953