Sunday, January 21, 2024
4 changes · 17.0
Resolved issues and error corrections
This update fixes an issue where UPS shipments with Collect on Delivery payment method were failing due to incorrect data format. The COD amount is now sent to UPS as a text string instead of a number, which aligns with UPS requirements and allows orders with this payment method to process successfully.
Original PR description
Steps to reproduce: Set up a UPS shipping method, enable "Collect on Delivery" in the configuration. Make a sale order with this shipping method, confirm and validate the delivery. Error: ``` Missing or invalid COD monetary value for Package 1. Valid length is 0 to 8 numeric and can hold up to 2 decimal places. ``` Based on UPS documentation, the value for COD needs to be of type string. opw-3666755 Forward-Port-Of: odoo/enterprise#54715 Forward-Port-Of: odoo/enterprise#53896
This update fixes an issue where tests were being run twice due to improper test class inheritance. The fix reorganizes the test structure to use a shared common test case and properly creates necessary test data, eliminating the duplicate test runs. This improves testing efficiency and reduces unnecessary processing time.
Original PR description
When inheriting from a test case that contains tests methods, the tests are run twice. The only reason to inherit from this case here, was to use the created partner. So let's use the existing common case ans let's create the partner. Forward-Port-Of: odoo/enterprise#54727
This fix resolves an issue where public website visitors received a "403 Forbidden" error when trying to view products that have accounting tags assigned. The problem occurred because the system attempted to access accounting tag information during tax calculations, but public users don't have permission to view these internal accounting records. The fix ensures that public users can now browse and purchase products without encountering permission errors.
Original PR description
Install module l10n_eu_oss_reports and website_sale Edit a product (i.e. Acoustic Bloc Screens) In Accounting tab add an account tag Try to access the product in webshop as public user User receive an error message 403: Forbidden The page you were looking for could not be authorized. Error message: You are not allowed to access 'Account Tag' (account.account.tag) records. [...] This occurs because during tax computation the system try to access account tags but they cannot be read by the public user opw-3455325 Forward-Port-Of: odoo/odoo#145536
This fix resolves a crash that occurs when users click "See Document" links in email notifications for certain record types that don't use the standard mail threading system. The issue affected rare cases where custom models implement email functionality without inheriting from the standard mail framework, such as the mail groups feature. The fix ensures these redirects work smoothly without errors.
Original PR description
'_redirect_to_record' is used notably when accessing 'mail/view' controller used notably with email notifications ('See Document' link). In order to try to avoid multi company issues a call to '_get_mail_redirect_suggested_company' is performed in order to find the record's preferred company.
However it is defined on 'mail.thread' which means the redirect crashes if invoked using a non thread record. This is quite rare but may happen with models using a mailgateway implementation similar to 'mail.thread' without inheriting from the mixin (see 'mail.group' model added in Odoo 16).
This limitation is present since a long time but is now more present since odoo/odoo@f4523fcd9219fd781a984dab11a0b8689e236b77 .
Task-3689459
Forward-Port-Of: odoo/odoo#150086
Forward-Port-Of: odoo/odoo#149794