Daily updates from Odoo
Monday, February 26, 2024
25 changes
13 changes
Enhancements to existing features
This update changes how product documents are ordered in Odoo, prioritizing them by name instead of ID. This gives users greater control over the appearance of documents in the eCommerce storefront and PDF quotation builder, ensuring the most relevant documents are displayed first.
Original PR description
Ordering documents attached to a produt by name, rather than ID. That allows a control on the order in the PDF quotation builder, and the eCommerce page. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#154961
This update adjusts the layout of the Point of Sale (POS) menu to place 'Close Session' and 'Backend' options at the bottom. This change enhances usability by grouping less frequently used functions together, making it easier for staff to find essential controls.
Original PR description
-Move menu options to have 'Close session' and 'Backend' at the bottom of the list task id: 3759943 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#154998
Resolved issues and error corrections
This update fixes an issue where the Point of Sale system incorrectly parsed decimal numbers (like '0,5'). The fix ensures that prices are interpreted correctly based on the system's decimal separator setting, preventing miscalculations and ensuring accurate order totals. This improves the reliability of sales transactions.
Original PR description
After commit 28b7d698be8255f933ba5314e44e7059746fc234, some part of the code moved to a new file. However, the `parseFloat` that was imported from web wasn't imported. This caused the default parseFloat to be used, which doesn't consider the system "Decimal Separator". As a result, it would parse "0,5" as zero. opw-3754496 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update adjusts the type definition for the `_t` function in the Odoo web module. While technically correct, the change introduced a compatibility issue with existing code. The previous definition was also valid as `LazyTranslatedString` is a type of `String`. This fix ensures continued compatibility and stability of the translation system.
Original PR description
Commit 0493f5d6aa changed the return type of `_t`
from `@returns {string}` to `@returns {string|LazyTranslatedString}`.
While it's not wrong, it breaks other function types which do not care (and should not care) about lazy translated string.
And the previous return type was also correct since `LazyTranslatedString` extends `String`. A return type which is stricter than what's actually returned is always correct.
consider the following function:
```js
/**
* @returns {string}
*/
function myStringFunction() {
...
return _t("a string")
}
```
Since commit 0493f5d6aa, the type is wrong:
`Type 'LazyTranslatedString' is not assignable to type 'string'`
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis update fixes an issue where the 'removeFormat' button in the web editor didn't fully clear text styles (like background and text color). Now, the button completely removes all formatting, ensuring text appears without any lingering styles. This improves the editor's functionality and user experience.
Original PR description
**Before this PR:** When using the removeFormat button, the backgroundColor and foregroundColor were not completely removed. **After this PR:** The removeFormat button will completely remove all the styles applied to it. **task-3344762** Forward-Port-Of: odoo/odoo#130670
This update resolves a minor issue in the Data Recycle module's testing process. Previously, tests relied on an outdated field in the partner record that no longer exists. This change updates the tests to use a different model, ensuring accurate and reliable test results. This ensures the Data Recycle functionality continues to operate correctly.
Original PR description
Since https://github.com/odoo/odoo/pull/112769, there isn't date field on res.partner, but there are still some tests using it (TestDataRecycle). Fix the test by using a other model.
This update fixes an issue where course articles in fullscreen mode were visually blended with the sidebar, making them difficult to read. Padding has been added to the article content, creating a clearer separation and improving the overall user experience. This ensures articles are easily visible and understandable in fullscreen course views.
Original PR description
Before this commit: - In the fullscreen player, the content of an article from any course stuck to the contents sidebar, leading to a lack of visual separation. After this commit: - Added padding to the article content in fullscreen view. Creating a clear distinction between the content and the sidebar. Task-3748836 Forward-Port-Of: odoo/odoo#154973 Forward-Port-Of: odoo/odoo#154588
This update corrects a technical issue where Odoo struggled to consistently handle field data as strings in certain situations. This fix ensures data is represented correctly, preventing potential errors and improving the reliability of Odoo's core functionality. It's a routine maintenance update focused on data integrity.
Original PR description
In some scenarios, it is necessary to evaluate the representation of fields as a string (which triggers issues if this is not the case). Forward-Port-Of: odoo/odoo#155176 Forward-Port-Of: odoo/odoo#154887
A minor issue in the sale loyalty delivery module was causing a test failure. This change corrects a configuration error related to product type definitions, ensuring the module functions correctly. The fix simplifies the test setup and ensures accurate results.
Original PR description
Since https://github.com/odoo/odoo/commit/a54c304487429139c08f384d7b2b620b50cf6f83, sale_loyalty_delivery does not depend on stock anymore. So, the type 'product' (and detailed_type) is not added to the selection. The test does not fail on runbot because the module is never tested alone. We should just change it to type 'consu'. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#155166
This update resolves an issue where sales order prices were being recalculated unexpectedly due to floating-point precision problems. The fix temporarily prevents the system from recomputing prices based on the quantity field, ensuring accurate pricing calculations. This improves the reliability of sales order processing.
Original PR description
Steps to reproduce * Create a new SO * Add a new line with a storable product and 15.12 as quantity * change the price to X * Save and confirm * Set a scheduled date (Other info tab) * Save -> The price of the SOL is recomputed. Cause Because of floating point issues, the value returned by the onchange for the product_uom_qty field is 15.1200000....1, therefore being considered in the client-side as having been changed by the onchange. The value is then sent to the server on save, triggering a recomputation of the SOL prices. Until there is a clear solution in the framework, this commit drops 'unmodified values' for the product_uom_qty field, using an existing check, and only if there is only one updated line in the write call. opw-3670318 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#155271
This update clarifies the settings within Odoo's alias domains, making them easier for users to understand and manage. Specifically, advanced configuration options like bounce and catchall addresses are now visible in debug mode, allowing for careful adjustments. Tooltips have also been added to guide users on how to use these fields effectively.
Original PR description
Ease understanding the purpose of main fields on alias domains. Set bounce, catchall and default_from available in debug mode as those are advanced configuration bits that should be displayed (and modified) with care. Task-3696224 Forward-Port-Of: odoo/odoo#150401
Features or functions removed from Odoo
This update removes integrations for payment methods that were not fully supported, specifically Amazon Pay with Adyen and BLIK with Stripe. These removals streamline the system and ensure we're only offering reliable payment options to our customers.
Original PR description
The following combinations of payment methods and providers are removed: - Amazon Pay - Adyen: The payment method cannot be activated because it requires saving a public key in Odoo, and no field was made available for that. Also, a custom configuration is necessary and the public key must be generated through a lengthy process that is too cumbersome for the added value of the payment method anyway. - BLIK - Stripe: The payment method is not supported by Stripe when the PaymentIntent object is created after collecting the payment details. See https://stripe.com/docs/payments/accept-a-payment-deferred?platform=web&type=payment#enable-payment-methods opw-3736511 Forward-Port-Of: odoo/odoo#153481
Code cleanup and technical improvements
This update simplifies the process of adding extra information to stock move lines during the unbuild process. Previously, developers needed to completely replace a core function, but now it's easier to extend and customize this process, allowing for more adaptable stock management. This change enhances the system's flexibility and reduces development effort.
Original PR description
With the current design, when we want to pass more parameters from the original move lines of MO to the unbuild move lines, we can't easily extend action_unbuild() and it seems we need to completely override it. After this refactoring commit, developers can easily extend and add more parameters. @qrtl --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#154667 Forward-Port-Of: odoo/odoo#151983
10 changes
Enhancements to existing features
Helpdesk ticket reports now show “Time to first assignment” and “Time to close” with greater precision, including minutes instead of only whole-hour values. This helps teams better understand response and resolution performance, especially for tickets handled quickly.
Original PR description
Converting "Time to first assignment" and "Time to close" fields of helpdesk tickets from integers to floats allows the users to see the time more precisely (minutes included). task-3700521
Miscellaneous changes
In the website tabl, try to add a website form Before this commit, there was a crash because of some callback that was not bound. After this commit, the flow works as expected. opw-3735624 Forward-Port-Of: odoo/enterprise#57122
Original PR description
In the website tabl, try to add a website form Before this commit, there was a crash because of some callback that was not bound. After this commit, the flow works as expected. opw-3735624 Forward-Port-Of: odoo/enterprise#57122
Before this commit, values in grouped lines are not in the company currency but in the foreign currency set on the move. This is wrong, this commit changes the way we're computing values to get the value in company currency instead of in foreign currency. To do that, we change the computation (`quantity * price_unit`) for this: `Sign of quantity * Sign of price unit * ABS(balance)` It means that we handle possibility that quantity and price unit could be negative (for some strange corne
Original PR description
Before this commit, values in grouped lines are not in the company currency but in the foreign currency set on the move. This is wrong, this commit changes the way we're computing values to get the value in company currency instead of in foreign currency. To do that, we change the computation (`quantity * price_unit`) for this: `Sign of quantity * Sign of price unit * ABS(balance)` It means that we handle possibility that quantity and price unit could be negative (for some strange corner cases), and we get the amount in company currency instead of in the foreign currency. opw-3757444 Forward-Port-Of: odoo/enterprise#57429 Forward-Port-Of: odoo/enterprise#57334
In this commit (https://github.com/odoo/enterprise/commit/0f31f77665b10ac85396ed890786f630401f0503), we ensure that generic report line ids are unique by using all discriminant values. This commit ads these discriminant values in the where to make sure that sublines have unique ID as well. no task id Forward-Port-Of: odoo/enterprise#57343 Forward-Port-Of: odoo/enterprise#57256
Original PR description
In this commit (https://github.com/odoo/enterprise/commit/0f31f77665b10ac85396ed890786f630401f0503), we ensure that generic report line ids are unique by using all discriminant values. This commit ads these discriminant values in the where to make sure that sublines have unique ID as well. no task id Forward-Port-Of: odoo/enterprise#57343 Forward-Port-Of: odoo/enterprise#57256
odoo-python and odoo-javascript comments in .pot files are used to determine which translations to load. Omitting them would cause the translations not to appear. This commit goes through all .pot files and re-exports the ones where the comments have been omitted. Task-3764933. Community: https://github.com/odoo/odoo/pull/155302 Forward-Port-Of: odoo/enterprise#57361
Original PR description
odoo-python and odoo-javascript comments in .pot files are used to determine which translations to load. Omitting them would cause the translations not to appear. This commit goes through all .pot files and re-exports the ones where the comments have been omitted. Task-3764933. Community: https://github.com/odoo/odoo/pull/155302 Forward-Port-Of: odoo/enterprise#57361
Currently, synchronizing done order in FBA creates some stock move that are not in the state done anymore. This is due to some changes in the management of the quantity done in stock, that needs to see if the quantity was picked or not. As, in this case, we are confirming a move for products that were stocked in an Amazon Warehouse and then delivered by Amazon, we can manually set the move as being picked. opw-3594556 opw-3662990 Forward-Port-Of: odoo/enterprise#56943
Original PR description
Currently, synchronizing done order in FBA creates some stock move that are not in the state done anymore. This is due to some changes in the management of the quantity done in stock, that needs to see if the quantity was picked or not. As, in this case, we are confirming a move for products that were stocked in an Amazon Warehouse and then delivered by Amazon, we can manually set the move as being picked. opw-3594556 opw-3662990 Forward-Port-Of: odoo/enterprise#56943
Issue --> For a database with a large number of `account.move` records, the computation of the field `l10n_ar_fce_transmission_type` leads to a MemoryError when installing the `l10n_ar_edi` module. Solution --> Use the `_auto_init` method to add the column to the `account_move` table to skip computation during installation. Set the value to NULL on init because the field does not have a default value. opw-3694393 Forward-Port-Of: odoo/enterprise#56879
Original PR description
Issue --> For a database with a large number of `account.move` records, the computation of the field `l10n_ar_fce_transmission_type` leads to a MemoryError when installing the `l10n_ar_edi` module. Solution --> Use the `_auto_init` method to add the column to the `account_move` table to skip computation during installation. Set the value to NULL on init because the field does not have a default value. opw-3694393 Forward-Port-Of: odoo/enterprise#56879
The file `test_ui` is currently not imported. The tour is pretty useless and has been improved in 17.0. We will keep it in that version, to be sure that we don't break the equivalent tour, but we can remove in these versions (it just creates a sample bill and post it, currently). The tour `account_accountant_tour_upload_ocr_step` has been deemed useless. It pops a bubble on a button where it makes no sense, with a self-explanatory message already. Forward-Port-Of: odoo/enterprise#5722
Original PR description
The file `test_ui` is currently not imported. The tour is pretty useless and has been improved in 17.0. We will keep it in that version, to be sure that we don't break the equivalent tour, but we can remove in these versions (it just creates a sample bill and post it, currently). The tour `account_accountant_tour_upload_ocr_step` has been deemed useless. It pops a bubble on a button where it makes no sense, with a self-explanatory message already. Forward-Port-Of: odoo/enterprise#57225 Forward-Port-Of: odoo/enterprise#56726
Fixes that sale_subscription mail templates is reverted on module upgrade When upgrading the sale_subscription module all subscription email templates was reverted due to missing noupdate=1 Forward-Port-Of: odoo/enterprise#57043
Original PR description
Fixes that sale_subscription mail templates is reverted on module upgrade When upgrading the sale_subscription module all subscription email templates was reverted due to missing noupdate=1 Forward-Port-Of: odoo/enterprise#57043
**Issue:** The total amounts div overlaps the digital stamp from the Mexican localization **Solution:** Put the digital stamp at the final of every element of the invoice to avoid the overlapping **opw-3742996** Forward-Port-Of: odoo/enterprise#56718
Original PR description
**Issue:** The total amounts div overlaps the digital stamp from the Mexican localization **Solution:** Put the digital stamp at the final of every element of the invoice to avoid the overlapping **opw-3742996** Forward-Port-Of: odoo/enterprise#56718
2 changes
Resolved issues and error corrections
A test in the sales loyalty delivery module was failing because it referenced a product type that is no longer available after a recent code change. The fix updates the test to use a consumable product type instead, ensuring the test runs correctly when the module is tested independently.
Original PR description
Since https://github.com/odoo/odoo/commit/a54c304487429139c08f384d7b2b620b50cf6f83, sale_loyalty_delivery does not depend on stock anymore. So, the type 'product' (and detailed_type) is not added to the selection. The test does not fail on runbot because the module is never tested alone. We should just change it to type 'consu'. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#155166
The translation template file for Odoo's base module has been updated to reflect the latest text strings in the system. This ensures that translators have the most current content to work with when localizing Odoo into different languages, improving the quality and completeness of translations across all supported languages.
Original PR description
Export pot of base module Entreprise: https://github.com/odoo/enterprise/pull/57503