**[IMP] web_editor, website: improve on hover animation**

This commit makes improvements as requested in the following pull
request [1] ("allowing the ability to flip/rotate image shapes" and
"adding an 'on hover' option for animations").

It mainly focuses on refining the code for better organization.

[1]: https://github.com/odoo/odoo/pull/119197

task-3495241

-----------------------------------------------------------------------------------------------------

**[IMP] web_editor, website: preview hover effects**

This commit adds the possibility to preview the various effects
available in the "effect" option for 'on hover' animations when hovering
over the dropdown. The sub-options of these effects are also previewed.

This commit also prevents the user from seeing the different changes
that occur to an image with a shape while changing one of its options
(e.g., changing the shape, previewing hover effects).

task-3495241

-----------------------------------------------------------------------------------------------------

**[FIX] web_editor, website: fix undo after enabling hover effects.**

Steps to reproduce the bug:

- In Website edit mode, drag & drop a text-image snippet onto the page.
- Click on the image of the snippet.
- In the image options, select "On Hover" for the "Animation" option.
- Click on the "Undo" button in the top bar of the editor panel.
- Bug: The "Animation" option has not been deactivated, the "Hover
Effect" is still present when hovering over the image.

task-3495241

Forward-Port-Of: odoo/odoo#134979

On the contact kanban view, add as much tags as possible. The point is to make the right hand part of the kanban card as tall as possible.

Before this commit, the image (on the left hand side) of the individual partner was taking all the space in the y-axis, which was on purpose, but the cropping of the image made it so that the image lost is sense: a face was too much cropped, or, if the image did not have sufficient pixel density, it was pixelized.

What is specific to 17 that is barely applicable in earlier versions, is the changes in the display of many2many tags in the kanban record: they now take more space and at a faster pace.

After this commit, we constrain that image to a maximum height and centering it.

opw-3748585
opw-3751016

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#155359

Steps to reproduce:
- Activate  "Verify VAT Numbers" option in the Settings
- Go to Contacts and create a new one
- Enter a valid EU VAT Number

Issue:
It happens that VIES service could not process the VAT number for some reason and returns an error.
That error is silently caught without notification to user and "Intra-Community Valid" field is set to False.
The user will wrongly think that the VAT number is not valid, but it hasn't been processed at all.

Here's the list of the potential errors returned by VIES service:
- INVALID_INPUT
- INVALID_REQUESTER_INFO
- SERVICE_UNAVAILABLE
- MS_UNAVAILABLE
- TIMEOUT
- VAT_BLOCKED
- IP_BLOCKED
- GLOBAL_MAX_CONCURRENT_REQ
- GLOBAL_MAX_CONCURRENT_REQ_TIME
- MS_MAX_CONCURRENT_REQ
- MS_MAX_CONCURRENT_REQ_TIME

Solution:
Log a note with the error (as it is done for some other error) to warn the user that the VAT number hasn't been processed.

opw-3687968




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#153196

Before this commit, when a salesman user without any access in other apps (just has the `sales_team.group_sale_salesman` group) creates an SO and adds a SOL for a product with `expense_policy='sales_price'` and then confirm the SO, he will got a traceback because he does not have access to `analytic.account.line` model. The reason is because an analytic account has to be generated for the SO since there is an expense product in its SOLs and so during the generated of analytic account a check is triggered to be sure the company set on that analytic account is correct.

This commit adds a sudo before calling the search method in `analytic.account.line` model to do the check without checking the access right since the user does not really want to read the analytic account line.

Steps to reproduce
==================
1. Log in as Salesman user (without other access)
2. Create a product and the expense policy to Sales price.
3. Create a SO and add a SOL with that product
4. Confirm the SO

Expected Behavior
=================
The SO should be confirmed without any issue (and an analytic account should set on that SO)

Actual Behavior
===============
Traceback is occured because the user cannot access to `analytic.account.line` model.

Follow-up task-3256865

Forward-Port-Of: odoo/odoo#155238

A lot of translations were missing from the l10n_mx* localizations therefore they are cleaned up by:

- re-exporting all of the pot files of the modules starting with l10n_mx* (most were out of date and/or incorrectly manually modified)
- the translations from v17 are backported (a bunch update of all of the terms in these modules was done for v17)
- the modules were all consistently updated to use es.po only, i.e. es_MX.po files were removed, since both were used but in v17 they were all converted to es_419 (i.e. the default Spanish local from v17 onwards)

Notes:
- This was only done in saas-16.3 onwards to support a ticket. Previous versions can have similar steps done for them when requested by customers, but are not done as part of this PR because it's cumbersome to do.
- Since terms change between versions, probably some translations are missing and can be added in as demanded/noticed by customers (since it's also cumbersome to track them down)

opw-3452127

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#155262
Forward-Port-Of: odoo/odoo#155214

PURPOSE

Mail: add tests for MailTemplate send_mail

Several flows use MailTemplate.send_mail() in batch, notably event email
scheduler which sends emails to event attendee in batch. This commit adds
tests around 'send_mail' method of MailTemplate model

  * add tests for batch: it is currently not supported hence using a loop but
    batch is going to be added soon, allowing to test the batch version works
    as intended;
  * add query counters, notably for batch mode and when dynamic reports are
    involved in templates;

Event: improve mail scheduler tests

Make them easier to improve and modify

  * use a dedicated setup (allowing to add specific unit tests on test data);
  * move initial asserts into its own unit test (to keep other tests shorter);
  * use available mocks for freezetime and sql.now;

Then add tests for registration emails, to check what happens for communication
scheduled right at registration time.

LINKS

Part of Task-3764894: Event: Allow using cron triggers for communication
Part of Task-3764891: Mail: Batch-ize MailTemplate send_mail
Part of Task-3164278: Mail: Batch send: ensure limit, avoid force
Part of Task-3084943: Event: Improve communication scheduler scalability

**Current behavior:**
When creating a new helpdesk team, if you have selected Random or Balanced as an Assignment Method and delete the default user in the avatar selection box then switch to the Manual assignment method option, you will simultaneously be unable to assign a user (as the selection box disappears) and required to provide at least one user before being saving.

**Expected behavior:**
The form should not require a value for a field when the UI does not permit one to be entered.

**Steps to reproduce:**
1. In the Helpdesk app, go to configuration -> Helpdesk Teams

2. Create a new team, select either Random or Balanced as the Assignment Method, delete the default value, then switch back to Manual assignment

3. Try to save the record

**Cause of the issue:**
member_ids is a required attribute of the helpdesk.team model despite the form view hiding the selection box when the Manual assignment option is selected (implying it is not required).

**Fix:**
Create an _onchange() method which populates the member_ids field with a default value when the user switches to Manual assignment with no member_ids assigned.

opw-3672587

Forward-Port-Of: odoo/enterprise#57608
Forward-Port-Of: odoo/enterprise#55767

**Current behavior:**
Modifying an email template associated with the Appraisals app will not result in that attachment being sent when a message is composed using that the template.

**Expected behavior:**
The attachment(s) of a certain template will be sent when an email is triggered that references that template.

**Steps to reproduce:**
1. Modify an HR Appraisals email template so that it has some file attachment

2. In the Appraisals app, create a new appraisal that will use the modified email template

3. Send the email, observe in the chatter sidebar or in the list of emails in settings that the attachment linked to the relevant template was not sent

**Cause of the issue:**
The attachment_ids field of the request.appraisal model was not passed as a kwarg to the action_invite() method, which is where the email gets composed and posted.

**Fix:**
Add the missing attachment_ids argument to this method.

opw-3644820

Forward-Port-Of: odoo/enterprise#57402
Forward-Port-Of: odoo/enterprise#55977

Previously, when exporting CIUS-RO XML and the supplier (company) or customer doesn't have a country code prefix on either their VAT or company ID, an error will be thrown preventing the user from generating the XML. But after allowing the XML generating process, the XML is then rejected by the validator because of `BR-CO-09` rule:

```xml
<assert id="BR-CO-09" flag="fatal" test="( contains( ' 1A AD AE AF AG AI AL AM AO AQ AR AS AT AU AW AX AZ BA BB BD BE BF BG BH BI BJ BL BM BN BO BQ BR BS BT BV BW BY BZ CA CC CD CF CG CH CI CK CL CM CN CO CR CU CV CW CX CY CZ DE DJ DK DM DO DZ EC EE EG EH EL ER ES ET FI FJ FK FM FO FR GA GB GD GE GF GG GH GI GL GM GN GP GQ GR GS GT GU GW GY HK HM HN HR HT HU ID IE IL IM IN IO IQ IR IS IT JE JM JO JP KE KG KH KI KM KN KP KR KW KY KZ LA LB LC LI LK LR LS LT LU LV LY MA MC MD ME MF MG MH MK ML MM MN MO MP MQ MR MS MT MU MV MW MX MY MZ NA NC NE NF NG NI NL NO NP NR NU NZ OM PA PE PF PG PH PK PL PM PN PR PS PT PW PY QA RE RO RS RU RW SA SB SC SD SE SG SH SI SJ SK SL SM SN SO SR SS ST SV SX SY SZ TC TD TF TG TH TJ TK TL TM TN TO TR TT TV TW TZ UA UG UM US UY UZ VA VC VE VG VI VN VU WF WS XI YE YT ZA ZM ZW ',substring(cbc:CompanyID,1,2) ) )">[BR-CO-09]-The Seller VAT identifier (BT-31), the Seller tax representative VAT identifier (BT-63) and the Buyer VAT identifier (BT-48) shall have a prefix in accordance with ISO code ISO 3166-1 alpha-2 by which the country of issue may be identified. Nevertheless, Greece may use the prefix ‘EL’.</assert>
```

In Romania however, there are multiple types of "Tax IDs", and it is perfectly valid in Romania to have a Tax ID without RO (country code prefix) in front of them. They are not a subject to paying VAT, and it should still be possible to generate CIUS-RO XML with their tax identifications.

This commit aims to fix this behavior by applying some special treatment to Romanian partners when generating the XML: by modiying the TaxScheme ID. The error only raises when the detected ID is 'VAT'.

This commit also fixes and clean some of the irrelevant constraints and tests previously written in `l10n_ro_edi`.

task-id: 3649426

Since Odoo v16, we also use grid in the form layout (inner group).
In a group we use the CSS `grid-template-columns` with the value of:
* `fit-content(150px)`: for the first column (TLDR: col max 150px)
* `1fr`: for the second column (TLDR: take the "remaining" max space)
```css
.o_form_view .o_inner_group {
  grid-template-columns: fit-content(150px) 1fr;
}
```
These rules at the first glance seem correct.
But due to "big word"/language, some unbreakable text is overflowing, to avoid this, we have added the `text-break` BS class.

So now all text can be "squash"/wrap if there is no space available.

The problem is when we have a text be too long and unbreakable in the second column, the label (first column) is squashed to see only one or two characters.

In our case, the bug happens when we upload a file with a big filename to an "Attachement" (`many2many_binary`) field.

On the `many2many_binary` field there is a custom CSS rules:
```css
.o_attachment .caption {
  white-space: nowrap;
}
```
that force the text to not wrap on the next line, and so the grid takes the width of the file name as its min value for the width of the second column, and "squash"/wrap the first column.

This commit fixes the issue by allowing the second column to be smaller than the `max-content` width using the css `minmax(0, 1fr)`.

Steps to reproduce:
* Open "Marketing automation" app
* Create a New campaign ("New" button)
* Click on "ADD NEW ACTIVITY"
* Select the "Mail Template" field
* Create and edit a "Mail Template"
* Click on the "Options" tab
* Upload an attachment with a long name => BUG, all labels (first column) are "squashed"

Note:
* the `text-break` class is equivalent to:
```css
.text-break {
  word-wrap: break-word !important;
  word-break: break-word !important;
}
```
* when we use `Xfr` (X a positive numeric value `1fr` in our case) outside a `minmax()` notation, the GRID specs[1] specifies that it should be converted to `minmax(auto, Xfr)`.
* also the `auto`[2] in the case of `minmax(auto, Xfr)`the value represents the largest minimum size (in our case, the file name).

[1]: https://www.w3.org/TR/css-grid-2/#valdef-grid-template-columns-flex
[2]: https://www.w3.org/TR/css-grid-2/#valdef-grid-template-columns-auto

task-3644267

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#155420

How to reproduce:
- Install hr with demo data
- Create a user without access to hr and turn it into an employee
- Create a user for Abigail
- Assign Abigail as manager of the new user
- Click on "onboarding plan" in the chatter of the new user
- Then in the dialog, click on "Schedule" button

You get the error "Assigned user test has no access to the document and is not able to handle this activity." because the new user has no access to the record employee on which those activities are scheduled.

As activities for which the user has no access to the underlying record are now displayed in the systray (with no access to the record), we remove the check that prevent assigning an activity to a user on a record he has no access to.

Technical note: before odoo/odoo#149965, activities scheduled manually were created with the flag "automated" set to True and when this flag is set the check that ensures that the user has access to the record is skipped. With odoo/odoo#149965, as the "automated" flag is set to False when scheduling activities manually, an error is trigerred if the user has no access to the underlying record. Here we always skip that test and mark the method as deprecated because the user can see the activity no matter the access he has on the underlying record.

Task-3598836

Before this commit, in a kanban view grouped by a date(time) field, with progressbars and an aggregate field, after clicking on a bar to filter records, the aggregate value was always 0.

This was due to a mismatch when trying to find the value of the aggregate in the web_read_group result, as when grouped by a date or datetime field, the key is `fieldname:granularity`, and we were looking for the fieldname only.

This commit fixes the issue. It also fixes the mocked version of read_progress_bar in the MockServer, s.t. we can correctly reproduce the scenario in tests, as in the previous version, keys in the returned object weren't computed the same way as in the real read_progress_bar (e.g., "14,Mitchel", instead of "Mitchel"). A similar fix has been done in [1]. This allows us to introduce a test when grouped by many2one, which doesn't work as of 17.0.

[1] fd759f18d056844c486a68d0c394df5a03e789f0

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#155524