Monday, March 11, 2024
27 changes
9 changes
Resolved issues and error corrections
A bug preventing the partner autocomplete from appearing during invoice creation has been fixed. This update ensures users can quickly and easily find and select partners when entering invoice data, improving efficiency. The fix addresses a change in how new invoices are created.
Original PR description
Steps to reproduce: [account, iap credit] - create a new invoice - start to write "test" for the partner Issue: The partner autocomplete is not displayed Cause: in https://github.com/odoo/odoo/pull/150106 we add a condition for the quickCreate bypassing the possibility of having createEdit set to true opw-3698400 Forward-Port-Of: odoo/odoo#154771 Forward-Port-Of: odoo/odoo#153608
This update addresses a warning that appears when modules incorrectly configure post-load methods. The change ensures that post-load methods are handled consistently, preventing potential issues during module loading and testing. This improves the stability and reliability of Odoo.
Original PR description
-Step to reproduce: add a post_load method in the init of any module, specify in the manifest like : 'post_load': 'post_load'. Run test_manifests of the test_lint module and we will get warning Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156347 Forward-Port-Of: odoo/odoo#154316
This update allows users to select a temporary account when creating a branch company within Point of Sale. Previously, this setting was unavailable, leading to inconsistencies in accounting. Now, branch companies can be properly configured for accurate financial reporting.
Original PR description
**Before this PR:** When the user creates a branch company, the pos(accounting) setting does not allow the selection of a default temporary account for the user. **After this PR:** The user is allowed to choose a temporary account from the branch company. **Task**-3775873 Forward-Port-Of: odoo/odoo#156478
This update fixes an issue where the order confirmation page and preparation display weren't activated when orders had a zero total amount. Now, the confirmation page and order sending process are consistently triggered upon order confirmation, regardless of the order total.
Original PR description
The confirmation page wasn't displayed and the order wasn't sent to the preparation display when confirming an order with a total of 0. Now the confirmation page is displayed and the order is send to the preparation display when the order is confirmed regardless of the total amount. Forward-Port-Of: odoo/odoo#157028
This update resolves an issue where the old job search route (`/jobs`) caused errors due to changes in how search parameters were handled. The fix automatically redirects users to the new route, preserving any search criteria entered to ensure a seamless and accurate job search experience.
Original PR description
__Current behavior before commit:__ `/jobs` routes have been modified in [this commit][1]. Old ones are deprecated but are still working for backward compatibility. When searching on this page,…
__Current behavior before commit:__ `/jobs` routes have been modified in [this commit][1]. Old ones are deprecated but are still working for backward compatibility. When searching on this page, search params are now just added at the end of the URL (instead of being part of the path like before). If the URL of the page is a deprecated one, this can create a conflict with the previous way the params were handled and produce an error. __Description of the fix:__ Redirect the user to the new route any time he tries to reach the deprecated ones. Any parameters included in the old URL will be carried over to the new route to maintain expected behavior. If a parameter is provided both in the path and as a kwarg, the kwarg value will take precedence. __Steps to reproduce the issue on runbot:__ 1. Go to `/jobs/country/20` 2. Make a search using the search bar -> Crash opw-3781374 [1]: https://github.com/odoo/odoo/commit/54f246f9c75b8f1ebdc637c6000f3e4773d702d5 Forward-Port-Of: odoo/odoo#157079 Forward-Port-Of: odoo/odoo#156918
This update fixes an incorrect translation within the Serbian language version of Odoo. Previously, the 'Specific VAT rate 10%' tax group was translated as an invalid term. Now, it correctly displays as 'Opšta stopa PDV-a 10%', ensuring accurate tax reporting for Serbian users.
Original PR description
Description of the issue/feature this PR addresses: This PR fixes translation of the tax group `Specific VAT rate 10%` Current behavior before PR: When using Serbian language tax group `Specific VAT rate 10%` is translated as `ZALIHE MATERIJALA` which is invalid. Desired behavior after PR is merged: When using Serbian language tax group `Specific VAT rate 10%` will be translated as `Opšta stopa PDV-a 10%` which is correct. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#155198
This update fixes an issue where the quantity of components consumed during MO unbuilding was incorrectly displayed. Previously, the system showed the full planned quantity even after consuming a smaller amount. This change ensures that the unbuild process accurately reflects the actual component usage, improving inventory accuracy.
Original PR description
Step: * Create BoM A: product A - qty 1, bom line: product = Component X, qty = 20 * Create MO with Bom A and produced_qty = 1: + on components: To Consume = 20, Consumed = 15 + Unbuild MO, check Unbuild, check Product Moves of Unbuild, check line product Component X has Quantity = 20, in fact quantity must = 15 **I consumed a smaller quantity of components than planned, but when I unbuild MO, move lines of unbuild has quantity done = quantity planned, not the actual quantity consumption. I think this is a bug** --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156952 Forward-Port-Of: odoo/odoo#152805
A recent update to asset depreciation calculations caused a sorting issue when viewing asset entries. This was triggered by modifying the dates of asset entries, specifically when using new entry IDs. This fix ensures that asset entries are correctly sorted regardless of their creation date, preventing incorrect display of depreciation schedules.
Original PR description
To reproduce: - Install account_accountant - Create an asset (monthly for example) - Compute Depreciation - Modify the date of the first entry to 2 months later - Modify the date of the second entry to 1 month later (so same month) => Traceback The problem is that sorted does not work with ids of NewId. We should look at its _origin. There is a PR that would try to fix it in general, but it's in master (and is not sure to be merged https://github.com/odoo/odoo/pull/155850) The problem only began to occur in 17.0 because of the changes of the onchange function. opw-3759153 (in chatter) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156874
This update adds logging for when cron jobs are run manually through the Odoo interface. Previously, these manual runs weren't tracked, leading to confusion when issues like duplicate emails occurred. By logging these actions, our support team can better diagnose and resolve problems related to concurrent cron executions.
Original PR description
The INFO "Starting job x" and "Job x done" logs are only logged for the automatic executing of the cron by the cron worker. When running the cron manually via its form view, no INFO was logged. The technical support is reporting problems where a cron server action is running twice at a same moment leading to problems such as mass-mailing sending emails twice. There is a mutual exclusion mechanism for cron workers but no exclusion mechanism seems in place for http worker vs cron worker. Logging the "run manually" actions will help us figuring out the problems. --- **[[FIX] base: concurrent cron worker and manual run](https://github.com/odoo/odoo/pull/154763/commits/3b74c9af776311e38a1712ab64cb42cd25188db4)** It is possible for a cron to be executed twice at a same moment if the cron is currently being executed by a cron worker and that a user click on the "run manually" button from its form view. Forward-Port-Of: odoo/odoo#156914 Forward-Port-Of: odoo/odoo#154763
13 changes
Enhancements to existing features
This update removes obsolete internal module markers from JavaScript files in accounting-related frontend code and tests. It does not change product behavior, but keeps the codebase cleaner and easier to maintain.
Original PR description
As the /* odoo-module */ statement isn't required anymore in both `static/src` and `static/tests` folders we can remove them.
Users can no longer create new company records directly from selected Planning and Helpdesk screens. This helps prevent accidental or duplicate company setup by requiring company creation through the proper process.
Original PR description
Disable on the fly creation for companies in some views: - `planning.slot.form`: Planning > List View > View Button - `helpdesk.team.form`: Helpdesk > Configuration > Helpdesk Teams > New - `resource.resource.tree`: Planing > Configuration > Materials task-3507965
The calendar event form now hides the appointment type field when it is not already set. This encourages users to configure appointment details through the dedicated Appointment Types flow, helping avoid confusing or inconsistent event setup.
Original PR description
While creating a calendar event record, different field duration, reminders, etc are expected to be filled with values **(when we select appointment type in the form view)** same manner as we create appointment type records via the front end. It's more effective to fill such field values directly from the Appointment Types (via the front end). so the appointment_type_id field is hidden when we create a calendar event record via form view. Task-3768152
Resolved issues and error corrections
Restores previously skipped mobile-related test coverage that was accidentally left out after an earlier change. This helps ensure mobile web behavior continues to be checked automatically and reduces the risk of regressions reaching users.
Original PR description
Some class relying on the inherited test side effect where forgotten during #148660 Enabling them again.
Copying a spreadsheet chart now preserves its link to the related Odoo menu. This prevents users from losing navigation context when duplicating charts, making copied spreadsheet content behave as expected.
Original PR description
## Task Description: When copying a chart in a spreadsheet, the link to the Odoo menu is not kept. This PR aims to fix it by taking advantage of the new clipboard refactoring,with a new clipboard handler saving the odooMenuLink in the clipboard data and putting it back in the newly created chart. ## Related Task: - Task: 3380568 - https://github.com/odoo/o-spreadsheet/pull/3670 (need to be merged to have the base class exported)
The Helpdesk website page now shows the "Optimize SEO" option in the Site menu again. This lets website managers adjust search engine settings for helpdesk pages, helping maintain visibility and consistency with earlier versions.
Original PR description
Description of the issue/feature this PR addresses: The "Optimize SEO" is missing in the site menu for the helpdesk page. It should be there (as before the v17) Current behavior before PR: The menu is missing Desired behavior after PR is merged: "Optimize SEO" menu available in the "Site" menu on the Helpdesk page To reproduce: Install website_helpdesk Go to the help page of the website, on the form fixes: opw-3766163
Miscellaneous changes
The button "insert in spreadsheet" added in the pivot view would display a tooltip of "0" when the button was active. The tooltip was only meant to be present when the button was disabled due to the presence of duplicated group bys in the pivot. This revision fixes the tooltip presence on the button and also removes a test that: - had a description that did not match the actual test - was in fact testing the same behaviour as another test -> useless redundancy Task: 3790072 Forward-Port
Original PR description
The button "insert in spreadsheet" added in the pivot view would display a tooltip of "0" when the button was active. The tooltip was only meant to be present when the button was disabled due to the presence of duplicated group bys in the pivot. This revision fixes the tooltip presence on the button and also removes a test that: - had a description that did not match the actual test - was in fact testing the same behaviour as another test -> useless redundancy Task: 3790072 Forward-Port-Of: odoo/enterprise#58323 Forward-Port-Of: odoo/enterprise#58160
…of SEPA Forward-Port-Of: odoo/enterprise#57981
Original PR description
…of SEPA Forward-Port-Of: odoo/enterprise#57981
Purpose: ------- If you open different frontend room booking views using the same browser profile, all rooms will receive and handle all bus notifications, which leads to rooms views showing bookings created for other rooms. This is due to the bus service using a single websocket connection that is shared across the different tabs. A simple workaround to display several frontend rooms views using one device consists in using different browser profiles. This commit adds a warning at the t
Original PR description
Purpose: ------- If you open different frontend room booking views using the same browser profile, all rooms will receive and handle all bus notifications, which leads to rooms views showing bookings created for other rooms. This is due to the bus service using a single websocket connection that is shared across the different tabs. A simple workaround to display several frontend rooms views using one device consists in using different browser profiles. This commit adds a warning at the top of the frontend view when several tabs are detected, that asks the user to close the other tabs . Task-3698135 Forward-Port-Of: odoo/enterprise#55018
Steps to reproduce ================== - Go to the barcode app - Click on "Batch transfers" - Open a record - Add a new product and confirm - Click on the pencil next to the newly added product - Click on the delete button => `Cannot read properties of undefined (reading 'suggested_package')` Cause of the issue ================== When deleting a line, it is removed from the state [0] Solution ======== We simply need to check that the line exists --- [0]: https://gi
Original PR description
Steps to reproduce ================== - Go to the barcode app - Click on "Batch transfers" - Open a record - Add a new product and confirm - Click on the pencil next to the newly added product - Click on the delete button => `Cannot read properties of undefined (reading 'suggested_package')` Cause of the issue ================== When deleting a line, it is removed from the state [0] Solution ======== We simply need to check that the line exists --- [0]: https://github.com/odoo/enterprise/blob/5ef4a85febcde0a690a71cb1886a8a74daf31f47/stock_barcode/static/src/models/barcode_model.js#L390 opw-3688415 Forward-Port-Of: odoo/enterprise#58341 Forward-Port-Of: odoo/enterprise#57691
This commit improves the '_get_social_stream_post' method to make it use a complete domain instead of relying on pathing through the stream, then the account, then the media (= 3 records fetch), to get the media type. This will save a lot of requests as it is a central method used in the controllers of all social media implementations. Forward-Port-Of: odoo/enterprise#58286
Original PR description
This commit improves the '_get_social_stream_post' method to make it use a complete domain instead of relying on pathing through the stream, then the account, then the media (= 3 records fetch), to get the media type. This will save a lot of requests as it is a central method used in the controllers of all social media implementations. Forward-Port-Of: odoo/enterprise#58286
Issue: ------ In the helpdesk application, when a timesheet is added to a helpdesk ticket, it does not have a commercial partner (we can add the field with studio to see this behaviour). There may be one if a commercial partner exists for the helpdesk project. This behaviour is contradictory to that found in project. Solution: --------- Add the `helpdesk_ticket_id` field invisibly in the view so that this field is in the fields to be updated with the onchange. It will be correctly up
Original PR description
Issue: ------ In the helpdesk application, when a timesheet is added to a helpdesk ticket, it does not have a commercial partner (we can add the field with studio to see this behaviour). There may be one if a commercial partner exists for the helpdesk project. This behaviour is contradictory to that found in project. Solution: --------- Add the `helpdesk_ticket_id` field invisibly in the view so that this field is in the fields to be updated with the onchange. It will be correctly updated during the onchange. Override the compute method to obtain the `commercial_partner_id` field in order to take the commercial partner from the helpdesk ticket and not from the task. opw-3759824 Forward-Port-Of: odoo/enterprise#58292 Forward-Port-Of: odoo/enterprise#58043
Currently in Odoo on the Swiss Balance Sheet: 1. Reserven und Jahresgewinn oder Jahresvelust (Main Group) (Reserves and profit or loss for the year) 1.1 Gesetzliche Reserven (Legal Reserves) (2950) 1.1.1 Accounts 2900-2991 What they expect for CH: 1. Reserven und Jahresgewinn oder Jahresvelust (Main Group) (Reserves and profit or loss for the year) 1.1 Gesetzliche Reserven (Legal Reserves) (2950) 1.1.1 Accounts 2900-2991 1.2 Test: Jahresgewinn oder Verlust (Profit or loss for the year (A
Original PR description
Currently in Odoo on the Swiss Balance Sheet: 1. Reserven und Jahresgewinn oder Jahresvelust (Main Group) (Reserves and profit or loss for the year) 1.1 Gesetzliche Reserven (Legal Reserves) (2950) 1.1.1 Accounts 2900-2991 What they expect for CH: 1. Reserven und Jahresgewinn oder Jahresvelust (Main Group) (Reserves and profit or loss for the year) 1.1 Gesetzliche Reserven (Legal Reserves) (2950) 1.1.1 Accounts 2900-2991 1.2 Test: Jahresgewinn oder Verlust (Profit or loss for the year (Annual profit and loss) 1.2.1 Accounts 2992-2999 opw-3668192 Forward-Port-Of: odoo/enterprise#58178
5 changes
Enhancements to existing features
This update improves the clarity and wording of the holiday attestation document in the Belgian payroll module. The changes make the termination holidays report easier to understand for employees and HR staff by refining the language used in the document.
Original PR description
task-3610704
Resolved issues and error corrections
This update standardizes the spacing of alert messages displayed above forms across Odoo, ensuring a consistent visual appearance. Following the recent Milk redesign, all alerts now use the same bottom margin as the status bar, removing previous inconsistencies in how alerts were displayed throughout the system.
Original PR description
Since Milk redesign the margin bottom on the alerts displayed above the sheet in a form view should be mb-2 (equivalent of the margin-bottom of the statusbar). Some alerts across Odoo were still inconsistent. This PR adapts the alerts from enterprise to remove the margin customizations on the impacted alerts. Letting the CSS variable introduced in the community counterpart PR handling the margin. task-3577058 Community PR: https://github.com/odoo/odoo/pull/146196 Forward-Port-Of: odoo/enterprise#58168 Forward-Port-Of: odoo/enterprise#52726
This update corrects an incorrect Serbian translation for the 10% VAT tax rate in Odoo's Serbian localization module. The tax group label is now properly translated to "Opšta stopa PDV-a 10%" instead of the previous invalid translation, ensuring accurate tax documentation and compliance for Serbian users.
Original PR description
Description of the issue/feature this PR addresses: This PR fixes translation of the tax group `Specific VAT rate 10%` Current behavior before PR: When using Serbian language tax group `Specific VAT rate 10%` is translated as `ZALIHE MATERIJALA` which is invalid. Desired behavior after PR is merged: When using Serbian language tax group `Specific VAT rate 10%` will be translated as `Opšta stopa PDV-a 10%` which is correct. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix resolves a validation warning that appears when modules use the post_load hook in their manifest file. The post_load default value is now aligned with other initialization hooks, eliminating false warnings during module testing and ensuring consistent behavior across Odoo versions.
Original PR description
-Step to reproduce: add a post_load method in the init of any module, specify in the manifest like : 'post_load': 'post_load'. Run test_manifests of the test_lint module and we will get warning Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156347 Forward-Port-Of: odoo/odoo#154316
This update ensures consistent spacing for alert messages displayed above form sections across Odoo. The change introduces a unified margin standard (matching the status bar spacing) and removes conflicting spacing rules that were causing visual inconsistencies. This improves the overall appearance and user experience when alerts are shown in forms.
Original PR description
Since Milk redesign the margin bottom on the alerts displayed above the sheet in a form view should be mb-2 (equivalent of the margin-bottom of the statusbar). Some alerts across Odoo were still inconsistent. This PR introduces a custom property `--alert-margin-bottom` which allows the customization of the alert's margin bottom depending on its context. This ensure that an alert rendered in the form view above the form_sheet will receive the appropriate margin as long as there is no utility class or override on the alert with this property, which is why this PR removes the mb-x classes or inner styling on the impacted alerts. task-3577058 Enterprise PR: https://github.com/odoo/enterprise/pull/52726 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156717 Forward-Port-Of: odoo/odoo#146196