This update corrects a bug where the employee search bar incorrectly displayed duplicate results for employees with the same name within the same company. The issue stemmed from a misconfiguration in the search domain, which wasn't properly applied to the front-end search functionality. This ensures accurate and consistent employee search results.

STEP TO REPRODUCE :
​===================

- Select only one company
- Write "marc demo" in employee search bar

You will see two Marc Demo for manager line.

task : 3716448

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

This update corrects a visual inconsistency in mass mailing emails. Previously, applying text color and font size adjustments automatically set the text color to black. Now, the text color will remain the user-defined color, ensuring consistent branding and appearance across all emails.

**Current behavior before PR:**

When we apply a text color and change its font size, the text color defaults to black. This occurs because the default black color is applied to a span within `o_basic_theme.o_layout`.

**Desired behavior after PR is merged:**

Now, when applying text color and adjusting its font size, the color of the text remains unchanged.

task-3770351

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#155715

This update prevents the system from incorrectly flagging changes in x2many fields as modifications, which was causing unnecessary recalculations of SO totals. The fix ensures that the system only updates totals when there's a genuine change in the data, improving performance and stability. This resolves a potential issue impacting SO reporting accuracy.

In some conditions, a x2many field can be considered as modified by the webclient when in fact there is no change in 'meaningful' stored fields.

In this case, on save, an empty list of magic commands will be sent to the server, potentially triggering unexpected recomputations.

Steps to reproduce:

* install sale_stock & sale_management
* create a new storable product
* create a new SO
* create a new line with this product
* Confirm the SO
* Set or Update the SO delivery date (Other info tab)
* Save

-> In the chatter, you will notice an useless tracking value being printed for the SO Total, with identical values before and after update.

Cause

Since the server received an empty list of commands for the `order_line` field, this triggered a recomputation of the total amounts of the SO, even though there were no effective changes in the lines.

Solution

Do not send empty command lists for x2m fields.
This will avoid unexpected recomputation and also improve performance since the fields were recomputed for 'nothing'


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#155549

This update ensures that QR codes are now printed on all receipt reprints. Previously, reprinted receipts lacked this crucial code, causing problems with validating receipts and scanning them. This improvement enhances the reliability of our point-of-sale system and improves the customer experience.

Before this commit, if a receipt was reprinted, the QR code was not included. This could lead to issues with receipt validation and scanning.

opw-3763169

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#156948

This update resolves an issue where record sorting unintentionally disrupted data prefetching and filtered out newly created records. The fix maintains prefetching functionality and avoids filtering new records during sorting, ensuring data integrity and stability.

BaseModel's sorted() has two problems:
- It breaks the prefetch of self for no reason
- When it is called without an argument, it filters out new records
because the search() used in sorted() doesn't return new records.

Keep the same prefetch as self to fix the first problem.
We partially fix/support the second issue, we just avoid filtering out
new records (but we don't actually sort them)

Forward-Port-Of: odoo/odoo#157033
Forward-Port-Of: odoo/odoo#156729

This update fixes an issue where localization modules, like l10n_pe, couldn't properly handle special characters in UBL invoice notes. By allowing localization modules to format the Note node content, this change ensures invoices are correctly displayed and processed across different regions and languages. This improves the accuracy of invoice data.

In UBL 2.0, the Note node can contain the narration field of an invoice. Its content can be some complex HTML.
Some localization (e.g. l10n_pe) doesn't support special characters like '\n' or '\u00A0'.
This fix allows the localization modules to format the value used by Note node.

opw-3744946


Linked enterprise PR: https://github.com/odoo/enterprise/pull/57268

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#155081

This update fixes an issue where link coloring in the Odoo editor was inconsistent, only affecting the first and last links in a list. Now, when a list of links is colored, the font element is correctly created within each link, ensuring consistent background color alignment with the font size. This improves the visual appearance and functionality of the editor.

Currently, when we color a list of links with more than three items in the list, only the first and last links are colored.

Now when the li element is colored in a list, the font element is
created inside the link. We also make sure when the font size is defined
the font element is created inside so that the background color is
aligned with the font size


task-3677214



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#156932
Forward-Port-Of: odoo/odoo#149056

This update corrects a bug that prevented public users from successfully entering their email addresses during Xendit payment transactions. Previously, an error would occur, disrupting donation processing. This fix ensures a smoother payment experience for all users, regardless of their account type.

When there's a payment that involves public user, an error will occur when they've input the email. An example is as you can see on the task when user wants to send donation as a public user

task-3789416



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#157195

This update resolves an issue where custom snippets created from event pages would retain original branding and styling, causing layout problems when the snippet was used elsewhere. The fix ensures that branding is cleaned from snippets before they are saved, preventing this disruption and maintaining consistent page formatting. This improves the reliability of custom content creation.

Steps to reproduce the bug:
- Go to an event "Introduction" page
- Enter edit mode
- Click on the pre-existing "Introduction" title (note that it cannot be removed because of the way the page is built, we might want to improve that in master)
- Save it as a new custom snippet
- Go to your homepage
- Drop that new custom snippet that was saved => It cannot be removed, the rest of the content is kinda broken as
   wells, etc etc.

This is because the original branding was saved with the snippet. Indeed the event pages are made in such a way those pre-defined titles are snippets but which are "editable root elements", i.e. elements whose ancestors cannot be edited since themselves or their neighbors contain dynamic elements.

opw-3633326

Forward-Port-Of: odoo/odoo#157191
Forward-Port-Of: odoo/odoo#157110

This update resolves an issue where a test for image gallery updates could produce unreliable results. The fix adds a deliberate click to ensure the editor panel is refreshed, preventing a potential error caused by checking outdated values. This improves the stability and reliability of the image gallery feature.

[FIX] website: adapt test tour to avoid undeterministic error

Since [1], image options like "Filter" are kept when a user changes the
position of an image in an "Image Gallery" snippet. [1] also adapted the
`snippet_image_gallery` tour (moved in `snippet_image_gallery_reorder`
from version 16) to test this behavior. To do so, the test adds a filter
on an image in an "Image Gallery" snippet, checks that the filter is
displayed on the editor panel, moves the image, clicks on it and finally
checks that the filter is still displayed on the editor panel. The
problem is that the steps that check if the filter is displayed on the
editor panel are the same before and after the move of the image which
means that the second check is true also before the move of the image.
This situation is a typical case where an undeterministic error could
happen. Indeed, we do not know if the second check tests an old value or
an updated one.

To solve the problem, the test has been adapted; after the move of the
image, the test clicks somewhere else (on the footer in this case), and
then back on the moved image to finally check that the filter is still
displayed on the editor panel. The goal of the click on the footer is to
be sure to have a loaded version of the editor panel. By doing so, we
remove the risk of an undeterministic error situation where a condition
is already true before an action is done.

Note: this problem has been discovered because the test
`snippet_image_gallery_reorder` succeeds on version 16.3 without the fix
of [1]. Now, the adapted test fails on version 16.3 without the fix of
[1].

[1]: https://github.com/odoo/odoo/commit/0fd2477d993e822fe6fd4497aace9f746af7a481

task-3717041

Forward-Port-Of: odoo/odoo#156943
Forward-Port-Of: odoo/odoo#153014

This update fixes a gap in our HR contract management system by adding essential fields. Previously, certain contract details were not consistently tracked, leading to potential data inconsistencies. Now, all contracts will include the required information, improving accuracy and streamlining HR processes.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#157012

This update corrects a problem where deleting an action in Odoo would sometimes display an error message related to a missing filter. The fix ensures that user-defined filters are automatically removed when their parent action is deleted, preventing these errors and improving data consistency.

When deleting records from ir.action.action, the user-defined filters(ir.filters) will not be deleted automatically, thus causing an error. 

Steps to reproduce:
- Create a User-defined Filter under any action
- Remove that action
- Go to User-defined Filter again

-> There will be an error message pop out that says action record does not exist

Cause
The User-defined Filters will not be automatically removed when the parent action gets deleted

Solution
Remove all the User-defined Filters when deleting the parent action

Forward-Port-Of: odoo/odoo#156622

This update fixes a display issue where the domain picker incorrectly reversed in RTL mode, showing email addresses in the wrong format (domain@alias instead of alias@domain). Now, the domain picker functions correctly regardless of the user's language settings, ensuring accurate email address display.

**Description of the issue/feature this PR addresses:**
This PR resolves an issue where the domain picker was being unintentionally reverted in RTL mode, leading to a disruption in the email format.

**Current behavior before PR:**
Switching to RTL mode would inadvertently revert the domain picker, causing a disruption in the email format. The expected format is Alias@domain, but it was displaying as domain@alias.

**Desired behavior after PR is merged:**
Now, the domain picker remains intact in RTL mode, ensuring that the email format is correctly displayed as alias@domain.

Task link: https://www.odoo.com/web#model=project.task&id=3624012
Task-3624012


---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#157091
Forward-Port-Of: odoo/odoo#154834

This update resolves an issue where the email composer could display inconsistent data due to user-specific inconsistencies. The fix ensures that the composer consistently accesses reliable information, leading to a more stable and accurate email creation experience. This improves the overall reliability of the email functionality.

Avoid accessing inconsistent data based on the user

Forward-Port-Of: odoo/odoo#157098

A recent test related to Odoo's image handling was intermittently failing. This update increases the test's waiting period, ensuring the image is properly set before the test completes. This resolves a minor issue that could have impacted the reliability of image functionality.

Before this commit, the changed test sometimes failed because we expected the image to be set, but it wasn't (yet). This commit increases the delay.

Runbot error 56099

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#157335

This pull request updates the core spreadsheet component used in Odoo. It addresses several bug fixes and performance improvements related to data validation, calculations, and autofill functionality, ensuring a smoother and more reliable spreadsheet experience for users. These changes contribute to overall stability and efficiency within the Odoo platform.

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/3a9f33458 [REL] 17.1.7
https://github.com/odoo/o-spreadsheet/commit/7d7fddba9 [FIX] header_positions: perfs of update style Task: 3797400
https://github.com/odoo/o-spreadsheet/commit/41682f930 [PERF] functions: return #N/A instead of throwing Task: 3775565
https://github.com/odoo/o-spreadsheet/commit/1c3a9fca1 [FIX] automatic_sum: wrong behaviour with spreaded values Task: 3782971
https://github.com/odoo/o-spreadsheet/commit/2133f544a [FIX] DataValidationCheckbox: Fix input positioning in FF Task: 3774645
https://github.com/odoo/o-spreadsheet/commit/81b1983d8 [FIX] evaluation: ensure value to evaluated cell
https://github.com/odoo/o-spreadsheet/commit/1b104b810 [FIX] GridComposer: Reset the cell reference visibility on stop edition Task: 3736211
https://github.com/odoo/o-spreadsheet/commit/99390b35a [FIX] data validation: checkbox not disabled in readonly Task: 3773923
https://github.com/odoo/o-spreadsheet/commit/f2fe5d0a7 [IMP] data validation: performance of icons Task: 3773923
https://github.com/odoo/o-spreadsheet/commit/ce113cc3c [PERF] evaluation: apply compute function Task: 3775636
https://github.com/odoo/o-spreadsheet/commit/b1aeca88d [FIX] autofill: allow to autofill a mix of number values and formulas Task: 3700733

This update fixes an issue where images, like user profile pictures, weren't loading correctly when viewed outside of the current record. The system was using an outdated method for caching images, leading to inconsistent display. This change ensures all images, including user images, load properly in Kanban and Activity views.

The way we cache the image is not right when that image is not on the current record. For instance displaying a partner/user image. The unique key used is not related to that record.

Introduced by https://github.com/odoo/odoo/pull/97544

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#157199
Forward-Port-Of: odoo/odoo#157004

This update ensures that a unique security identifier (secure_sequence_id) is automatically created when a new journal is set up with specific security restrictions. Previously, this ID wasn't generated unless the journal was manually modified. This change improves security by consistently tracking journal configurations and preventing potential vulnerabilities.

**Description of the issue/feature this PR addresses:**
The secure_sequence_id is not generated when creating a journal with restrict_mode_hash_table set to True. It only happens if you trigger a write() on the record. Even changing it's name on edit triggers the creation of the sequence.

On runbot is correctly created because account_check_printing triggers a write() after the create of the account.journal. But this module is not a dependency from account (or any of it's dependencies) and if it is uninstalled, this behaviour occurs.

**Current behavior before PR:**
When creating an account.journal with restrict_mode_hash_table set to True we should generate the secure_sequence_id but it's not happing. It is only contemplated on the write() 

**Desired behavior after PR is merged:**
When creating an account.journal with restrict_mode_hash_table set to True we generate the secure_sequence_id.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#157134
Forward-Port-Of: odoo/odoo#155188

This update addresses a technical issue within the Odoo system related to a test for user avatars. The original fix attempted a problematic workaround, which has now been removed. This change ensures the test runs correctly and maintains the system's stability.

This PR fixes an infinite setTimout loop in a m2x avatar test. Patching the setTimeout method is not a good idea anyway since it makes it synchronous which totally changes the flow that is tested.

This PR removes this patch as the assertion that relies on it is too technical anyway.

fixes runbot-55891

This update resolves an issue where non-administrator users were unable to access journal items within the accounting module. Previously, access was restricted, preventing users from performing essential accounting tasks. This change ensures all users, regardless of their permissions, can manage journal items correctly.

Steps to reproduce:
- Install Accounting
- Connect with a user without "Administration: Settings" rights (e.g. Marc Demo)
- Go to "Accounting / Accounting / Journals / Journal Items"

Issue:
An Access Error is raised when trying to access a "ir.ui.view" record that is restricted to "Administration/Settings" group.

opw-3787114

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#157363

Documents that are only useful for demonstrations have been moved out of the standard Documents setup and into demo data. This keeps regular databases cleaner while preserving example content for demo environments.

Since https://github.com/odoo/enterprise/commit/f3c1cecf1583e0185d1bd75e757ce45b1912299a, some documents are added in Documents data. These documents are not meant to be installed on each databases, and only serve demonstration purposes. This commit therefore moves those documents data to demo data and reorder items in alphabetical order.

This update adjusts how several apps use database indexes to reduce unnecessary storage and improve search behavior where it matters. Helpdesk searches should better support partial text matching, while Knowledge, Marketing Automation, and Subscriptions avoid overly broad indexes that may slow maintenance without clear benefit.

See  odoo/odoo#135057 for the core ideas. This just applies them in locations triggering warnings.

This update aligns Belgian payroll accounting tests with a simplified leave duration setup. It reduces reliance on duplicate leave-related fields, helping keep payroll test maintenance simpler and more consistent.

Before this commit, there was way too much fields related to the duration of the leave in `hr_holidays`:
- number_of_days
- number_of_hours
- number_of_days_display
- number_of_hours_display
- number_of_hours_text
- duration_display

This commit only adapts the enterprise code to the change that only keeps `number_of_days`, `number_of_hours` and `duration_display` to simplify things.

Appraisal surveys now rely on a shared availability setting to decide when live session options should appear. This keeps appraisal survey screens cleaner and reduces duplicated customization, with no live sessions enabled for appraisals.

Where possible, use the newly introduced `session_available` field to identify whether to show options allows to reduce views overrides.

See related COM PR, where this field is an opt-in method based on survey_type, such that no live session is enabled for appraisals.

Task-2803327

The Documents app no longer shows the split PDF scissors button in the inspector when viewing documents from the Activity view. This avoids offering an action in a context where it should not be available, making the interface clearer for users managing activities.

Before this commit:
- Switch to the Activity view
- Schedule an activity for any PDF file and select it
- The scissor (split PDF) button is present on the inspector

After this commit:
- We remove the scissor (split PDF)  button from the inspector.

Task-3770691

The HR demo data has been adjusted so the Marc Demo manager account no longer receives extra access rights across related apps. Payroll conflict messages were also made clearer by showing the employee name, helping teams identify issues faster.

Expired or refused salary offers no longer show the salary configurator or send by email buttons. This helps prevent users from taking actions that are no longer relevant for inactive offers.

With this commit, when an offer is expired or refused, these buttons : "salary configurator" and "send by email" are hidden.

task : 3746557

Several payroll and project messages now use a shared formatting helper instead of manually building lists. This improves consistency and makes translated text read more naturally for users in different languages.

*=hr_payroll_account,project_enterprise,project_holidays

This PR replaces a few occurrences of list being manually constructed by making use of the new helper.

Task-3506960

Community: https://github.com/odoo/odoo/pull/154395

This update refreshes how Odoo works with PDF files across delivery, documents, payroll, and signing features. It keeps these workflows compatible with the newer PDF library version without changing the intended user experience.

This pull request updates internal automated tests across several Odoo Enterprise apps so they align with upcoming changes in the shared testing framework. It should not change day-to-day product behavior, but helps keep future upgrades smoother and reduces maintenance risk.

See individual commits.

https://github.com/odoo/odoo/pull/157058

In commit 355250d, the domain was adjusted to automatically select the invoice document type for customers with a RUC and limit others to the "boleta" document type. This generally holds true, except for export invoices requiring the 01 document type. This commit addresses the current restriction, allowing the selection of document type 01 other than "boleta" or "debit note boleta." For this, inherit the compute method, and extend the depends to add the operation type and allow generate invoi

In commit 355250d, the domain was adjusted to automatically select the invoice document type for customers with a RUC and limit others to the "boleta" document type. This generally holds true, except for export invoices requiring the 01 document type. This commit addresses the current restriction, allowing the selection of document type 01 other than "boleta" or "debit note boleta."

For this, inherit the compute method, and extend the depends to add the operation type and allow generate invoice for exportation cases.

[Odoo PR related](https://github.com/odoo/odoo/pull/154511)

Forward-Port-Of: odoo/enterprise#56465

…ct warning * a regular user error can be displayed user-side instead of the redirect warning, in case we don't want to propose to contact the support (in case there's no need) Forward-Port-Of: odoo/enterprise#58308 Forward-Port-Of: odoo/enterprise#56935

…ct warning

* a regular user error can be displayed user-side instead of the redirect warning, in case we don't want to propose to contact the support (in case there's no need)

Forward-Port-Of: odoo/enterprise#58308
Forward-Port-Of: odoo/enterprise#56935

Steps to reproduce: - Install Accounting and l10n_pe_edi - Switch to a Peruvian company (e.g. PE Company) - Configure Peruvian localization (https://www.odoo.com/documentation/17.0/applications/finance/fiscal_localizations/peru.html) - Create an invoice: * Customer: Comercial Constructora los Patitos S.A. * Operation Type: [0101] Internal sale * Invoice Lines: - Product: Arroz descascarillado (arroz cargo o arroz pardo) - Taxes: 18% - Terms and Conditions: [text containing

Steps to reproduce:
- Install Accounting and l10n_pe_edi
- Switch to a Peruvian company (e.g. PE Company)
- Configure Peruvian localization (https://www.odoo.com/documentation/17.0/applications/finance/fiscal_localizations/peru.html)
- Create an invoice:
  * Customer: Comercial Constructora los Patitos S.A.
  * Operation Type: [0101] Internal sale
  * Invoice Lines:
    - Product: Arroz descascarillado (arroz cargo o arroz pardo)
    - Taxes: 18% - Terms and Conditions: [text containing several consecutive spaces and/or several lines]
- Confirm the invoice
- Process UBL 2.1

Issue:
The service responds with an error because the <cbc:Note> node doesn't comply with the supported format.
Special characters like '\n' and '\u00A0' are not supported.

opw-3744946


Linked community PR: https://github.com/odoo/odoo/pull/155081

Forward-Port-Of: odoo/enterprise#57268

**Issue** website_appointment_tour was not working properly because of some changes done in the mail.py and appointment app. **After this PR** Now the appointment tour is working perfectly as expected. Task-3774280 Forward-Port-Of: odoo/enterprise#57898

**Issue**
website_appointment_tour was not working properly because of some changes done in the mail.py and appointment app.

**After this PR**
Now the appointment tour is working perfectly as expected.

Task-3774280

Forward-Port-Of: odoo/enterprise#57898

task-3610704 Forward-Port-Of: odoo/enterprise#52297

task-3610704

Forward-Port-Of: odoo/enterprise#52297

This commit fixes an issue with the comments panel when creating comment. When you have the panel opened and you want to create a comment, after logging your message the temporary box is not removed, leading to issues like boxes not being handled or crashes. This is caused because when syncing the handler and the panel when creating the comment, the insertion function was still the one from the handler meaning that the KnowledgeComment was not using the correct function which led to thos

This commit fixes an issue with the comments panel when creating comment.
When you have the panel opened and you want to create a comment, after logging
your message the temporary box is not removed, leading to issues like boxes not
being handled or crashes.

This is caused because when syncing the handler and the panel when creating the
comment, the insertion function was still the one from the handler meaning that
the KnowledgeComment was not using the correct function which led to those
issues.

Now when the panel is adding the comment from the handler we change the
function so that it uses the correct one.

task-3792116

Forward-Port-Of: odoo/enterprise#58253

Forward-Port-Of: odoo/enterprise#58326

Forward-Port-Of: odoo/enterprise#58326

Steps to reproduce: ------------------- 1. Install sale_planning (without demo data) 2. Create a service product with "Plan Services" activated 3. Create an SO with this product and confirm the SO 4. Click on "To Plan" stat button 5. Click on any pill to create a new slot 6. The traceback occurs The traceback also occurs in the following scenario: ------------------- 1. Install sale_planning (without demo data) 2. Open Planning > Schedule > By Role 3. Click on any pill to create a

Steps to reproduce:
-------------------
1. Install sale_planning (without demo data)
2. Create a service product with "Plan Services" activated
3. Create an SO with this product and confirm the SO
4. Click on "To Plan" stat button
5. Click on any pill to create a new slot
6. The traceback occurs

The traceback also occurs in the following scenario:
-------------------
1. Install sale_planning (without demo data)
2. Open Planning > Schedule > By Role
3. Click on any pill to create a new slot
4. The traceback occurs

Fix:
-------------------
When there is no demo data/records, the gantt view uses sample data. In which for instance, the role_id field is randomly generated. So when clicking on the pill to create a new slot with the given role_id, the corresponding 'planning.role' record is not found, resulting in a traceback. To fix that, we check if the sample data is enabled, in which case we ignore the "fake" ids given by the sample records.

task-3777485

Forward-Port-Of: odoo/enterprise#58096

Steps to reproduce: - - Create an SO with two lines containing the product “Field Service” - Confirm the SO > 2 fsm tasks are created - Open the first task > access catalog via the `Products` smartbutton - Add any product to the SO. - Open the second task > access catalog via the `Products` smartbutton - Add the same product to the SO. - Open the first task > access catalog via the `Products` smartbutton - Try to add more of that product **IMPOSSIBLE : “You can’t edit this product in

Steps to reproduce:
-
- Create an SO with two lines containing the product “Field Service”
- Confirm the SO > 2 fsm tasks are created
- Open the first task > access catalog via the `Products` smartbutton
- Add any product to the SO.
- Open the second task > access catalog via the `Products` smartbutton
- Add the same product to the SO.
- Open the first task > access catalog via the `Products` smartbutton
- Try to add more of that product

**IMPOSSIBLE : “You can’t edit this product in the catalog”**

Cause of the issue:
-
The way the catalogue is computed was refactored between 16.4 and 17.0 see:
odoo commit bc01c7bcec974ee095f5855f225667645ef40213 
The above situtation is not yet handled by this refactoring. In 16.4, since the catalogue was acceced from the task linked to the Field service, the quantities it displayed were computed with respect to that task. However, in 17.0 the quantities appearing in the catalogue are computed from the main SO containing both `Field services` SOL instead of being computed contextually from the task they are linked to.

To be more precise:
-
When clicking on the smart button, the quantities appearing in the calatalogue are computed by the `_get_product_catalog_order_line_info`. This method starts by grouping the SOL referencing each product of the catalogue using the `_get_product_catalog_record_lines`: https://github.com/odoo/odoo/blob/c7f982774654459a2db6decd6ae1948e05e7d622/addons/product/models/product_catalog_mixin.py#L91-L92 https://github.com/odoo/odoo/blob/c7f982774654459a2db6decd6ae1948e05e7d622/addons/sale/models/sale_order.py#L1823-L1829 
But here is the problem, since both SOL were able to reference the same product of the catalogue the product of the catalog will be set to 'readOnly' here (because `self` will contain both SOL): https://github.com/odoo/odoo/blob/c91ffa3bdbff845088111bc3036500c2c03fc357/addons/sale/models/sale_order_line.py#L1222-L1227 
Hence, we will not be able to edit its value from the catalogue: https://github.com/odoo/odoo/blob/c91ffa3bdbff845088111bc3036500c2c03fc357/addons/product/static/src/product_catalog/order_line/order_line.xml#L18-L20

Fix:
-
As discussed with the PO of the Field Service module (see conversation of the ticket), the catalogue should be computed contextually using the task from which we access it and not from all tasks referring to that product in the main SO. Doing so will solve the problem since only one SOL will be associated to that product of the catalogue and the product will be set to `'readOnly' : False`:
https://github.com/odoo/odoo/blob/c91ffa3bdbff845088111bc3036500c2c03fc357/addons/sale/models/sale_order_line.py#L1212-L1216

opw-3748833
---

Forward-Port-Of: odoo/enterprise#57561

**Step to reproduce:** - Insert a view using /item list or /item kanban in knowledge - Open dropdown on any of the view - Click within that view anywhere outside dropdown - you notice that dropdown did't close **Issue:** Dropdown did't close when clicking within the embedded view. **Technical Reason:** There is a function called onWindowClick in the dropdown.js file, inside which we get different values in 'this.ui.activeElement' and 'this.nyActiveEl', so the dropdown doesn't

**Step to reproduce:**

- Insert a view using /item list or /item kanban in  knowledge
- Open dropdown on any of the view
- Click within that view anywhere outside dropdown
- you notice that dropdown did't close

**Issue:**

Dropdown did't close when clicking within the embedded view.

**Technical Reason:**

There is a function called onWindowClick in the dropdown.js file, inside which we get different values in 'this.ui.activeElement' and 'this.nyActiveEl', so the dropdown doesn't close.

**Before this commit:**

When we insert an embedded view, and the user opens any dropdown and after that, if the user clicks within the embedded view that dropdown is not closing.

**After this commit:**

Removing the condition related to 'this.ui.activeElement' and 'this.myActiveEl' means that now, In the embedded view, when opening the dropdown menu, clicking within that view close the dropdown.

task-3717014

Forward-Port-Of: odoo/enterprise#57471
Forward-Port-Of: odoo/enterprise#56366

This update removes a test for Mexican electronic invoicing (EDI) that was failing consistently due to missing test data. The fix also improves error messages to help diagnose future test failures. This ensures the test suite runs reliably without false failures.

The test for `sw` fails every time because we don't have identifiers. 
We don't have any, so we just get rid of the test. 
Also added the message to the error, so we can know why it failed. 
(Other tests failed some time, but we can't reproduce and know why it failed).

Linked to runbot error 25908

Forward-Port-Of: odoo/enterprise#58443

This update fixes a test that was checking the same condition before and after moving an image, which could lead to unpredictable test failures. The test now includes an extra step to refresh the editor panel between actions, ensuring it properly validates that image filters are preserved when images are repositioned in the gallery.

[FIX] website: adapt test tour to avoid undeterministic error

Since [1], image options like "Filter" are kept when a user changes the
position of an image in an "Image Gallery" snippet. [1] also adapted the
`snippet_image_gallery` tour (moved in `snippet_image_gallery_reorder`
from version 16) to test this behavior. To do so, the test adds a filter
on an image in an "Image Gallery" snippet, checks that the filter is
displayed on the editor panel, moves the image, clicks on it and finally
checks that the filter is still displayed on the editor panel. The
problem is that the steps that check if the filter is displayed on the
editor panel are the same before and after the move of the image which
means that the second check is true also before the move of the image.
This situation is a typical case where an undeterministic error could
happen. Indeed, we do not know if the second check tests an old value or
an updated one.

To solve the problem, the test has been adapted; after the move of the
image, the test clicks somewhere else (on the footer in this case), and
then back on the moved image to finally check that the filter is still
displayed on the editor panel. The goal of the click on the footer is to
be sure to have a loaded version of the editor panel. By doing so, we
remove the risk of an undeterministic error situation where a condition
is already true before an action is done.

Note: this problem has been discovered because the test
`snippet_image_gallery_reorder` succeeds on version 16.3 without the fix
of [1]. Now, the adapted test fails on version 16.3 without the fix of
[1].

[1]: https://github.com/odoo/odoo/commit/0fd2477d993e822fe6fd4497aace9f746af7a481

task-3717041

Forward-Port-Of: odoo/odoo#156943
Forward-Port-Of: odoo/odoo#153014

This update corrects how a tax destination field is hidden in the partner view table. The system was using an incorrect display attribute that wasn't working properly in table layouts. The fix ensures the field is properly hidden from users when viewing partner tax information.

In one2many, for the view, the attribute to hide a field should be column_invisible and not invisible





---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

This update resolves a testing issue in the web module where image field tests were failing intermittently due to timing problems. The fix increases the delay in the test to ensure images are fully loaded before validation, improving test reliability and reducing false failures.

Before this commit, the changed test sometimes failed because we expected the image to be set, but it wasn't (yet). This commit increases the delay.

Runbot error 56099

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#157335

This update corrects a typo in the stock move module where the cancellation state was incorrectly named. The proper state for cancelled stock moves is now correctly set to "cancel". This ensures inventory operations are properly tracked and reported when orders are cancelled.

Correct state for stock move is "cancel".

**opw-3783252**