Odoo Changelog — 2024-04-27

Saturday, April 27, 2024

3 changes · 17.0

Bug Fixes(3)

Resolved issues and error corrections

[FW][FIX] l10n_cl_edi_stock: fix delivery guide report with no demand

Enterprise17.0l10n_cl_edi_stockHIGH

This fix resolves a critical error that occurred when printing delivery guide reports for Chilean shipments with no demand quantity. The system was attempting to divide by zero when calculating unit prices. The fix now uses the completed quantity instead of demand quantity for price calculations, ensuring reports can be generated successfully even when products are added manually to deliveries.

Original PR description

**Steps to reproduce:**
- Install Sales and l10n_cl_edi_stock
- Switch to a Chilean company (e.g. CL Company)
- Create a SO:
  * Customer: [a Chilean customer] (e.g. Blanco Martin & Asociados EIRL)
  * Product: [any storable product with quantity on hand]
- Confirm the invoice
- Go to the delivery
- In "Detailed Operations" tab, add a product with "Done" set to 1
- Save the delivery
=> In "Operations" tab, "Demand" of the added product should be 0
- Do not validate the delivery
- Click on "Print > Delivery Guide SII DTE 52 (CL)"

**Issue:**
A traceback is raised due to a division by 0.

**Cause:**
The Total price of a product line is computed from its "Demand" quantity.
It's also the case for the price unit that is computed with this formula: `(Total price / Demand quantity)` where Demand quantity is 0 in this case.

**Solution:**
The computation can be made from "Done" quantity.

opw-3873020

Forward-Port-Of: odoo/enterprise#61612
Forward-Port-Of: odoo/enterprise#61377

#Chile#delivery#reporting#bug fix

[FW][FIX] account: fix taxes proposition in fiscal position of branch

PR #163552

Core17.0accountMEDIUM

This fix resolves an issue where users couldn't select taxes from the parent company when creating fiscal positions in a branch company. Previously, the tax mapping feature in fiscal positions was not properly configured to access parent company taxes, limiting functionality for multi-company setups. This update enables proper tax selection for branch companies.

Original PR description

Steps to reproduce:
- Install Accounting
- Go to "Settings / Users & Companies / Companies"
- Create a branch company (e.g. Branch Company) for a company (e.g. YourCompany)
- Switch to Branch Company
- Create a fiscal position

Issue:
It is not possible to select the taxes from the parent company in the tax mapping.

opw-3850514



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#162872

#fiscal-position#taxes#branch-company#multi-company

[FW][FIX] l10n_sa_edi: fix scheme ID for foreign customers

PR #163652

Core17.0l10n_sa_ediMEDIUM

This fix resolves an issue where invoices for customers outside Saudi Arabia were failing ZATCA validation. The system now correctly uses the customer's VAT number as their identification in electronic invoices when they don't have a Saudi-specific identification number, ensuring compliance with tax authority requirements.

Original PR description

**Steps to reproduce:** - Install Contacts, Accounting and l10n_sa_edi - Switch to a Saudi Arabian company (e.g. SA Company) - Create a contact who is not in Saudi Arabia: * Address: [Complete…

**Steps to reproduce:**
- Install Contacts, Accounting and l10n_sa_edi
- Switch to a Saudi Arabian company (e.g. SA Company)
- Create a contact who is not in Saudi Arabia:
  * Address: [Complete address in United Arab Emirates]
  * VAT: [any]
- Create an invoice:
  * Customer: [The created contact]
  * Product: [any]
- Confirm the invoice
- Process by ZATCA

**Issue:**
The following warning is returned:
"The other Buyer ID (BT-46) must present in the tax invoice and associated debit notes and credit notes (KSA-2, position 1 and 2 = 01), where the buyer VAT registration number or buyer group VAT registration number (BT-48) is not provided."

**Cause:**
"PartyIdentification" element is not set in the electronic invoice for customer because he doesn't have "l10n_sa_additional_identification_number" field set.
This field is only available for contacts living in Saudi Arabia.
For contacts who don't live in Saudi Arabia, "PartyIdentification" should be populate with their VAT number.

opw-3845645



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#162809

#Saudi Arabia#ZATCA#invoice validation#foreign customers#tax compliance

**Steps to reproduce:** - Install Sales and l10n_cl_edi_stock - Switch to a Chilean company (e.g. CL Company) - Create a SO: * Customer: [a Chilean customer] (e.g. Blanco Martin & Asociados EIRL) * Product: [any storable product with quantity on hand] - Confirm the invoice - Go to the delivery - In "Detailed Operations" tab, add a product with "Done" set to 1 - Save the delivery => In "Operations" tab, "Demand" of the added product should be 0 - Do not validate the delivery - Click on "Print > Delivery Guide SII DTE 52 (CL)" **Issue:** A traceback is raised due to a division by 0. **Cause:** The Total price of a product line is computed from its "Demand" quantity. It's also the case for the price unit that is computed with this formula: `(Total price / Demand quantity)` where Demand quantity is 0 in this case. **Solution:** The computation can be made from "Done" quantity. opw-3873020 Forward-Port-Of: odoo/enterprise#61612 Forward-Port-Of: odoo/enterprise#61377

Steps to reproduce: - Install Accounting - Go to "Settings / Users & Companies / Companies" - Create a branch company (e.g. Branch Company) for a company (e.g. YourCompany) - Switch to Branch Company - Create a fiscal position Issue: It is not possible to select the taxes from the parent company in the tax mapping. opw-3850514 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#162872

**Steps to reproduce:** - Install Contacts, Accounting and l10n_sa_edi - Switch to a Saudi Arabian company (e.g. SA Company) - Create a contact who is not in Saudi Arabia: * Address: [Complete address in United Arab Emirates] * VAT: [any] - Create an invoice: * Customer: [The created contact] * Product: [any] - Confirm the invoice - Process by ZATCA **Issue:** The following warning is returned: "The other Buyer ID (BT-46) must present in the tax invoice and associated debit notes and credit notes (KSA-2, position 1 and 2 = 01), where the buyer VAT registration number or buyer group VAT registration number (BT-48) is not provided." **Cause:** "PartyIdentification" element is not set in the electronic invoice for customer because he doesn't have "l10n_sa_additional_identification_number" field set. This field is only available for contacts living in Saudi Arabia. For contacts who don't live in Saudi Arabia, "PartyIdentification" should be populate with their VAT number. opw-3845645 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#162809