Daily updates from Odoo
Thursday, May 2, 2024
21 changes
13 changes
Features or functions removed from Odoo
An unused action for opening subscriptions was removed from the Sales Subscription area. This is a small cleanup that reduces maintenance overhead without changing expected user workflows.
Original PR description
In this commit, the "action_open_subscriptions" function is no longer utilized, hence it has been removed. task-3860359
Miscellaneous changes
- Adds missing section D and E to the tax report. - Change line 43 to editable instead of aggregation. Forward-Port-Of: odoo/enterprise#61557 Forward-Port-Of: odoo/enterprise#57367
Original PR description
- Adds missing section D and E to the tax report. - Change line 43 to editable instead of aggregation. Forward-Port-Of: odoo/enterprise#61557 Forward-Port-Of: odoo/enterprise#57367
… variables To be able to render a human-readable qweb, we need to evaluate some arbitrary python expressions. Thos can produce bad sql queries because at this point, we are not, by construction in the conditions that produce correct queries (missing records etc....) Before this commit, when an query error occured at that step, the whole transaction was corrupted, and crashed the whole thing. After this commit, we do our partial evaluation things in a separate cursor, to avoid polluting
Original PR description
… variables To be able to render a human-readable qweb, we need to evaluate some arbitrary python expressions. Thos can produce bad sql queries because at this point, we are not, by construction in the conditions that produce correct queries (missing records etc....) Before this commit, when an query error occured at that step, the whole transaction was corrupted, and crashed the whole thing. After this commit, we do our partial evaluation things in a separate cursor, to avoid polluting the main one. opw-3815284 Forward-Port-Of: odoo/enterprise#60754
This commit moves the call for the Banxico currency update to the IAP server, where we can create a daily cache of currency rates. Part of: task-3749574 Forward-Port-Of: odoo/enterprise#61726 Forward-Port-Of: odoo/enterprise#58685
Original PR description
This commit moves the call for the Banxico currency update to the IAP server, where we can create a daily cache of currency rates. Part of: task-3749574 Forward-Port-Of: odoo/enterprise#61726 Forward-Port-Of: odoo/enterprise#58685
`Net profit/Loss for the Year` report.line has now an aggregation expression[1] which cannot have a groupby. But as the groupby field was removed instead of set to `eval=False`. The groupby is still there and blocking upgrades to 16.0 and 17.0 [1] https://github.com/odoo/enterprise/pull/52157 ``` File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 567, in _tag_root raise ParseError(msg) from None # Restart with "--log-handler odoo.tools.convert:DEBUG" for complete traceback
Original PR description
`Net profit/Loss for the Year` report.line has now an aggregation expression[1] which cannot have a groupby. But as the groupby field was removed instead of set to `eval=False`. The groupby is still there and blocking upgrades to 16.0 and 17.0
[1] https://github.com/odoo/enterprise/pull/52157
```
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 567, in _tag_root
raise ParseError(msg) from None # Restart with "--log-handler odoo.tools.convert:DEBUG" for complete traceback
odoo.tools.convert.ParseError: while parsing /home/odoo/src/enterprise/17.0/l10n_no_reports/data/profit_loss.xml:3
Groupby feature isn't supported by aggregation engine. Please remove the groupby value on 'Net profit/Loss for the Year'
View error context:
'-no context-'
```
Forward-Port-Of: odoo/enterprise#61445[IMP] l10n_mx : Update master data with new Exento tax and fix the XML reader issues Add a new tax, Exento, to the master data of the module l10n_mx, change the fiscal position 'Foreign Customer' and add a new tax group for Exento. Add the Exento tax recognition for the XML reader for vendor bills. task id: 3774996 Forward-Port-Of: odoo/enterprise#61701 Forward-Port-Of: odoo/enterprise#60107
Original PR description
[IMP] l10n_mx : Update master data with new Exento tax and fix the XML reader issues Add a new tax, Exento, to the master data of the module l10n_mx, change the fiscal position 'Foreign Customer' and add a new tax group for Exento. Add the Exento tax recognition for the XML reader for vendor bills. task id: 3774996 Forward-Port-Of: odoo/enterprise#61701 Forward-Port-Of: odoo/enterprise#60107
The `send as message` macro for the template/clipboard block is only supposed to open and edit the message composer on the target form view, then discard it. The form view does not become dirty because of that. However it has been observed that on some Odoo versions, the form view sometimes becomes dirty (indeterministic factor), which is unrelated to the successful macro operation. Therefore it has been decided to always attempt to discard the form so that the test does not fail no matter
Original PR description
The `send as message` macro for the template/clipboard block is only supposed to open and edit the message composer on the target form view, then discard it. The form view does not become dirty because of that. However it has been observed that on some Odoo versions, the form view sometimes becomes dirty (indeterministic factor), which is unrelated to the successful macro operation. Therefore it has been decided to always attempt to discard the form so that the test does not fail no matter if the view is dirty or not during the test. runbot error 62459 Forward-Port-Of: odoo/enterprise#61705 Forward-Port-Of: odoo/enterprise#61682
Added bold formatting to the header text in the template preview to help users distinguish it from the body text. A new line is added between the header and body text in the template preview for the same reason. Task - 3605612 Forward-Port-Of: odoo/enterprise#59143
Original PR description
Added bold formatting to the header text in the template preview to help users distinguish it from the body text. A new line is added between the header and body text in the template preview for the same reason. Task - 3605612 Forward-Port-Of: odoo/enterprise#59143
As seen in support tickets, other errors can be raised by PyPDF2 when trying to compute pages count on corrupted files. As we are not going to do any kind of handling and must not crash because of this, we'll simply log and discard any non-exit exception raised. Task-3614532 Forward-Port-Of: odoo/enterprise#59026
Original PR description
As seen in support tickets, other errors can be raised by PyPDF2 when trying to compute pages count on corrupted files. As we are not going to do any kind of handling and must not crash because of this, we'll simply log and discard any non-exit exception raised. Task-3614532 Forward-Port-Of: odoo/enterprise#59026
**Version:** - saas-16.3 **Step to reproduce:** - Create a subscription product with the type set to 'product' - Create a BOM for that product with the BOM type set to 'kit' - In the component, add any product with the type 'product' - Create a sale order with the products that are created and generate an invoice - Upon creating the next invoice for the subscription product, the picking was not being generated. **Issue:** Currently, if the product type is set to 'product' and
Original PR description
**Version:** - saas-16.3 **Step to reproduce:** - Create a subscription product with the type set to 'product' - Create a BOM for that product with the BOM type set to 'kit' - In the component, add any product with the type 'product' - Create a sale order with the products that are created and generate an invoice - Upon creating the next invoice for the subscription product, the picking was not being generated. **Issue:** Currently, if the product type is set to 'product' and recurring_invoice is true, and the product has a bill of materials (BOM) with the type 'kit' the picking was not created after the first invoice. **Solution:** If the product has a subscription, the quantity for BOM kits will not be updated. task-3681597 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/enterprise#61610 Forward-Port-Of: odoo/enterprise#56121
Steps to reproduce ================== - Open studio on a form view - Edit something - Click on "Restore default view" => Nothing visually happens and the changes stays Forward-Port-Of: odoo/enterprise#61236 Forward-Port-Of: odoo/enterprise#60009
Original PR description
Steps to reproduce ================== - Open studio on a form view - Edit something - Click on "Restore default view" => Nothing visually happens and the changes stays Forward-Port-Of: odoo/enterprise#61236 Forward-Port-Of: odoo/enterprise#60009
Currently, it's not possible to create a form on `event.event` because website_studio doesn't check whether `/event` already exists. Steps: - Install `website_studio` and `website_event` - Open `Events` - Open `Studio` - Click on `Website` tab - Try to add a new form by clicking on `New Form` - Studio doesn't create a new form because it points to /event which already exists (created by `website_event`). This commit verifies that the route doesn't exist before creating it.
Original PR description
Currently, it's not possible to create a form on `event.event` because website_studio doesn't check whether `/event` already exists. Steps: - Install `website_studio` and `website_event` - Open `Events` - Open `Studio` - Click on `Website` tab - Try to add a new form by clicking on `New Form` - Studio doesn't create a new form because it points to /event which already exists (created by `website_event`). This commit verifies that the route doesn't exist before creating it. Pages are served as a fallback when Python routing (`@route`) doesn't match and there is no attachment matching that url. For simplicity and performance, we only check that our new page doesn't collide with an `@route` controller, because we assume that attachments url won't collide. see `website/models/ir_http.py` `Http::_serve_fallback` opw-3778543 Forward-Port-Of: odoo/enterprise#60752 Forward-Port-Of: odoo/enterprise#58504
This is a backport of odoo/enterprise#58479 This commit adds the bidimensional code on the receipt, it also adds to the receipt header the requirements for considering the receipt as a valid electronic document. task-id: 3747828 Community PR: odoo/odoo#161342 Forward-Port-Of: odoo/enterprise#60561 Forward-Port-Of: odoo/enterprise#60451
Original PR description
This is a backport of odoo/enterprise#58479 This commit adds the bidimensional code on the receipt, it also adds to the receipt header the requirements for considering the receipt as a valid electronic document. task-id: 3747828 Community PR: odoo/odoo#161342 Forward-Port-Of: odoo/enterprise#60561 Forward-Port-Of: odoo/enterprise#60451
8 changes
Resolved issues and error corrections
The check report summary line had misaligned columns where the partner name, date, and check number were compressed at the start of the line. This fix properly spaces these columns across the line with the partner name at the beginning, date in the middle, and check number at the end, improving the readability and professional appearance of printed checks.
Original PR description
Check Report Summary line columns were not aligned correctly, fixing it to have partner_name at the beginning, date at the middle, and check sequence number at the end of the line. task id: 3708433
This update improves the reliability of automated tests for the helpdesk knowledge template feature. The test now consistently discards forms after sending messages, preventing occasional test failures that occurred unpredictably on certain Odoo versions. This ensures the test runs reliably without being affected by unexpected form state changes.
Original PR description
The `send as message` macro for the template/clipboard block is only supposed to open and edit the message composer on the target form view, then discard it. The form view does not become dirty because of that. However it has been observed that on some Odoo versions, the form view sometimes becomes dirty (indeterministic factor), which is unrelated to the successful macro operation. Therefore it has been decided to always attempt to discard the form so that the test does not fail no matter if the view is dirty or not during the test. runbot error 62459 Forward-Port-Of: odoo/enterprise#61705 Forward-Port-Of: odoo/enterprise#61682
The WhatsApp template preview has been enhanced to make it easier for users to distinguish between the header and body text. Bold formatting is now applied to the header text, and a line break separates the two sections, improving the overall clarity and usability of the template preview interface.
Original PR description
Added bold formatting to the header text in the template preview to help users distinguish it from the body text. A new line is added between the header and body text in the template preview for the same reason. Task - 3605612 Forward-Port-Of: odoo/enterprise#59143
The Duplicate action was appearing twice in the Payroll app's Salary Structures menu due to the action being defined in two places. This fix removes the duplicate definition, ensuring users see the action only once when selecting salary structure entries. This improves the user experience by eliminating confusion from redundant menu options.
Original PR description
**Steps:** Go to Payroll App > Configuration > Salary > Structures Select checkbox for any entry Now click on the Action Button **Issue:** "Duplicate" action menu is displayed 2 times…
**Steps:** Go to Payroll App > Configuration > Salary > Structures Select checkbox for any entry Now click on the Action Button **Issue:** "Duplicate" action menu is displayed 2 times  **Cause:** Prior to this update, the 'list_controller.js' file in version saas~16.4 did not included the "Duplicate" menu action within the [getActionMenuItems](https://github.com/odoo/odoo/blob/saas-16.4/addons/web/static/src/views/list/list_controller.js#L287-L325) function. However, in the same version, the 'hr.payroll' model defined this action in the [hr_payroll_structure_views.xml](https://github.com/odoo/enterprise/blob/saas-16.4/hr_payroll/views/hr_payroll_structure_views.xml#L132-L143) file, utilized within the 'Salary Structures' in the Payroll app. In version 17.0, the "Duplicate" menu action was added to the [getStaticActionMenuItems](https://github.com/odoo/odoo/blob/17.0/addons/web/static/src/views/list/list_controller.js/#L304-L349) function of 'list_controller.js'. Following the update, despite the addition of the "Duplicate" menu action in the 'list_controller.js' file for version 17.0, it still remained present in the [hr_payroll_structure_views.xml](https://github.com/odoo/enterprise/blob/17.0/hr_payroll/views/hr_payroll_structure_views.xml#L134-L145) file. **Fix:** Removed the 'ir_actions_server_duplicate_structure' from hr_payroll_structure_views.xml, to ensure the same menu action "Duplicate" do not exist twice, in the 'Salary Structures'. Affected Version: 17.0 ~ master Task ID: [3854557](https://www.odoo.com/web#id=3854557&cids=2&menu_id=4720&action=4043&model=project.task&view_type=form)
This fix corrects an incorrect visibility condition on a report field in the WhatsApp template interface. The issue occurred during a code merge and has been resolved to ensure the field displays properly for users. This ensures the WhatsApp messaging feature works as intended without display errors.
Original PR description
Wrong conflict resolution when forward porting https://github.com/odoo/enterprise/commit/b81c50278a8d55a733c6f1579dc764c19b92e08d Task-3901993
This update corrects the styling of payment information popups in the accounting module. A deprecated custom style class was replaced with the standard Bootstrap styling class, ensuring the payment field displays correctly and consistently with the rest of the application.
Original PR description
o_popover_header was removed on [1], so the bootstrap class popover-header could be used instead. References: - [1] https://github.com/odoo/odoo/commit/777eb767 **16.0:**  **17.0 previous this commit:**  **17.0 after this commit:**  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Two missing account translations have been added to the Italian localization module. This ensures that Italian users will see properly translated account names in the system, improving the user experience for businesses operating in Italy.
Original PR description
Two account translations were missing in the Italian localization. We're adding them here. Forward-Port-Of: odoo/odoo#163999
A test in the web module was using hardcoded dates that caused automated build processes to fail. This fix skips that problematic test to restore normal build operations. This is a quick maintenance fix to keep development workflows running smoothly.
Original PR description
Quick fix to unlock runbot and mergebot builds. Forward-Port-Of: odoo/odoo#164141