Sunday, May 5, 2024
2 changes · 17.0
Resolved issues and error corrections
This fix corrects the approval workflow to only notify users about rules that actually apply to their record. Previously, the system was incorrectly sending notifications for approval rules whose conditions didn't match the record being reviewed. Now, only applicable rules at the next approval level will trigger notifications, ensuring users only see relevant approvals they need to handle.
Original PR description
…igher rules Have rules such as: 1. no domain, notification order: 1 2. no domain, notification order: 2 3. a domain that doesn't match the record, notification order: 2 Manually validate the rule 1, that is, do not hit the button of the action, rather, enter the popup of the approvals, and validate the rule. The spec of the flow is that, when all rules from a level (or notification order) have been validated, rules that have a higher order will trigger an activity and a notification to their responsible. After all, those rules are "next in line". Before this commit, both rule 2 and 3 sent a notification and created an activity for the current record. This was wrong as rule 3 should not be considered, because its domain doesn't match the record. After this commit, only rule 2 sends a notification and creates an activity. opw-3815732
This update fixes an intermittent problem in the website sales module where automated tests were failing unpredictably during nightly builds. The issue was related to product combinations not being properly archived in certain scenarios. This fix ensures the test suite runs reliably without random failures.
Original PR description
Some nightly builds are failing with a message hinting that the expected combination was not correctly archived. runbot issue 61115 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#164054 Forward-Port-Of: odoo/odoo#164003