Daily updates from Odoo
Sunday, May 12, 2024
6 changes · 17.0
Resolved issues and error corrections
This fix resolves an issue where email attachments linked to documents couldn't be properly edited due to message attachment restrictions. The system now creates a copy of attachments when modifying documents instead of attempting to modify the original, allowing users to edit document-related fields without permission errors. This ensures email attachments work seamlessly within the documents module.
Original PR description
When receiving emails, the attachments of the email may be made directly into a document. This will not make a copy, meaning restrictions on message attachments apply on these attachments. By extension this means the related fields on documents cannot be used properly. We now do a second check, filtering documents, if the access rights check fails because of message attachment restrictions. The reason to do two checks is that we do not want to add querries in the most common cases where the check will succeed regardless of filtering. issue introduced in odoo/odoo@4c4e63f01aefa01c2377f15f2020485cb0f7e4da task-3519815 Forward-Port-Of: odoo/enterprise#62322 Forward-Port-Of: odoo/enterprise#62174
Fixed an issue where accounting firms couldn't configure Luxembourg-specific tax fields when their company had a Belgian fiscal country but a Luxembourg VAT position. This prevented them from generating and submitting required tax declaration files to the government. The fix now properly checks all enabled tax countries, not just the primary fiscal country.
Original PR description
Before, only the fiscal country of the company was checked. Because of that, a Belgian company with a foreign VAT fiscal position in Luxembourg could for example not define those fields on its accounting firm, making it impossible for it to submit its tax declaration file to the government (since generating the file required those fields to be set). opw-3875483 Forward-Port-Of: odoo/enterprise#62317 Forward-Port-Of: odoo/enterprise#62126
This update fixes a bug in the journal report audit feature where tax grid information was not being properly captured when opposite tax grids were used. Previously, only the last tax grid was being recorded instead of all applicable ones, which could lead to incomplete or inaccurate tax reporting. This fix ensures all tax grids are now correctly included in audit reports.
Original PR description
Before this commit, when having opposite tax grid the domain of the journal_report_tax_tag_template_open_aml function was wrong. In case of opposite tax grid we should have put a list of tax_grid in the tag_id key which wasn't the case. It was only taking the last one since it was overridden in the next iteration of the loop. task-3869482 Forward-Port-Of: odoo/enterprise#62320 Forward-Port-Of: odoo/enterprise#61302
This update addresses various defects and adds new functionality to the evaluation system. Key improvements include fixes to templates and configuration files, new state management module, and enhanced evaluation features with conditional questions and detail views. The changes improve the user experience for managing and viewing assigned evaluations.
This fix resolves an error that occurred when customers tried to add service products with milestone-based invoicing to their cart on the e-commerce store. The issue prevented logged-out users from purchasing these products. The fix allows the system to properly handle these products while maintaining appropriate access controls for users who manage milestones.
Original PR description
Steps to reproduce: Create a Service Product with the Invoicing Policy "Based on Milestones" and publish its eCommerce page. When logged out, click on "Add to Cart" on the product's eCommerce page. an error message occurs Bug: since this commit[1] "delivered_milestones" is only a valid selection for users with the group "group_project_milestone" Fix: compute the field as sudo to avoid access error but still only allow the correct group to manually set that value opw-3892462 [1]:https://github.com/odoo/odoo/commit/50ffc339991b136b48525b2d60aa34a3039bb8 Forward-Port-Of: odoo/odoo#165133 Forward-Port-Of: odoo/odoo#164714
This update refines how Odoo controls access to attachments linked to messages. Previously, users couldn't modify any attachment details if it was connected to a message. Now, non-critical information like attachment names can be edited, while sensitive data fields remain protected. This allows other modules to work with message attachments more flexibly while maintaining security for important data.
Original PR description
We only care about data fields when it comes to restricting access to message attachments. As some modules may use these attachments directly, it may be desirable for them to use the attachment name or similar metadata fields. "write" is only restricted if writing on a data field, as it's effectively the same as unlinking for our purposes. Other fields have the same access rights as prior to [1] Additional changes: - Admins can delete attachments from message in the UI again - Check returns True instead of None when it succeeds, to match its parent - AccessError is raised with a cause so that we can detect if it was raised because of the message check 1: odoo/odoo@4c4e63f01aefa01c2377f15f2020485cb0f7e4da task-3519815 Forward-Port-Of: odoo/odoo#165158 Forward-Port-Of: odoo/odoo#164894