Saturday, May 18, 2024
1 change · 17.0
Resolved issues and error corrections
This fix resolves an issue where users couldn't easily access the download button for attachments in messages when they don't have permission to delete them. The problem occurred because the system was using inconsistent conditions to show the delete button versus styling the attachment options. Now the conditions are aligned, ensuring all attachment buttons are properly accessible to all users.
Original PR description
The template for the attachment list adds a class to show multiple options when attachments can be deleted. However the condition to display the delete button is different from the condition to apply…
The template for the attachment list adds a class to show multiple options when attachments can be deleted. However the condition to display the delete button is different from the condition to apply that style. Meaning if one condition `showDelete` is true while the other `isDeletable` is false it is impossible to access the download button as the correct style is not applied. - Fix the template to use the same condition everywhere - Fix the condition for showDelete to always be false is deletion is disallowed Issue noticeable since [1] when attachments were made conditionally deletable as opposed to always deletable previously. Steps to reproduce: - Post a couple attachments on the same message as a user in a chatter - Switch to a different user that is not allowed to delete the attachment (not admin) - You can't select the download button without using the tab key 1: 32a80a3ce1b2cbc46b1fc20f96b82256639beb9f task-3519815 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr