Monday, May 20, 2024
9 changes · saas-17.2
Resolved issues and error corrections
The GSTR-1 JSON export no longer includes tables that India's production government API does not yet accept. This prevents filing failures caused by unsupported data fields while keeping the report compatible with the live portal.
Original PR description
While filing GSTR-1, we encountered the following error: ``` [0]JSON validation failed due to - #: extraneous key [supeco] is not permitted ``` In this commit, we have resolved the error mentioned above. For various reasons, the government API has not yet implemented GSTR-1 tables 14 and 15 in production though they are available in the sandbox environment. As a solution, it is best not to include supeco in the JSON until the government API releases supeco into production.
Miscellaneous changes
`writeoff_account_id` is defined as a computed field but the method `_compute_writeoff_account_id` does not exist. opw-3931425 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166058 Forward-Port-Of: odoo/odoo#165879
Original PR description
`writeoff_account_id` is defined as a computed field but the method `_compute_writeoff_account_id` does not exist. opw-3931425 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166058 Forward-Port-Of: odoo/odoo#165879
Keep logic as it was before the onchange -> computes refactoring, so that (default) products added to an order before the onchange execution are not dropped. Forward-Port-Of: odoo/odoo#166010
Original PR description
Keep logic as it was before the onchange -> computes refactoring, so that (default) products added to an order before the onchange execution are not dropped. Forward-Port-Of: odoo/odoo#166010
_get_invoiced_lot_values in module `sale_stock` returns a key lot_id. https://github.com/odoo/odoo/blob/725f1923cb34be1188fe0bb83be5d55414aebef3/addons/sale_stock/models/account_move.py#L99-L106 All related methods should do the same, for coherence and easier inherit opw-3847889 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165035
Original PR description
_get_invoiced_lot_values in module `sale_stock` returns a key lot_id. https://github.com/odoo/odoo/blob/725f1923cb34be1188fe0bb83be5d55414aebef3/addons/sale_stock/models/account_move.py#L99-L106 All related methods should do the same, for coherence and easier inherit opw-3847889 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165035
Version: ---------- sass-16.3 Steps to reproduce: -------------------------- - open the Calendar module - click on the everybody's calendar filter option to view all the meetings - click on any meeting to open the form view for that meeting - now navigate back through the breadcrumb - the everybody's calendar filter is now unchecked Issue: ---------- The 'Everybody's Calendar' option is not set and one needs to check it again every time he come back through the breadcrumb. Cau
Original PR description
Version: ---------- sass-16.3 Steps to reproduce: -------------------------- - open the Calendar module - click on the everybody's calendar filter option to view all the meetings - click on any…
Version: ---------- sass-16.3 Steps to reproduce: -------------------------- - open the Calendar module - click on the everybody's calendar filter option to view all the meetings - click on any meeting to open the form view for that meeting - now navigate back through the breadcrumb - the everybody's calendar filter is now unchecked Issue: ---------- The 'Everybody's Calendar' option is not set and one needs to check it again every time he come back through the breadcrumb. Cause: ---------- All the other filters are saved in the backend through orm calls but the All filter is not saved since it does not have a recordId. Solution: ---------- The filter state is now stored in the user context, so when a user come back through the breadcrumb the previous set value is taken from the user context. task-3792066 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165924 Forward-Port-Of: odoo/odoo#160952
Avalara fields should not be shown to countries that are neither US or Canada. This commit handles this. task-3477234 Forward-Port-Of: odoo/enterprise#62690 Forward-Port-Of: odoo/enterprise#62615
Original PR description
Avalara fields should not be shown to countries that are neither US or Canada. This commit handles this. task-3477234 Forward-Port-Of: odoo/enterprise#62690 Forward-Port-Of: odoo/enterprise#62615
`_get_invoiced_lot_values` in module `sale_stock` returns a key lot_id. https://github.com/odoo/odoo/blob/725f1923cb34be1188fe0bb83be5d55414aebef3/addons/sale_stock/models/account_move.py#L99-L106 All related methods should do the same, for coherence and easier inherit opw-3847889 Forward-Port-Of: odoo/enterprise#62253
Original PR description
`_get_invoiced_lot_values` in module `sale_stock` returns a key lot_id. https://github.com/odoo/odoo/blob/725f1923cb34be1188fe0bb83be5d55414aebef3/addons/sale_stock/models/account_move.py#L99-L106 All related methods should do the same, for coherence and easier inherit opw-3847889 Forward-Port-Of: odoo/enterprise#62253
This commit fixes an oversight in the forward-port of https://github.com/odoo/enterprise/pull/59342, see comment https://github.com/odoo/enterprise/pull/59342#pullrequestreview-1966528450 opw-3746608 Forward-Port-Of: odoo/enterprise#62603
Original PR description
This commit fixes an oversight in the forward-port of https://github.com/odoo/enterprise/pull/59342, see comment https://github.com/odoo/enterprise/pull/59342#pullrequestreview-1966528450 opw-3746608 Forward-Port-Of: odoo/enterprise#62603
**Steps to reproduce:** - Install l10n_es_reports - Switch to a Spanish company (e.g. ES Company) - Go to "Accounting / Reporting / Statement Reports / Tax Report" - Check that a Spanish Tax Report is selected (i.e. Mod 111/115/303/347/349) - Click on "Save" - Select "BOE" for "Export To" option - Export **Issue:** A traceback is raised: "TypeError: export_boe() takes 2 positional arguments but 3 were given" **Cause:** The wrong method is called. "export_boe" is called instead o
Original PR description
**Steps to reproduce:** - Install l10n_es_reports - Switch to a Spanish company (e.g. ES Company) - Go to "Accounting / Reporting / Statement Reports / Tax Report" - Check that a Spanish Tax Report is selected (i.e. Mod 111/115/303/347/349) - Click on "Save" - Select "BOE" for "Export To" option - Export **Issue:** A traceback is raised: "TypeError: export_boe() takes 2 positional arguments but 3 were given" **Cause:** The wrong method is called. "export_boe" is called instead of "open_boe_wizard". The BOE wizard should be opened to enter extra manual data. opw-3856749 Forward-Port-Of: odoo/enterprise#61945