Wednesday, May 22, 2024
12 changes · master
Enhancements to existing features
Leads generated from social media posts or comments now include any attached images, giving sales teams fuller context when following up. The lead description also formats social media links with proper spacing for clearer reading.
Original PR description
Purpose ======= Display the post/comment image(s) in the related generated lead description. Also fixing a missing spacing around the social media link in the lead description. Specifications ============== When generating a lead from a post/comment containing an image, only the post/comment message content is displayed in the lead description. Adding the display of the post/comment image(s) if there is. Task-3834228
Product category records have been renamed and unused categories removed across several Odoo business apps. This keeps demo and test data more consistent, reducing confusion for teams working with products, sales, accounting, rentals, manufacturing, and related workflows.
Resolved issues and error corrections
This fixes an issue where read/seen indicators could appear incorrectly on multiple messages in general discussion channels. WhatsApp chat channels are also marked correctly so users still get the expected seen status where the feature is supported.
Original PR description
Before this commit, the seen indicator were displayed in the channels of type 'channel'. This was not intentional, and actually caused a UI issue where the seen indicator was visible on all messages…
Before this commit, the seen indicator were displayed in the channels of type 'channel'. This was not intentional, and actually caused a UI issue where the seen indicator was visible on all messages before the last message relevant to display the seen indicator. Step to reproduce: - As Mitchell Admin, post 2 messages in `#general` - As Marc Demo, post a single message in `#general` => Mitchell Admin sees the seen indicator on both of his messages, instead of 1 (feature enabled) or 0 (feature disabled). The 2 indicators happen because the channels is considered as not elligible for seen indicator feature. Because of this, field `Thread.lastSelfMessageSeenByEveryone` is unset, which also sets `Message.isMessagePreviousToLastSelfMessageSeenByEveryone` to `false` and thus makes all fields elligible to display the seen indicator. This commit fixes the issue by showing the seen indicator only when the thread of channel supports seen indicator, that is chat channels. ===== This enterprise commit adapts whatsapp code to properly flag whatsapp channels as supporting the seen feature. Tests were passing due to bug on `'channel'` channels. https://github.com/odoo/odoo/pull/165883
Miscellaneous changes
Task-id: 3631712 Forward-Port-Of: odoo/enterprise#62751 Forward-Port-Of: odoo/enterprise#52348
Original PR description
Task-id: 3631712 Forward-Port-Of: odoo/enterprise#62751 Forward-Port-Of: odoo/enterprise#52348
Original PR description
**This commit adapts the changes of product category cleaning** - Renaming the records for product category and removing the one's not required. (For eg. - `product_category_5` to `product_category_office`) **Affected version** ~ master **Task**: 3941328
Financial PDF reports now respect the “Hide lines at 0” option, so zero-value lines hidden on screen are also omitted when printed. This makes printed reports more consistent with the report view and reduces confusion for users comparing both versions.
Original PR description
When "Hide lines at 0" is toggled, lines at 0 are still included in the PDF report, despite being hidden in the report view. This leads to a difference between what the user sees and what is printed. Another reason to hide lines at 0 from the printed report is that lines with Hide if Zero checked does impact the PDF. This means the two options (Hide lines at 0 and Hide if Zero) have similar impacts in the user view but different behavior in printed reports. This commit implements the function _filter_out_0_lines to remove lines at 0 from printed report if "Hide lines at 0" is toggled. task-3888290
Versions -------- - 17.0+ Steps ----- 1. Go to timesheet grid view; 2. start a new timer for a project; 3. wait at least one minute; 4. leave view and come back; 5. press stop & start timer in quick succession; 6. if timer starts like normal, go back to step 1. Issue ----- Timer may display a negative value after first tick. Cause ----- 1. `onWillStart` begins; 2. it suspends for a RPC to get the server time; 3. render is canceled on resetting the timer; 4. `onWillDestro
Original PR description
Versions -------- - 17.0+ Steps ----- 1. Go to timesheet grid view; 2. start a new timer for a project; 3. wait at least one minute; 4. leave view and come back; 5. press stop & start timer in quick succession; 6. if timer starts like normal, go back to step 1. Issue ----- Timer may display a negative value after first tick. Cause ----- 1. `onWillStart` begins; 2. it suspends for a RPC to get the server time; 3. render is canceled on resetting the timer; 4. `onWillDestroy` is called; 5. timer isn't canceled because it hasn't started yet; 6. `onWillStart` continues; 7. a timer is added for a destroyed component. Solution -------- Use Owl's `status` function to ensure the component hasn't been destroyed before adding a timer. opw-3815398 Forward-Port-Of: odoo/enterprise#62110
payment_method_code was in the view for the batch payment creation view. However, when you create batch payment the check printing module has a compute that was being triggered on all payments with the same payment method because the payment method's code was being written by the payment_method_code on this view. This would cause performance issues on some databases. Setting this to readonly causes the create to no longer use this payment_method_code value and subsquently no longer triggers t
Original PR description
payment_method_code was in the view for the batch payment creation view. However, when you create batch payment the check printing module has a compute that was being triggered on all payments with the same payment method because the payment method's code was being written by the payment_method_code on this view. This would cause performance issues on some databases. Setting this to readonly causes the create to no longer use this payment_method_code value and subsquently no longer triggers the recompute. opw-3848817 Forward-Port-Of: odoo/enterprise#62431 Forward-Port-Of: odoo/enterprise#61908
# Issue: In a Partner Ledger using the "Prefix Groups Threshold" option, there are the "Open" and "Journal Items" buttons that are available as any other line in partner ledger report but they aren't bind to a specific Partner so the Open button, redirect to a "New partner" page and the Journal Items raise a traceback. # Reproduce: - Go in debug mode - Accounting > Configuration > Accounting Report > Partner Ledger > Options - Set Prefix Groups Threshold to 2 - Go in
Original PR description
# Issue:
In a Partner Ledger using the "Prefix Groups Threshold" option, there are the "Open" and "Journal Items" buttons that are available as any other line in partner ledger report but they aren't bind to a specific Partner so the Open button, redirect to a "New partner" page and the Journal Items raise a traceback.
# Reproduce:
- Go in debug mode
- Accounting > Configuration > Accounting Report > Partner Ledger > Options
- Set Prefix Groups Threshold to 2
- Go in Accounting > Reports > Partner Ledger
- Try to open a journal items on a "Grouping Line"
# Task:
opw-3916555
Forward-Port-Of: odoo/enterprise#62774
Forward-Port-Of: odoo/enterprise#62360Update legacy tests importing mail/test_utils.js to use HOOT instead of Qunit. Task-3818666 Community PR: https://github.com/odoo/odoo/pull/165371 Forward-Port-Of: odoo/enterprise#62434
Original PR description
Update legacy tests importing mail/test_utils.js to use HOOT instead of Qunit. Task-3818666 Community PR: https://github.com/odoo/odoo/pull/165371 Forward-Port-Of: odoo/enterprise#62434
**Steps to reproduce:** 1) Open any view of any module. 2) Click on insert a link in the article from Favorites. 3) Now publish the article from the share panel. 4) Copy that link and open it from the public user. 5) Click on the embedded link. **Issue:** Nothing will happen on click of that embedded link. **Solution:** Redirect the public user to the login page and after logging in redirect the user to that view if they have access to that view. **Task**-3082042 Forward-Port-O
Original PR description
**Steps to reproduce:** 1) Open any view of any module. 2) Click on insert a link in the article from Favorites. 3) Now publish the article from the share panel. 4) Copy that link and open it from the public user. 5) Click on the embedded link. **Issue:** Nothing will happen on click of that embedded link. **Solution:** Redirect the public user to the login page and after logging in redirect the user to that view if they have access to that view. **Task**-3082042 Forward-Port-Of: odoo/enterprise#62674 Forward-Port-Of: odoo/enterprise#57346
When receiving a webhook to update for template quality it may crash with the following error: ``` ValueError: Wrong value for whatsapp.template.quality: 'unknown' ``` As indicated in the reference documentation [^1], whatsapp use the value `UNKOWN` whereas we're using `none` for `whatsapp.template` quality, so this commit convert it to the appropriate value. [^1]: https://developers.secure.facebook.com/docs/graph-api/reference/whats-app-business-account/message_templates/ Forward-Po
Original PR description
When receiving a webhook to update for template quality it may crash with the following error: ``` ValueError: Wrong value for whatsapp.template.quality: 'unknown' ``` As indicated in the reference documentation [^1], whatsapp use the value `UNKOWN` whereas we're using `none` for `whatsapp.template` quality, so this commit convert it to the appropriate value. [^1]: https://developers.secure.facebook.com/docs/graph-api/reference/whats-app-business-account/message_templates/ Forward-Port-Of: odoo/enterprise#62756
Since you don't need the group 'hr.group_hr_manager' to access the value of the yearly cost and you have it displayed in the view list. We remove the group in the view form Forward-Port-Of: odoo/enterprise#62892
Original PR description
Since you don't need the group 'hr.group_hr_manager' to access the value of the yearly cost and you have it displayed in the view list. We remove the group in the view form Forward-Port-Of: odoo/enterprise#62892