Wednesday, May 22, 2024
2 changes · master
Resolved issues and error corrections
This fixes an issue where read/seen indicators could appear incorrectly on multiple messages in general discussion channels. WhatsApp chat channels are also marked correctly so users still get the expected seen status where the feature is supported.
Original PR description
Before this commit, the seen indicator were displayed in the channels of type 'channel'. This was not intentional, and actually caused a UI issue where the seen indicator was visible on all messages…
Before this commit, the seen indicator were displayed in the channels of type 'channel'. This was not intentional, and actually caused a UI issue where the seen indicator was visible on all messages before the last message relevant to display the seen indicator. Step to reproduce: - As Mitchell Admin, post 2 messages in `#general` - As Marc Demo, post a single message in `#general` => Mitchell Admin sees the seen indicator on both of his messages, instead of 1 (feature enabled) or 0 (feature disabled). The 2 indicators happen because the channels is considered as not elligible for seen indicator feature. Because of this, field `Thread.lastSelfMessageSeenByEveryone` is unset, which also sets `Message.isMessagePreviousToLastSelfMessageSeenByEveryone` to `false` and thus makes all fields elligible to display the seen indicator. This commit fixes the issue by showing the seen indicator only when the thread of channel supports seen indicator, that is chat channels. ===== This enterprise commit adapts whatsapp code to properly flag whatsapp channels as supporting the seen feature. Tests were passing due to bug on `'channel'` channels. https://github.com/odoo/odoo/pull/165883
Financial PDF reports now respect the “Hide lines at 0” option, so zero-value lines hidden on screen are also omitted when printed. This makes printed reports more consistent with the report view and reduces confusion for users comparing both versions.
Original PR description
When "Hide lines at 0" is toggled, lines at 0 are still included in the PDF report, despite being hidden in the report view. This leads to a difference between what the user sees and what is printed. Another reason to hide lines at 0 from the printed report is that lines with Hide if Zero checked does impact the PDF. This means the two options (Hide lines at 0 and Hide if Zero) have similar impacts in the user view but different behavior in printed reports. This commit implements the function _filter_out_0_lines to remove lines at 0 from printed report if "Hide lines at 0" is toggled. task-3888290