Odoo Changelog — 2024-05-27

Monday, May 27, 2024

37 changes

Branch: saas-17.2

13 changes

Bug Fixes(2)

Resolved issues and error corrections

[FIX] pos_self_order: prevent error when opening mobile view

PR #164867

Coresaas-17.2pos_self_order

This change prevents an error when staff open the restaurant Mobile View after a register has been closed and there are no active orders. It keeps the self-ordering page accessible instead of triggering a backend failure, improving reliability for restaurant operations.

Original PR description

This error usually occurs when there are no active orders present, and we've closed the register and then tried to access the ``Mobile View`` feature. Steps to reproduce: - Install the…

This error usually occurs when there are no active orders present, and we've closed the register and then tried to access the ``Mobile View`` feature.

Steps to reproduce:

- Install the ``pos_restaurant`` and ``point_of_sale`` modules
- Make sure there are no active orders in the restaurant
- Dashboard > Open Register > Open session > Close Register
- Dashboard > Restaurant > Dropdown Menu > Mobile View
- An Error will be generated in the terminal

Traceback : 
``ValueError: bus.Bus only string channels are allowed.``

This situation arises because we have two self-ordering modes: i) ``Mobile`` and ii) ``kiosk``. When the condition at [1] is evaluated, it will become false because the session has been closed, causing ``pos_config.has_active_session`` to be false. Additionally, since the mode is ``Mobile``, the condition in the ``elif`` statement at [1] also evaluates to false. As a result, we will get the value of ``config_access_token`` as a boolean value from line [2] because the value of ``config_access_token`` will not be set from both of the above conditions. Due to ``config_access_token`` being a boolean value, the value of ``channels`` ends up being a boolean value.

This commit will fix the above error by providing an empty string within ``config_access_token``, rather than boolean values. So, the value of ``channels`` will consistently be a string.

[1]: https://github.com/odoo/odoo/blob/16120774d6e7b16b44f771ca8224426e78676295/addons/pos_self_order/controllers/self_entry.py#L35-L47
[2]: https://github.com/odoo/odoo/blob/16120774d6e7b16b44f771ca8224426e78676295/addons/pos_self_order/controllers/self_entry.py#L16C8-L23C50

sentry-5136273134

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#mobile view#restaurant#self-ordering#point of sale

[FIX] web: enable developper mode from settings

PR #166672

Coresaas-17.2web

The Settings page now properly activates developer mode when users click the option. This ensures administrators can access advanced configuration tools without needing a manual workaround or page refresh.

Original PR description

Steps to reproduce
==================

- Go to settings
- Click on "Activate the developer mode"

=> Nothing happens

Cause of the issue
==================

The page isn't reloaded

Solution
========

Use the router and pass the reload option.
The same call is done in debug_provider.js

opw-3922717

#settings#developer-mode#administration

Other(11)

Miscellaneous changes

[FW][FIX] web_editor: fix no dropzone after hiding a snippet's column

PR #166776

Coresaas-17.2web_editor

Original PR description

Steps to reproduce the bug:

- In Website edit mode.
- Drop 2 "Columns" snippets.
- Hide one of the columns in the first snippet by clicking on the "Hide
on desktop" button of the "Column" options in the side panel.
- Start to drag another snippet.
- Bug: There is no dropzone between the 2 "Column" snippets.

The issue happens because when the column becomes invisible, after
clicking the button, the attribute `data-invisible="1"` is added to the
column in the DOM thanks the 'snippet_option_visibility_update' event.

However, this event then propagates to the column's parent elements
(`<section>` and `<main>`). So, the attribute `data-invisible="1"` is also
added to the `<section>`, causing the dropzone not to be inserted as
expected. We should investigate this further later because it doesn't
seem consistent. For now, we prefer not to make changes at this level to
avoid introducing other bugs.

In this commit, we change the selector that determines where not to
insert dropzones so that it no longer considers `data-invisible="1"`.
This was added by this commit [1], but it seems unnecessary, and
':not(:visible)' in the selector is sufficient to avoid placing
dropzones between two non-visible elements.

[1]: https://github.com/odoo/odoo/commit/f9bd3033b21dbd1e4487d6d6cd1d8d8fdfbfb2ac

Forward-Port-Of: odoo/odoo#165797

Branch: master

12 changes

Improvements(1)

Enhancements to existing features

[IMP] sale_subscription: log refactor simplification

PR #62736

Enterprisemastersale_subscription

The subscription sales order logging code has been simplified to make it easier to maintain. This is an internal improvement that should reduce complexity and help future updates without changing day-to-day user workflows.

Original PR description

Simplify sale order log code

#subscriptions#sales-orders#maintenance

Rows:Rows per page:

10 25 50 100

1 / 2Page 1 of 2 · 37 days total

This error usually occurs when there are no active orders present, and we've closed the register and then tried to access the ``Mobile View`` feature. Steps to reproduce: - Install the ``pos_restaurant`` and ``point_of_sale`` modules - Make sure there are no active orders in the restaurant - Dashboard > Open Register > Open session > Close Register - Dashboard > Restaurant > Dropdown Menu > Mobile View - An Error will be generated in the terminal Traceback : ``ValueError: bus.Bus only string channels are allowed.`` This situation arises because we have two self-ordering modes: i) ``Mobile`` and ii) ``kiosk``. When the condition at [1] is evaluated, it will become false because the session has been closed, causing ``pos_config.has_active_session`` to be false. Additionally, since the mode is ``Mobile``, the condition in the ``elif`` statement at [1] also evaluates to false. As a result, we will get the value of ``config_access_token`` as a boolean value from line [2] because the value of ``config_access_token`` will not be set from both of the above conditions. Due to ``config_access_token`` being a boolean value, the value of ``channels`` ends up being a boolean value. This commit will fix the above error by providing an empty string within ``config_access_token``, rather than boolean values. So, the value of ``channels`` will consistently be a string. [1]: https://github.com/odoo/odoo/blob/16120774d6e7b16b44f771ca8224426e78676295/addons/pos_self_order/controllers/self_entry.py#L35-L47 [2]: https://github.com/odoo/odoo/blob/16120774d6e7b16b44f771ca8224426e78676295/addons/pos_self_order/controllers/self_entry.py#L16C8-L23C50 sentry-5136273134 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Steps to reproduce ================== - Go to settings - Click on "Activate the developer mode" => Nothing happens Cause of the issue ================== The page isn't reloaded Solution ======== Use the router and pass the reload option. The same call is done in debug_provider.js opw-3922717

Steps to reproduce the bug: - In Website edit mode. - Drop 2 "Columns" snippets. - Hide one of the columns in the first snippet by clicking on the "Hide on desktop" button of the "Column" options in the side panel. - Start to drag another snippet. - Bug: There is no dropzone between the 2 "Column" snippets. The issue happens because when the column becomes invisible, after clicking the button, the attribute `data-invisible="1"` is added to the column in the DOM thanks the 'snippet_option_visibility_update' event. However, this event then propagates to the column's parent elements (`<section>` and `<main>`). So, the attribute `data-invisible="1"` is also added to the `<section>`, causing the dropzone not to be inserted as expected. We should investigate this further later because it doesn't seem consistent. For now, we prefer not to make changes at this level to avoid introducing other bugs. In this commit, we change the selector that determines where not to insert dropzones so that it no longer considers `data-invisible="1"`. This was added by this commit [1], but it seems unnecessary, and ':not(:visible)' in the selector is sufficient to avoid placing dropzones between two non-visible elements. [1]: https://github.com/odoo/odoo/commit/f9bd3033b21dbd1e4487d6d6cd1d8d8fdfbfb2ac Forward-Port-Of: odoo/odoo#165797

## Issue: - When a customer places an order on the website and there are errors in the shipping informations, such as an invalid address format, the shipping costs drop to 0€ if only one shipping method is available. - Despite these errors, Odoo does not block the "Pay now" button, allowing the customer to proceed and pay 0€ for shipping. ## Steps To Reproduce: - Install UPS US on your db and publish it. - unpublish the other shipping methods. - Go to /shop and purchase any product as a customer - During the checkout process, add an address that has more than 35 characters - Notice you'll be allowed to pay and your order will be confirmed. In an other scenario: - Install Fedex US on your db and publish it. - Set Fedex service type to STANDARD_OVERNIGHT - unpublish the other shipping methods. - Go to /shop and purchase any product as a customer - During the checkout process, set Hawaii in state/Povince - Notice you'll be allowed to pay and your order will be confirmed even though Hawaii doesn't support STANDARD_OVERNIGHT shipping. ## Explanation and Solution: - The first issue arises when there is only one shipping provider available; it gets selected by default. After this selection, the `start` method of `websiteSaleDelivery` is triggered, which attempts to force-click the already checked shipping carrier. Consequently, it returns without completing the logic because the click event handler `_onCarrierClick` dismisses with the following condition: `if (radio.checked && !this._shouldDisplayPickupLocations(ev)) {return;}` - The second problem occurs because the `start` method is triggered as soon as the `websiteSaleDelivery` public widget is rendered, which does not allow enough time for the `PaymentButton` to be rendered. This delay causes the `_disablePayButton` method to fail. - To address the first issue, I added a flag `refreshclick` to indicate that the shipping carrier was set by default. - To address the second issue, I modified the `_enableButton` method to actively disable the button if the status is false. This change ensures that the `PaymentButton` widget has sufficient time to render since `_enableButton` is called within `_handleCarrierUpdateResult` after awaiting the response from an RPC call. opw-3844214 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165832 Forward-Port-Of: odoo/odoo#161704

### Issue: Trying to validate a wave transfer with an empty picking will raise and error. ### Expected behavior: The empty picking should be removed from the wave transfer and the rest of the operations should be validated. ### Steps to reproduce: - In the settings: enable Batch Transfers > Wave Transfers - Create 2 receipts: 1) 1 x product P1 2) 1 x product P2 - In the inventory overview, click on the dots of receipts > operations - Select your receipts > Add to wave > Create new wave transfer - Go to inventory > Operations > Transfers > Wave transfers - Open your wave transfer and set the quantity of P1 to 0 ### Cause of the issue: Currently, only the empty pickings 'waiting for another operation' are removed from the batch when it is validated: https://github.com/odoo/odoo/blob/3cfe548ee03f96713c7a6d462409be9c825d22e7/addons/stock_picking_batch/models/stock_picking_batch.py#L201-L204 In particlar, other empty pickings will not pass the sanity check: https://github.com/odoo/odoo/blob/3cfe548ee03f96713c7a6d462409be9c825d22e7/addons/stock_picking_batch/models/stock_picking_batch.py#L217-L218 and an operation error will be raised for them. opw-3884043 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#163320

In a7adb61e41ef17459eb95d9252cd53db37ebe0b2, the document_state component was removed from l10n_mx_edi to be put in account. We had to keep an "empty shell" component in l10n_mx_edi to avoid having to modify the l10n_mx_edi views in stable. But in master, we can remove this "empty shell" and use the generic component from account.

Before this commit, the tour planning_split_shift_week would crash when the current day is the beginning of the current week. This happened because when today is the first day of the week, the selector used in the step "Select first day of the current week" would be the start of the previous week. Thus the final date range produced, would contain two weeks instead of one, making the tour timeout (waitUntil condition not met).

In this commit https://github.com/odoo/enterprise/commit/84e0edcfc88c3361e1e042e80c82f6c4b950c738, we added the deferred_start_date and end_date in the pdf. This change is applied for everyone and it shouldn't be. A next task will be created to assess this problem but in the meantime we will revert the commit no task-id

Currently, in tour_compiler, to check that an element is actually present in the DOM in a step, there are 2 possibilities. - `isCheck: true` => Checks that the element is in the DOM. The latter can be disabled. - `run() {}` => Checks that the element is in the DOM (because this is what is done by default). However, if the element is disabled, the step will be aborted. In the codebase, we can see a lot of `run() {} //it's a check` and `isCheck:true`. However, the behavior is not exactly the same. What's more, there are 2 ways to do "the same thing". In order to clarify the turns API, it was decided to no longer put an action (step.run) by default. (Previously, the default action was the "click" action). From then on, it is no longer necessary to stipulate `step.isCheck: true` nor `run() {}`. The corollary is that now, you must explicitly write `run: click`, if you want the click action to be triggered on the target. This commit sets the stage for making this change.

Steps to reproduce: ------------------- - create a product: - service - based on timesheet - create on order: project & task - create a sale order with this product - confirm the sale order - go on the created task - add timesheets with an employee - go to timesheet - validate created timesheets - go to the project settings - in invoicing tab, change de sale order item for the employee Issue: ------ The sale order item linked to the validated timesheets are modified. This behaviour causes negative side effects. A validated timesheet should no longer be modified, but the backend logic does, which is not consistent. Solution: --------- Make the condition that filters timesheets to update take account of whether the timesheet is validated or not. opw-3791062 Forward-Port-Of: odoo/enterprise#63163 Forward-Port-Of: odoo/enterprise#61122

The tour is failing rarely and undeterministically. It seems like the reason is because 2 steps from the tour are done before a request is done (and so the number of the call to the function). We add a step to enforce that the request is made before the next step of the tour. We also enforce that we don't do the last action before closing the tour. In ulterior versions, the tour can be stuck when adding a product. Our guess is that the button is clicked before the page is fully loaded. The tour would then consider it did click the button, while the action didn't happen. We add a check to wait for the page to be fully loaded before clicking. Linked to runbot error 61458, 63532, 59031 (and happened before already). Forward-Port-Of: odoo/enterprise#63019 Forward-Port-Of: odoo/enterprise#61964

The payment acquirer must always be linked to a single journal, one per company. It's currently an hard constraint So after the duplication, both are always linked to the same journal but only one appear on it. This "fix" is improving that allowing the duplication of an existing acquirer and to be able to link them to diffe opw-3704407 Forward-Port-Of: odoo/enterprise#62989 Forward-Port-Of: odoo/enterprise#62744

Branch: saas-17.2

Bug Fixes(2)

[FIX] pos_self_order: prevent error when opening mobile view

[FIX] web: enable developper mode from settings

Other(11)

[FW][FIX] web_editor: fix no dropzone after hiding a snippet's column

Branch: master

Improvements(1)

[IMP] sale_subscription: log refactor simplification

Branch: saas-17.2

Bug Fixes(2)

[FIX] pos_self_order: prevent error when opening mobile view

[FIX] web: enable developper mode from settings

Other(11)

[FW][FIX] web_editor: fix no dropzone after hiding a snippet's column

Branch: master

Improvements(1)

[IMP] sale_subscription: log refactor simplification

[FW][IMP] point_of_sale: refactor tests for scanning barcodes

[FW][FIX] l10n_hu_edi: Allow install to continue even if tax config fails

[FW][FIX] website_sale: block payment when shipping carrier error

[FW][FIX] stock_picking_batch: validate batch with empty pickings

[FW][FIX] mail: error opening chatwindow of a non member channel

[FW][FIX] website_slides: no 'false' text when no description on quiz content

[FW][FIX] purchase_stock: Bill currency different than PO

[FW][FIX] point_of_sale: unshow default price list

[FW][FIX] account: Fix retrieve_product domain on company

[FW][FIX] payment_stripe: express checkout update carrier remove legacy rpc

Bug Fixes(4)

[FIX] l10n_mx_edi: use the generic account_document_state component

[FIX] planning: tour planning_split_shift_week

[FIX] documents_spreadsheet: add missing aggregator name

[REV] account_accountant: revert deferred date in pdf

Refactoring(2)

[DRAFT][REF] click

[REF] web_tour: prepare to change the default action in tour_compiler

Other(5)

[FW][FIX] l10n_be_hr_payroll: fix the DPV computation to include commissions

[FW][IMP] website_sale_stock_renting: adapt tests

[FW][FIX] sale_timesheet_enterprise: prevent editing so line

[FW][FIX] account_avatax_sale: tour is failing number

[FW][FIX] account_payment: allow duplicate acquirer per company