Thursday, May 30, 2024
22 changes · saas-17.2
Resolved issues and error corrections
This fix ensures permission checks for newly created or unsaved users return a safe negative result instead of causing an error. It improves reliability in workflows where user records may be checked before they are fully saved.
Original PR description
opw-3940549 opw-3943985 opw-3943909 opw-3937897 opw-3932111
This fixes default mail activity test records so they are treated as active and can be found during standard searches. It improves the reliability of mail-related automated tests and mock data behavior without changing end-user features.
Original PR description
**Before this PR:** Default records in `mail_activity` mock model are not set active by default, as a result when you do search operation on `mail.activity` it will check `active_test` and won't return these records. **After this PR:** Setting `active` true so these records would pass `active_test`. Part of task-[3818666](https://www.odoo.com/odoo/project/1519/tasks/3818666?debug=&cids=2) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where the message chatter panel appeared inside pop-up dialogs, such as when opening a Time Off calendar entry. The change keeps dialogs cleaner and prevents users from seeing an unexpected communication panel where it should not be shown.
Original PR description
Before this commit, the chatter was shown in dialog when it should never. Steps to reproduce: - Install Time Off (`hr_holidays`) - Open Time Off app - Click on a date in the calendar view => The chatter is visible in dialog when it shouldn't This happens because the Chatter hook had a `t-if` on `!env.inDialog`, but it was overridden by another `t-if` on layout. As a result, the view template never took into consideration of `!env.inDialog`. This commit fixes the issue by properly combining the 2 `t-if` together. task-3957107
Miscellaneous changes
We prepare the following fix by adding a modelParam getter that can be overridden by sub-classes. How to reproduce: 1. Schedule an activity for a document. 2. Go to activity view. 3. Select the document to preview in the inspector. 4. Rename the document. 5. Refresh the page. The document name is not renamed. In the kanban and list view, the document is updated because multiEdit model parameter is enabled. It is not the case for the activity view. Similarly to what is done in li
Original PR description
We prepare the following fix by adding a modelParam getter that can be overridden by sub-classes. How to reproduce: 1. Schedule an activity for a document. 2. Go to activity view. 3. Select the document to preview in the inspector. 4. Rename the document. 5. Refresh the page. The document name is not renamed. In the kanban and list view, the document is updated because multiEdit model parameter is enabled. It is not the case for the activity view. Similarly to what is done in list and kanban controller, we add a modelParam getter to the activity controller to allow to override the parameters in subclasses which will allows to enable the multiEdit parameter in the document activitty controller. Task-3817795 Forward-Port-Of: odoo/odoo#164052 Forward-Port-Of: odoo/odoo#158874
Current behavior: When an iot device is linked to the PoS and invoice report, you had an error because action service and iot_websocket service where not available. Steps to reproduce: - Install pos_iot - Set an iot_device printer on the pos session - Set an iot_device on the report of the invoice - Open session, make an order and invoice it - You get an error opw-3792576 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo
Original PR description
Current behavior: When an iot device is linked to the PoS and invoice report, you had an error because action service and iot_websocket service where not available. Steps to reproduce: - Install pos_iot - Set an iot_device printer on the pos session - Set an iot_device on the report of the invoice - Open session, make an order and invoice it - You get an error opw-3792576 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165798
This commit implements a new (bridge) module that adds the spanish TBai QR code on the Point of Sale checkout order receipt. Problem: Right now, with the l10n_es_pos, it works when the EDI is SII as it creates the invoice automatically and sends it in the background. In the case of simplified invoices, we even skipped the downloading of the PDF because that takes time. But there, you do not need any response from the government to show to your client. With TicketBai however, this is differe
Original PR description
This commit implements a new (bridge) module that adds the spanish TBai QR code on the Point of Sale checkout order receipt. Problem: Right now, with the l10n_es_pos, it works when the EDI is SII as it creates the invoice automatically and sends it in the background. In the case of simplified invoices, we even skipped the downloading of the PDF because that takes time. But there, you do not need any response from the government to show to your client. With TicketBai however, this is different, as we need the QR code on the ticket. Solution: when processing the data in the PoS payment, we look for the move created and asks for the qr url right away. If it doesn't have them (because the sending is not done yet), we synchronously call the post method and get the url. This URL is then transfered to the javascript code and eventually the XML of the receipt, where the QR code is shown. task-id: 3916236 Forward-Port-Of: odoo/odoo#166019
There is a traceback when editing the `amount_currency` field in the "Journal Items" tab of an inovice. It happens when account_3way_match is installed. The commit that introduced the traceback: 87a1ebb338277e45d2367344c212d4867405b7a4 Related commit setting the `bin_size` key to `True` ebd538a1942c532bcf1c9deeab3c25efe23b6893 A test was added to the account_3way_match module in the related enterprise PR. enterprise PR: https://github.com/odoo/enterprise/pull/63339 related PR: t
Original PR description
There is a traceback when editing the `amount_currency` field in the "Journal Items" tab of an inovice. It happens when account_3way_match is installed. The commit that introduced the traceback: 87a1ebb338277e45d2367344c212d4867405b7a4 Related commit setting the `bin_size` key to `True` ebd538a1942c532bcf1c9deeab3c25efe23b6893 A test was added to the account_3way_match module in the related enterprise PR. enterprise PR: https://github.com/odoo/enterprise/pull/63339 related PR: that fixes account_3way_match: https://github.com/odoo/enterprise/pull/63336 (16.0) Forward-Port-Of: odoo/odoo#167014
Before this commit, drag-and-drop functionality for groups/records in the kanban view did not work properly if the user lacked write access. Steps to Reproduce: - Log in to Odoo as Marc Demo. - Open the Project module. - Attempt to drag and drop any group/record in the kanban view. Observed Behavior: The group in the kanban view does not reset to its original position if the user lacks the right to reorder the groups/records, rendering the group/record immovable. Expected Behavior
Original PR description
Before this commit, drag-and-drop functionality for groups/records in the kanban view did not work properly if the user lacked write access. Steps to Reproduce: - Log in to Odoo as Marc Demo. - Open the Project module. - Attempt to drag and drop any group/record in the kanban view. Observed Behavior: The group in the kanban view does not reset to its original position if the user lacks the right to reorder the groups/records, rendering the group/record immovable. Expected Behavior: The group in the kanban view should reset to its original position if the user lacks the right to reorder the groups/records. After this commit, drag-and-drop functionality for groups/records in the kanban view now works properly, even if the user does not have write access. Task ID: 3865617 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166881 Forward-Port-Of: odoo/odoo#164879
Purpose ======= Fix the course title which was truncated with a single letter in the website breadcrumbs. Specification ============= The course title breadcrumb had its width limited by a w-25 class which always prevented the title from being fully visible. Removing that class and allowing each breadcrumb to take the whole available width before being truncated. Also adding the "title" attribute on each breadcrumb so that, even truncated, hovering on it will still make them readable.
Original PR description
Purpose ======= Fix the course title which was truncated with a single letter in the website breadcrumbs. Specification ============= The course title breadcrumb had its width limited by a w-25 class which always prevented the title from being fully visible. Removing that class and allowing each breadcrumb to take the whole available width before being truncated. Also adding the "title" attribute on each breadcrumb so that, even truncated, hovering on it will still make them readable. Co-authored-by: pko-odoo pko@odoo.com Co-authored-by: amdi-odoo amdi@odoo.com Task-3876972 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167013 Forward-Port-Of: odoo/odoo#165625
Update tax codes: - IVA 5% (411, Bienes) -> _IVA 5% (435, Bienes) (code_base: 435, code_applied: 445)_ - IVA 5% (510, Crédito IVA) -> _IVA 5% (550, Crédito IVA) (code_base: 550, code_applied: 560)_ Create Report lines: - _Ventas locales (excluye activos fijos) gravadas tarifa 5%_ - _Adquisiciones y pagos locales (excluye activos fijos) gravados con tarifa 5% (con derecho a crédito tributario)_ Forward-Port-Of: odoo/odoo#165672
Original PR description
Update tax codes: - IVA 5% (411, Bienes) -> _IVA 5% (435, Bienes) (code_base: 435, code_applied: 445)_ - IVA 5% (510, Crédito IVA) -> _IVA 5% (550, Crédito IVA) (code_base: 550, code_applied: 560)_ Create Report lines: - _Ventas locales (excluye activos fijos) gravadas tarifa 5%_ - _Adquisiciones y pagos locales (excluye activos fijos) gravados con tarifa 5% (con derecho a crédito tributario)_ Forward-Port-Of: odoo/odoo#165672
Activate Margins and Margin Analysis Create a new product [TEST] with no price set (0.0) Create a SO Add a line with [TEST] setting a unit price of 100 Margin will be 100 Confirm sale, create and confirm the invoice Go to Accounting>Reporting>Invoice Analysis Switch to pivot view Enable Margin mesure Issue: Margin for invoice will not be set This occurs because the price has not set so the sql computation for the margin will be NULL opw-3916863 Forward-Port-Of: odoo/odoo#166845
Original PR description
Activate Margins and Margin Analysis Create a new product [TEST] with no price set (0.0) Create a SO Add a line with [TEST] setting a unit price of 100 Margin will be 100 Confirm sale, create and confirm the invoice Go to Accounting>Reporting>Invoice Analysis Switch to pivot view Enable Margin mesure Issue: Margin for invoice will not be set This occurs because the price has not set so the sql computation for the margin will be NULL opw-3916863 Forward-Port-Of: odoo/odoo#166845
Before this commit: =================== Duplicate down payment lines were being generated multiple times upon clicking the order button after importing the Quotation/Order. Steps To Reproduced: ===================== - Step 1: Create order in Sales and save it - Step 2: Open POS Restaurant and click on Quotation/Order - Step 3: Select order and Settle order as Down-payment - Step 4: Once added into cart click on the order button multiple times. - Step 5: Go to back-end and open Sa
Original PR description
Before this commit: =================== Duplicate down payment lines were being generated multiple times upon clicking the order button after importing the Quotation/Order. Steps To Reproduced: ===================== - Step 1: Create order in Sales and save it - Step 2: Open POS Restaurant and click on Quotation/Order - Step 3: Select order and Settle order as Down-payment - Step 4: Once added into cart click on the order button multiple times. - Step 5: Go to back-end and open Sales order You'll see multiple down-payment entries corresponding to each click on the order button. After this commit: =================== The creation of duplicate down payment lines is prevented. task - 3877380 Forward-Port-Of: odoo/odoo#162772
- Before this commit One using an Input Method Editor (i.e. for writing hiraganas) could potentially trigger an hotkey, which does not make any sense. - After this commit While an IME is still composing, the hotkey service will ignore. opw-3633735 Forward-Port-Of: odoo/odoo#165229
Original PR description
- Before this commit One using an Input Method Editor (i.e. for writing hiraganas) could potentially trigger an hotkey, which does not make any sense. - After this commit While an IME is still composing, the hotkey service will ignore. opw-3633735 Forward-Port-Of: odoo/odoo#165229
Description of the issue/feature this PR addresses: Avoid IndexError when selecting default_dest_location in `_get_default_dest_location` when: - Adding a new line (stock.move.line) inside a Batch - User has _stock.group_stock_storage_categories_ group https://www.loom.com/share/fbe5d532cab94080b4ea3384ebaeb7c0?sid=e3115127-7153-42a5-9caf-69e871077c1a Current behavior before PR: IndexError Desired behavior after PR is merged: Allow to add an empty line without error --- OP
Original PR description
Description of the issue/feature this PR addresses: Avoid IndexError when selecting default_dest_location in `_get_default_dest_location` when: - Adding a new line (stock.move.line) inside a Batch - User has _stock.group_stock_storage_categories_ group https://www.loom.com/share/fbe5d532cab94080b4ea3384ebaeb7c0?sid=e3115127-7153-42a5-9caf-69e871077c1a Current behavior before PR: IndexError Desired behavior after PR is merged: Allow to add an empty line without error --- OPW-3916135 MT-5971 @moduon @rafaelbn @yajo @EmilioPascual --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165753
Before this commit: ========== - Tax layout of order receipt was making a bad User experience. After this commit: ========= - Improved Tax layout of order receipt. task-3933459 Forward-Port-Of: odoo/odoo#166317
Original PR description
Before this commit: ========== - Tax layout of order receipt was making a bad User experience. After this commit: ========= - Improved Tax layout of order receipt. task-3933459 Forward-Port-Of: odoo/odoo#166317
Since https://github.com/odoo/odoo/pull/143852 and the backport https://github.com/odoo/odoo/pull/163564 , we have added a lot of index for account.move, but still there are some missing left, so this commit is to add the index btree_not_null for those one. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of:
Original PR description
Since https://github.com/odoo/odoo/pull/143852 and the backport https://github.com/odoo/odoo/pull/163564 , we have added a lot of index for account.move, but still there are some missing left, so this commit is to add the index btree_not_null for those one. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166887
Description of the issue/feature this PR addresses: This PR addresses an issue in the attendance module. When an employee's job position is not set, the kiosk mode displays `false` in the employee kanban view when manually identified. Cause The issue arises when the job position is not set in the employee profile. Fix: This PR resolves the issue by modifying the kanban view template of employees in kiosk mode.if condition is added to ensure that the job position is displayed only if it
Original PR description
Description of the issue/feature this PR addresses: This PR addresses an issue in the attendance module. When an employee's job position is not set, the kiosk mode displays `false` in the employee kanban view when manually identified. Cause The issue arises when the job position is not set in the employee profile. Fix: This PR resolves the issue by modifying the kanban view template of employees in kiosk mode.if condition is added to ensure that the job position is displayed only if it is set for the employee. task-3892580 Forward-Port-Of: odoo/odoo#165342
This commit adds a check to ensure that the listId exists when processing the command `UPDATE_ODOO_LIST_DOMAIN` in the `beforeHandle` function. Task: 3908657 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167199 Forward-Port-Of: odoo/odoo#166797
Original PR description
This commit adds a check to ensure that the listId exists when processing the command `UPDATE_ODOO_LIST_DOMAIN` in the `beforeHandle` function. Task: 3908657 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167199 Forward-Port-Of: odoo/odoo#166797
Steps to reproduce: - Navigate to Product Variants list view in the Inventory module - Search for a warehouse e.g. "My Company" in the list view - Click on any storable product e.g. DESK0005 - In the product form view click on the "Forecasted" button This gives a traceback because the 'warehouse' in the context is the name and not the id. Fixes #165330 Forward-Port-Of: odoo/odoo#165934
Original PR description
Steps to reproduce: - Navigate to Product Variants list view in the Inventory module - Search for a warehouse e.g. "My Company" in the list view - Click on any storable product e.g. DESK0005 - In the product form view click on the "Forecasted" button This gives a traceback because the 'warehouse' in the context is the name and not the id. Fixes #165330 Forward-Port-Of: odoo/odoo#165934
With tens of millions of channels, the query for getting the channels of the current user goes from 1.2s to 6ms. `auto_join` makes sense as channels are almost always fetched together with member (and in particular for checking ACL of member). Forward-Port-Of: odoo/odoo#167205
Original PR description
With tens of millions of channels, the query for getting the channels of the current user goes from 1.2s to 6ms. `auto_join` makes sense as channels are almost always fetched together with member (and in particular for checking ACL of member). Forward-Port-Of: odoo/odoo#167205
Steps to reproduce: =============== - Create new POS - Tick Is a Bar/Restaurant option - Create new floor - Add a table Issue: ===== On adding a new table, table is added but does not reflect on the floor. Cause: ====== On adding new floor the length of floor was not updated which leads to the issue. Fix: === After this commit floor length is currently updated. task-3888097 Forward-Port-Of: odoo/odoo#163708
Original PR description
Steps to reproduce: =============== - Create new POS - Tick Is a Bar/Restaurant option - Create new floor - Add a table Issue: ===== On adding a new table, table is added but does not reflect on the floor. Cause: ====== On adding new floor the length of floor was not updated which leads to the issue. Fix: === After this commit floor length is currently updated. task-3888097 Forward-Port-Of: odoo/odoo#163708
The context menu (and clickable cell) `use_global_filter` should take the value of the underlying pivot formula, and apply it to the matching global filters. This works, but was supposed to work only for `ODOO.PIVOT.HEADER` formulas, and not simple `ODOO.PIVOT` formulas. This commit fixes the visibility of the `use_global_filter` option in the context menu, so that it is only visible for `ODOO.PIVOT.HEADER`. Also removed/changed tests that were testing that the menu was visible for positio
Original PR description
The context menu (and clickable cell) `use_global_filter` should take the value of the underlying pivot formula, and apply it to the matching global filters. This works, but was supposed to work only for `ODOO.PIVOT.HEADER` formulas, and not simple `ODOO.PIVOT` formulas. This commit fixes the visibility of the `use_global_filter` option in the context menu, so that it is only visible for `ODOO.PIVOT.HEADER`. Also removed/changed tests that were testing that the menu was visible for positional `ODOO.PIVOT` formulas. Task: [3714696](https://www.odoo.com/web#id=3714696&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form) Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166971