Daily updates from Odoo
Tuesday, June 4, 2024
19 changes
1 change
Resolved issues and error corrections
This fix prevents an error when users add an overdue activity to the Call Queue and then open or edit it. It improves reliability in activity workflows by handling cases where an old activity is automatically removed right after creation.
Original PR description
Before this commit, when adding an outdated activity from kanban activity widget, it crashed with the following error: TypeError: Cannot read properties of undefined (reading 'toLocaleString') Steps…
Before this commit, when adding an outdated activity from kanban activity widget, it crashed with the following error: TypeError: Cannot read properties of undefined (reading 'toLocaleString') Steps to reproduce: - on crm lead schedule call activity and make sure that activity is at least 1 month old - add activity to the Call Queue - try to access/edit activity This happens because of adding an outdated activity, this is automatically considered as an old activity, which leads to its deletion immediately after creation. OWL is rendering the template of `ActivityListPopover` while the activity is deleted, which is a problem because activity doesn't exist therefore its fields have been cleared, such as date_deadline that is undefined instead of a DateTime. task-3945492 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
4 changes
Resolved issues and error corrections
The demo employee timesheet data now shows the correct last validated timesheet date. This keeps sample Timesheet records consistent and avoids misleading dates when users explore or test the module.
Original PR description
In the Timesheet Module, we are fixing the data related to the demo employee set, specifically in the last_validated_timesheet_date field. it will result in the last validated timesheet date being returned as 10 days earlier. task-350454
Working schedule hour values in Payroll are now shown in a cleaner time format instead of raw decimal numbers. This makes required full-time hours and weekly hours easier for HR users to read and reduces confusion when reviewing schedules.
Original PR description
full_time_required_hours and hours_per week are no longer displayed as floats. task-3888824
An obsolete setting related to spreadsheet date filters was removed from the code. This reduces maintenance overhead and helps prevent confusion without changing how users work with spreadsheets.
Original PR description
There was still reference on global filter's automaticDefaultValue in the code, but automaticDefaultValue isn't used. This commit removes the dead code. Task: [3956477](https://www.odoo.com/web#id=3956477&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form)
Saudi Arabia payroll salary rules have been adjusted and expanded to better match required payroll calculations. The update also adds supporting employee, leave, and departure reason data so payroll results are more accurate for affected employees.
Original PR description
Ticket ID: [3215965](https://www.odoo.com/odoo/project.task/3215965?cids=14) Modifications to existing salary rules in KSA payroll + adding some new rules.
14 changes
Resolved issues and error corrections
This fix addresses an issue where cancelling an upsell subscription failed to revert quantity changes made to the parent subscription. When an upsell was confirmed, it would update the parent subscription's product quantities, but cancelling the upsell would not restore the original quantities. The system now properly reverts these changes and provides clearer messaging to users about quantity updates.
Original PR description
To reproduce: ============= - create a subscription and confirm it - create the invoice for this subscription - create an upsell, add some recurring products with qty > 0 - confirm the upsell, you can see that the parent sub has been updated with the qty coming from Upsell - cancel the upsell afterward -> the parent sub has not been reverted. Problem: ======== When we cancel an upsell, the changes on the parent subscription are not reverted. The message in the chatter is improved to notify the quantities on the subscription may need to be updated. opw-3269465 Forward-Port-Of: odoo/enterprise#63752 Forward-Port-Of: odoo/enterprise#61678
Fixed a bug that caused the system to crash when users tried to add or edit outdated activities in the CRM module. The issue occurred because required data fields were not being loaded properly. This fix ensures activities can be managed smoothly regardless of their age.
Original PR description
Before this commit, when adding an outdated activity from kanban activity widget, it crashed with the following errors: `TypeError: cannot read property of undefined (reading `mail_template_ids`)` `TypeError: Cannot read properties of undefined (reading 'toLocaleString')` Steps to reproduce: - on crm lead schedule call activity and make sure that activity is at least 1 month old - book activity and save it - try to access/edit activity This happens because when the `get_today_call_activities` function is called. Function fetches fields during the records formatting, but it doesn't fetch `date_deadline` and `mail_template_ids`, therefore those fields remain undefined, hence the errors rise. task-3945492
This update fixes the informational message displayed in the CodaBox SODA import wizard for Belgian accounting users. The message text has been updated to match the latest version, ensuring users see the correct and most current guidance when importing bank statements through the CodaBox integration.
Original PR description
Backport codabox soda wizard info text from 17.1
This fix resolves a crash that occurred when users tried to select certain field types (like selection, boolean, or radio fields) while editing forms in Web Studio. The issue was caused by a recent code update that changed how the system accesses field information. Users can now successfully select and work with these field types without encountering errors.
Original PR description
Currently, an error occurs when the user tries to select a selection, boolean, or radio field. Steps to produce an error: 1. Install web_studio 2. Go to Settings > Users & Companies > Users > Select…
Currently, an error occurs when the user tries to select a selection, boolean, or radio field.
Steps to produce an error:
1. Install web_studio
2. Go to Settings > Users & Companies > Users > Select any user
3. Open studio mode by clicking the studio icon.
4. Try to select the Administration field from the access right page
Error:
```
TypeError: WebStudioController.get_default_value() missing 1 required positional argument: 'field_name'
File "odoo/http.py", line 2139, in __call__
response = request._serve_db()
File "odoo/http.py", line 1715, in _serve_db
return service_model.retrying(self._serve_ir_http, self.env)
File "odoo/service/model.py", line 133, in retrying
result = func()
File "odoo/http.py", line 1742, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 1943, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "addons/website/models/ir_http.py", line 235, in _dispatch
response = super()._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 191, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 717, in route_wrapper
result = endpoint(self, *args, **params_ok)
```
This is because before the owl refactor of webstudio with https://github.com/odoo/enterprise/pull/37285/commits/e44403193cbfd7893708ff739fd072f8bb1197c6, the code tries
to access the field name from the 'attrs' of the node (see [1]), but after Commit[1],
it tries to access the field name from the 'field' of the node (see [1]), and it works for
normal fields like text, number, etc., but not for grouped fields like selection, boolean, radio, etc.
This commit fixes the above issue by not fetching or changing the
default value of reified fields. Now, after this commit, the default
value box is not showing for the reified fields.
[1]-https://github.com/odoo/enterprise/blob/1fd7b1182146f1d7e6a7cbb9b725cb4d47281e14/web_studio/static/src/legacy/js/views/view_editor_manager.js#L1029 [2]-https://github.com/odoo/enterprise/blob/50b6e04d2e2f47797ec14bf506a030bd1d9bc797/web_studio/static/src/client_action/view_editor/interactive_editor/properties/field_properties/field_properties.js#L117
sentry-4156923959
Forward-Port-Of: odoo/enterprise#63465
Forward-Port-Of: odoo/enterprise#50249A scheduled task in the payroll system was incorrectly running monthly instead of hourly. This fix corrects the schedule settings so that PDF generation now runs every hour as originally intended, ensuring timely document processing.
Original PR description
Intended: Generate pdfs is meant to run in every hour. It was intention as well at creation and it shows from how nextcall is defined: <field name="nextcall" eval="(DateTime.now() + timedelta(hours=1))"/> Current behavior: But regardless how nextcall is defined, now the cron runs in every month. This is because interval_type is not explicitly defined on the cron and thus it takes default value - that is 'months'. To correct the cron behavior, we explicitly define interval_number and interval_type task-3960037 Forward-Port-Of: odoo/enterprise#63565
This update corrects how overtime hours are calculated in the HR system to properly account for individual employee contracts. Previously, overtime computation may not have accurately reflected contract-specific terms. This ensures employees are credited with the correct overtime hours based on their actual contract agreements.
Original PR description
task-3597205
This fix corrects an issue where clicking the partner ledger button from a customer or vendor record was incorrectly displaying transaction details instead of the Partner Ledger report. Users will now see the proper Partner Ledger report view when accessing it directly from a partner record, improving navigation accuracy and user experience.
Original PR description
Fix when opening the partner ledger directly from res.partner button it goes to account.move.line insted of Partner Ledger report 17.0
This fix addresses an issue where all new batch payments were being displayed in the reconciliation widget. A default filter has been added to hide new batch payments by default, providing a cleaner view of the reconciliation interface. This improves the user experience by reducing clutter and focusing on relevant payment batches.
Original PR description
Before this commit in the reconciliation widget, all new batch payment are show. This PR add a default filter to remove them. Before : <img width="1000" alt="image" src="https://github.com/odoo/enterprise/assets/16716992/a64ab576-00a4-4b46-8af4-5bbac4aac0ff"> After : <img width="1006" alt="image" src="https://github.com/odoo/enterprise/assets/16716992/57bc21cc-8311-4800-a1f2-fa594b6517b8">
This update corrects how overtime hours are calculated in the HR system to be based on individual employee contracts rather than using a global approach. This ensures that overtime is accurately computed according to each employee's specific contract terms, working hours, and conditions, leading to more precise payroll and attendance tracking.
Original PR description
task-3597205
This fix resolves a system crash that occurred when users tried to add an outdated activity from the activity widget. The issue happened because the system was attempting to access activity information that had already been deleted, causing an error. Users can now safely add and manage outdated activities without encountering crashes.
Original PR description
Before this commit, when adding an outdated activity from kanban activity widget, it crashed with the following error: TypeError: cannot read property of undefined (reading `mail_template_ids`) Steps…
Before this commit, when adding an outdated activity from kanban activity widget, it crashed with the following error: TypeError: cannot read property of undefined (reading `mail_template_ids`) Steps to reproduce: - on crm lead schedule call activity and make sure that activity is at least 1 month old - add activity to the Call Queue - try to access/edit activity This happens because of adding an outdated activity, this is automatically considered as an old activity, which leads to its deletion immediately after creation. OWL is rendering the template of `ActivityListPopover` while the activity is deleted, which is a problem because activity doesn't exist therefore its fields have been cleared, such as mail_template_ids that is undefined instead of a list. task-3945492 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update improves the performance of the holiday search feature by description. The change reduces database query size and prevents server overload by using a more efficient query method, ensuring the system runs smoothly when employees search for their leave records.
Original PR description
**Description of the issue/feature this PR addresses:** fine tuning of https://github.com/odoo/odoo/commit/f8182fb625eb3e20c85388d4c342553af4fe7ab9 to prevent an olverload of postgres. @thle-odoo @sofiagvaladze I have update the commit. I use 'inselect' to reduce the query size. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update removes an unnecessary rounding factor from the resource calendar calculations. The change simplifies how work hours and scheduling are computed, ensuring more accurate time tracking and resource planning without the previous rounding adjustments that could cause minor discrepancies.
Original PR description
Test (stable version)
This fix corrects how fixed-amount taxes are displayed on invoices. Previously, fixed taxes were incorrectly shown as proportional to the invoice amount. Now, fixed taxes are displayed with their actual fixed amount without any amount-based calculations, ensuring accurate tax representation on invoices.
Original PR description
[FIX] account: exclude on-amount of fixed-tax in invoices 1- When you create a fixed tax and link it to group e.g., X_group. 2- Then, create a percentage tax and link it to another group e.g., Y_group 3- Create an invoice with those two taxes => You will see the fix tax proportional to the amount and We don't want any amount to be displayed on Fixed Taxes Solution: exclude that on-amount if the tax amount_type is fixed task-id#3964942 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents the system from creating duplicate serial numbers when users perform mass production operations. Previously, the system would attempt to create serial numbers even if they already existed in the database, which could cause errors or data conflicts. Now, the system checks if a serial number already exists before creating it, ensuring cleaner and more reliable production workflows.
Original PR description
When the user performs a mass produce, the generated serial numbers will only be created if they do not already exist in the database.