Odoo Changelog — 2024-06-17

Monday, June 17, 2024

36 changes

Branch: saas-17.2

19 changes

Bug Fixes(3)

Resolved issues and error corrections

[FIX] web: clicking on old style URL link

PR #167474

Coresaas-17.2web

This fix ensures that opening older-format Odoo links no longer removes the previous record from the browser history. It also makes internal links work more smoothly when pasted links use a different http/https protocol, reducing navigation disruption for users.

Original PR description

- On a record A;
- Click on a link to open a record B (with an old style URL);
- The record B is open;

Before this commit, the record A is missing on the browser history. This
occurs because, when an old style URL is converted into a canonical URL,
a replacement of the current URL is done. This replacement was done to
update the old URL when the URL was copy/paste on the browser.
In this particular case, the replacement is not necessary, because the
current URL is the one of the record A. Doing the replacement, will
remove the record A from the browser history.

Now, the URL retro-compatibility will only update the URL, if the URL in
the browser is the one with the old style.

#browser-history#navigation#links

[FIX] mock server: look into mockRemockRpcRegistry when calling parent

PR #169229

Coresaas-17.2web

This fixes an issue in Odoo's web testing mock server so it correctly checks the expected override registry when falling back to a parent call. The change helps prevent inaccurate automated test behavior, improving confidence in future updates without affecting day-to-day users.

#testing#mock-server#quality

[FIX] web: tests - allow RPC 'parent' for all listeners

PR #169596

Coresaas-17.2web

This fix improves the internal web testing framework so test callbacks can correctly pass control to earlier registered handlers. It helps Odoo's automated tests better mirror expected behavior and reduces the risk of false failures during development.

Original PR description

Before this PR, only model-defined methods could be called by the `parent` helper function given to callbacks of `onRpc` in tests.

This meant that callbacks registered through the `mock_rpc` registry couldn't use this inheritance system (i.e a callback defined after another couldn't call the previous one).

This PR makes it so that all listeners are aligned in a queue and a call to `parent` will simply call the next callback (eventually falling back to the model-defined methods), allowing registry-defined methods to be called in between.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#tests#rpc#reliability

Other(16)

Miscellaneous changes

[FW][FIX] project: prevent infinite recurring tasks creation

PR #169523

Coresaas-17.2project

Steps to reproduce: ------------------- - in settings, activate "Recurring Tasks" - create a recurring task with a dateline to today and a recurrence every "1 Days Until tomorrow" - save - change the state to "Done" - on the new created task, change the state to "Done" Issue: ------ Steps can be repeated indefinitely, creating an infinite number of recurring tasks with a specific end date for the recurrence. Cause: ------ There is no check with the `repeat_until` field when creat

Original PR description

Steps to reproduce:
-------------------
- in settings, activate "Recurring Tasks"
- create a recurring task with a dateline to today and a recurrence every "1 Days Until tomorrow"
- save
- change the state to "Done"
- on the new created task, change the state to "Done"

Issue:
------
Steps can be repeated indefinitely, creating an infinite number of recurring tasks with a specific end date for the recurrence.

Cause:
------
There is no check with the `repeat_until` field when creating a recurring task.

opw-3941688

Forward-Port-Of: odoo/odoo#168003

Branch: master

6 changes

Refactoring(1)

Code cleanup and technical improvements

[REF] mail: flatten store data sent on network (part 1)

PR #64700

Enterprisemasterdocumentsvoipwebsite_helpdesk_livechatwhatsappmail

This update streamlines how chat, WhatsApp, VoIP, documents, and helpdesk live chat data is prepared before being sent to the browser. It reduces repeated information, which can improve responsiveness and make future performance improvements easier.

Original PR description

This will reduce data transferred to the client and processed in JS when the same member was appearing multiple times.

This also makes more clear what is transferred by avoiding nested values.

Note: this is a first step, many format methods still have to be converted, in particular the one from member, which will then allow converting the one from partner, which will significantly reduce duplicate data send for the current partner (one duplicate per open channel).

Formatting code eventually becomes simpler too, by always adding data to the store rather than updating pre-existing dict manually.

Part of task-3605717

https://github.com/odoo/odoo/pull/169484

Rows:Rows per page:

10 25 50 100

1 / 2Page 1 of 2 · 36 days total

- On a record A; - Click on a link to open a record B (with an old style URL); - The record B is open; Before this commit, the record A is missing on the browser history. This occurs because, when an old style URL is converted into a canonical URL, a replacement of the current URL is done. This replacement was done to update the old URL when the URL was copy/paste on the browser. In this particular case, the replacement is not necessary, because the current URL is the one of the record A. Doing the replacement, will remove the record A from the browser history. Now, the URL retro-compatibility will only update the URL, if the URL in the browser is the one with the old style.

Before this PR, only model-defined methods could be called by the `parent` helper function given to callbacks of `onRpc` in tests. This meant that callbacks registered through the `mock_rpc` registry couldn't use this inheritance system (i.e a callback defined after another couldn't call the previous one). This PR makes it so that all listeners are aligned in a queue and a call to `parent` will simply call the next callback (eventually falling back to the model-defined methods), allowing registry-defined methods to be called in between. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

This will reduce data transferred to the client and processed in JS when the same member was appearing multiple times. This also makes more clear what is transferred by avoiding nested values. Note: this is a first step, many format methods still have to be converted, in particular the one from member, which will then allow converting the one from partner, which will significantly reduce duplicate data send for the current partner (one duplicate per open channel). Formatting code eventually becomes simpler too, by always adding data to the store rather than updating pre-existing dict manually. Part of task-3605717 https://github.com/odoo/odoo/pull/169484

`to_recheck_leaves` stores every leave that is not yet taken into account by the "allocation_leaves_consumed" dictionary. now for some leave type, it's allocation contain False value as key of this `allocation_leaves_consumed` dictionary. because when leave_type with requires_allocation Is not yes then we pass leave type data with False as allocation. see: https://github.com/odoo/odoo/blob/7363d568df6e82119eed1cec55b3ae67a3816a1a/addons/hr_holidays/models/hr_employee.py#L565 and this will create issue when we try to calculate `latest_accrual_bonus` value by iterating consumed_content which call `_get_future_leaves_on` function but as we got allocation as False will get error : ``` File "/home/odoo/src/odoo/17.0/addons/hr_holidays/models/hr_employee.py", line 105, in _compute_allocation_remaining_display leaves_taken = self._get_consumed_leaves(allocations.holiday_status_id)[0] File "/home/odoo/src/odoo/17.0/addons/hr_holidays/models/hr_employee.py", line 582, in _get_consumed_leaves latest_accrual_bonus += allocation._get_future_leaves_on(date_to_simulate) AttributeError: 'bool' object has no attribute '_get_future_leaves_on' ``` Generated during upgrade. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#169208

### Steps to reproduce: 1. Create a BOM with 2 operations: op 1 and 2 2. Create and confirm an MO for 10 units using that BOM. 3. Put the quantity to 10 then start and done op 1 4. Put the quantity to 2 then start and done op 2 5. Produce and create a backorder 6. Put the quantity to 4 then start and done op 2 7. Produce and create a backorder #### > instead of 4 units remaining in op 2 we have 4 units remaining in op 1 ### Cause of the issue: The operations of a productions (`mrp.workorder`'s) are ordered by `leave_id`, `date_start` and then `id`: https://github.com/odoo/odoo/blob/26239b2d0bdbc2f06d50f7739d61c490248b65bb/addons/mrp/models/mrp_workorder.py#L14-L17 Since, in the first backorder, the workorder corresponding to op 1 is cancelled it has an empty `leave_id` and `date_start`. On the other hand, once the partial operation of op 2 has been completed its associated `date_start` is not empty anymore and the order of both operations is therefore swaped. However, when a backorder is created, the quantity of the workorders is set by relying on the order of operations (which is not the same with and without `leave_id`, `date_start`): https://github.com/odoo/odoo/blob/d826c3782d737fc1724887692b71b27999bf846d/addons/mrp/models/mrp_production.py#L1973-L1983 So that the data is set on the wrong line. opw-3880963 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166820

When using the new sparse gantt mode [1] users would get a crash if an appointment was visible. This is because there was an assumption the rows would always represent records of the model of the last grouping. In the sparse mode the rows represent the pill records, in this case events. So we find the parent group instead to find the relevant attendee, in that mode. `partner_id` on `calendar.event` in test models is also updated to use `.id` as `related` doesn't work well with relational fields. task-3950682 [1] e5f9c54415d3ca10378fc5729b242508396b2316 Forward-Port-Of: odoo/enterprise#63417

When triggering the onchange method of the reconciliation widget, the `_get_invoice_matching_amls_candidates` method is executed. If there are both numerical and exact tokens, it produces a query with 6 subqueries (a general query with 6 UNION ALL). This can become quite slow on database with lots of amls. Because for each of these 6 "subqueries" the FROM, JOIN and WHERE clauses are the same, we can extract all of them in a single CTE. Thanks to that the CTE is executed only once and each UNION ALL simply scans the CTE to get the correct columns + performs an additional filtering. This reduces the average execution of the query by a factor of 3-4 on hot-cache. Since the onchange is triggered each time we do something in the reconciliation widget, on average the cache is expected to be hot so the average speedup boils down to the hot-cache scenario. #### speedup Customer 17.0 database with 7M account_move_lines and 8000 accounts, the query execution, given a st_line and with both numerical and exact tokens: 7.5s -> 2.3s ##### dalibo [Standard](https://explain.dalibo.com/plan/0a6fe16h503614e0) vs [CTE](https://explain.dalibo.com/plan/495a777ef95d2980) There is also a speedup achievable with a partial multicolumn index but that's more of a case by case index. opw-3938995 Forward-Port-Of: odoo/enterprise#64433

Revisions are technical records that are never supposed to be changed (except the `active` field). If any of `res_model`, `res_id`, `revision_uuid` is changed, the spreadsheet history will be broken. Changing field `commands` could also break the spreadsheet if the json is malformed or the command is made invalid. In this commit, we prevent the admin to make any changes. Forward-Port-Of: odoo/enterprise#64401 Forward-Port-Of: odoo/enterprise#64328

Create an asset Reverse an entry in the past => In depreciation schedule, if we take the current period, initial amount in Depreciation does not correspond to the cumulative depreciation in the Depreciation Board of the asset. The reversed entry are not taken into account, which was normal before, but now we take reversal entry into account so these should be too. opw-3890144 Forward-Port-Of: odoo/enterprise#64564 Forward-Port-Of: odoo/enterprise#63821

Steps to reproduce: - Install `documents_project` - Go to one of the task and add a document - Close it Issues: In the project update the number of documents is shown however it is wrong, as it compute it by retrieving all the tasks without taking into account the state of the tasks. When clicking on the documents button you don't see documents linked to task that are closed, the desired behaviour is to see all of them and not take into account the state of the tasks. The behaviour was due to the way the domain is set on the `task_ids` in the project model. https://github.com/odoo/odoo/blob/174cb193592f12c7f4167eb34642665778deb208/addons/project/models/project.py#L332-L333 Because of this when we retrieved the documents we didn't have all the tasks. https://github.com/odoo/enterprise/blob/0e98a5fdf5e4f32eeae769552284297b9233088c/documents_project/models/project_project.py#L204 opw-3921156 Forward-Port-Of: odoo/enterprise#64603

Branch: saas-17.2

Bug Fixes(3)

[FIX] web: clicking on old style URL link

[FIX] mock server: look into mockRemockRpcRegistry when calling parent

[FIX] web: tests - allow RPC 'parent' for all listeners

Other(16)

[FW][FIX] project: prevent infinite recurring tasks creation

Branch: master

Refactoring(1)

[REF] mail: flatten store data sent on network (part 1)

Branch: saas-17.2

Bug Fixes(3)

[FIX] web: clicking on old style URL link

[FIX] mock server: look into mockRemockRpcRegistry when calling parent

[FIX] web: tests - allow RPC 'parent' for all listeners

Other(16)

[FW][FIX] project: prevent infinite recurring tasks creation

Branch: master

Refactoring(1)

[REF] mail: flatten store data sent on network (part 1)

[FW][FIX] website_livechat: do not show welcome message on chat requests

[FW][FIX] hr_holidays: fixed bool attribute error

[FW][ADD] hw_drivers: display devices on IoT display

[FW][IMP] l10n_din5008_sale: address display

[FW][FIX] resource: remove daterange widget from resources leaves views

[FW][FIX] product_expiry: scheduled_date can be false

[FW][FIX] account: fix branch fiscal not auto applying on the invoice

[FW][FIX] website_sale: Do not remove note lines

[FW][FIX] l10n_ar: allow COA reload

[FW][FIX] purchase_stock: include discounts in AVCO stock valuation

[FW][FIX] mrp: dont mix operations on backorder creation

[FW][IMP] base_import: add support for openpyxl

[FW][FIX] spreadsheet: falsy date filter traceback

[FW][FIX] mail: fix non reliable message unread counter

[FW][FIX] account: missing group by in invoice view.

Other(5)

[FW][FIX] appointment: avoid crash on sparse gantt

[FW][PERF] account_accountant: add CTE to invoice amls candidates query

[FW][FIX] documents_spreadsheet: prevent edition of revision

[FW][FIX] account_asset: reversed entry should be in depreciation schedule

[FW][FIX] documents_project: view all documents in project updates