Monday, June 17, 2024
18 changes
6 changes
Resolved issues and error corrections
The Philippine localization now uses the supported tax calculation process when generating BIR 2307 files. This prevents an error when users download the XLS certificate for vendor bills with withholding tax, allowing the document to be generated as expected.
Original PR description
Steps to reproduce: - Install l10n_ph modules - Configure Vendor Tax ID - Create Vendor Bill - Set the Vendor with Tax ID - Set a invoice lines with withholding tax - Action > Download BIR 2307 XLS Current behaviour: - Exception raised Expected behaviour: - Generate a BIR 2307 XLS file Explanation: From SaaS 17.2+, account.tax doesn't have _compute_amount anymore. It is replaced by compute_all method. opw-3991609
Duplicating a website page now creates a unique internal page identifier, preventing errors when opening or editing the copied page. This makes page duplication reliable for website editors and avoids disruptive traceback errors after refresh.
Original PR description
Since [1], the `copy` and `copy_data` methods have been refactored to handle recordsets. This change broke the `clone_page` method in the Website Page model, causing the duplicated page to have the…
Since [1], the `copy` and `copy_data` methods have been refactored to handle recordsets. This change broke the `clone_page` method in the Website Page model, causing the duplicated page to have the same view key as the original. The view key must be unique. Steps to reproduce: - Navigate to Website. - Click on the "Site" menu > "Pages". - Click on "New" and select the "blank page" template. - Enter a name for the page (e.g., NewPage1). - Click on "Create". - When the editor opens, click on "Discard". - Click on the "Site" menu > "Pages" again. - Select the checkbox next to NewPage1. - Click on "Actions" > "Duplicate". - Enter a name for the duplicated page (e.g., NewPage2) and click on "Ok" - Refresh the page (F5). - The new page appears: click on it. - Edit the page by clicking on "Edit" in the top-right corner. - Bug: Traceback error occurs. This commit fixes the bug by appending a unique ID to the duplicated view key. opw-3936237 [1]: https://github.com/odoo/odoo/commit/4ac2702c31f0e95f33f9ad554e7350bef9dab8bd
This fixes Norwegian localization tax setup by using the correct term “medium rate” and correcting which accounts are assigned to certain taxes. It helps businesses using Norwegian accounting avoid inaccurate tax reporting and better align with official SAF-T expectations.
Original PR description
- Replace "middle rate" & "average rate" by "medium rate" - Fix misusage of accounts in taxes See: https://github.com/Skatteetaten/saf-t fixes odoo/odoo#161396 task-3864178 Co-Authored-By: Henrik Norlin <henrik.norl@gmail.com> **Enterprise PR:** odoo/enterprise#64363
This fix ensures that opening older-format Odoo links no longer removes the previous record from the browser history. It also makes internal links work more smoothly when pasted links use a different http/https protocol, reducing navigation disruption for users.
Original PR description
- On a record A; - Click on a link to open a record B (with an old style URL); - The record B is open; Before this commit, the record A is missing on the browser history. This occurs because, when an old style URL is converted into a canonical URL, a replacement of the current URL is done. This replacement was done to update the old URL when the URL was copy/paste on the browser. In this particular case, the replacement is not necessary, because the current URL is the one of the record A. Doing the replacement, will remove the record A from the browser history. Now, the URL retro-compatibility will only update the URL, if the URL in the browser is the one with the old style.
This fixes an issue in Odoo's web testing mock server so it correctly checks the expected override registry when falling back to a parent call. The change helps prevent inaccurate automated test behavior, improving confidence in future updates without affecting day-to-day users.
This fix improves the internal web testing framework so test callbacks can correctly pass control to earlier registered handlers. It helps Odoo's automated tests better mirror expected behavior and reduces the risk of false failures during development.
Original PR description
Before this PR, only model-defined methods could be called by the `parent` helper function given to callbacks of `onRpc` in tests. This meant that callbacks registered through the `mock_rpc` registry couldn't use this inheritance system (i.e a callback defined after another couldn't call the previous one). This PR makes it so that all listeners are aligned in a queue and a call to `parent` will simply call the next callback (eventually falling back to the model-defined methods), allowing registry-defined methods to be called in between. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
2 changes
Resolved issues and error corrections
Appointment booking pages now avoid browser cache errors when users move back and forward after choosing an appointment. The change improves booking reliability and keeps the selected timezone consistent by prioritizing the session timezone.
Original PR description
Steps to reproduce: - Install Appointments - Login as admin (or user with appointment manager rights) - Go to URL "/appointment" - Select an appointment and clicks Continue - Click on previous button and next button => ERR_CACHE_MISS (in Chrome) or Document Expired (in Firefox) The use of "Cache-Control: no-store" leads to an issue when navigating the browser history through the previous/next buttons. When posting data from a form, this leads to a security error of the browser as it prevents the form to be resend automatically. Instead of submitting the form, we redirect manually when clicking on the continue button. Also, to avoid any issue with a previous timezone selected we reused the timezone from the session before any other if it was set. task-3945356
10 changes
Resolved issues and error corrections
The help center was displaying empty sections for knowledge articles that don't have names. This fix filters out unnamed articles so only valid articles appear, improving the visual presentation and user experience of the help center.
Original PR description
Currently in the help center, knowledge articles without names are not sorted out, leading to empty divs being displayed. This PR will fix this by excluding articles without name in the _compute_latest_articles(). task-3940889
This fix prevents spreadsheet pivot insertions from creating an extra table unless the pivot is added directly from the pivot view. It avoids unintended table creation and keeps spreadsheet behavior consistent for users.
Original PR description
Creating a table should be done only when the pivot is inserted from the pivot view, not when it is inserted with the command "INSERT_PIVOT". Task: 3987435
Fixed an issue where users couldn't open document previews by clicking on the upper part of cards in the split tool when using Safari or Firefox browsers. The fix involved adjusting the CSS styling to ensure the clickable area works properly across all browsers.
Original PR description
Bug === 1. Open Safari or Firefox 2. Open the split tool 3. We can not open the preview by clicking on the upper card of the card Technical ========= The hover effect was done with CSS trickery, so we added a new div to remove the CSS `transform` trick. Task-3863428
This fix corrects how documents are counted and displayed in project updates. Previously, the system was incorrectly filtering out documents linked to closed tasks, showing an inaccurate document count and hiding documents when users clicked to view them. Now all documents are visible regardless of task status, giving users a complete view of project documentation.
Original PR description
Steps to reproduce: - Install `documents_project` - Go to one of the task and add a document - Close it Issues: In the project update the number of documents is shown however it is wrong, as it compute it by retrieving all the tasks without taking into account the state of the tasks. When clicking on the documents button you don't see documents linked to task that are closed, the desired behaviour is to see all of them and not take into account the state of the tasks. The behaviour was due to the way the domain is set on the `task_ids` in the project model. https://github.com/odoo/odoo/blob/174cb193592f12c7f4167eb34642665778deb208/addons/project/models/project.py#L332-L333 Because of this when we retrieved the documents we didn't have all the tasks. https://github.com/odoo/enterprise/blob/0e98a5fdf5e4f32eeae769552284297b9233088c/documents_project/models/project_project.py#L204 opw-3921156 Forward-Port-Of: odoo/enterprise#64603
This fix ensures that reversed asset entries are properly reflected in the depreciation schedule. Previously, when an asset entry was reversed in the past, the depreciation schedule would show incorrect cumulative depreciation amounts because reversed entries were not being included in the calculations. This update corrects the reporting to accurately account for all reversals.
Original PR description
Create an asset Reverse an entry in the past => In depreciation schedule, if we take the current period, initial amount in Depreciation does not correspond to the cumulative depreciation in the Depreciation Board of the asset. The reversed entry are not taken into account, which was normal before, but now we take reversal entry into account so these should be too. opw-3890144 Forward-Port-Of: odoo/enterprise#64564 Forward-Port-Of: odoo/enterprise#63821
Product Label Reports have been updated and are now being blocked from editing in Studio. These reports are primarily composed of automatically generated data rather than editable model fields, making them unsuitable for customization through the Studio interface. This change prevents users from attempting to modify reports that cannot be properly edited.
Original PR description
Since https://github.com/odoo/odoo/commit/1f438ca0e109b9e93c895824bd8342a2df170503 , the various product label reports have changed their name. Is still does not make much sense to edit them from studio, since they are composed of mostly generated data and not model fields. We thus blacklist them again. opw-3942356
This fix resolves an error that occurred when creating invoices between companies using products that are only defined for one company. The system now properly handles company-specific products during inter-company transactions, allowing automatic invoice generation to work correctly without access errors.
Original PR description
…efined Steps to reproduce: - Have a company A - Have a company B - Have a Product A defined only for Company A - Activate intercompany and automatic invoice/bills in both Company A and Company B - In Company A, create an invoice with Product A and Company B as the customer - Confirm Issue: An access error is raised Cause: Because of the new access rules introduced by branches, `account.move.line` have `_check_company_auto = True` https://github.com/odoo/odoo/blob/14db39961c445a8243c2cc7af44132320a655594/addons/account/models/account_move_line.py#L23 Triggering the check at https://github.com/odoo/odoo/blob/e30853b9fbde28cd4b1dc9948e12fe2be0b03abc/odoo/models.py#L4324-L4325 Creating inconsistencies at https://github.com/odoo/odoo/blob/e30853b9fbde28cd4b1dc9948e12fe2be0b03abc/odoo/models.py#L3745-L3750 Solution: Set the product on the bill only it has no company_id set on it opw-3875354 Forward-Port-Of: odoo/enterprise#63086
This update fixes a technical issue in the Documents module where certain calculated fields used for sharing documents were missing their required dependencies. This ensures that these fields update correctly when their underlying data changes, improving the reliability of document sharing functionality.
Original PR description
Task-3924439
This update fixes how the Amazon sales connector handles subsidiary and multi-company setups. Previously, the system had issues managing Amazon accounts across different company entities within the same Odoo instance. The fix ensures that Amazon sales orders and inventory are properly synchronized across all company structures, improving reliability for organizations with multiple subsidiaries.
Original PR description
opw-3935664
This update enables credit card accounts to be treated as liquidity accounts in bank journals, allowing them to be used in the bank reconciliation process. The change updates the reconciliation wizard and Romanian SAFT reporting to properly recognize credit card accounts alongside traditional bank accounts.
Original PR description
*l10n_ro_saft According to the related community commit, we consider the account type `liability_credit_card` also as a liquidity account for bank journals. We adapt the reconciliation wizard and Romanian SAFT code to take this into account. task-3891250 Related to https://github.com/odoo/odoo/pull/166258 Forward-Port-Of: odoo/enterprise#63367 Forward-Port-Of: odoo/enterprise#63259
This update improves the Swiss payroll system with multiple fixes and enhancements, including proper handling of tax rate imports with predefined categories, corrected payslip line total calculations to support Swiss-specific rounding rules, and implementation of ELM 5 standardization for payslip computation. The changes ensure accurate payroll processing for Swiss companies and better support for complex localization requirements like canton-specific rules and foreign worker declarations.