Saturday, June 29, 2024
2 changes · master
Miscellaneous changes
## Pull Request HOOT (PRHOOT) - part 18 Part 1: https://github.com/odoo/odoo/pull/152930 Part 2: https://github.com/odoo/odoo/pull/153018 Part 3: https://github.com/odoo/odoo/pull/153023 Part 4: https://github.com/odoo/odoo/pull/153203 Part 5: https://github.com/odoo/odoo/pull/153425 Part 6: https://github.com/odoo/odoo/pull/153700 Part 7: https://github.com/odoo/odoo/pull/154054 Part 8: https://github.com/odoo/odoo/pull/154579 Part 9: https://github.com/odoo/odoo/pull/155073 Part 10
Original PR description
## Pull Request HOOT (PRHOOT) - part 18 Part 1: https://github.com/odoo/odoo/pull/152930 Part 2: https://github.com/odoo/odoo/pull/153018 Part 3: https://github.com/odoo/odoo/pull/153023 Part 4:…
## Pull Request HOOT (PRHOOT) - part 18 Part 1: https://github.com/odoo/odoo/pull/152930 Part 2: https://github.com/odoo/odoo/pull/153018 Part 3: https://github.com/odoo/odoo/pull/153023 Part 4: https://github.com/odoo/odoo/pull/153203 Part 5: https://github.com/odoo/odoo/pull/153425 Part 6: https://github.com/odoo/odoo/pull/153700 Part 7: https://github.com/odoo/odoo/pull/154054 Part 8: https://github.com/odoo/odoo/pull/154579 Part 9: https://github.com/odoo/odoo/pull/155073 Part 10: https://github.com/odoo/odoo/pull/155639 Part 11: https://github.com/odoo/odoo/pull/156255 / https://github.com/odoo/enterprise/pull/58135 Part 12: https://github.com/odoo/odoo/pull/156869 Part 13: https://github.com/odoo/odoo/pull/158384 / https://github.com/odoo/enterprise/pull/59019 Part 14: https://github.com/odoo/odoo/pull/158916 Part 15: https://github.com/odoo/odoo/pull/160292 / https://github.com/odoo/enterprise/pull/59971 Part 15.5: https://github.com/odoo/odoo/pull/166463 Part 16: https://github.com/odoo/odoo/pull/166311 Part 17: https://github.com/odoo/odoo/pull/168328 Community: https://github.com/odoo/odoo/pull/171004 This pull requests brings various improvements and fixes to Hoot and the Odoo unit test ecosystem. See the different commit messages for more details. Note: these changes are made in stable to avoid having to support multiple versions of the HOOT API. As such, these changes are intended to be strictly limited to unit tests as to not put the rest of the code base at risk. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/enterprise#65727 Forward-Port-Of: odoo/enterprise#65657
…atch payment Create a branch company and switch to it Activate SEPA Direct Debit (SDD) and add Creditor Identifier Activate Batch Payments Add a SEPA bank account on the Bank journal Add a SEPA bank account on a partner Create SEPA mandate for the partner bank account on the Bank journal Make an invoice to the partner Register payment with payment method "SEPA Direct Debit" Go to Accounting>Customer>Payments Select the payment > Hit 'Create Batch' Validate creted batch Issue: A
Original PR description
…atch payment Create a branch company and switch to it Activate SEPA Direct Debit (SDD) and add Creditor Identifier Activate Batch Payments Add a SEPA bank account on the Bank journal Add a SEPA bank…
…atch payment
Create a branch company and switch to it
Activate SEPA Direct Debit (SDD) and add Creditor Identifier
Activate Batch Payments
Add a SEPA bank account on the Bank journal
Add a SEPA bank account on a partner
Create SEPA mandate for the partner bank account on the Bank journal
Make an invoice to the partner
Register payment with payment method "SEPA Direct Debit"
Go to Accounting>Customer>Payments
Select the payment > Hit 'Create Batch'
Validate creted batch
Issue: A traceback will raise
```py
File "[...]/enterprise/account_sepa_direct_debit/models/account_payment.py", line 117, in _sdd_xml_gen_header
create_xml_node_chain(InitgPty, ['Id','OrgId','Othr','Id'], company_id.sdd_creditor_identifier)
File "[...]/odoo/tools/xml_utils.py", line 109, in create_xml_node_chain
current_node.text = last_node_value
File "src/lxml/etree.pyx", line 1039, in lxml.etree._Element.text.__set__
File "src/lxml/apihelpers.pxi", line 747, in lxml.etree._setNodeText
File "src/lxml/apihelpers.pxi", line 735, in lxml.etree._createTextNode
File "src/lxml/apihelpers.pxi", line 1538, in lxml.etree._utf8
TypeError: Argument must be bytes or unicode, got 'bool'
```
This occurs because we assign the credit identifier to the branch
company, but when validating the batch the system exports the
sdd xml using the company found on the journal
https://github.com/odoo/enterprise/blob/88d25bd184585143f39011947263e928b14551e5/account_batch_payment/models/account_batch_payment.py#L343
so the parent company that have no Creditor Identifier defined
After adding the Creditor Identifier on the parent company and trying
again the validation an error will block the action
"""Trying to generate a Direct Debit XML file containing payments from
another company than that file's creditor."""
opw-3943103
Forward-Port-Of: odoo/enterprise#64277