Saturday, July 6, 2024
23 changes
1 change
Miscellaneous changes
[ADD] account: Add tax_tag shortcut formula While we are working on a refactor for italian tax report https://github.com/odoo/odoo/pull/164064 We discovered the need for having tax_tag shortcut as the report was getting huge. So, we thought it's the time to have the tax_tags shortcut Solution: Adding 'tax_tags_formula' for the tax_tags shortcut in a similar way like aggregation_formula task-id#3969688 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/su
Original PR description
[ADD] account: Add tax_tag shortcut formula While we are working on a refactor for italian tax report https://github.com/odoo/odoo/pull/164064 We discovered the need for having tax_tag shortcut as the report was getting huge. So, we thought it's the time to have the tax_tags shortcut Solution: Adding 'tax_tags_formula' for the tax_tags shortcut in a similar way like aggregation_formula task-id#3969688 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172010 Forward-Port-Of: odoo/odoo#167979
22 changes
Enhancements to existing features
HR action buttons for launching plans, requesting appraisals, and requesting signatures now stay hidden until the employee record has been saved. This prevents users from starting actions before required employee details, such as an email address or manager, are available.
Original PR description
Before this commit, the buttons `Launch Plan`, `Request Appraisal` and `Signature Request` were visible even before the record was saved, which is not ideal because as there are fields that need to be set before we can do the actions (like an e-mail for the signature request - or a manager for an onboarding plan) This commit makes the buttons invisible until the record is saved. task: 3999996
Field service task views now open with a daily range by default instead of starting from the initial date. This makes it quicker for users to focus on the work scheduled for the current day.
Original PR description
Currently, the default range is 'initial date'. In this commit, we set the default range to 'day' for my FSM task. task:3977878
Payroll officers can now see and use the Salary Attachment menu without needing administrator access. This makes payroll-related attachment management available to the right operational users while keeping access limited to payroll officer roles and above.
Original PR description
Salary Attachment menu item isn't visible to users who have payroll app officer access rights. It is only visible to users with admin access. This change makes `Salary Attachment` menu item visible to users who have payroll officer and above access rights. task-4007927
Resolved issues and error corrections
This fixes an internal payroll accounting test related to employee leave allocation in Belgium. The change makes the test data setup more reliable by assigning values in an order that avoids accidental recalculation issues, helping keep payroll validation stable.
Original PR description
Given the definition of model hr.leave.allocation, assigning one field may lead to a recomputation fest, where sometimes a field looses its value. We simply changed the order in which fields are assigned.
This fixes an issue where changing tabs in a chart side panel could break the chart type dropdown. Users can now move between chart settings and design options without the dropdown failing.
Original PR description
The override would mistakenly reassign an object to `undefined`. How to reproduce: - Create a chart - open its sidepanel and go to the Design tab - go back to the Configuration tab - click on the cahrt type dropdown task-4032877
This fix prevents an error from appearing when users merge duplicate records in Data Cleaning. It corrects an internal reference so the merge action opens reliably after the module restructuring.
Original PR description
Cause: - This issue was caused after merging `data_merge` into `data_cleaning`. The external ID was not getting `data_merge_record_view_search_merge_action` because it is now in `data_cleaning`. this issue was introduced in this [PR](https://github.com/odoo/enterprise/pull/62979) Fix: - Corrected the module name in the external ID. task-4008186
Features or functions removed from Odoo
Unused code was removed from the Documents Spreadsheet area to complete a previous cleanup. This helps keep the product easier to maintain without changing how users work with documents or spreadsheets.
Original PR description
This commit removes the code which should have been removed following the change below mentioned in the link below. https://github.com/odoo/enterprise/pull/24727/files#diff-bddc62fd8c16d444c8ceaec48ed4d634bcb15d33cb144ad33b37821c0360067f Task-4029155
Code cleanup and technical improvements
This update renames an internal WhatsApp messaging data label to avoid conflicts with another record format. It helps keep upcoming data format changes safer and reduces the risk of confusion in the messaging system.
Original PR description
There is a conflict between the _to_store of the thread and the _to_store of the record, which will be highlighted when converting partner format to store. Thread is a specific use case which is therefore renamed to avoid issue. Part of task-3605717 https://github.com/odoo/odoo/pull/172120
Removed unused SMS-related data from WhatsApp message formatting. This is an internal cleanup that reduces unnecessary code without changing the user experience.
Original PR description
This value is never used anywhere. Part of task-3605717 https://github.com/odoo/odoo/pull/172074
The social push notification request and Twitter wall features now use newer website components instead of older internal widgets. This reduces maintenance risk and helps keep these website-related features aligned with Odoo's modern interface framework, with no intended change to business behavior.
Original PR description
*: social_push_notifications, website_twitter_wall There are 4 use cases left in the codebase: - Push notification popup request - Twitter wall - Website builder right panel - Mass mailing inner root widget This commit removes the first two, by just using public widgets instead. The third one is currently being converted to OWL in another PR. The last one will be investigated later.
Miscellaneous changes
Forward-Port-Of: odoo/enterprise#66060
Original PR description
Forward-Port-Of: odoo/enterprise#66060
This commit fixes the size of studio icons when the window is resized. The w-75 class was applied, which caused the element to be resized instead of keeping the desired width of 70px, like other icons do. Now, the icon keep the same dimensions, like any other app icon. task-3998287 Forward-Port-Of: odoo/enterprise#66123
Original PR description
This commit fixes the size of studio icons when the window is resized. The w-75 class was applied, which caused the element to be resized instead of keeping the desired width of 70px, like other icons do. Now, the icon keep the same dimensions, like any other app icon. task-3998287 Forward-Port-Of: odoo/enterprise#66123
Before this commit, when activating analytic the total column of horizontal group was displayed which was not the intended behavior but also a traceback appeared when selecting a None horizontal group because the name was undefined. Also changing the fact that the horizontal group should reload the page when changing the filter. task: 4013957 Forward-Port-Of: odoo/enterprise#65548
Original PR description
Before this commit, when activating analytic the total column of horizontal group was displayed which was not the intended behavior but also a traceback appeared when selecting a None horizontal group because the name was undefined. Also changing the fact that the horizontal group should reload the page when changing the filter. task: 4013957 Forward-Port-Of: odoo/enterprise#65548
With PostgreSQL 16, test_report_load_more_limit fails because the result of `_get_lines` is not deterministic. It is the case because the query in `_report_custom_engine_partner_vat_listing` doesn't have a ORDER BY clause. Add a ORDER BY clause to have a deterministic behavior. Forward-Port-Of: odoo/enterprise#66113 Forward-Port-Of: odoo/enterprise#65991
Original PR description
With PostgreSQL 16, test_report_load_more_limit fails because the result of `_get_lines` is not deterministic. It is the case because the query in `_report_custom_engine_partner_vat_listing` doesn't have a ORDER BY clause. Add a ORDER BY clause to have a deterministic behavior. Forward-Port-Of: odoo/enterprise#66113 Forward-Port-Of: odoo/enterprise#65991
STEP TO REPRODUCE: ================== ISSUE 1: ======== 0- Create a database without demodata 1- Go on Attendance Application 2- Click on Load demo data 3- Write in "gegegege" in search bar for employee 4 - Click again on Load demo data An error will be raised. To fix that if the demo data have been already launched this button will be hide. ISSUE 2: ======== To have this issue, today's month need to have less than 3
Original PR description
STEP TO REPRODUCE:
==================
ISSUE 1:
========
0- Create a database without demodata
1- Go on Attendance Application
2- Click on Load demo data
3- Write in "gegegege" in search bar for employee
4 - Click again on Load demo data
An error will be raised. To fix that if the demo data have been already launched this button will be hide.
ISSUE 2:
========
To have this issue, today's month need to have less than 31 days.
0- Create a database without demodata
1- Go on Attendance Application
2- Click on Load demo data
An error about month's number will be raised.
task-3983778
Forward-Port-Of: odoo/enterprise#64539When computing the number of children of an employee, if the field was never changed, it will be equal to False and appear as 0 on the form view, leading to an error in the retrieval of the appropriate IS Code. We also improve the recompute whole sheet mechanism, applying changes to salary attachments and contract modifications. Forward-Port-Of: odoo/enterprise#65799
Original PR description
When computing the number of children of an employee, if the field was never changed, it will be equal to False and appear as 0 on the form view, leading to an error in the retrieval of the appropriate IS Code. We also improve the recompute whole sheet mechanism, applying changes to salary attachments and contract modifications. Forward-Port-Of: odoo/enterprise#65799
This test expects a search result to be in a specific order but the order is not specified in the search query. With postgresql 16 it leads to random order. Forward-Port-Of: odoo/enterprise#66055 Forward-Port-Of: odoo/enterprise#65903
Original PR description
This test expects a search result to be in a specific order but the order is not specified in the search query. With postgresql 16 it leads to random order. Forward-Port-Of: odoo/enterprise#66055 Forward-Port-Of: odoo/enterprise#65903
Since [1], the shop floor application might crash when not running an update of the MRP application to add the new filter to the search view. This fix resolves this issue by ignoring the 'This Station' filter if it is not installed. [1] https://github.com/odoo/enterprise/pull/64551 Forward-Port-Of: odoo/enterprise#65987
Original PR description
Since [1], the shop floor application might crash when not running an update of the MRP application to add the new filter to the search view. This fix resolves this issue by ignoring the 'This Station' filter if it is not installed. [1] https://github.com/odoo/enterprise/pull/64551 Forward-Port-Of: odoo/enterprise#65987
# Description Previously, attempting to re-insert a list containing NaN values would cause multiple traceback errors. To resolve this, an error message will now be displayed in the input dialog when the user tries to insert a list with invalid numbers. Task: [4008696](https://www.odoo.com/odoo/project/2328/tasks/4008696?cids=2) Forward-Port-Of: odoo/enterprise#65966 Forward-Port-Of: odoo/enterprise#65592
Original PR description
# Description Previously, attempting to re-insert a list containing NaN values would cause multiple traceback errors. To resolve this, an error message will now be displayed in the input dialog when the user tries to insert a list with invalid numbers. Task: [4008696](https://www.odoo.com/odoo/project/2328/tasks/4008696?cids=2) Forward-Port-Of: odoo/enterprise#65966 Forward-Port-Of: odoo/enterprise#65592
### Steps to reproduce: 1. Navigate to the 'Recurring Plan' page and create a plan for the annual option. 2. Under a company setting: - Create a new product named test. - Add attributes/variants such as v1, v2. - In the 'Recurring Plan' tab, assign v1 and v2 to the annual plan with distinct prices(e.g., v1 = , v2 = ). - Ensure no product category is added (or leave it by default). 3. Go to 'Website': - Locate the product and switch between variants v1 and v2. - Observe th
Original PR description
### Steps to reproduce: 1. Navigate to the 'Recurring Plan' page and create a plan for the annual option. 2. Under a company setting: - Create a new product named test. - Add attributes/variants such…
### Steps to reproduce: 1. Navigate to the 'Recurring Plan' page and create a plan for the annual option. 2. Under a company setting: - Create a new product named test. - Add attributes/variants such as v1, v2. - In the 'Recurring Plan' tab, assign v1 and v2 to the annual plan with distinct prices(e.g., v1 = , v2 = ). - Ensure no product category is added (or leave it by default). 3. Go to 'Website': - Locate the product and switch between variants v1 and v2. - Observe that the product price remains unchanged upon switching, but if you add the product to the cart, the prices differ. ### Current behavior before PR: The recurring product's price doesn't get updated when choosing another variant. This is happening because the xml template shown in this form is static and not getting re-rendered when a value changes. https://github.com/odoo/enterprise/blob/saas-17.2/website_sale_subscription/views/templates.xml#L25:L42 ### Desired behavior after PR is merged: We are updating the data shown in the xml tag responsible to show the price from JS side by writing the new value in the textContent value of this xml tag. opw-3983826 Forward-Port-Of: odoo/enterprise#65457
Before this commit, receiving logs with non-ascii characters would cause a traceback. After this commit, non-ascii characters are processed correctly. With the proposed fix, should a client send an ascii-encoded string, it will still be decoded correctly, ensuring backwards compatibility. This means that if the IoT box doesn't get updated and interacts with an updated server, since the UTF-8 table covers the ascii table, it won't lead to any error server-side. OPW-4001252 Forward-Port-
Original PR description
Before this commit, receiving logs with non-ascii characters would cause a traceback. After this commit, non-ascii characters are processed correctly. With the proposed fix, should a client send an ascii-encoded string, it will still be decoded correctly, ensuring backwards compatibility. This means that if the IoT box doesn't get updated and interacts with an updated server, since the UTF-8 table covers the ascii table, it won't lead to any error server-side. OPW-4001252 Forward-Port-Of: odoo/enterprise#65956
Versions -------- - 16.0+ Steps ----- 1. Create a rental product template; 2. add an attribute w/ 2 or more values; 3. go to "Rental prices" and add new pricings for specific variants; 4. copy the product template; 5. go to the "Rental prices" of the copied product. Issue ----- The pricings refer to the products variants of the original template instead of the newly created ones. Cause ----- Default copy logic doesn't link the new pricings to the new products. Solution -
Original PR description
Versions -------- - 16.0+ Steps ----- 1. Create a rental product template; 2. add an attribute w/ 2 or more values; 3. go to "Rental prices" and add new pricings for specific variants; 4. copy the product template; 5. go to the "Rental prices" of the copied product. Issue ----- The pricings refer to the products variants of the original template instead of the newly created ones. Cause ----- Default copy logic doesn't link the new pricings to the new products. Solution -------- Add a `copy` override which creates new pricings for the proper variants. opw-3878124 Forward-Port-Of: odoo/enterprise#65871 Forward-Port-Of: odoo/enterprise#63284