Saturday, July 20, 2024
16 changes
10 changes
Miscellaneous changes
When you duplicate a payment provider, a new payment method line is generated. However, in some configurations, people specifies custom outstanding accounts on payment method lines. When duplicating the payment provider, the outstanding account is not copied and then, at the end of the payment flow, the payment raises an error because an outstanding account is missing and the journal items can't be generated. task_id: 4019380 --- I confirm I have signed the CLA and read the PR guidelines
Original PR description
When you duplicate a payment provider, a new payment method line is generated. However, in some configurations, people specifies custom outstanding accounts on payment method lines. When duplicating the payment provider, the outstanding account is not copied and then, at the end of the payment flow, the payment raises an error because an outstanding account is missing and the journal items can't be generated. task_id: 4019380 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172803 Forward-Port-Of: odoo/odoo#171715
Create an invoice Add on a line the tax 1.4%SE Confirm Open Tax report mod 303 Issue: Section "Total cuota devengada" is incorrect This occur because tax repartition line tax tags have been inverted - Invoices tax lines should be tagged with +mod303[21] - Refunds tax lines should be tagged with -mod303[26] **edit 1** Adding also a fix for the tax 'VAT 12% (agriculture)' having a negative tag on both repartition lines opw-4060963 Forward-Port-Of: odoo/odoo#173801
Original PR description
Create an invoice Add on a line the tax 1.4%SE Confirm Open Tax report mod 303 Issue: Section "Total cuota devengada" is incorrect This occur because tax repartition line tax tags have been inverted - Invoices tax lines should be tagged with +mod303[21] - Refunds tax lines should be tagged with -mod303[26] **edit 1** Adding also a fix for the tax 'VAT 12% (agriculture)' having a negative tag on both repartition lines opw-4060963 Forward-Port-Of: odoo/odoo#173801
tldr: The init function should not be used in this case for creating records. Doing so results in errors. The content of this init function can be safely moved to the post-init hook The problem: In saas~17.2, creating a company with a country can result in the installation of its accompanying localisation. If it is a European country, this will trigger the installation of base_vat too. If project_timesheet_holdiays is installed this can result in the installation of base_vat failing. The
Original PR description
tldr: The init function should not be used in this case for creating records. Doing so results in errors. The content of this init function can be safely moved to the post-init hook The problem: In…
tldr: The init function should not be used in this case for creating records. Doing so results in errors. The content of this init function can be safely moved to the post-init hook The problem: In saas~17.2, creating a company with a country can result in the installation of its accompanying localisation. If it is a European country, this will trigger the installation of base_vat too. If project_timesheet_holdiays is installed this can result in the installation of base_vat failing. The init method described on res_company in project_timesheet_holidays is triggered when the res_partner model is extended, for instance, in base_vat when adding fields. The registry will contain these fields, but the accompanying fields will not yet have been written to the db. When the project and task are created, a chain of dependencies result in the company's partner being read. In turn, a query is issued using fields from the registry that aren't yet written to the DB, resulting in an SQL error. Solution: Move the content of this method to the post-init hook. This is safe to do and works the same way. task-id: 4060907 Forward-Port-Of: odoo/odoo#173719
### Issue: The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one. ### Steps to reproduce: - In app Contact, create a new one - Select Israel as country and enter a non-valid VAT number - The default ref is displayed: 'CC##' (CC=Country Code, ##=VAT Number) - And the number 039225313 should be accepted ### Cause: he check used by the library stdnum is not up-to-date. There is a PR to modify the library stdnum: ht
Original PR description
### Issue: The reference displayed when entering a non valid VAT number for Israel is incorrect. And the check used is not the right one. ### Steps to reproduce: - In app Contact, create a new one - Select Israel as country and enter a non-valid VAT number - The default ref is displayed: 'CC##' (CC=Country Code, ##=VAT Number) - And the number 039225313 should be accepted ### Cause: he check used by the library stdnum is not up-to-date. There is a PR to modify the library stdnum: https://github.com/arthurdejong/python-stdnum/ PR436 as the law has changed. Before only corporations could have a VAT number, now individuals can also have one. ### Solution: Use the right check (tdnum.il.idnr), which is available in the library stdnum. opw-3954674 Forward-Port-Of: odoo/odoo#173767 Forward-Port-Of: odoo/odoo#172760
This solves 2 issues. The first is that the flat discount due to negative lines should be divided by the quantity. It's like a discount to the price unit. The second issue is that we rounded by mistake the price unit. So an invoice with a product that had more than 2 decimals would be wrong. opw-4039333 opw-4052821 and others --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173489
Original PR description
This solves 2 issues. The first is that the flat discount due to negative lines should be divided by the quantity. It's like a discount to the price unit. The second issue is that we rounded by mistake the price unit. So an invoice with a product that had more than 2 decimals would be wrong. opw-4039333 opw-4052821 and others --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173489
This PR is created in order to sing the odoo CLA and contribute to Odoo. needed for --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173717
Original PR description
This PR is created in order to sing the odoo CLA and contribute to Odoo. needed for --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173717
Description of the issue/feature this PR addresses: Add new contributor Rosen Vladimirov cla-file Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173805
Original PR description
Description of the issue/feature this PR addresses: Add new contributor Rosen Vladimirov cla-file Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173805
The `account` module adds the `tax_string` field to product forms: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/views/product_view.xml#L76 That field calls `Model(account.tax).compute_all()`: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/product.py#L71 That method needs access to `account.account.tag` records: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/acco
Original PR description
The `account` module adds the `tax_string` field to product forms: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/views/product_view.xml#L76 That field…
The `account` module adds the `tax_string` field to product forms: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/views/product_view.xml#L76 That field calls `Model(account.tax).compute_all()`: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/product.py#L71 That method needs access to `account.account.tag` records: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/account_tax.py#L563 https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/account_tax.py#L632 https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/account_tax.py#L648 https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/account_tax.py#L671 Internal users were able to read `account.tax` and `account.tax.repartition.line` records, but they couldn't read `account.account.tag` records. So, this lead to the absurd situation where a user with permissions to read products (like stock, PoS or event users) couldn't be able to see the product form anymore whenever that product happened to have a tax with a repartition line with a tag: https://github.com/odoo/odoo/assets/973709/1801eef5-8f1a-4883-8051-858cdd457e74 This is a regression from Odoo 14, introduced in https://github.com/odoo/odoo/pull/74138 and https://github.com/odoo/odoo/pull/73602. I'm granting all internal users read permission over `account.account.tag`, just like the one they have for `account.tax` and `account.tax.repartition.line`. BTW that's the fix suggested by Odoo helpdesk. @moduon MT-4390 OPW-3636032 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#152169 Forward-Port-Of: odoo/odoo#146787
`* = {'web', 'project', 'hr_timesheet', 'hr_holidays', 'hr_attendance', 'analytic'}` Before this Commit: The Graph view was not adaptable to the use of widgets, leading to issues with the representation of time. Specifically, hours were shown as float values in the graph view. For example, 5 hours and 30 minutes were displayed as 5.50 instead of the more intuitive hh:mm format. Although widgets like "float_time" or "timesheet_uom" were available to format these values, they were ineffe
Original PR description
`* = {'web', 'project', 'hr_timesheet', 'hr_holidays', 'hr_attendance', 'analytic'}` Before this Commit: The Graph view was not adaptable to the use of widgets, leading to issues with the…
`* = {'web', 'project', 'hr_timesheet', 'hr_holidays', 'hr_attendance',
'analytic'}`
Before this Commit:
The Graph view was not adaptable to the use of widgets, leading to issues with
the representation of time. Specifically, hours were shown as float values in
the graph view. For example, 5 hours and 30 minutes were displayed as 5.50
instead of the more intuitive hh:mm format. Although widgets like "float_time"
or "timesheet_uom" were available to format these values, they were ineffective
in the Graph view due to the architecture parser's limitations. This caused
confusion for users trying to interpret the time accurately.
After this Commit:
The Graph view is now adaptable to the use of widgets. This means that when a
widget is applied to format a field's value, the value will be displayed in the
specified format. For example, hours can now be shown in the hh:mm format
instead of as a float.
Widget `timesheet_uom` is used at places where the module is related/depended
on `hr_timesheet` otherwise `float_time`.
This improvement also ensures that the formatted values
are reflected in the Y-axis (Ticks/Intervals) of the Graph view, enhancing the
user's ability to interpret the data accurately.
Enterprise PR: https://github.com/odoo/enterprise/pull/66050
Task-3861721
Forward-Port-Of: odoo/odoo#173575
Forward-Port-Of: odoo/odoo#164280Before this commit, when dragging elements with draggable hooks, the Y coordinate of the dragged element was not correctly clamped within its container. This is because its own height wasn't taken into account and it could overflow on the bottom. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173882 Forward-Port-Of: odoo/odoo#173670
Original PR description
Before this commit, when dragging elements with draggable hooks, the Y coordinate of the dragged element was not correctly clamped within its container. This is because its own height wasn't taken into account and it could overflow on the bottom. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173882 Forward-Port-Of: odoo/odoo#173670
6 changes
Resolved issues and error corrections
This fixes incorrect unit values in the project subscription demo data. It helps ensure sample subscription records display more accurately for testing, demos, and onboarding without affecting live customer data.
Miscellaneous changes
This homogenizes the address format we send for each location and adds the terms and conditions and delivery date. This makes the customer invoice PDF that Avatax generates more complete and less confusing for users and their customers. task-3894745 Forward-Port-Of: odoo/enterprise#66929 Forward-Port-Of: odoo/enterprise#66868
Original PR description
This homogenizes the address format we send for each location and adds the terms and conditions and delivery date. This makes the customer invoice PDF that Avatax generates more complete and less confusing for users and their customers. task-3894745 Forward-Port-Of: odoo/enterprise#66929 Forward-Port-Of: odoo/enterprise#66868
…roup when opening the consolidated trial balance report, the folding/unfolding or consolidation groups were not working correctly. This was because the parent_line_id wasn't correctly passed in _get_generic_line_id opw-ticket: 4046553 Forward-Port-Of: odoo/enterprise#66990
Original PR description
…roup when opening the consolidated trial balance report, the folding/unfolding or consolidation groups were not working correctly. This was because the parent_line_id wasn't correctly passed in _get_generic_line_id opw-ticket: 4046553 Forward-Port-Of: odoo/enterprise#66990
This [commit](https://github.com/odoo/odoo/commit/12477a5401c4d0eaf39c87c17afc7f82d9018986) changed the way the French tax report computes its value to make sure they are rounded to the unit. It also unintentionally broke the auditing of the tax lines since tax tags are no longer used. The fix consists in adjusting the `expression_label` in the action in order to target the expression that uses the `tax_tags` engine, allowing to display the expected journal items. opw-3999520 Forward-P
Original PR description
This [commit](https://github.com/odoo/odoo/commit/12477a5401c4d0eaf39c87c17afc7f82d9018986) changed the way the French tax report computes its value to make sure they are rounded to the unit. It also unintentionally broke the auditing of the tax lines since tax tags are no longer used. The fix consists in adjusting the `expression_label` in the action in order to target the expression that uses the `tax_tags` engine, allowing to display the expected journal items. opw-3999520 Forward-Port-Of: odoo/enterprise#66909
The aim of this commit is reverting a part of this commit [1]. We have to do that because by removing the call to consent expiring date after the sucess, users don't receive the new consent date directly. Users have to wait until the next call to the refresh token and this call is made every 24h so users have the feeling that the consent wasn't updated. In one case, we don't have the consent expiring date provided by the TPP directly. For that case, we keep the call after the renew token. [1
Original PR description
The aim of this commit is reverting a part of this commit [1]. We have to do that because by removing the call to consent expiring date after the sucess, users don't receive the new consent date directly. Users have to wait until the next call to the refresh token and this call is made every 24h so users have the feeling that the consent wasn't updated. In one case, we don't have the consent expiring date provided by the TPP directly. For that case, we keep the call after the renew token. [1]: https://github.com/odoo/enterprise/commit/25ec0ba479372126f84fd1ece6f34aea7b1eb829 Forward-Port-Of: odoo/enterprise#65408
**Steps to reproduce:** - Install Accounting, Sales, l10n_mx_edi - Switch to a Mexican company (e.g. ESCUELA KEMPER URGATE) - Create a SO: * Customer: [a Mexican customer] (e.g. INMOBILIARIA CVA) * Order Lines: Product | Quantity | Unit Price | Taxes ---------------|----------------|----------------|---------- Product A | 1.00 | 1000.00 | 16% Product B | 1.00 | 1500.00 | 16% Product C | 1.00 |
Original PR description
**Steps to reproduce:** - Install Accounting, Sales, l10n_mx_edi - Switch to a Mexican company (e.g. ESCUELA KEMPER URGATE) - Create a SO: * Customer: [a Mexican customer] (e.g. INMOBILIARIA CVA) *…
**Steps to reproduce:**
- Install Accounting, Sales, l10n_mx_edi
- Switch to a Mexican company (e.g. ESCUELA KEMPER URGATE)
- Create a SO:
* Customer: [a Mexican customer] (e.g. INMOBILIARIA CVA)
* Order Lines:
Product | Quantity | Unit Price | Taxes
---------------|----------------|----------------|----------
Product A | 1.00 | 1000.00 | 16%
Product B | 1.00 | 1500.00 | 16%
Product C | 1.00 | 3000.00 | 16%
- Confirm the SO
- Create a 90% down payment
- Confirm down payment and generate CFDI via "Send & Print" button
- Create a regular invoice for the remaining amount
- Confirm the invoice and generate CFDI
**Issue:**
The verification of the CDFI fails because there is one line with a negative base amount.
**Cause:**
The down payment line has a negative amount.
This negative amount is dispatched between the other lines and the "base" and "importe" values of these other lines are recomputed depending on the amount that is deducted from it.
However, the computation is based on a ratio computed from the price subtotal of the negative line, but the ratio is then applied to the remaining "base" amount of the negative line, which decreases for each deducted line.
This generates incorrect values in "transferred_values_list" field for the the second line and the following ones on which some amount is dispatched.
The issue only happens on the last line on which some amount has been dispatched because it receives the remaining amount that is too high due to the values deducted by the other lines being lower than what it should has been.
**Solution:**
The ratio should be computed from the remaining "base" amount of the negative line.
opw-4033979
Forward-Port-Of: odoo/enterprise#66715