Thursday, August 29, 2024
5 changes · master
Resolved issues and error corrections
Demo bank records for Indian payroll now use correctly formatted bank identifier values. This helps ensure sample payroll data follows expected banking standards and avoids confusion during demos or testing.
Original PR description
In this commit, add formatted values for demo bank data. format: 11 characters - alphabetic code for the first four characters. - fifth character should always be zero and reserved for future use. - last 6 characters are usually numeric but can also be alphabetic. Related Task - 3794859
This fix updates how VoIP call data is refreshed so it stays reliable after underlying system changes. It also makes related automated tests faster, helping future VoIP updates be validated more efficiently.
Original PR description
The voip model was overriding `static insert` method as if this works on a single record. For some time, this method works on multiple records, and its implementation detail has changed so assuming it does `get() ?? new()` is no longer guaranteed. The intent of override was to enrich data after them being assigned. This has been converted to an override of `update()`, which guarantees it being called whenever fields are updated on record, without making too much assumption in implementation details of records. This commit also speeds up tests of VOIP, which were awaiting input that contains a value. This is not observed by mutation observer, so these tests took 3 seconds to execute. This PR puts the value in `data-value`, so that this is a mutation that can be observed by contains, thus reducting time of such test to mere dozens of ms. https://github.com/odoo/odoo/pull/177059
Clicking a journal item in Accounting no longer opens an unwanted form view. When an attachment is available, users are taken to the expected preview instead, keeping the review flow focused and avoiding confusion.
Original PR description
The bug consisted of the form view to be opened when we clicked on an aml (journal item). The expected behaviour is to preview its attachment if there is one. But we never want to show that form view The cause is a commit from RD-JS https://github.com/odoo/odoo/pull/176707/files That changed the logic of opening the form view if there is no actions. task-4132306
Commission report filters have been adjusted so users only see options they are allowed to use. This prevents confusing access-right errors and keeps reporting tools aligned with each user's permissions.
Original PR description
Before this commit, some filters raised access right errors, filter that should be used have received access right and others were hidden.
This fix removes an obsolete VAT closing warning field that could still affect tax closing workflows. It helps ensure manually edited closing entries are not unintentionally refreshed in a way that erases user changes when posting or reviewing periodic VAT entries.
Original PR description
Before this commit https://github.com/odoo/enterprise/pull/65645/commits/ba50a831bb99d9808ed28899dfe1a73e0fe7566b when posting a manually modified closing entry, the entire move would be refreshed, and all user-modified information would be erased. This occurred because, when accessing the action_periodic_vat_entries, the current tax closing move was overwritten. We also removed tax_closing_show_multi_closing_warning but didn't remove the field so this PR will remove the last occurrence of the field and the compute. task: 4083471 related upgrade PR: https://github.com/odoo/upgrade/pull/6410