Thursday, August 29, 2024
14 changes
2 changes
Resolved issues and error corrections
Users can now mark or unmark products as favorites directly from the product page. This restores expected behavior and makes it easier to manage commonly used products without extra navigation.
Original PR description
Problem: The `is_favorite` field was set to read-only on the product page, preventing users from toggling the favorite status. Steps to reproduce: - Open any product page. - Try to toggle the favorite status. opw-4139344 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fleet vehicle records now only accept numbers in the Model Year field. This prevents users from entering values like ranges or text that could cause an error when saving a vehicle.
Original PR description
Currently an error occurs when a user adds a character in the `Model Year` of fleet vehicles. Stack Trace: ``` ValueError: invalid literal for int() with base 10: '2016/2017' File "odoo/http.py",…
Currently an error occurs when a user adds a character in the `Model Year` of fleet vehicles.
Stack Trace:
```
ValueError: invalid literal for int() with base 10: '2016/2017'
File "odoo/http.py", line 2373, in __call__
response = request._serve_db()
File "odoo/http.py", line 1903, in _serve_db
return self._transactioning(
File "odoo/http.py", line 1966, in _transactioning
return service_model.retrying(func, env=self.env)
File "odoo/service/model.py", line 134, in retrying
result = func()
File "odoo/http.py", line 1933, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 2177, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 223, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 754, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 35, in call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 459, in call_kw
result = getattr(recs, name)(*args, **kwargs)
File "addons/web/models/models.py", line 73, in web_save
self = self.create(vals)
File "<decorator-gen-41>", line 2, in create
File "odoo/api.py", line 421, in _model_create_multi
return create(self, [arg])
File "addons/mail/models/mail_thread.py", line 268, in create
threads = super(MailThread, self).create(vals_list)
File "<decorator-gen-0>", line 2, in create
File "odoo/api.py", line 422, in _model_create_multi
return create(self, arg)
File "odoo/models.py", line 4768, in create
records = self._create(data_list)
File "odoo/models.py", line 4935, in _create
colval = field.convert_to_column(stored[fname], self, stored)
File "odoo/fields.py", line 1491, in convert_to_column
return int(value or 0)
```
With the recently code change with https://github.com/odoo/odoo/commit/d69cb61b6c69a4110bc1af30323d5c8b8398129b, a 'char' widget was added in the field 'model_year' so it allows entering a character instead of an of an integer.
This commit removes the 'char' widget from the mode l'model_year' so the user will allow entering only numbers.
sentry-56670643535 changes
Resolved issues and error corrections
Demo bank records for Indian payroll now use correctly formatted bank identifier values. This helps ensure sample payroll data follows expected banking standards and avoids confusion during demos or testing.
Original PR description
In this commit, add formatted values for demo bank data. format: 11 characters - alphabetic code for the first four characters. - fifth character should always be zero and reserved for future use. - last 6 characters are usually numeric but can also be alphabetic. Related Task - 3794859
7 changes
Resolved issues and error corrections
This fix prevents users from submitting documents without actually signing them. Previously, users could submit a document in Draw mode without drawing a signature, resulting in unsigned documents being sent. The fix now properly disables the submit button when no signature has been created, ensuring documents can only be submitted after a valid signature is provided.
Original PR description
This fix updates how VoIP call data is refreshed so it stays reliable after underlying system changes. It also makes related automated tests faster, helping future VoIP updates be validated more efficiently.
Original PR description
The voip model was overriding `static insert` method as if this works on a single record. For some time, this method works on multiple records, and its implementation detail has changed so assuming it does `get() ?? new()` is no longer guaranteed. The intent of override was to enrich data after them being assigned. This has been converted to an override of `update()`, which guarantees it being called whenever fields are updated on record, without making too much assumption in implementation details of records. This commit also speeds up tests of VOIP, which were awaiting input that contains a value. This is not observed by mutation observer, so these tests took 3 seconds to execute. This PR puts the value in `data-value`, so that this is a mutation that can be observed by contains, thus reducting time of such test to mere dozens of ms. https://github.com/odoo/odoo/pull/177059
Clicking a journal item in Accounting no longer opens an unwanted form view. When an attachment is available, users are taken to the expected preview instead, keeping the review flow focused and avoiding confusion.
Original PR description
The bug consisted of the form view to be opened when we clicked on an aml (journal item). The expected behaviour is to preview its attachment if there is one. But we never want to show that form view The cause is a commit from RD-JS https://github.com/odoo/odoo/pull/176707/files That changed the logic of opening the form view if there is no actions. task-4132306
Commission report filters have been adjusted so users only see options they are allowed to use. This prevents confusing access-right errors and keeps reporting tools aligned with each user's permissions.
Original PR description
Before this commit, some filters raised access right errors, filter that should be used have received access right and others were hidden.
This fix removes an obsolete VAT closing warning field that could still affect tax closing workflows. It helps ensure manually edited closing entries are not unintentionally refreshed in a way that erases user changes when posting or reviewing periodic VAT entries.
Original PR description
Before this commit https://github.com/odoo/enterprise/pull/65645/commits/ba50a831bb99d9808ed28899dfe1a73e0fe7566b when posting a manually modified closing entry, the entire move would be refreshed, and all user-modified information would be erased. This occurred because, when accessing the action_periodic_vat_entries, the current tax closing move was overwritten. We also removed tax_closing_show_multi_closing_warning but didn't remove the field so this PR will remove the last occurrence of the field and the compute. task: 4083471 related upgrade PR: https://github.com/odoo/upgrade/pull/6410
## Issue: After the changes we have made to sign in 17.0 we stop properly handling the state of the buttons for submit our sign after signing, the problem then is that in Draw mode for example, we…
## Issue: After the changes we have made to sign in 17.0 we stop properly handling the state of the buttons for submit our sign after signing, the problem then is that in Draw mode for example, we are able to submit the sign even before drawing anything, which will allow us to send the document "unsigned", since there will not be any sign. ## Steps to reproduce: 1. Get Sign module. 2. Upload any document to sign. 3. Add sign box and go to sign the document. 4. Now change from Auto to Draw. ## Solution: We should take into account that it makes sense that everytime we update if our signature is empty, we update the state of the buttons accordingly avoiding this way to be able to sign without an actual sing. The solution address a similar approach at what was already being done with the onChangeName, we move this logic to be handled by a specific function for this buttons 'handleButtonStateChange'. The fix is part of > [#164410](https://github.com/odoo/odoo/pull/164410) opw-3874034
Fixed an issue where field service technicians assigned to tasks couldn't see those tasks in their Field Service view, even though they were task followers. The fix ensures that users with limited project access can still view and work on tasks they're assigned to, improving workflow visibility for team members with restricted permissions.
Original PR description
Steps to reproduce: - Log in as admin - Project > Configuration > Projects > Field service - In the Settings tab set Visibility to 'Invited Internal Users' - Create a task with Marc Demo as assignee…
Steps to reproduce:
- Log in as admin
- Project > Configuration > Projects > Field service
- In the Settings tab set Visibility to 'Invited Internal Users'
- Create a task with Marc Demo as assignee
- Check that Marc Demo is a follower of the task and not of the project
- Settings > Users & Companies > Users > Marc Demo
- Set Marc Demo's access rights for Project and Field Service to 'User'
- Log in as Marc Demo > Field Service
- No tasks are displayed
As per the specifications of the 'Invited Internal Users' mode of project privacy, a user should be able to see tasks they are a follower of even if they do not have access to the project they are from. This is correctly reflected in Projects > Tasks > My Tasks where the followed task is visible.
This does not happen because of a lack of access rights on the task as we can copy the url of the task in Field Service as admin and access the page when pasting it as demo.
The issue here is threefold:
- The domain we use filters tasks by (project_id != False), but the project is not acessible to us so we cannot read that field. This is however redundant since the domain also contains a check on is_fsm which is read on the project, ensuring it exists.
- is_fsm is currently a field defined with both 'related' and 'search' arguments. Prior to 17.2, search is ignored in favor of search_related so the domain once again tries and fails to access the information on the related project. The search function defined here (which was previously unused) bypasses the issue by getting is_fsm through an SQL query.
- Since is_fsm is not storable on task, the search function is used to translate domains of type ('is_fsm', '=', ...). However the _search_is_fsm function did not take into account the value passed as argument (only the operator), resulting in domains like ('is_fsm', '=', 'False') not being inverted as they should.
opw-4003133This update corrects the payroll category structure for Slovak HR payroll, ensuring that deduction and allowance categories are properly assigned to employee rules only. Additionally, a data file was renamed to maintain consistency with other payroll modules in the system.
Original PR description
With this commit, some rules category are fixed : deduction, allowance are set only on employee rule. One file's name changed to be coherent with others payrolls. task-4069829
This fix resolves an issue where the rental period field was hidden when users created new rental orders through the Schedule feature in the rental module. The rental period is now properly displayed instead of being replaced by the payment period, allowing users to correctly set rental dates when creating orders.
Original PR description
…ew ro Version: 17.0 Steps: Click on the schedule feature in the rental module. Click on the 'New' to create the rental order. Issue : When a user clicks on the "Schedule" feature in the rental module and then clicks on "New" to create a rental order, the rental period feature is disabled, and the payment period appears instead. Cause : The issue is caused by the condition invisible="not is_rental_order" on the rental_start_date field. fix: To fix this issue, we remove the invisible="not is_rental_order" condition from the rental_start_date field definition. This ensures that the rental period feature is always visible when creating a new rental order. opw-4016866
This update fixes a test reliability issue in the manufacturing subcontracting accounting module. The change ensures test data is processed in a consistent order every time, preventing intermittent test failures that could occur when data was retrieved in different sequences.
Original PR description
This commit make sure the values are get in the same order every time to avoid falsy error runbot 76085 Forward-Port-Of: odoo/enterprise#68963
This fix resolves an issue where helpdesk teams in multi-company environments were incorrectly assigned field service projects from the wrong company, causing access errors. The system now properly assigns the correct field service project based on each team's assigned company, ensuring users can access their helpdesk team settings without errors.
Original PR description
Problem: Upon installing helpdesk_fsm in a multi-company setup, the default fsm project when enabling "use_fsm" on helpdesk teams is incorrectly retrieving the fsm project from the wrong company. This leads to a multi-company access error when trying to navigate to the fsm project linked to the helpdesk teams. Purpose: Instead of incorrectly defaulting the fsm project from the wrong company upon installation using a default method, compute the default of fsm project based on the team's company. Steps to Reproduce on Runbot: 1. Install Project, Field Service, and any l10n module 2. Switch to the localized company 3. Create a helpdesk team 4. Install the helpdesk_fsm module 5. Navigate to the helpdesk team settings 6. Enable "use_fsm" on the team 7. Try to access the default fsm project 8. multi-company AccessError is thrown opw-3989799 Forward-Port-Of: odoo/enterprise#68831 Forward-Port-Of: odoo/enterprise#65701
This update fixes a bug where clicking the partner ledger button from a customer or vendor record was incorrectly opening a detailed transaction list instead of the Partner Ledger report. Now users will see the correct Partner Ledger report view when accessing it directly from a partner record, providing a better experience when reviewing partner financial information.
Original PR description
[FIX] account_reports: fix opening of partner ledger from partner Fix when opening the partner ledger directly from res.partner button it goes to account.move.line insted of Partner Ledger report Signed-off-by: David Goldfeder <dgw@appti.mx> 17.0 Mexico, 2024-05-05 Appti agrees to the terms of the Odoo Corporate Contributor License Agreement v1.0. I declare that I am authorized and able to make this agreement and sign this declaration. Signed, David Goldfeder <dgw@appti.mx> https://github.com/appti-mx List of contributors: David Goldfeder <dgw@appti.mx> https://github.com/appti-mx