Thursday, August 29, 2024
41 changes
15 changes
Resolved issues and error corrections
Users can now mark or unmark products as favorites directly from the product page. This restores expected behavior and makes it easier to manage commonly used products without extra navigation.
Original PR description
Problem: The `is_favorite` field was set to read-only on the product page, preventing users from toggling the favorite status. Steps to reproduce: - Open any product page. - Try to toggle the favorite status. opw-4139344 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fleet vehicle records now only accept numbers in the Model Year field. This prevents users from entering values like ranges or text that could cause an error when saving a vehicle.
Original PR description
Currently an error occurs when a user adds a character in the `Model Year` of fleet vehicles. Stack Trace: ``` ValueError: invalid literal for int() with base 10: '2016/2017' File "odoo/http.py",…
Currently an error occurs when a user adds a character in the `Model Year` of fleet vehicles.
Stack Trace:
```
ValueError: invalid literal for int() with base 10: '2016/2017'
File "odoo/http.py", line 2373, in __call__
response = request._serve_db()
File "odoo/http.py", line 1903, in _serve_db
return self._transactioning(
File "odoo/http.py", line 1966, in _transactioning
return service_model.retrying(func, env=self.env)
File "odoo/service/model.py", line 134, in retrying
result = func()
File "odoo/http.py", line 1933, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 2177, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 223, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 754, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 35, in call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 459, in call_kw
result = getattr(recs, name)(*args, **kwargs)
File "addons/web/models/models.py", line 73, in web_save
self = self.create(vals)
File "<decorator-gen-41>", line 2, in create
File "odoo/api.py", line 421, in _model_create_multi
return create(self, [arg])
File "addons/mail/models/mail_thread.py", line 268, in create
threads = super(MailThread, self).create(vals_list)
File "<decorator-gen-0>", line 2, in create
File "odoo/api.py", line 422, in _model_create_multi
return create(self, arg)
File "odoo/models.py", line 4768, in create
records = self._create(data_list)
File "odoo/models.py", line 4935, in _create
colval = field.convert_to_column(stored[fname], self, stored)
File "odoo/fields.py", line 1491, in convert_to_column
return int(value or 0)
```
With the recently code change with https://github.com/odoo/odoo/commit/d69cb61b6c69a4110bc1af30323d5c8b8398129b, a 'char' widget was added in the field 'model_year' so it allows entering a character instead of an of an integer.
This commit removes the 'char' widget from the mode l'model_year' so the user will allow entering only numbers.
sentry-5667064353Miscellaneous changes
Issue: the reserved quantity appearing on the SOL wizard is not well behaved with respect to 2+ steps deliveries. ### Steps to reproduce: - Enable Multi-step routes in the settings - Inventory > Configuration > Warehouse Management > Warehouses - Enable delivery in 2 steps - Create a storable product and put 1 unit in stock - Create and confirm an SO for 1 unit - Click on the chart icon next to the delivered qty #### > the reserved qty is 0 + "No future availability" even though 1
Original PR description
Issue: the reserved quantity appearing on the SOL wizard is not well behaved with respect to 2+ steps deliveries. ### Steps to reproduce: - Enable Multi-step routes in the settings - Inventory >…
25 changes
Enhancements to existing features
Automated checks were added for the Planning front end to help catch issues before they reach users. This reduces the risk that future changes accidentally break key planning workflows.
Original PR description
Currently there are no tests for the planning's front end. This means that changes in the code could break the front end's functionality without anyone noticing. Unfortunately, with the way that the front end is set-up there is no formal way to test the front-end like the back-end. This commit adds two tours which should make sure that the main functionalities of the front end are tested for future potential changes. task-3800770
1 change
Resolved issues and error corrections
This update fixes a test reliability issue in the manufacturing subcontracting accounting module. The change ensures test data is processed in a consistent order every time, preventing intermittent test failures that could occur when data was retrieved in different sequences.
Original PR description
This commit make sure the values are get in the same order every time to avoid falsy error runbot 76085 Forward-Port-Of: odoo/enterprise#68963
Issue: the reserved quantity appearing on the SOL wizard is not well behaved with respect to 2+ steps deliveries. ### Steps to reproduce: - Enable Multi-step routes in the settings - Inventory > Configuration > Warehouse Management > Warehouses - Enable delivery in 2 steps - Create a storable product and put 1 unit in stock - Create and confirm an SO for 1 unit - Click on the chart icon next to the delivered qty #### > the reserved qty is 0 + "No future availability" even though 1 unit is reserved from stock ### Cause of the issue: The reserved qty displayed on the next to the delivered qty on the SOL is the `qty_available_today` computed field of the SOL model. This field is computed by summing the qties of the stock moves linked to the SOL: https://github.com/odoo/odoo/blob/817186b7b896c9a415bd947baf189bf7f1bde321/addons/sale_stock/models/sale_order_line.py#L69 https://github.com/odoo/odoo/blob/817186b7b896c9a415bd947baf189bf7f1bde321/addons/sale_stock/models/sale_order_line.py#L80-L81 However, when you are not delivering in 1 step, the only delivery move linked to the SOL will be the move which destination is the customer location. To be more precise, confirming the SO in a delivery in two steps a stock move from the Output to the customer will be created and linked to the SOL. During the action confirm of this move a procurement will be run to generate a move from stock to the Output but the SOL will not be referenced anymore so that the SOL will not be linked to it. ### Note: The behavior is different in saas-17.2 where each of the delivering move is linked to the SOL so that the probably need to be adapted. opw-3981935 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#176891 Forward-Port-Of: odoo/odoo#176756
Currently the amount due of a move was always sent in an email for any type of move. The condition only checked if there was an `invoice_date_due` set. This field is set for any kind of move and default to the creation date of that move. However it only makes sense to show amounts due for invoices, bills, receipts and credit notes. Showing these for miscellaneous moves like the tax closing entry causes users to be confused. The amount displayed is the total amount of the move and not the amou
Original PR description
Currently the amount due of a move was always sent in an email for any type of move. The condition only checked if there was an `invoice_date_due` set. This field is set for any kind of move and default to the creation date of that move. However it only makes sense to show amounts due for invoices, bills, receipts and credit notes. Showing these for miscellaneous moves like the tax closing entry causes users to be confused. The amount displayed is the total amount of the move and not the amount to be paid to the authorities. This fix makes sure we only show the amount due in emails for the right move types in order not to confuse users. Task link: https://www.odoo.com/odoo/project/967/tasks/4042715 opw-4042715 Forward-Port-Of: odoo/odoo#176172 Forward-Port-Of: odoo/odoo#174819
…number Steps to reproduce: [l10n_ec] - Create a credit note from the Bill journal - Set a foreign customer - Set a customized document number Issue: An error will be raised saying that the format is not correct But, as defined by VBE, "If a Credit Note is created from a Vendor Bill and the partner_id != "EC", [we should] allow the user to allocate any number without following the EC format." Solution: When we call `_format_document_number` we don't have any information about t
Original PR description
…number Steps to reproduce: [l10n_ec] - Create a credit note from the Bill journal - Set a foreign customer - Set a customized document number Issue: An error will be raised saying that the format is not correct But, as defined by VBE, "If a Credit Note is created from a Vendor Bill and the partner_id != "EC", [we should] allow the user to allocate any number without following the EC format." Solution: When we call `_format_document_number` we don't have any information about the initial move. Instead of using a context or adding new fields, we add a hook in which we can specify certain conditions to bypass the document check/formatting for localisations. opw-3993305 Forward-Port-Of: odoo/odoo#177597 Forward-Port-Of: odoo/odoo#174950
Before this commit when being in a branches environment, creating an account group on the main company was not propagated to the account of the child companies opw: 4055582 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173634
Original PR description
Before this commit when being in a branches environment, creating an account group on the main company was not propagated to the account of the child companies opw: 4055582 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173634
This PR fixes issues linked to the fact that the sliding of carousels is an asynchronous operation. Indeed, the options and the history of the carousels were not taking this into account. - [FIX] website: always set the first carousel slide as the active one - [FIX] website: make the `Carousel` options atomic - [FIX] website: prevent recording sliding of some carousels in history - [FIX] website: add a tour to test the `Carousel` options task-3744613 related to opw-3675019 Forward-Po
Original PR description
This PR fixes issues linked to the fact that the sliding of carousels is an asynchronous operation. Indeed, the options and the history of the carousels were not taking this into account. - [FIX] website: always set the first carousel slide as the active one - [FIX] website: make the `Carousel` options atomic - [FIX] website: prevent recording sliding of some carousels in history - [FIX] website: add a tour to test the `Carousel` options task-3744613 related to opw-3675019 Forward-Port-Of: odoo/odoo#173684 Forward-Port-Of: odoo/odoo#153892
Before this commit the tax grid of the tax was wrong. The value of this tax should be put in the total sales of goods and services in Field C in the tax report. link to documentation: https://skat.dk/erhverv/moms/moms-ved-handel-med-udlandet/moms-ved-handel-med-virksomheder/moms-ved-handel-med-lande-uden-for-eu/moms-ved-salg-af-varer-og-ydelser-i-lande-uden-for-eu task: 4132444 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Po
Original PR description
Before this commit the tax grid of the tax was wrong. The value of this tax should be put in the total sales of goods and services in Field C in the tax report. link to documentation: https://skat.dk/erhverv/moms/moms-ved-handel-med-udlandet/moms-ved-handel-med-virksomheder/moms-ved-handel-med-lande-uden-for-eu/moms-ved-salg-af-varer-og-ydelser-i-lande-uden-for-eu task: 4132444 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#177566
When calling apply_inheritance_specs and moving a node (before after or inside), we merge the text content of the adjacents nodes. If the parent and target node both have no text, we should not set the text to an empty string. When a node has no text, it is serialized as follows: `<node/>` But if it has an empty string, it has the following representation: `<node></node>` In the linked PR, we now apply the studio inheritance manually, and since we use the resulting tree directly i
Original PR description
When calling apply_inheritance_specs and moving a node (before after or inside), we merge the text content of the adjacents nodes. If the parent and target node both have no text, we should not set the text to an empty string. When a node has no text, it is serialized as follows: `<node/>` But if it has an empty string, it has the following representation: `<node></node>` In the linked PR, we now apply the studio inheritance manually, and since we use the resulting tree directly instead of parsing the result, the `remove_blank_text` option of the parser has no effect. This causes existing tests to show some difference. opw-3819667 Forward-Port-Of: odoo/odoo#178037 Forward-Port-Of: odoo/odoo#175867
**Current behavior:** When a kit bom product move line is broken down into move lines for its component products, changes written to the move line (not on the move) will not carry over to the new move nor move lines. **Expected behavior:** The change should be observed beyond the decomposition. **Steps to reproduce:** 1. Create a new internal transfer in barcode 2. Add a product with some bom via form, also edit the destination location in the form to be something non-
Original PR description
**Current behavior:** When a kit bom product move line is broken down into move lines for its component products, changes written to the move line (not on the move) will not carry over to the new…
**Current behavior:**
When a kit bom product move line is broken down into move lines
for its component products, changes written to the move line
(not on the move) will not carry over to the new move nor move
lines.
**Expected behavior:**
The change should be observed beyond the decomposition.
**Steps to reproduce:**
1. Create a new internal transfer in barcode
2. Add a product with some bom via form, also edit the
destination location in the form to be something
non-default.
3. Save the form, validate the transfer
4. See that the broken down move lines don't keep the changed
destination location
**Cause of the issue:**
When the kit bom moves are exploded, the location information of
its move lines is not taken into account at any point- and thus
it's lost.
**Fix:**
For kit bom products, use a move line's location information
during creation of a move as opposed to the picking. Only link a
new move line for a kit bom product to an existing move if (in
addition to the product) the location source and destination
values match.
opw-4016702
Forward-Port-Of: odoo/odoo#173347When an editable content is dropped in the website form, the editable elements identification and adaptation happens on `start()` (async). In a normal user interaction context, the dropped content would be set as editable in time, but when doing automated testing, we need to make sure the dropped content has `[contenteditable=true]` before editing its content. Remark: This commit also removes the `_keydown()` test function from the tour (since it still uses the deprecated `execCommand
Original PR description
When an editable content is dropped in the website form, the editable elements identification and adaptation happens on `start()` (async). In a normal user interaction context, the dropped content would be set as editable in time, but when doing automated testing, we need to make sure the dropped content has `[contenteditable=true]` before editing its content. Remark: This commit also removes the `_keydown()` test function from the tour (since it still uses the deprecated `execCommand()`) and replaces it with a simple `run: "text ..."`. runbot-64816 Forward-Port-Of: odoo/odoo#165361
### Description of the issue/feature this PR addresses: 1. Add validation to CI and NIE identification types. 2. Improve the RUT message to more clear message about the expected format. Before this change only RUT document type was validated. With this new change we are able to validate also NIE and CI Uruguayan document types ### Current behavior before PR: 1. Trying to set an invalid NIE to a contact, there is not warning for the user and we let the user to store the number. 2. R
Original PR description
### Description of the issue/feature this PR addresses: 1. Add validation to CI and NIE identification types. 2. Improve the RUT message to more clear message about the expected format. Before this…
### Description of the issue/feature this PR addresses: 1. Add validation to CI and NIE identification types. 2. Improve the RUT message to more clear message about the expected format. Before this change only RUT document type was validated. With this new change we are able to validate also NIE and CI Uruguayan document types ### Current behavior before PR: 1. Trying to set an invalid NIE to a contact, there is not warning for the user and we let the user to store the number. 2. RUT: If we set an invalid number we receive the warning but the suggested format is not ok  ### Desired behavior after PR is merged: 1. If invalid RUT: improve error message:  2. If we set an invalid NIE to a contact we receive message warning that is not a valid one  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#177118 Forward-Port-Of: odoo/odoo#173451
Steps to reproduce: - Install Sign - Open Sign, add a document and put a signature box - Make the sign box have a weird aspect ratio (very short and super wide for example) Issues: When you sign with the frame, the frame will be partially hidden making the hash invisible. Solution: Put the container back just like in the 16.0, that way we don't have the weird CSS behavior that we had previously. opw-4042289 Forward-Port-Of: odoo/odoo#175819
Original PR description
Steps to reproduce: - Install Sign - Open Sign, add a document and put a signature box - Make the sign box have a weird aspect ratio (very short and super wide for example) Issues: When you sign with the frame, the frame will be partially hidden making the hash invisible. Solution: Put the container back just like in the 16.0, that way we don't have the weird CSS behavior that we had previously. opw-4042289 Forward-Port-Of: odoo/odoo#175819
__Current behavior before commit:__ When you check out your cart with a product not in the stock anymore you have an error message. There is no product name in this message so if you have multiple products in your cart you don't know which one to remove. __Description of the fix:__ Add the product name in the error message, so it's easy to identify which product to remove of the cart. The warning method is linked to sale.order.line so we can access to the product directly. __Steps to re
Original PR description
__Current behavior before commit:__ When you check out your cart with a product not in the stock anymore you have an error message. There is no product name in this message so if you have multiple products in your cart you don't know which one to remove. __Description of the fix:__ Add the product name in the error message, so it's easy to identify which product to remove of the cart. The warning method is linked to sale.order.line so we can access to the product directly. __Steps to reproduce the issue:__ - add products to your cart - remove one or many products of the stock - try to validate your payment opw-4016059 (upgrade issues) Forward-Port-Of: odoo/odoo#177068 Forward-Port-Of: odoo/odoo#174615
Issue ---- The date fields in the activity view aren't displayed according to the language's date/time formats. Steps ----- - Go to Settings -> Translations -> Language. - Use a custom date & time format. - Create a new model that has an activity view, say a project task. You'll see the task's deadline is displayed according to your format (correct behavior). - Add an activity and set a due date. - The "Created" & "Due On" dates don't match your custom format. Cause ----- I
Original PR description
Issue ---- The date fields in the activity view aren't displayed according to the language's date/time formats. Steps ----- - Go to Settings -> Translations -> Language. - Use a custom date & time format. - Create a new model that has an activity view, say a project task. You'll see the task's deadline is displayed according to your format (correct behavior). - Add an activity and set a due date. - The "Created" & "Due On" dates don't match your custom format. Cause ----- In the activity component, the dates weren't formated according to the current language's date/time format but rather a hard-coded one. opw-3929864 Forward-Port-Of: odoo/odoo#168074
Forms now automatically let fields without labels use the full available width inside grouped sections. This removes the need for extra layout settings and reduces awkward empty space in accounting, payroll, delivery, localization, and manufacturing screens.
Original PR description
Grid is set to use 2 columns in a `<group/>` used as an inner group.
So before this commit, we had to put `colspan="2"` to force no label
fields to take all the available space.
If not, the field was located in the first column and you had some
empty space on the right due to the second column.
In this commit, we want to make this attribute optional when
`nolabel="1"` by collapsing these 2 columns automatically.
<group string="...">
<field name="x2many_field" nolabel="1"/>
</group>Resolved issues and error corrections
Demo bank records for Indian payroll now use correctly formatted bank identifier values. This helps ensure sample payroll data follows expected banking standards and avoids confusion during demos or testing.
Original PR description
In this commit, add formatted values for demo bank data. format: 11 characters - alphabetic code for the first four characters. - fifth character should always be zero and reserved for future use. - last 6 characters are usually numeric but can also be alphabetic. Related Task - 3794859
This fix updates how VoIP call data is refreshed so it stays reliable after underlying system changes. It also makes related automated tests faster, helping future VoIP updates be validated more efficiently.
Original PR description
The voip model was overriding `static insert` method as if this works on a single record. For some time, this method works on multiple records, and its implementation detail has changed so assuming it does `get() ?? new()` is no longer guaranteed. The intent of override was to enrich data after them being assigned. This has been converted to an override of `update()`, which guarantees it being called whenever fields are updated on record, without making too much assumption in implementation details of records. This commit also speeds up tests of VOIP, which were awaiting input that contains a value. This is not observed by mutation observer, so these tests took 3 seconds to execute. This PR puts the value in `data-value`, so that this is a mutation that can be observed by contains, thus reducting time of such test to mere dozens of ms. https://github.com/odoo/odoo/pull/177059
Clicking a journal item in Accounting no longer opens an unwanted form view. When an attachment is available, users are taken to the expected preview instead, keeping the review flow focused and avoiding confusion.
Original PR description
The bug consisted of the form view to be opened when we clicked on an aml (journal item). The expected behaviour is to preview its attachment if there is one. But we never want to show that form view The cause is a commit from RD-JS https://github.com/odoo/odoo/pull/176707/files That changed the logic of opening the form view if there is no actions. task-4132306
Commission report filters have been adjusted so users only see options they are allowed to use. This prevents confusing access-right errors and keeps reporting tools aligned with each user's permissions.
Original PR description
Before this commit, some filters raised access right errors, filter that should be used have received access right and others were hidden.
Code cleanup and technical improvements
The Belgian salary contract module’s browser code was modernized by replacing older jQuery usage with standard JavaScript. This is an internal cleanup that helps reduce technical dependencies and supports easier long-term maintenance without changing expected business behavior.
Original PR description
Description of the issue/feature this PR addresses: This PR aim to convert all jQuery code into Vanilla JS in hr_contract_salary, this way we will reduce the dependency of jQuery in Odoo codebase. task-3770362
Miscellaneous changes
[IMP] l10n_in_asset: add unit tests to indian asset depreciation This is about adding test to the new indian asset depreciation feature https://github.com/odoo/enterprise/pull/67225/commits/23591bb39500018afb3c4dab1c33c665c5f3a064 task-id#3909619 original-pr: https://github.com/odoo/enterprise/pull/67225 Forward-Port-Of: odoo/enterprise#69098 Forward-Port-Of: odoo/enterprise#68460
Original PR description
[IMP] l10n_in_asset: add unit tests to indian asset depreciation This is about adding test to the new indian asset depreciation feature https://github.com/odoo/enterprise/pull/67225/commits/23591bb39500018afb3c4dab1c33c665c5f3a064 task-id#3909619 original-pr: https://github.com/odoo/enterprise/pull/67225 Forward-Port-Of: odoo/enterprise#69098 Forward-Port-Of: odoo/enterprise#68460
Steps to reproduce: - Install `l10n_{ar,pe}_pos` and `l10n_ec_edi_pos` - Enable "Use QR Code on ticket" - Make an order and validate it inside the POS - Open in an incognito window the link given by the QR Code Issues: Internal error, the cause is the multiple else that are added to the `get_info_div` block. This problem is blocking #175591 and #175593 related community PR: https://github.com/odoo/odoo/pull/176746 Forward-Port-Of: odoo/enterprise#68432
Original PR description
Steps to reproduce:
- Install `l10n_{ar,pe}_pos` and `l10n_ec_edi_pos`
- Enable "Use QR Code on ticket"
- Make an order and validate it inside the POS
- Open in an incognito window the link given by the QR Code
Issues:
Internal error, the cause is the multiple else that are added to the `get_info_div` block.
This problem is blocking #175591 and #175593
related community PR: https://github.com/odoo/odoo/pull/176746
Forward-Port-Of: odoo/enterprise#68432Because of https://github.com/odoo/odoo/blob/e1fb54cb3d5db9c906946fa11ff49c1ca86d3722/odoo/fields.py#L620-L621, writing on a field which is `related` and `readonly=False` will effectively forward the new value on the parent field if this one is also `readonly=False`. This was not the case for fields + `intercompany_warehouse_id` + `intercompany_sync_delivery_receipt` + `intercompany_receipt_type_id` defined in res_company and related in res_config_setting As they are computed fiel
Original PR description
Because of https://github.com/odoo/odoo/blob/e1fb54cb3d5db9c906946fa11ff49c1ca86d3722/odoo/fields.py#L620-L621, writing on a field which is `related` and `readonly=False` will effectively forward the new value on the parent field if this one is also `readonly=False`. This was not the case for fields + `intercompany_warehouse_id` + `intercompany_sync_delivery_receipt` + `intercompany_receipt_type_id` defined in res_company and related in res_config_setting As they are computed fields which implies that are `readonly=True` by default. Forward-Port-Of: odoo/enterprise#69067
Changes ----- Since 17.2, the subscription view in the portal only shows what will be invoiced next. SO lines of non recurring products are hidden if already invoiced. This commit makes the following changes: 1. When viewing a subscription in the portal from the Orders button, the breadcrumb links to the Subscriptions page instead of the Sales Orders page. 2. To allow the user to see non recurring products of a subscription, accessing previous orders from the "History" link of a subscripti
Original PR description
Changes ----- Since 17.2, the subscription view in the portal only shows what will be invoiced next. SO lines of non recurring products are hidden if already invoiced. This commit makes the following changes: 1. When viewing a subscription in the portal from the Orders button, the breadcrumb links to the Subscriptions page instead of the Sales Orders page. 2. To allow the user to see non recurring products of a subscription, accessing previous orders from the "History" link of a subscription will link to the sales orders (which show the non recurring lines). opw-4028536 Forward-Port-Of: odoo/enterprise#67595
Before this Fix =============== The repost and like operations on the feed view lead to failure. Reason ====== Due to the modifications in [code](https://github.com/odoo/odoo/blob/844ef1895c8fd4f39c5bebe7e3cffa5a6e68fe0d/addons/web/controllers/home.py#L37) any RPC calls with URLs starting with 'social_twitter/' are now being redirected to the mentioned controller, causing errors and operational failures. After this Fix ============== Rpcs call will be redirected to the respected cont
Original PR description
Before this Fix =============== The repost and like operations on the feed view lead to failure. Reason ====== Due to the modifications in [code](https://github.com/odoo/odoo/blob/844ef1895c8fd4f39c5bebe7e3cffa5a6e68fe0d/addons/web/controllers/home.py#L37) any RPC calls with URLs starting with 'social_twitter/' are now being redirected to the mentioned controller, causing errors and operational failures. After this Fix ============== Rpcs call will be redirected to the respected controller and operations will not fail. Task-4072724 Forward-Port-Of: odoo/enterprise#68298
Before this commit, there were discrepancies between a kanban view with or without the progress bar. The kanban view, with the progress bar, have the count of each group (folded or not). Contrariwise, the kanban view, without the progress bar, only have the count of the folded groups. This commit adds a count to all the columns of the kanban view, folded or not, with the progress bar or without. opw-4132389 Forward-Port-Of: odoo/enterprise#69048
Original PR description
Before this commit, there were discrepancies between a kanban view with or without the progress bar. The kanban view, with the progress bar, have the count of each group (folded or not). Contrariwise, the kanban view, without the progress bar, only have the count of the folded groups. This commit adds a count to all the columns of the kanban view, folded or not, with the progress bar or without. opw-4132389 Forward-Port-Of: odoo/enterprise#69048
**Current behavior:** In Barcode, it is possible for a split of incomplete moves to be triggered which leaves the original move with a quantity and demand of zero- effectively generating a superfluous record value. **Expected behavior:** A split should not occur when the original line has `quantity == 0`. **Steps to reproduce:** 1. Create a transfer for 2 units of some product, assign it 2. Open the transfer in Barcode and use the form to add 1 unit 3. Use the back button with
Original PR description
**Current behavior:** In Barcode, it is possible for a split of incomplete moves to be triggered which leaves the original move with a quantity and demand of zero- effectively generating a…
**Current behavior:**
In Barcode, it is possible for a split of incomplete moves to be
triggered which leaves the original move with a quantity and
demand of zero- effectively generating a superfluous record
value.
**Expected behavior:**
A split should not occur when the original line has
`quantity == 0`.
**Steps to reproduce:**
1. Create a transfer for 2 units of some product, assign it
2. Open the transfer in Barcode and use the form to add 1 unit
3. Use the back button within the Barcode app to return to the
previous action
4. Reopen the transfer, set the quantity on the move to 0 from 1
5. Use the back button to exit the transfer again
6. Open the transfer in the backend to see there is a move with
a line for 0 / 0 units.
**Cause of the issue:**
We split moves if their quantity is less than demand without
considering it may be zero.
**Fix:**
Reset the move in the case of `quantity == 0`- thus it will no
longer become a split candidate.
opw-4056241
Forward-Port-Of: odoo/enterprise#69046
Forward-Port-Of: odoo/enterprise#68554Once an archived employee has a draft contract archived, he is deleted. We should not do that as it tries to delete some of employees that really have worked in the company. So we aslo check that the employee we want to delete has no other contract in the company. We also don't need to look after cars, as they are not created if the contract is not signed. Forward-Port-Of: odoo/enterprise#68606
Original PR description
Once an archived employee has a draft contract archived, he is deleted. We should not do that as it tries to delete some of employees that really have worked in the company. So we aslo check that the employee we want to delete has no other contract in the company. We also don't need to look after cars, as they are not created if the contract is not signed. Forward-Port-Of: odoo/enterprise#68606
SEPA file was generated for payslips even if the wage was 0. It should not be the case. This fix filters the payslips to generate SEPA file only for those with wage>0. Forward-Port-Of: odoo/enterprise#69052
Original PR description
SEPA file was generated for payslips even if the wage was 0. It should not be the case. This fix filters the payslips to generate SEPA file only for those with wage>0. Forward-Port-Of: odoo/enterprise#69052
As we force sending the mail to the signatories, we've put a commit in the transaction before sending the mail to ensure the document is signed before sending the mail. The issue is that if the transcation failed later in an override (e.g. create a car, send another document, ...), the document is signed and the transaciton has only been partially processed. To avoid this kind o issues (silent errors), we are using the function 'send_after_commit' instead of 'send' to only send the email w
Original PR description
As we force sending the mail to the signatories, we've put a commit in the transaction before sending the mail to ensure the document is signed before sending the mail. The issue is that if the transcation failed later in an override (e.g. create a car, send another document, ...), the document is signed and the transaciton has only been partially processed. To avoid this kind o issues (silent errors), we are using the function 'send_after_commit' instead of 'send' to only send the email when the entire transaction is processed. Forward-Port-Of: odoo/enterprise#68975
The constraint here fails because when uploading the certificate, password and key through the settings, the values are written one by one on the company, which made it fail in case the password is written first (the constraint would test the password on empty values and throw an error). The groups right is not useful anymore as the flow uses sudo to modify it outside of the settings. Forward-Port-Of: odoo/enterprise#68826 Forward-Port-Of: odoo/enterprise#67874
Original PR description
The constraint here fails because when uploading the certificate, password and key through the settings, the values are written one by one on the company, which made it fail in case the password is written first (the constraint would test the password on empty values and throw an error). The groups right is not useful anymore as the flow uses sudo to modify it outside of the settings. Forward-Port-Of: odoo/enterprise#68826 Forward-Port-Of: odoo/enterprise#67874
When filling big numbers (10+ digits) in the input field with Actual Demand/Replenishment activated, the field limits itself to 38% of the cell width, which then crops the number inside. This fix replace the inline-flex by a normal flex, as well as removes the max-width. This way if Actual Demand/Replenishment is activated, it will be shown over 2 lines in the cell. fp-request Forward-Port-Of: odoo/enterprise#69040 Forward-Port-Of: odoo/enterprise#66164
Original PR description
When filling big numbers (10+ digits) in the input field with Actual Demand/Replenishment activated, the field limits itself to 38% of the cell width, which then crops the number inside. This fix replace the inline-flex by a normal flex, as well as removes the max-width. This way if Actual Demand/Replenishment is activated, it will be shown over 2 lines in the cell. fp-request Forward-Port-Of: odoo/enterprise#69040 Forward-Port-Of: odoo/enterprise#66164
Steps: - Install `marketing_automation` and `web_studio` - Open Marketing Automation and studio - Click "Edit Menu" - Click "New Menu" - Set a name - Set Existing Model - Select "Marketing Activity" - Confirm - Try to use this new menu - Traceback This is because a compute is triggered in marketing_activity and we use `literal_eval` on domain fields unsetted. `literal_eval` works only with string https://docs.python.org/3/library/ast.html#a
Original PR description
Steps:
- Install `marketing_automation` and `web_studio`
- Open Marketing Automation and studio
- Click "Edit Menu"
- Click "New Menu"
- Set a name
- Set Existing Model
- Select "Marketing Activity"
- Confirm
- Try to use this new menu
- Traceback
This is because a compute is triggered in marketing_activity and we use `literal_eval` on domain fields unsetted.
`literal_eval` works only with string https://docs.python.org/3/library/ast.html#ast.literal_eval
opw-4115586
Forward-Port-Of: odoo/enterprise#68920Steps to reproduce: 1) Go to runbot Odoo 16 enterprise and install "l10n_ar_edi" module (Argentinean Electronic Invoicing). 2) Take position on Argentinian company (AR) (Responsable Inscripto) . 3) Create customer electronic invoice and confirm. If there is a response with 503 error (HTTPError: 503 Server Error. Service Unavailable) while connecting to the webservice then it will be raised the error message and this text "Please report this error to your Odoo provider" (but this text is
Original PR description
Steps to reproduce: 1) Go to runbot Odoo 16 enterprise and install "l10n_ar_edi" module (Argentinean Electronic Invoicing). 2) Take position on Argentinian company (AR) (Responsable Inscripto) . 3)…
Steps to reproduce: 1) Go to runbot Odoo 16 enterprise and install "l10n_ar_edi" module (Argentinean Electronic Invoicing). 2) Take position on Argentinian company (AR) (Responsable Inscripto) . 3) Create customer electronic invoice and confirm. If there is a response with 503 error (HTTPError: 503 Server Error. Service Unavailable) while connecting to the webservice then it will be raised the error message and this text "Please report this error to your Odoo provider" (but this text is not suitable because the odoo provider can`t solve the error. The webservice is not available). Current behavior: If there is a response with 503 error (HTTPError: 503 Server Error. Service Unavailable) while connecting to the webservice when the user is trying to confirm an electronic customer invoice then it will be raised the error message and this text "Please report this error to your Odoo provider". Expected behavior: If there is a response with 503 error (HTTPError: 503 Server Error. Service Unavailable) while connecting to the webservice when the user is trying to confirm an electronic customer invoice then it will be raised the error message and this text 'The AFIP electronic billing webservice is not available. Wait a few minutes for it to reset and try to validate the action again.'. Task Adhoc: 37771 Forward-Port-Of: odoo/enterprise#67566 Forward-Port-Of: odoo/enterprise#59983
We no longer need to add isCheck after this version on a tour we remove the checks and fix a small typo to avoid failing runbots. opw-76050 Forward-Port-Of: odoo/enterprise#68962
Original PR description
We no longer need to add isCheck after this version on a tour we remove the checks and fix a small typo to avoid failing runbots. opw-76050 Forward-Port-Of: odoo/enterprise#68962
`portal.CustomerPortal.OPTIONAL_BILLING_FIELDS` is deprecated, we should rather use the method `_get_optional_fields` c.f. the OC-side commit Forward-Port-Of: odoo/enterprise#68969 Forward-Port-Of: odoo/enterprise#68679
Original PR description
`portal.CustomerPortal.OPTIONAL_BILLING_FIELDS` is deprecated, we should rather use the method `_get_optional_fields` c.f. the OC-side commit Forward-Port-Of: odoo/enterprise#68969 Forward-Port-Of: odoo/enterprise#68679
Issue ----- Error when multiple input lines on a payslip are of the same type. Steps ----- [hr_payroll] 1. Create a salary attachment for an employee, type "Attachment of salary", with a monthly amount and total amount A. 2. Create another salary attachment for the same employee, same type and monthly amount and total amount B different from A. 3. Create a payslip for the employee, create a contract with a start date matching the salary attachment date. On "Other Inputs", remove the "A
Original PR description
Issue ----- Error when multiple input lines on a payslip are of the same type. Steps ----- [hr_payroll] 1. Create a salary attachment for an employee, type "Attachment of salary", with a monthly amount and total amount A. 2. Create another salary attachment for the same employee, same type and monthly amount and total amount B different from A. 3. Create a payslip for the employee, create a contract with a start date matching the salary attachment date. On "Other Inputs", remove the "Attachment of salary" line. Create two input lines of type "Attachment of salary", one with amount A and another with amount B. 4. Compute sheet > Confirm > Mark as paid > ** Error ** Cause ----- Generally, input lines of the same type on a payslip will be merged in one input line, but it is not the case if there are multiple salary attachments of the same type matching these input lines. opw-4066851 Forward-Port-Of: odoo/enterprise#68934 Forward-Port-Of: odoo/enterprise#68441
This commit adds the website_generator_sale module for the website generator, which will allow for the importing of products. This includes support for variants, redirects and category pages. [Task](https://www.odoo.com/odoo/project/8390/tasks/3987140?cids=1) Forward-Port-Of: odoo/enterprise#66832
Original PR description
This commit adds the website_generator_sale module for the website generator, which will allow for the importing of products. This includes support for variants, redirects and category pages. [Task](https://www.odoo.com/odoo/project/8390/tasks/3987140?cids=1) Forward-Port-Of: odoo/enterprise#66832