Monday, September 2, 2024
17 changes
5 changes
Resolved issues and error corrections
This fix prevents Odoo's web utilities from mistakenly combining details attached to functions when merging data. It makes internal data handling more predictable and reduces the risk of subtle interface issues in the web client.
Original PR description
Before this commit: Functions where treated as object by the deepMerge utils, causing it to merge function properties. After this commit: Functions are now treated as values (This commit is a backport of [03f7b5f](https://github.com/odoo/odoo/commit/03f7b5f4f79b31c373b0f5a57a7bcced1e5a26b0) from 17.4 to 17.2) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
[MOV] website: rename automatic editor tests The goal of this commit is to rename the `automatic_editor` test files. This will be usefull in the next commit. runbot-60056 runbot-69009 ---------------------------------------------------------------------------------------------------------------------------------------------- [FIX] website: adapt the automatic editor on new website test The goal of this commit is to simplify the `automatic_editor_on_new_website` test. Indeed, th
Original PR description
[MOV] website: rename automatic editor tests The goal of this commit is to rename the `automatic_editor` test files. This will be usefull in the next commit. runbot-60056 runbot-69009…
[MOV] website: rename automatic editor tests The goal of this commit is to rename the `automatic_editor` test files. This will be usefull in the next commit. runbot-60056 runbot-69009 ---------------------------------------------------------------------------------------------------------------------------------------------- [FIX] website: adapt the automatic editor on new website test The goal of this commit is to simplify the `automatic_editor_on_new_website` test. Indeed, the test was added by [1] to check if the editor was correctly started after the creation of a website under some circonstences but since [2], the editor is not started after creating a website. The part that tests the installation of a new language through the theme editor has been removed as it is already implemented in the `rte_translator` test. The remaining part that tests the creation of a website with the skip of the configurator is kept as it is not implemented in another test. [1]: https://github.com/odoo/odoo/commit/81f5c768278d15d4ef943deffa397736b867c825 [2]: https://github.com/odoo/odoo/commit/e38808e1a77dab291beb4020a2bf3c248f88cdef runbot-60056 runbot-69009 Forward-Port-Of: odoo/odoo#177865
12 changes
Enhancements to existing features
The “Generate Offer” button is now hidden once an applicant reaches the Hired stage. This keeps the recruitment screen clearer and prevents users from starting an offer process when it is no longer relevant.
Original PR description
It does not make sense to show "Generate Offer" button on applicant in Hired stage, thus we hide it. task-4037642
This commit brings out some more improvement to the New Zealand localization. It will mostly be about translating a few terms, improving tax labels on invoices and mark invoices as "tax invoices". Task id #3753652 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178663 Forward-Port-Of: odoo/odoo#165686
Original PR description
This commit brings out some more improvement to the New Zealand localization. It will mostly be about translating a few terms, improving tax labels on invoices and mark invoices as "tax invoices". Task id #3753652 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#178663 Forward-Port-Of: odoo/odoo#165686
Steps to reproduce: 1) Install hr_work_entry_contract_planning_attendance 2) Create planning-based contracts for employee 3) create a shift for the employee for 8 hours (Based on the working schedule) 4) create attendance more than shift hours 5) Open work entries and you get Extra Overtime work entry Cause: For the work entries, we defined date_generated_from and date_generated_to in contracts Based on these dates we are going to decide whether we need to create work entries for the sp
Original PR description
Steps to reproduce: 1) Install hr_work_entry_contract_planning_attendance 2) Create planning-based contracts for employee 3) create a shift for the employee for 8 hours (Based on the working schedule) 4) create attendance more than shift hours 5) Open work entries and you get Extra Overtime work entry Cause: For the work entries, we defined date_generated_from and date_generated_to in contracts Based on these dates we are going to decide whether we need to create work entries for the specific period working schedule as work entry source Fix: these dates are set for both types of contracts task-3646385 Forward-Port-Of: odoo/odoo#156432
Forward-Port-Of: odoo/odoo#178525
Original PR description
Forward-Port-Of: odoo/odoo#178525
A no-longer-used portal setting was removed from subscription payment flows. This keeps the subscription portal code simpler and avoids passing values that no longer affect what customers see.
Original PR description
In this commit, remove the 'message_class' argument from the subscription portal as it is no longer used. when set default payment token from portal for subscription the value passed in url is not used anymore after [this changes](https://github.com/odoo/enterprise/pull/53528/files#diff-fe832fe3ee067a3129a91a8293986e886f557b50ecf87e0fe0438ac1b6c82bc6L165-L167). If not using that value is intentional then this changes need to be applied. otherwise we should not remove message_class argument to display this message on portal. task-4077522
Resolved issues and error corrections
The Partner Ledger partner filter now excludes contact-only partner records, so users see only relevant accounting partners. This reduces confusion when selecting partners for accounting reports and helps avoid misleading report filters.
Original PR description
Steps to reproduce: - Go to Partner Ledger report - Open partner filtering dropdown list Current behaviour: - Show all partners include contact partners Expected behaviour: - Should not show contact partners Explanation: Based on the discussion on discord, https://discord.com/channels/678381219515465750/1099994955830796348/1268492839575093291 We should not display contact partners filtering for accounting report.
This fix makes the Philippine tax reporting logic return accounting entries in a consistent order. It prevents occasional test failures caused by unpredictable ordering, helping keep the module stable without changing user-facing behavior.
Original PR description
Since the moves query didn't specify the ordering, sometimes unit test will failed since the order of the moves are different. x-origin-commit: f25f362
Code cleanup and technical improvements
This draft change reorganizes parts of the Studio approval setup for buttons and related tests. It appears aimed at making the underlying approval configuration easier to maintain without introducing a major business workflow change.
This change simplifies how spreadsheet-related screens handle shared behavior like renaming records and declaring interface components. It reduces duplicated logic across spreadsheet apps, making future maintenance safer without changing the user experience.
Miscellaneous changes
Purpose: ------- Currently when editing a booking from the frontend form view, a warning notification is shown, indicating that the booking being edited has been updated or deleted. This notification should only be shown when the booking being edited has been updated or deleted by another user (because in that case the user will be forced to leave the edition view without doing anything). Task-4104748 Forward-Port-Of: odoo/enterprise#68158
Original PR description
Purpose: ------- Currently when editing a booking from the frontend form view, a warning notification is shown, indicating that the booking being edited has been updated or deleted. This notification should only be shown when the booking being edited has been updated or deleted by another user (because in that case the user will be forced to leave the edition view without doing anything). Task-4104748 Forward-Port-Of: odoo/enterprise#68158
Description of the issue this commit addresses: The xml export of invoices in the mexican edi is missing the line's description --- Desired behavior after this commit is merged: The description of the lines are present in the xml export. --- Details on the fix: The fix basically consists in using a concatenation of both the product's name and the invoice line's name but in some configurations, the line's name might contain the product's making it appear twice. Because of tha
Original PR description
Description of the issue this commit addresses: The xml export of invoices in the mexican edi is missing the line's description --- Desired behavior after this commit is merged: The description of the lines are present in the xml export. --- Details on the fix: The fix basically consists in using a concatenation of both the product's name and the invoice line's name but in some configurations, the line's name might contain the product's making it appear twice. Because of that an if-else statement is required to check if the product's name and the invoice line's are redundant and decides based on that. --- task-4149256 Forward-Port-Of: odoo/enterprise#69179
In this PR, one test case is added to ensure the behavior of the planning-based contract on work entries Task - 3646385 Forward-Port-Of: odoo/enterprise#66801
Original PR description
In this PR, one test case is added to ensure the behavior of the planning-based contract on work entries Task - 3646385 Forward-Port-Of: odoo/enterprise#66801
Currently, a traceback occurs when the user creates a product with a barcode. To reproduce this issue: 1) Install `stock`, `barcode lookup` 2) Give an `API` key in settings for `barcodelookup` 3) Now create a new product variant by scanning the barcode of a product or enter the barcode manually in stock. Note:- API key for testing:- `wjgkytojaghoiyzu9n2f6vc6wgysp9` Barcode for testing:- `8901207035715` Error:- ``` TypeError: unsupported operand type(s) for +=: 'bool' and
Original PR description
Currently, a traceback occurs when the user creates a product with a barcode. To reproduce this issue: 1) Install `stock`, `barcode lookup` 2) Give an `API` key in settings for `barcodelookup` 3) Now create a new product variant by scanning the barcode of a product or enter the barcode manually in stock. Note:- API key for testing:- `wjgkytojaghoiyzu9n2f6vc6wgysp9` Barcode for testing:- `8901207035715` Error:- ``` TypeError: unsupported operand type(s) for +=: 'bool' and 'Markup' ``` Initially, there will be no product description while creating a new product. So it leads to a traceback when `+=` is used between the markup and description https://github.com/odoo/enterprise/blob/67ecb18497ee3f1ade6cc81738db3df08f94ba2f/product_barcodelookup/models/product_template.py#L189-L190 sentry-5744282512 Forward-Port-Of: odoo/enterprise#69065
Currently, a traceback occurs when the user creates a PO with a product from a company other than 'KE'. To reproduce this issue: 1) Install `l10n_ke_edi_oscu_stock` 2) Switch to a company other than `KE` 3) Create a PO with a product > `Confirm Order` 4) Click on `Receive Products` > `Validate` and get back to PO through breadcrumb 5) Click on the `Create Bill` Error:- ``` ValueError: Compute method failed to assign purchase.order.line(19, ).display_name ``` The above error o
Original PR description
Currently, a traceback occurs when the user creates a PO with a product from a company other than 'KE'. To reproduce this issue: 1) Install `l10n_ke_edi_oscu_stock` 2) Switch to a company other than…
Currently, a traceback occurs when the user creates a PO with a product from a company other than 'KE'. To reproduce this issue: 1) Install `l10n_ke_edi_oscu_stock` 2) Switch to a company other than `KE` 3) Create a PO with a product > `Confirm Order` 4) Click on `Receive Products` > `Validate` and get back to PO through breadcrumb 5) Click on the `Create Bill` Error:- ``` ValueError: Compute method failed to assign purchase.order.line(19, ).display_name ``` The above error occurs because of a computing method in which a filter is used to access the `KE` company record. But when the user is not in `KE` company it returns None. Here, the `display_name` is a readonly and non-stored field. Which leads to the above traceback. https://github.com/odoo/enterprise/blob/7a9157e059fd70831eb3174863a797abdb99ad53/l10n_ke_edi_oscu_stock/models/purchase.py#L71-L73 After applying this commit, We can resolve the above issue by giving the POl name when it is not `KE` company. sentry-5726618591 Forward-Port-Of: odoo/enterprise#69101 Forward-Port-Of: odoo/enterprise#68693
**Current behavior:** When adding an unplanned move line to a transfer in barcode, if the line is added to an existing move which is a subcontract transfer, it will not take the subcontract location as its source location value. Rather, it will use whatever value is defined on the picking. **Expected behavior:** Use the more precise location defined on the move rather than the picking. **Steps to reproduce:** 1. Create a product with a subcontract BOM 2. Create a receipt for that pro
Original PR description
**Current behavior:** When adding an unplanned move line to a transfer in barcode, if the line is added to an existing move which is a subcontract transfer, it will not take the subcontract location…
**Current behavior:** When adding an unplanned move line to a transfer in barcode, if the line is added to an existing move which is a subcontract transfer, it will not take the subcontract location as its source location value. Rather, it will use whatever value is defined on the picking. **Expected behavior:** Use the more precise location defined on the move rather than the picking. **Steps to reproduce:** 1. Create a product with a subcontract BOM 2. Create a receipt for that product from the subcontractor 3. Open the transfer in Barcode and manually add another line for the same product -> validate 4. In the receipt form, look at the move lines (detailed operations) and group by location to see the discrepancy **Cause of the issue:** When creating a move line here, it does not initially get a `move_id` value. Later when the move is written to the line, we would not generally want to override whatever value is on the line already because it (normally) is more precise/was purposely changed later than what value is on the move. **Fix:** In the case of lines which are created and then linked to a subcontract move, take the `location_id` of the move rather than whatever value is on the MoveLine. opw-4007423 Forward-Port-Of: odoo/enterprise#69011 Forward-Port-Of: odoo/enterprise#68032