Tuesday, September 10, 2024
11 changes
5 changes
Resolved issues and error corrections
Installing Point of Sale with demo data could fail when Barcode had already been installed because the demo tax setup lacked a matching tax group for the active company. This fix adds the required demo tax group fallback so the installation completes successfully in that scenario.
Original PR description
### Steps to reproduce: - Create a fresh db with demo data - Activate the "stock_barcode" module - Activate the "point_of_sale" module #### > Error: operation cannot be completed ### Cause of the…
### Steps to reproduce: - Create a fresh db with demo data - Activate the "stock_barcode" module - Activate the "point_of_sale" module #### > Error: operation cannot be completed ### Cause of the issue: Activating the "stock_barcode" module will create a second company. When you activate point of sale with the demo data, it will first install accounting and create a tax group for company 2 and then create the pos demo data: https://github.com/odoo/odoo/blob/42fa237296f9b1fa556ae310b3273f863420e659/addons/point_of_sale/data/point_of_sale_demo.xml#L74-L78 However, during since no tax group is specified for this account.tax, it is expected to be computed here: https://github.com/odoo/odoo/blob/42fa237296f9b1fa556ae310b3273f863420e659/addons/account/models/account_tax.py#L221-L222 But since no tax group was created for the current company, this computation will fail to give a result https://github.com/odoo/odoo/blob/42fa237296f9b1fa556ae310b3273f863420e659/addons/account/models/account_tax.py#L232-L235 and the transaction will be aborted. ### Fix: We create a tax group demo data that will be associated to the same company as the one for which our demo tax is created and hence provide a fall back value in case no other tax group was created. opw-4141575 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes how action aliases are shown in URL paths so they no longer include an unwanted underscore. The change helps keep navigation links cleaner and more consistent for users and integrations.
Original PR description
…ndercore Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Restaurant point-of-sale order buttons now show only the most relevant product category when a product belongs to multiple categories. This avoids confusing duplicate category labels and makes order information clearer for staff.
Original PR description
Steps to reproduce : - Install pos_restaurant - Go to products - Set 2 pos_categories in a product - Open restaurant and add that product to order Issue : Both categories will be shown in order button and also not in correct sequence. Cause : Trying to show all categories and not the dominant once. Fix : Showing only the dominant once to make it more relatable. task: 3976224
This change adjusts mail/discuss behavior related to WhatsApp notifications so users receive the expected alerts. It aims to correct notification handling in conversations, reducing confusion when messages are sent through WhatsApp.
Original PR description
WIP, needs to be retargetted probably Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an error from appearing in Odoo logs when users open Accounting settings with the Mexican localization installed in a replicated database setup. It adjusts when configuration view changes are applied so the settings page remains stable during testing and read-only operations.
Original PR description
To reproduce: - Launch Odoo instance with the option --db_replica_host='' - Install l10n_mx - access Settings > Accounting - You'll get the error in the log The Issue During testing, attempting to modify a field's state using the 'get_views' function, which is marked as read-only, results in a read-only error. The Fix: To resolve this, apply changes only when we are not in test mode and ensure the view is initially imported as inactive. runbot-60422 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
1 change
Resolved issues and error corrections
This fixes an issue where editing a food delivery order in Point of Sale and going back could create duplicate order lines. Orders now keep the correct line identity, reducing billing mistakes and manual cleanup for restaurant staff.
Original PR description
Steps: - Install pos_urban_piper - Open Point of Sale. - Configure Food Delivery Connector for one of pos - Place a test order. - Edit order and add a new product. - Press Back button Issue: - Duplicate orderline is been created. Fix: - uuid was not handled while creating orderline which is been taken care of from this commit. task-4147488
5 changes
Resolved issues and error corrections
This update corrects a layout issue in the HR Payroll module where the "Availability in Structure" field was displayed in the wrong position. The fix ensures the field appears in the correct location alongside other input type settings, improving the user interface organization and usability.
Original PR description
This commit fix a design issue in the hr_payroll where the "Availability in Structure" field was incorrectly positioned among other input types. task-4050183 Forward-Port-Of: odoo/enterprise#67532
Fixed an issue in Odoo Studio where the editor menu was not updating when users switched between different tabs such as views and automations. Now the menu properly refreshes to reflect the selected tab, improving the user experience when navigating between different studio features.
Original PR description
Before this commit, in studio, the editorMenu was not updated when clicking on a different tab (views, automations etc...) After this commit, the menu is updated.
This update fixes failing automated tests in the Colombian EDI website sales module. The tests were breaking due to an incorrect stepDelay argument in the test code. This fix ensures that the automated testing process runs smoothly without errors.
Original PR description
The stepDelay argument in the l10n_co_edi_website_sale tour tests fails when loading the js for the tours https://runbot.odoo.com/web/#id=77298&menu_id=424&cids=1&action=573&model=runbot.build.error&view_type=form
This fix resolves a crash that occurred when users tried to view the Cash Flow Statement report under certain journal configurations. The issue happened when the system couldn't find payment accounts to query, causing a database error. Now the report will display properly even when payment accounts are unavailable.
Original PR description
Currently, an exception is generated when the user tries to open the "Cash Flow Statement" report. Steps to produce an error: - install 'Accounting Reports' - Open Accounting > Configuration >…
Currently, an exception is generated when the user tries to open the "Cash Flow Statement" report.
Steps to produce an error:
- install 'Accounting Reports'
- Open Accounting > Configuration > Accounting > Journals
- Now delete all journals except "Miscellaneous Operations"
- change type of "Miscellaneous Operations" to sales > sale
- Click Reporting > click "Cash Flow Statement" >>> exception occurs
Stack Trace:
```
SyntaxError: syntax error at or near ")"
LINE 28: ... AND account_move_line.account_id NOT IN ((), ())
^
File "odoo/http.py", line 2373, in __call__
response = request._serve_db()
File "odoo/http.py", line 1903, in _serve_db
return self._transactioning(
File "odoo/http.py", line 1966, in _transactioning
return service_model.retrying(func, env=self.env)
File "odoo/service/model.py", line 134, in retrying
result = func()
File "odoo/http.py", line 1933, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "odoo/http.py", line 2177, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "odoo/addons/base/models/ir_http.py", line 223, in _dispatch
result = endpoint(**request.params)
File "odoo/http.py", line 754, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "addons/web/controllers/dataset.py", line 35, in call_kw
return call_kw(request.env[model], method, args, kwargs)
File "odoo/api.py", line 459, in call_kw
result = getattr(recs, name)(*args, **kwargs)
File "home/odoo/src/enterprise/saas-17.4/account_reports/models/account_report.py", line 4872, in get_report_information
'lines': self._get_lines(options, all_column_groups_expression_totals=all_column_groups_expression_totals, warnings=warnings),
File "home/odoo/src/enterprise/saas-17.4/account_reports/models/account_report.py", line 2275, in _get_lines
dynamic_lines = self._get_dynamic_lines(options, all_column_groups_expression_totals, warnings=warnings)
File "home/odoo/src/enterprise/saas-17.4/account_reports/models/account_report.py", line 2705, in _get_dynamic_lines
rslt = self.env[self.custom_handler_model_name]._dynamic_lines_generator(self, options, all_column_groups_expression_totals, warnings=warnings)
File "home/odoo/src/enterprise/saas-17.4/account_reports/models/account_cash_flow_report.py", line 16, in _dynamic_lines_generator
report_data = self._get_report_data(report, options, layout_data)
File "home/odoo/src/enterprise/saas-17.4/account_reports/models/account_cash_flow_report.py", line 57, in _get_report_data
for aml_groupby_account in self._get_liquidity_moves(report, options, currency_table_query, payment_account_ids, cashflow_tag_ids):
File "home/odoo/src/enterprise/saas-17.4/account_reports/models/account_cash_flow_report.py", line 365, in _get_liquidity_moves
self._cr.execute(SQL(' UNION ALL ').join(queries))
File "odoo/sql_db.py", line 347, in execute
res = self._obj.execute(query, params)
```
This is because at the time of query building for getting liquidity moves, it gets an empty tuple from line [1] as we do not have any journals with the type 'bank', 'cash', or 'general'.
This commit will fix the above issue by returning empty report_data when payment_account_ids is empty.
[1] - https://github.com/odoo/enterprise/blob/8fa01948610809d191b75260772782e25ea3a737/account_reports/models/account_cash_flow_report.py#L195
sentry-5555757610This fix prevents the system from automatically overwriting planned dates that users manually set on tasks. Previously, when users entered specific planned hours outside normal working hours, the system would incorrectly replace those dates. Now the system respects user-entered dates while still maintaining automatic scheduling for bulk task operations.
Original PR description
Versions -------- - 15.0+ Steps ----- 1. Have a task assigned to you; 2. ensure planned hours are empty; 3. plan the task partially outside working hours (e.g. 16:00 -> 21:00); 4. save. Issue ----- Planned hours are overwritten. Cause ----- Commit 52536bf8bb5 added logic to provide schedule-based start dates for tasks created in Gantt view, as well as other tasks, by overwriting the provided (default) date values. Solution -------- As of commit 0eda2ab1332, Gantt task dates are planned in JS, and skipped in the back-end due to the `smart_task_scheduling` context value. Therefore we can skip the overwriting of dates if we're working on a single record, which would usually be from a form view. This way, we can still do schedule-based planning when batch processing from list view. opw-3947876 Forward-Port-Of: odoo/enterprise#68909 Forward-Port-Of: odoo/enterprise#65404