Daily updates from Odoo
Monday, September 30, 2024
15 changes · 17.0
Enhancements to existing features
This update refreshes and completes translation files for Argentine localization modules (EDI and Reports). Missing and outdated translation files have been updated, and unnecessary empty Belgian French translations have been removed to keep the codebase clean and maintainable.
Original PR description
Some pot files were out of date/missing, some .po files were out of date/missing/missing translations. Also delete unnecessary fr_BE.po files that didn't have any translations in them
Resolved issues and error corrections
This fix ensures that the packaging button appears in the barcode app's inventory adjustment feature, even when no initial quantity demand is set. Previously, users couldn't quickly add products in packaging multiples during inventory adjustments because the button was hidden. Now the button displays correctly, making it easier to process packaged items.
Original PR description
### Steps to reproduce: - In the settings: Enable "product packaging" - Create a product with a barcode - Inventory > Configuration > Product Packaging > New - Create a packaging for that prodcut with a quantity of 10 - In the barcode app create an inventory adjustment or a new immediate transfer and scan your product - Click on the pencil icon > you are redirected to the digipad #### > The button to add prodcuts by multiple of your packaging is not there ### Cause of the issue: Currently, a packaging buttons is only displayed if the quantity of the demandQty of the move line is higher or equal to the packaging qty: https://github.com/odoo/enterprise/blob/dbe94f71121851babeb1831814ccc3349301430e/stock_barcode/static/src/widgets/digipad.js#L63-L81 However, it should also be is the picking or inventory adjustment did not defined an initial demand. ### opw-4156249
A test tour for adding documents to dashboard groups was not running because the Python test method was missing the required 'test_' prefix. The tour has been fixed to work with the new functionality that allows creating dashboards from new spreadsheets. This ensures the feature is properly tested.
Original PR description
The tour `spreadsheet_dashboard_document_add_document_to_dashboard_group` was never actually run because the python method wasn't prefixed by `test_`. The toru was also broken since we allowed to create a dashboard based on a new spreadsheet. Task: [4199036](https://www.odoo.com/web#id=4199036&cids=1&menu_id=4720&action=333&active_id=2328&model=project.task&view_type=form)
This fix corrects how employee salaries are calculated in Mexican payroll when employees are paid on a weekly or other non-monthly schedule. Previously, the system was incorrectly dividing the wage amount by a pay schedule coefficient, resulting in incorrect basic salary amounts on payslips. The fix ensures employees receive the correct wage amount for their pay period while maintaining proper calculations for special payments like Christmas bonuses.
Original PR description
Issue: ====== `paid_amount` is not calculated correctly when the schedule pay isn't month. Steps to reproduce the issue: ============================= - Switch to MX company - Go to roque and employee and add these values to his contract : salary structure type( Mexico:Employee) - both schedule pay fields (weekly) - add any amount in wage. - Go to payslips and create one for roque and click on compute sheet - Go to salary computation tab - Basic salary is wrong it should be the amount you put at the start. Origin of the issue and solution: ================================= We were dividing by the coefficient of the pay schedule but in reality we didn't have to since we create the payslip for the period of the schedule pay so it will have the full mentioned wage. But for the christmas we need to divide by the coefficient since it's computed by `days/year`. opw-413332
This fix resolves an issue where combo products could not be invoiced in Peru due to a tax validation error. Combo products don't require individual tax assignments since taxes are applied to each component product within the combo. The fix treats the parent combo line similar to notes or sections on quotations, allowing invoicing to proceed without errors.
Original PR description
Currently, some localizations are not able to invoice if a combo product was bought. Steps to reproduce: ------------------- * Install **l10n_pe_edi_pos** * Switch to the **PE Company** * Go to the **Point of sale** App * Go to the products * Select a combo product * Navigate through all the products that can be selected in the combo and apply a tax on each * Open shop session * Add the combo product to the order * Validate and invoice the order > Observation: Invalid Operation: Taxes need to be assigned on all invoice lines Why the fix: ------------ Combo products do not have the possibility to be assigned a tax, as they are not supposed to. Taxes are computed for each product chosen and applies on that product. We can treat the parent combo line as the note or sections we would put on a quotation. opw-4090946 Community PR: https://github.com/odoo/odoo/pull/181068
This update corrects how times are displayed in the Field Service task view when using 12-hour time format. Previously, times showed incorrectly as "02:00 A" instead of "02:00 AM/PM". The fix corrects a formatting error so that AM and PM indicators now display properly for users in regions using 12-hour time formats.
Original PR description
### Steps to reproduce: - Install Field Service module - Set 12-hour time format in the languages - Navigate to My tasks kanban view in Field Service ### Current behavior before PR: When having 12-hour time format for Field Service it will be shown in the kanban view as '02:00 A' for example. This is happening because when formatting the time in the fsm_date widget the format we are using have a typo 'hh:mm A' where the 'AM, PM' should be represented with lowercase 'a' not uppercase 'A' ### Desired behavior after PR is merged: Fixed the typo and added the correct format opw-4178726 Forward-Port-Of: odoo/enterprise#70250
Fixed an issue where the EC Sales List menu option was not appearing when installing the French localization module. Users in France can now access the EC Sales List reporting feature directly after installing the French localization without needing to install additional modules.
Original PR description
Currently the EC Sales List menuitem is not visible when only installing `l10n_fr_reports` (and no other localization activating the item). To reproduce it you need to install `l10n_fr_reports` on a database where the item is not already visible. (It does not work on the runbot.) Forward-Port-Of: odoo/enterprise#70723
This fix resolves an issue where users were redirected to an error page after logging in to access a knowledge article view link. The problem occurred because the system was generating an incorrect redirect URL. The fix ensures users are properly redirected to the correct article view after authentication, allowing them to access shared knowledge articles seamlessly.
Original PR description
When a visitor clicks on a view link, they are redirected to the login page to authenticate and gain access to the view. This is necessary to ensure the user has the appropriate permissions to open…
When a visitor clicks on a view link, they are redirected to the login page to authenticate and gain access to the view. This is necessary to ensure the user has the appropriate permissions to open the view and access the records.
Current problem:
When clicking on a view link, the users are redirected to an error page after successfully logging in. This happens because the system generates a faulty redirection URL (`/knowledge/article/undefined`) for the login page. This occurs because the `KnowledgeWidget` widget generates the URL using `this.resId` (`/knowledge/article/{this.resId}`) and the widget does not have any `resId` property set.
Steps to reproduce:
1. Open any list or kanban view
2. In the view's cog menu: "Knowledge" > "Insert link in article"
3. Click the "New" button to create a new article
4. After being redirected to the article, click on the "Share" button
5. Publish the article
6. Copy the generated article URL
7. Open a private window and paste the URL
8. Click the view link
9. Enter valid credentials
=> After logging in, the user is redirected to an error page.
TO BE: After logging in, the user should be redirected to the backend view of the article. The user should then be able to open the view by clicking on the view link.
Solution:
To solve this issue, we will use `this.$id` instead of `this.resId` to get the current article id.
Reference: https://github.com/odoo/enterprise/pull/57346
task-4210743Planning users can now see and access the Schedule by Sales Order menu when they have the appropriate permissions. This fix ensures that the menu visibility is properly controlled based on user access rights, allowing planning teams to manage schedules more effectively.
Original PR description
Before: The Schedule by Sales Order menu was not visible to planning users, even if they had the necessary access rights. After: The Schedule by Sales Order menu is now visible to planning users who have the appropriate access rights. Fix: Add the user group so that the menu will now be visible based on the user's access rights. Task:4192098
This fix resolves a problem where the order of insurance solutions in employee contracts was affecting salary calculations for IJM and LAAC insurance types. Previously, changing from multiple insurance solutions to fewer ones could result in incorrect cumulative salary calculations. The system is now position-aware, meaning the number and order of insurance solutions no longer impact the accuracy of payroll calculations.
Original PR description
Currently, order of Many2many insurance_line_ids matters for IJM and LAAC, which can be error prone in the case where you go from example from 2 solutions -> 11,12 to one solution -> 12, the cumulated salaries will not be computed properly in this case. We make the rules Position aware in this PR, meaning that order or quantity of solutions in the contract does not matter anymore.
This fix resolves an issue where customer and sale order information were not automatically populated when portal users created tasks in shared Field Service projects. The problem occurred because the quick task creation form was missing a required field reference, preventing the system from automatically filling in customer details. This update ensures that when users quickly create tasks, all relevant customer and billing information is properly set.
Original PR description
- Install the Field Services (industry_fsm) and sales module. - Create a sale order with the following configuration: - Select any customer. - Select the product 'Junior Architect' (Invoice on…
- Install the Field Services (industry_fsm) and sales module. - Create a sale order with the following configuration: - Select any customer. - Select the product 'Junior Architect' (Invoice on Timesheets). - Confirm the sale order. - On the header of the sale order, click on the project option. - Then, in the left side corner, click on 'Share Editable'. - Share the project to your company. - Log in as a portal user. - Open the projects menu. - Open the project you just shared. - In the kanban view, click on the 'Quick Create Task' button. - Add a task name and click on the edit button. - You will see the form view where the customer and sale order item are not set by default. Issue: ------------------ When logging in as a portal user(project sharing), the fields for Customer and Sale Order Item are not set by default when creating a task via quick create in the Kanban view. Cause: ------------------- The _compute_partner_id function relies on the project_id field to determine the partner_id (customer) for a task. However, in the quick create view, only the partner_id field is mentioned . in the quick view, the project ID is not provided so the partner ID cannot be computed, resulting in an empty field for the partner_id (customer). Solution: ---------------------- add a project_id field in the 'project_sharing_quick_create_task_form_inherit' quick create form view. task-3743360 Forward-Port-Of: odoo/enterprise#57113
This fix corrects a typo in the Swiss payroll insurance threshold calculation that was causing payslip generation to fail. The fallback value was incorrectly formatted as a tuple instead of a decimal number, which broke the payroll processing. This resolves errors when generating payslips for Swiss employees.
Original PR description
Steps to reproduce: - Intall Payroll and Switzerland localization > Switch to CH company - Employees > New > Work Information tab > Set any Canton - Create a contract for that employee > Set it to 'Running' state - Payroll > Work Entries > Work Entries > Remove filters - Navigate to next month > Regenerate Work Entries - Generate Payslips > Error is raised This error is raised because the fallback value in _get_ac_threshold is 0, 0 instead of being a float (same as the otherwise returned line.amount). This was most likely just a typo using the wrong decimal separator which turned th fallback into a tuple, breaking on the following operations. opw-4204580
This fix prevents invisible fields and text elements from being incorrectly displayed inside button boxes when using the Studio visual editor. When toggling the "show invisible elements" option in Studio, some hidden fields were appearing in button areas where they shouldn't be visible, which has now been corrected.
Original PR description
Steps to reproduce ================== - Install studio,project - Open any task - Open studio - Toggle show invisible elements => Some fields are displayed inside the button box Cause of the issue ================== Some always invisible non buttons elements are sometimes used inside a button box. https://github.com/odoo/odoo/blob/1c685b9ce7483c426fc2db964ef357003229ddc6/addons/project/views/project_task_views.xml#L269-L275 opw-4164661
This update fixes a visual formatting problem in the Sign module where placeholder text was overlapping with navigation controls when fields were left-aligned in templates. The issue was caused by excessive padding removal that was added in a previous update. This fix restores proper spacing while maintaining the intended visual consistency across the application.
Original PR description
Steps to reproduce: - Sign > Edit any template > Add a field - Click your field > Select left alignment > Validate The placeholder text overlaps with the arrow block, in 16.0 this does not occur. The culprit is the ps-0 class added to signItem which removes all padding from the block. The formatting was changed in f1b35ae9030ff82afc498bfbd6315414407bb4e1 to make it consistent between the other views (The shift is kept even the move icon is not visible) but the alignment feels consistent even without this class. opw-4159676
This fix resolves an issue where the 'Time Spent' label was not displaying in the helpdesk portal when multiple support teams had different timesheet settings. The system now correctly shows the label if any team has time tracking enabled, rather than only checking the first team. This ensures customers see accurate timesheet information regardless of how their tickets are organized.
Original PR description
Steps to reproduce: - Install the helpdesk_sale_timesheet module. - Create two helpdesk teams (e.g. VIP Support and Customer Care). - Enable time billing and timesheets for the VIP Support team only.…
Steps to reproduce: - Install the helpdesk_sale_timesheet module. - Create two helpdesk teams (e.g. VIP Support and Customer Care). - Enable time billing and timesheets for the VIP Support team only. - In the portal view of tickets observe that the "Time Spent" label is missing Issue: - In the portal view you will see the 'Time Spent' label missing. Cause: - In the portal view of tickets the 'Time Spent' label is missing because when data is grouped (e.g. by stage, assignee, or team) it will check for the first group of tickets. It evaluates group in ascending order and if `use_helpdesk_sale_timesheet` is set to false for the first group the 'Time Spent' label will disappears even if it's enabled for other group. Fix: - In this commit we will check the `use_helpdesk_sale_timesheet` field for every ticket in the list. If it is set to true for any ticket the "Time Spent" label will be displayed; otherwise it will remain hidden. limitation : - In this case we need to add the list because removing `any` from the condition would violating our stability policy. task-4058210 Forward-Port-Of: odoo/enterprise#69331